- 19 Nov, 2017 2 commits
-
-
Yang Guo authored
Previously, in order to get immortal immovable objects onto the first page, the serializer would iterate the root list twice. The first time it would prioritize immortal immovables. The second time it would serialize the rest. This does not guarantee that immortal immovable objects actually end up on the first page, and by now this is not necessary anymore, since we mark all pages created during heap init as immortal immovable pages. R=mlippautz@chromium.org Change-Id: Ie95fcd779377a75337621ba862bc1a745ed5cbaa Reviewed-on: https://chromium-review.googlesource.com/768731 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49468}
-
v8-autoroll authored
Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f2ca3e0..509676b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5d6e78e23d83234c8c80eaef4a7c8a51c7575e6a Reviewed-on: https://chromium-review.googlesource.com/777929Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49467}
-
- 18 Nov, 2017 4 commits
-
-
Anna Henningsen authored
The existance of an `AllowJavascriptExecutionDebugOnly` scope in `Isolate::ReportPendingMessages()` indicates that the API supports running arbitrary JS code in a `AddMessageListener` callback. Currently, this can fail in debug mode: The `!isolate->external_caught_exception()` condition is checked when entering API methods inside such a handler. However, if there is a verbose `TryCatch` active when the exception occurs, this check fails, and when calling `ToString()` on the exception object leaves a pending exception itself, the flag is re-set to `true`. Fix this problem by clearing the flag and the pending exception if there was one during `ToString()`. This matches the code a few lines up in `messages.cc`, so the exception state is now consistent during the callback. This currently makes a Node.js test fail in debug mode (`parallel/test-error-reporting`). Bug: node:7144 Bug: node:17016 Change-Id: I060d00fea3e9a497f4df34c6ff8d6e29ebe96321 Reviewed-on: https://chromium-review.googlesource.com/718096 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49466}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5698e23..5718716 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/3196d83..461b345 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fd88dfb..37921f1 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/e07d437..ebf8d92 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e70074d..f2ca3e0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib22ef3b367d667199b3c3b12c892a1f7b476d7a7 Reviewed-on: https://chromium-review.googlesource.com/777595Reviewed-by:
-
Camillo Bruni authored
- This precents us from logging two ICEvents for a megamorphic miss that adds a new property - We don't have to reset the profiler ticks anymore for this miss The particular case for missing to add a new property happens ~1700 times in the Speedometer Angular benchmark where we get an already internalized key as property name. Change-Id: I2362c3b7a66d9def1bc4295f6f1e64c96b25fe8a Reviewed-on: https://chromium-review.googlesource.com/777259 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49464}
-
Adam Klein authored
Fixes instruction names to be all in one <td>, rather than being split between two due to miscalculation of op_offset. Change-Id: Ieef5d20c238c8e0a5b2316239324d375090006a1 Reviewed-on: https://chromium-review.googlesource.com/777761Reviewed-by:
-
- 17 Nov, 2017 30 commits
-
-
Jakob Kummerow authored
This CL creates the invariant that the BigInt class treats BigInt objects as immutable. Writing to new BigInt objects as part of their construction is done by the MutableBigInt helper class, which in turn is hidden as an implementation detail in bigint.cc. As a side effect, this refactoring enforces right-trimming checks for all newly created BigInts, and ensures that all BigInt allocations possibly exceeding kMaxLength check for this case and throw a RangeError instead of crashing. Bug: v8:6791 Tbr: mlippautz@chromium.org Change-Id: Id239746108e6b076b47a03ba37462001eb501507 Reviewed-on: https://chromium-review.googlesource.com/742329 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49462}
-
Ulan Degenbaev authored
The layout descriptor helper computes the object header size using map->instance_size() and map->GetInObjectProperties(). It races with finalization of slack tracking, which changes both the instance size and the in-object properties count. This patch replaces the in-object properties count byte in the map with the byte that stores the start offset of in-object properties. The new byte can be used in the layout descriptor to compute the object header size and it is immutable. This patch also renames InstanceSize to InstanceSizeInWords where the instance size is represented in words. Bug: chromium:786069, chromium:694255 Change-Id: I4b48c6944d3fe8a950bd7b0ba43d75216b177a78 Reviewed-on: https://chromium-review.googlesource.com/776720 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49461}
-
Igor Sheludko authored
Class' prototype temporarily got properies backing store inconsistent with the map which obviously confused heap verifier. Bug: v8:5799 Change-Id: Ie28b0418daa657763d07c8a928851111680718ed Reviewed-on: https://chromium-review.googlesource.com/777560Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49460}
-
Pierre Langlois authored
The logger for perf does not support relocating code objects so as a result we disable code space compacting to make sure code does not move. However, a a CodeMove event may still happen if a BytecodeArray object moves, which isn't relevant to the perf jit support so we can ignore it. Bug: Change-Id: Ie6acf58fe6adfb5cec2f8756f457134cf3b13c2a Reviewed-on: https://chromium-review.googlesource.com/759795Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#49459}
-
Leszek Swirski authored
Add another entry to the NoCacheReason enum, reporting that the chromium ScriptResource has no cache handler. Also, the amount of chromium-specific entries in this enum is getting too high. So, added a TODO for removing them -- possibly in the future we want to do this no-cache reason logging in Chromium after all, propagating isolate cache hits and consume failures back up the API with an out parameter. Bug: chromium:769203 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I63ca863cfef61e04e7104318eb79810796b61a9c Reviewed-on: https://chromium-review.googlesource.com/776893Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#49458}
-
Igor Sheludko authored
This CL also includes fixes for CF issues found while the previous reland was active. Bug: v8:5799, chromium:783902, chromium:783926, chromium:783822 Change-Id: I1f7d9b037d90838469c45f5d72771a77444c662e Reviewed-on: https://chromium-review.googlesource.com/764067Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Persistent handles are always independent these days. Users should mark weak handles as active using MarkActive if they want to keep weak handles that are otherwise unreachable alive across scavenges. Bug: chromium:780749 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I116e984ce14a035d1cef491d49f11a388fa8169d Reviewed-on: https://chromium-review.googlesource.com/759794 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Adam Klein authored
This reverts commit 236298ac. Reason for revert: suspected cause of failures on GC stress bots: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/16341 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/16269 Original change's description: > [wasm] Unify deoptimization data > > Add methods to add deoptimization data and use them from all the places > where we currently add them manually. Also add them to wasm-to-wasm > wrappers compiled on table set, which was missing before, leading to > the referenced bug. > > Drive-by: Disable non-applicable MaybeHandle constructors to allow > overloading functions with different Handle types. > > R=ahaas@chromium.org > > Bug: chromium:779292 > Change-Id: Ib9132d9faeb1092c46e22dd8196d201ce5c0942f > Reviewed-on: https://chromium-review.googlesource.com/774838 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49452} TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I02fb49d2ece8e04ac5fb26f618bfe6fb2f133d06 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:779292 Reviewed-on: https://chromium-review.googlesource.com/777079Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49455}
-
Jakob Gruber authored
This reverts commit 4d3bc552. Reason for revert: https://crbug.com/785778 Original change's description: > [coverage] add coverage for binary expressions > > Adds block-level coverage tracking for binary && and || > expressions. Introduces a BinaryOperation source-range > for tracking the operations themselves and an Expression > source-range, used for tracking NaryLogical expressions. > > This builds on work by jgruber@chromium.org in > the issue. > > TBR=marja@chromium.org > R=jgruber@chromium.org, rmcilroy@chromium.org > > Bug: v8:6660 > Change-Id: I83a81f13a3514a734c06948b2d3e91138fb00e18 > Reviewed-on: https://chromium-review.googlesource.com/754564 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49304} TBR=rmcilroy@chromium.org,marja@chromium.org,jgruber@chromium.org,ben@npmjs.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6660 Change-Id: Ie017c528604b2e01400f527511413eaea5786198 Reviewed-on: https://chromium-review.googlesource.com/776768Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49454}
-
Adam Klein authored
Both of these features were shipped in Chrome 62. Bug: v8:4545, v8:6172 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ie00dcbeded7517a15696d4a78fcfbbf162919923 Reviewed-on: https://chromium-review.googlesource.com/775601Reviewed-by:
-
Clemens Hammacher authored
Add methods to add deoptimization data and use them from all the places where we currently add them manually. Also add them to wasm-to-wasm wrappers compiled on table set, which was missing before, leading to the referenced bug. Drive-by: Disable non-applicable MaybeHandle constructors to allow overloading functions with different Handle types. R=ahaas@chromium.org Bug: chromium:779292 Change-Id: Ib9132d9faeb1092c46e22dd8196d201ce5c0942f Reviewed-on: https://chromium-review.googlesource.com/774838Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49452}
-
Jakob Gruber authored
This test iterates all builtin objects; explicitly deserialize builtins when necessary to avoid verifying DeserializeLazy by accident. Bug: v8:6624 Change-Id: Iab3f708380809b7486ef11a2816e9593ee7e65cd Reviewed-on: https://chromium-review.googlesource.com/654902 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:748057 No-Try: true Change-Id: I20a74823678510f343c865b074b2d088c1080b94 Reviewed-on: https://chromium-review.googlesource.com/776719 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49450}
-
Bill Budge authored
- Warn on unused result for OS Allocate, Free, SetPermissions, CommitRegion, UncommitRegion functions. - Adds CHECKS or DCHECK/USE around call sites. Bug: chromium:756050 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ic00b0a42a1e09bdba013b7fa2b1b4e2b7591bac6 Reviewed-on: https://chromium-review.googlesource.com/769792Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:748057 Change-Id: I013bae778c3cc1ccf545d33bf99aadb42ad49834 Reviewed-on: https://chromium-review.googlesource.com/775122 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49448}
-
Michael Achenbach authored
This reverts commit acfef3ec. Reason for revert: Makes logmaps timeout in nosnap mode: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/18933 Original change's description: > [log] Properly log all maps creating during bootstrapping > > Logger::LogMaps will print all maps currently present on the heap. > > Note that currently this does not properly log the detailed transitions > for these maps. > > Change-Id: Ia3218d371549d7634fe3eda9e8e59b0b0bd8bebb > Reviewed-on: https://chromium-review.googlesource.com/753885 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49444} TBR=yangguo@chromium.org,cbruni@chromium.org Change-Id: I264362552cbc2f8f0c1df84412f4dbeea08ef384 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/776815Reviewed-by:
-
Ulan Degenbaev authored
Bug: Change-Id: Ide7fab96e5ba1650aa17ba266e6ed2ed893208d7 Reviewed-on: https://chromium-review.googlesource.com/776658Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Since we only ever have preparsed scope info data for functions that haven't been parsed yet, it never overlaps with there being other function data (such as a bytecode array). So, we can merge the two fields. This drops the SharedFunctionInfo size by one pointer. Bug: chromium:783853 Change-Id: I7166010271cf661b04d3d118ac87c65c79555f96 Reviewed-on: https://chromium-review.googlesource.com/774863Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#49445}
-
Camillo Bruni authored
Logger::LogMaps will print all maps currently present on the heap. Note that currently this does not properly log the detailed transitions for these maps. Change-Id: Ia3218d371549d7634fe3eda9e8e59b0b0bd8bebb Reviewed-on: https://chromium-review.googlesource.com/753885Reviewed-by:
-
Predrag Rudic authored
This test uses 136GB of memory which is too much for our MIPS boards. NOTRY=true Bug: v8:7093 Change-Id: I382bf0832da6ae74241e89a2016c3738f03979fd Reviewed-on: https://chromium-review.googlesource.com/776765Reviewed-by:
-
Michael Starzinger authored
This removes support for optimized frame which lack deoptimization information. All optimized JavaScript frames now imply that the underlying bytecode is available too. R=rmcilroy@chromium.org BUG=v8:6409 Change-Id: Ie73c0a376002466884388f1da9e1ec2741884596 Reviewed-on: https://chromium-review.googlesource.com/612162 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 3e0bf580. Reason for revert: MSVC does not compile any more, see https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/172 Original change's description: > MIPS[64] Implementation of MSA instructions in builtin simulator > > This commit is a step toward enabling test-run-wasm-simd tests for MIPS. > 36 of those were failing in V8 builtin simulator because some instructions > were not implemented. Also there are minor fixes to some of the already > implemented instructions. > > This commit has only 32-bit implementation. After review I will add > 64-bit version. > > Bug: > Change-Id: I25b0cac352db3efb56b922ace64ab2aaef82472d > Reviewed-on: https://chromium-review.googlesource.com/744008 > Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> > Cr-Commit-Position: refs/heads/master@{#49439} TBR=jkummerow@chromium.org,mstarzinger@chromium.org,mlippautz@chromium.org,bmeurer@chromium.org,predrag.rudic@mips.com,ivica.bogosavljevic@mips.com,Ilija.Pavlovic@mips.com,sreten.kovacevic@mips.com,Miran.Karic@imgtec.com Change-Id: Ic0c6339473481fa75908e942bc86de2b5c6349d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/776655Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49441}
-
Clemens Hammacher authored
std::is_base_of<A, B> has undefined behaviour if B is not a complete type. Hence, avoid it and use is_convertible<B*, A*> instead. This captures exactly the requirement that Handle<A> foo() { return produce<Handle<B>>(); } is valid exactly if A* foo() { return produce<B>(); } is valid. Also, change some static asserts to enable_ifs in order to allow overloading a function by different Handle types, which would cause disambiguity otherwise. R=tebbi@chromium.org Change-Id: I60fbdfcfd96c7b216e42819a5b5de3423a2c38d0 Reviewed-on: https://chromium-review.googlesource.com/774841Reviewed-by:Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49440}
-
Predrag Rudic authored
This commit is a step toward enabling test-run-wasm-simd tests for MIPS. 36 of those were failing in V8 builtin simulator because some instructions were not implemented. Also there are minor fixes to some of the already implemented instructions. This commit has only 32-bit implementation. After review I will add 64-bit version. Bug: Change-Id: I25b0cac352db3efb56b922ace64ab2aaef82472d Reviewed-on: https://chromium-review.googlesource.com/744008Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
-
Ivo Markovic authored
Added return value registers on both MIPS32 and MIPS 64. Bug: Change-Id: I3199a73f90ef7b0bc9e18d716fcdf4c8c479f7fd Reviewed-on: https://chromium-review.googlesource.com/774286Reviewed-by:
-
Tom Anderson authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/98bbbff..5698e23 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/93a751e..3196d83 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/755a485..fd88dfb Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4b58512..e70074d R=machenbach@chromium.org Change-Id: If3f0ca871fbcf5e46876d2dab00b034dc496f91c Bug: Reviewed-on: https://chromium-review.googlesource.com/775632Reviewed-by:
-
Michael Achenbach authored
This reverts commit 01f670d8. Reason for revert: https://crbug.com/785170 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/98bbbff..610a818 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/93a751e..9c40f80 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/755a485..1087227 > > Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/e07d437..7f70365 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4b58512..c2f2e01 > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: Ic9902f605333991c0d33f91f22dca32763a7f21d > Reviewed-on: https://chromium-review.googlesource.com/775835 > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49435} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I9c0a5c9130a59dbdc45648062c1ed7d470ee7b13 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/776593Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/98bbbff..610a818 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/93a751e..9c40f80 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/755a485..1087227 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/e07d437..7f70365 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4b58512..c2f2e01 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic9902f605333991c0d33f91f22dca32763a7f21d Reviewed-on: https://chromium-review.googlesource.com/775835Reviewed-by:
-
Adam Klein authored
It was shipped in Chrome 62. Bug: v8:5070 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I77119540411d1fe15691d40012cb96f4e2e45048 Reviewed-on: https://chromium-review.googlesource.com/776154Reviewed-by:
-
Jakob Kummerow authored
"AbsoluteDivSmall" had a shortcut path for abs(divisor) == 1 where it would simply return the dividend as result. However, its caller "Divide" was blissfully ignorant of this trick and would therefore simply set the value's sign as needed, modifying the input. This CL prevents that, while continuing to avoid the full division algorithm for abs(divisor) == 1. Bug: v8:6791 Change-Id: I04cdc93f5ed2a696587c35c754e68f07012dd1a9 Reviewed-on: https://chromium-review.googlesource.com/772332 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
- 16 Nov, 2017 4 commits
-
-
Michael Achenbach authored
This reverts commit b8092f43. Reason for revert: Seems to crash all tests on arm debug: https://chromium-swarm.appspot.com/task?id=39df3b647e100a10&refresh=10&show_raw=1 Original change's description: > Remove no_custom_libcxx and update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/98bbbff..5698e23 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/93a751e..9c40f80 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/755a485..fd88dfb > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4b58512..e70074d > > R=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I659fc77cdada9b96c42b9b7ea86766b47b6f8352 > Reviewed-on: https://chromium-review.googlesource.com/775320 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49428} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,thomasanderson@chromium.org Change-Id: I9a6210bfdea9ad0d0a344a97bf0ce63d13e90288 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/775159Reviewed-by:
-
Brad Nelson authored
BUG=v8:7068 R=kschimpf@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iaf29d3696094722853fb67b29c697860752e256e Reviewed-on: https://chromium-review.googlesource.com/763995 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49431}
-
Bill Budge authored
- Adds SetPermissions method which returns bool result. - Eliminates Guard, SetReadAndWritable, SetReadAndExecutable, and SetReadWriteAndExecutable methods. - Adds some Fuchsia memory allocation implementation. - Some minor fixes in usage of OS::AllocatePageSize and OS::CommitPageSize. - Adds DCHECKs for sanitizing parameters to OS::Allocate/Free. Bug: chromium:756050 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I966ec6f029dd0371d70eca20bae197d87956f8b5 Reviewed-on: https://chromium-review.googlesource.com/760657 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Reland of https://chromium-review.googlesource.com/c/v8/v8/+/727893 The crashes should be fixed by https://chromium-review.googlesource.com/c/v8/v8/+/763531 Original change's description: > Revert "Reland^5 "[turbofan] eagerly prune None types and deadness from the graph"" > > This reverts commit ac0661b3. > > Reason for revert: Clusterfuzz unhappy: chromium:783019 chromium:783035 > > Original change's description: > > Reland^5 "[turbofan] eagerly prune None types and deadness from the graph" > > > > This gives up on earlier attempts to interpret DeadValue as a signal of > > unreachable code. This does not work because free-floating dead value > > nodes, and even pure branch nodes that use them, can get scheduled so > > early that they get reachable. Instead, we now eagerly remove branches > > that use DeadValue in DeadCodeElimination and replace DeadValue inputs > > to value phi nodes with dummy values. > > > > Reland of https://chromium-review.googlesource.com/715716 > > > > Bug: chromium:741225 chromium:776256 > > Change-Id: I251efd507c967d4a8882ad8fd2fd96c4185781fe > > Reviewed-on: https://chromium-review.googlesource.com/727893 > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#49188} > > TBR=jarin@chromium.org,tebbi@chromium.org > > Bug: chromium:741225 chromium:776256 chromium:783019 chromium:783035 > Change-Id: I6a8fa3a08ce2824a858ae01817688e63ed1f442e > Reviewed-on: https://chromium-review.googlesource.com/758770 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49262} TBR=jarin@chromium.org,tebbi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:741225 chromium:776256 chromium:783019 chromium:783035 Change-Id: I6c02b4beb02997ec34015ed2f6791a93c70f5e36 Reviewed-on: https://chromium-review.googlesource.com/772150 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
