Commits · 67101597160b513cfc9b240366a456c0f4a1ae9b · Linshizhi / V8

16 Jun, 2016 29 commits

PPC/S390: [builtins] Introduce proper Float64Log2 and Float64Log10 operators. · 67101597

jyan authored Jun 16, 2016

port d9bf520a

R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com

BUG=v8:5095

Review-Url: https://codereview.chromium.org/2070893002
Cr-Commit-Position: refs/heads/master@{#37043}

67101597

Revert of [heap] Add page evacuation mode for new->new (patchset #18 id:440001... · 2263ee9b

mlippautz authored Jun 16, 2016

Revert of [heap] Add page evacuation mode for new->new (patchset #18 id:440001 of https://codereview.chromium.org/1957323003/ )

Reason for revert:
Fragmentation of LABs could result in increasing memory usage (pages) instead of shrinking.

BUG=chromium:620320
LOG=N

Original issue's description:
> [heap] Add page evacuation mode for new->new
>
> Adds an evacuation mode that allows moving pages within new space without
> copying objects.
>
> Basic idea:
> a) Move page within new space
> b) Sweep page to make iterable and process ArrayBuffers
> c) Finish sweep till next scavenge
>
> Threshold is currently 70% live bytes, i.e., the same threshold we use
> to determine fragmented pages.
>
> BUG=chromium:581412
> LOG=N
> CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel
>
> Committed: https://crrev.com/49b23201671b25092a3c22eb85783f39b95a5f87
> Cr-Commit-Position: refs/heads/master@{#36990}

TBR=ulan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:581412

Review-Url: https://codereview.chromium.org/2063013005
Cr-Commit-Position: refs/heads/master@{#37042}

2263ee9b

S390: [wasm] Relocatable Globals. · b60da28c

jyan authored Jun 16, 2016

Port 2d1f977c

Original commit message:

    Support for relocatable globals, to facilitate compilation before
    instantiation.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com

BUG=v8:5072
LOG=N

Review-Url: https://codereview.chromium.org/2071883002
Cr-Commit-Position: refs/heads/master@{#37041}

b60da28c

S390: [Heap] Fix comparing against new space top pointer · a3b6f9bb

jyan authored Jun 16, 2016

Port d6473f5c

Original commit message:

    See bug description.

R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com

BUG=chromium:619382
LOG=N

Review-Url: https://codereview.chromium.org/2072723002
Cr-Commit-Position: refs/heads/master@{#37040}

a3b6f9bb

Revert of [builtins] Introduce proper Float64Exp operator. (patchset #5... · 789b0ad7

machenbach authored Jun 16, 2016

Revert of [builtins] Introduce proper Float64Exp operator. (patchset #5 id:80001 of https://codereview.chromium.org/2077533002/ )

Reason for revert:
[Sheriff] Leads to some different rounding as it seems in some audio layout tests. Please rebase upstream first if intended:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7508

Original issue's description:
> [builtins] Introduce proper Float64Exp operator.
>
> Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
> TurboFan operator based on that, similar to what we do for Float64Log.
> Rewrite Math.exp() as TurboFan builtin and use that operator to also
> inline Math.exp() into optimized TurboFan functions.
>
> BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
> R=mvstanton@chromium.org
>
> Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260
> Cr-Commit-Position: refs/heads/master@{#37037}

TBR=mvstanton@chromium.org,ahaas@chromium.org,bmeurer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108

Review-Url: https://codereview.chromium.org/2070813002
Cr-Commit-Position: refs/heads/master@{#37039}

789b0ad7

[wasm] Check for duplicate export names · 6fa656fd

clemensh authored Jun 16, 2016

Without this check, instantiation of the wasm module would fail on
DefineOwnProperty on the exports object for the duplicate export.
Now we detect this as validation error.

R=rossberg@chromium.org, titzer@chromium.org, ahaas@chromium.org

Review-Url: https://codereview.chromium.org/2065043002
Cr-Commit-Position: refs/heads/master@{#37038}

6fa656fd

[builtins] Introduce proper Float64Exp operator. · 93e26314

bmeurer authored Jun 16, 2016

Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.exp() as TurboFan builtin and use that operator to also
inline Math.exp() into optimized TurboFan functions.

BUG=v8:3266,v8:3468,v8:3493,v8:5086,v8:5108
R=mvstanton@chromium.org

Review-Url: https://codereview.chromium.org/2077533002
Cr-Commit-Position: refs/heads/master@{#37037}

93e26314

[wasm] Make reported "column number" 1-based · b16d51ef

clemensh authored Jun 16, 2016

We report the byte offset as column number, but devtools assumes them
to be 1-based and subtracts one unconditionally before further
processing it. It's a bit unfortunate, but because of that we have to
just add 1 to the reported column number on the public StackTrace API.

R=ahaas@chromium.org, titzer@chromium.org
BUG=chromium:613110

Review-Url: https://codereview.chromium.org/2071563002
Cr-Commit-Position: refs/heads/master@{#37036}

b16d51ef

[builtins] Introduce proper Float64Log2 and Float64Log10 operators. · d9bf520a

mvstanton authored Jun 16, 2016

BUG=v8:5095

Review-Url: https://codereview.chromium.org/2063693002
Cr-Commit-Position: refs/heads/master@{#37035}

d9bf520a

[es8] Unstage syntactic tail calls. · 76a51443

ishell authored Jun 16, 2016

BUG=v8:4915
LOG=Y

Review-Url: https://codereview.chromium.org/2072683002
Cr-Commit-Position: refs/heads/master@{#37034}

76a51443

[ic] LoadICState cleanup. · 5fcd3eb8

ishell authored Jun 16, 2016

LoadICState was used to hold the TypeofMode flag which is relevant only for LoadGlobalIC.
This CL removes usage of this state from LoadIC and KeyedLoadIC and renames the state
class to LoadGlobalICState.

BUG=chromium:576312
LOG=Y

Review-Url: https://codereview.chromium.org/2065373003
Cr-Commit-Position: refs/heads/master@{#37033}

5fcd3eb8

[d8] Make exception reporting more resilient. · 424d4f3b

Michael Starzinger authored Jun 16, 2016

This is a follow-up to a recent fix to make the exception reporting even
more resilient. The original regression test flushed out more issues on
different configurations.

TBR=yangguo@chromium.org
TEST=mjsunit/regress/regress-crbug-620253
BUG=chromium:620253
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/2071783002 .

Cr-Commit-Position: refs/heads/master@{#37032}

424d4f3b

[d8] Make exception reporting more resilient. · e55384b2

mstarzinger authored Jun 16, 2016

This makes sure exception reporting done by the debug shell behaves
gracefully even near the stack limit. When line number determination
fails we just fallback to not printing source information.

R=yangguo@chromium.org
TEST=mjsunit/regress/regress-crbug-620253
BUG=chromium:620253

Review-Url: https://codereview.chromium.org/2069543007
Cr-Commit-Position: refs/heads/master@{#37031}

e55384b2

[ic] Remove --new-load-global-ic switch. · d6b3b7e6

ishell authored Jun 16, 2016

BUG=chromium:576312
LOG=Y

Review-Url: https://codereview.chromium.org/2062343002
Cr-Commit-Position: refs/heads/master@{#37030}

d6b3b7e6

Revert of [turbofan] Properly handle dictionary maps in the prototype chain.... · 47fb39e4

bmeurer authored Jun 16, 2016

Revert of [turbofan] Properly handle dictionary maps in the prototype chain. (patchset #1 id:1 of https://codereview.chromium.org/2067423003/ )

Reason for revert:
As discussed offline with Toon, this is not the correct fix here.

Original issue's description:
> [turbofan] Properly handle dictionary maps in the prototype chain.
>
> Dictionary prototypes don't have stable maps, but still don't matter for
> element access. Generalized the JSNativeContextSpecialization a bit to
> handle everything that Crankshaft can handle in this regard.
>
> R=jarin@chromium.org
> BUG=chromium:616709
>
> Committed: https://crrev.com/1c7bdc7f6f4d9512f4982590bd949f265ee9c8c3
> Cr-Commit-Position: refs/heads/master@{#37019}

TBR=jarin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616709

Review-Url: https://codereview.chromium.org/2076493002
Cr-Commit-Position: refs/heads/master@{#37029}

47fb39e4

[wasm] Add functionality to decode a function offset table · 175fc180

clemensh authored Jun 16, 2016

This will be needed during debugging to know function boundaries within
the wasm module bytes, and to extract the bytes for a single function
to disassemble it.

R=titzer@chromium.org
BUG=chromium:613110

Review-Url: https://codereview.chromium.org/2055783002
Cr-Commit-Position: refs/heads/master@{#37028}

175fc180

[gn] Fix targets for x86 v8_target_arch · acfff97c

machenbach authored Jun 16, 2016

Those were wrongly translated from gyp with ia32. This should
land before renaming v8_target_arch to v8_target_cpu.

BUG=chromium:620527
NOTRY=true
TBR=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2065323004
Cr-Commit-Position: refs/heads/master@{#37027}

acfff97c

[wasm] Implement AST printing into an ostream · 12aa132d

clemensh authored Jun 16, 2016

This will be used for disassembling individual wasm function for
showing them in devtools.
The PrintAst function now also optionally provides an offset table
mapping from byte offset to line and column in the generated text.

R=titzer@chromium.org, ahaas@chromium.org
BUG=chromium:613110

Review-Url: https://codereview.chromium.org/2050213002
Cr-Commit-Position: refs/heads/master@{#37026}

12aa132d

[tools] make ic-explorer deal with empty map records from --trace-ic · 13d08bc3
cbruni authored Jun 16, 2016
```
BUG=

Review-Url: https://codereview.chromium.org/2062323003
Cr-Commit-Position: refs/heads/master@{#37025}
```
13d08bc3

[turbofan] Type feedback for numeric comparisons. · a49c4b0a

jarin authored Jun 16, 2016

Review-Url: https://codereview.chromium.org/2035383003
Cr-Commit-Position: refs/heads/master@{#37024}

a49c4b0a

PPC: [Heap] Fix comparing against new space top pointer · b95de044

bjaideep authored Jun 16, 2016

Port d6473f5c

Original commit message:

    See bug description.

R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=chromium:619382
LOG=N

Review-Url: https://codereview.chromium.org/2066603007
Cr-Commit-Position: refs/heads/master@{#37023}

b95de044

PPC: use Cmpi to handle case when kMaxRegularHeapObjectSize > 16bits · 3adefd71

bjaideep authored Jun 16, 2016

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2069363002
Cr-Commit-Position: refs/heads/master@{#37022}

3adefd71

PPC: [wasm] Relocatable Globals. · aa2e6a73

bjaideep authored Jun 16, 2016

Port 2d1f977c

Original commit message:

    Support for relocatable globals, to facilitate compilation before
    instantiation.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=v8:5072
LOG=N

Review-Url: https://codereview.chromium.org/2069163003
Cr-Commit-Position: refs/heads/master@{#37021}

aa2e6a73

[turbofan] Properly mark the Check/Checked operators are pure. · daf462a6

bmeurer authored Jun 16, 2016

Those operators don't have JavaScript observable side effects and would
otherwise block load elimination and other optimizations.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2075443003
Cr-Commit-Position: refs/heads/master@{#37020}

daf462a6

[turbofan] Properly handle dictionary maps in the prototype chain. · 1c7bdc7f

bmeurer authored Jun 16, 2016

Dictionary prototypes don't have stable maps, but still don't matter for
element access. Generalized the JSNativeContextSpecialization a bit to
handle everything that Crankshaft can handle in this regard.

R=jarin@chromium.org
BUG=chromium:616709

Review-Url: https://codereview.chromium.org/2067423003
Cr-Commit-Position: refs/heads/master@{#37019}

1c7bdc7f

[turbofan] The Check and Checked operators don't produce control. · 4d0768dc

bmeurer authored Jun 16, 2016

These operators don't need to be part of the control chain.

Drive-by-fix: Properly wire the effects during representation selection.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2073683002
Cr-Commit-Position: refs/heads/master@{#37018}

4d0768dc

[arm] BitcastF32U32 uses float registers. · 886f6b33

bbudge authored Jun 16, 2016

LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2050563002
Cr-Commit-Position: refs/heads/master@{#37017}

886f6b33

Update V8 DEPS. · 7596b5c6

v8-autoroll authored Jun 16, 2016

Rolling v8/build to 76e9bd0241b00735b5bc402c926d7cb141a726ef

Rolling v8/buildtools to 3780bc523aad1d68a5bd00e05c453a80b2ba0b35

Rolling v8/tools/clang to 8b0c8f71a4d41c7d2cd0d898f3547e9984f79b5d

Rolling v8/tools/mb to bc05800a7cd7833ad7c2d1423cd8b2153470c9bd

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review-Url: https://codereview.chromium.org/2069333002
Cr-Commit-Position: refs/heads/master@{#37016}

7596b5c6

Promises: Add regression test for promise resolution with proxy · 3624a5e1

gsathya authored Jun 16, 2016

BUG=v8:5004

Review-Url: https://codereview.chromium.org/2070213002
Cr-Commit-Position: refs/heads/master@{#37015}

3624a5e1

15 Jun, 2016 11 commits

S390: [debugger] simplify debug stepping. · c304d414

jyan authored Jun 15, 2016

Port 3e2d60d8

R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com

BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2069193003
Cr-Commit-Position: refs/heads/master@{#37014}

c304d414

[Turbofan] Make operand canonicalization distinguish between FP types. · 70d83fbd
bbudge authored Jun 15, 2016
```
Review-Url: https://codereview.chromium.org/2054343002
Cr-Commit-Position: refs/heads/master@{#37013}
```
70d83fbd

S390: [turbofan] Prevent storing signalling NaNs into holey double arrays. · 2dedf215

jyan authored Jun 15, 2016

Port 6470ddad

Original commit message:

    This introduces SilenceNaN operator, which makes sure that we only
    store quiet NaNs into holey arrays. We omit the NaN silencing code
    at instruction selection time if the input is an operation that
    cannot possibly produce signalling NaNs.

R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com

BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2070583002
Cr-Commit-Position: refs/heads/master@{#37012}

2dedf215

[wasm] Support for memory size relocation for asm-wasm. · c5e3c9bf

mtrofin authored Jun 15, 2016

Only Intel needed changes, arm and mips work as expected.

BUG=

Review-Url: https://codereview.chromium.org/2061833003
Cr-Commit-Position: refs/heads/master@{#37011}

c5e3c9bf

[heap] Add inlined fast path for JSArrayBuffer (un)register in tracker · 5846acc2

mlippautz authored Jun 15, 2016

BUG=chromium:619491,chromium:611688
LOG=N
R=ulan@chromium.org

Review-Url: https://codereview.chromium.org/2065013002
Cr-Commit-Position: refs/heads/master@{#37010}

5846acc2

[mb] Whitespace change to test mb switch · 6368b0d9
Michael Achenbach authored Jun 15, 2016
```
Cr-Commit-Position: refs/heads/master@{#37009}
```
6368b0d9

[snapshot] support multiple contexts in the same snapshot. · 533453f9

yangguo authored Jun 15, 2016

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892

Review-Url: https://codereview.chromium.org/2055203002
Cr-Commit-Position: refs/heads/master@{#37008}

533453f9

PPC: [debugger] simplify debug stepping. · 85bef237

bjaideep authored Jun 15, 2016

Port 3e2d60d8

R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2065423002
Cr-Commit-Position: refs/heads/master@{#37007}

85bef237

[ic] Enable new LoadGlobalIC machinery. · b6aa77d9

ishell authored Jun 15, 2016

BUG=chromium:576312
LOG=Y

Review-Url: https://codereview.chromium.org/2066763004
Cr-Commit-Position: refs/heads/master@{#37006}

b6aa77d9

Introduce JIT code events dispatcher for the isolate. · 9df23510

alph authored Jun 15, 2016

The patch introduces a dedicated dispatching class for JIT code events. It is
set as a helper on the isolate.
This allows classes across v8 to break their dependency on Logger and CpuProfiler.
These two became just regular clients of the dispatcher.

BUG=v8:4789

Review-Url: https://codereview.chromium.org/2061623002
Cr-Commit-Position: refs/heads/master@{#37005}

9df23510

[interpreter] Teach register optimizer about SuspendGenerator. · 6073a342

neis authored Jun 15, 2016

When seeing a SuspendGenerator bytecode, the register optimizer must flush its
state.

R=oth@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2071443002
Cr-Commit-Position: refs/heads/master@{#37004}

6073a342