- 25 Sep, 2020 19 commits
-
-
Clemens Backes authored
Operations on locals are the most common wasm operations (especially local.get), and just computing the number of locals from the vector shows up with a few percent in the profile. Storing this number separately removes a few percent of execution time from the {DecodeLocalGet} method. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I9c12842c944e4ad2e602e05838948a33922ff438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429950Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70148}
-
Bill Budge authored
Bug: v8:10933 Change-Id: I4db540cf47ce5cfa25757d776a2bf988ce3ed554 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432072Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#70147}
-
Ng Zhi An authored
i8 and i16 nodes are stored in word32 nodes, when splat-ing them, we need to make sure to handle overflow values and also sign extend them correctly. This fix allows us to pass simd-splat.js. It still fails on ARM (non-simulator) due to a use of f32x4.min in the test. Bug: v8:10507 Change-Id: I1507637a7edb33a530c84c85ee8d4acb481293e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2430170Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70146}
-
Almothana Athamneh authored
Add opt and noturbo inlining to these tests to ensure that they keep working. Bug: v8:10924 Change-Id: Icdb5ddffad11ea3c2eea723e339d450d8405b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426604 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70145}
-
Gus Caplan authored
This fixes the logic in the desugaring of destructuring assignments. In particular, a spread element would not check if previous `next` results had already been done, and would always call `next()` again. Change-Id: I1bd384678722e6cf51c5777fc3b0dd965360291a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2430488 Commit-Queue: Gus Caplan <snek@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#70144}
-
Adam Klein authored
These instructions were changed from "s8x16" to "i8x16" prefixes in https://github.com/WebAssembly/simd/pull/321. This CL updates all V8 code, including arch-specific code, to match. Bug: v8:10946, v8:10933 Change-Id: I26ef9ad77571f94501d42c1d65f57380fd507f3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432068Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#70143}
-
Francis McCabe authored
This reverts commit 22c0fc8f. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20gcc/8712? Original change's description: > cppgc: Provide jobs support through DefaultPlatform and TestPlatform > > This CL extends cppgc::DefaultPlatform and TestPlatform to emulate > jobs using std::thread and v8::base::Thread respectively. > Jobs using these platform do not yield unless the job as been > cancelled. Additionally, the job priority is ignored. > > Bug: chromium:1056170 > Change-Id: I72db1eef410d2be3d3e5ea7d4ece9e5584a451f2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416378 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70139} TBR=mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: Ic29235e3ab78a1b515a5b14b808e116a1ccffc0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432087Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70142}
-
Santiago Aboy Solanes authored
Bug: v8:9708, v8:6949 Change-Id: Ic219e0eb18648166a712493039f96e067ad47418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2395555Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#70141}
-
Victor Gomes authored
- InterpretedFrames are just StandardFrames with 2 extra values. - BuiltinExitFrames are ExitFrames with 4 extra expected arguments. Change-Id: I2c4e4a24185bfa0f23ff63616c8ef66780506796 Bug: v8:10933 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429948Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Omer Katz authored
This CL extends cppgc::DefaultPlatform and TestPlatform to emulate jobs using std::thread and v8::base::Thread respectively. Jobs using these platform do not yield unless the job as been cancelled. Additionally, the job priority is ignored. Bug: chromium:1056170 Change-Id: I72db1eef410d2be3d3e5ea7d4ece9e5584a451f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416378 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#70139}
-
Etienne Pierre-Doray authored
This reverts commit 92f815a8. Reason for revert: broke tests; see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33395? Original change's description: > Reland "[Heap] ScavengerCollector use Jobs." > > This is a reland of 9e8c54f8 > Safe to reland as-is with fix in AcquireTaskId > https://chromium-review.googlesource.com/c/v8/v8/+/2401964 > > Additional changes are made in the reland: > -TRACE_GC is be split for background/foreground scope. > -New IndexGenerator is used for dynamic work assignement. > > Original change's description: > > [Heap] ScavengerCollector use Jobs. > > > > No yielding is necessary since the main thread Join()s. > > > > max concurrency is determined based on either > > remaining_memory_chunks_ or global pool size > > (copied_list_ + promotion_list_) > > > > Change-Id: Ie30fa86c44d3224b04df5d79569bce126ce7d96b > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354390 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#69746} > > Change-Id: Id9d7a5bf3b2337ae4cf1e76770f4b14ebb8ca256 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2399041 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70135} TBR=ulan@chromium.org,etiennep@chromium.org Change-Id: I4823c642546b82a9a9c8955151cd8784e4b86bc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431551 Commit-Queue: Francis McCabe <fgm@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This is a reland of 64caf2b0 Original change's description: > [torque] refactor: use -tq only in filenames derived from .tq files > > This is to establish a naming rule for Torque-generated files: > - If the file is called foo/bar-tq..., then it is derived from a > file foo/bar.tq > - Otherwise it doesn't belong to a specific .tq file. > > So far, we attached -tq to all Torque-generated file names, where it > sometimes corresponded to a .tq file name and sometimes not. > It is not necessary to add -tq to file names to indicate that they are > Torque-generated, since they are already in a directory called > torque-generated, and we always refer to them as > "torque-generated/filename", so there is no confusion even though some > files now have the same name as a corresponding hand-written file, for > example factory.cc. > > TBR: hpayer@chromium.org > Bug: v8:7793 > Change-Id: Ie172babad1fc7422fd1059c48f5dafaa53e50c8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414218 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70060} Bug: v8:7793 TBR: hpayer@chromium.org jgruber@chromium.org Change-Id: I6c492bc64aee1ff167e7ef401825eca9097a7f38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431565 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70137}
-
Milad Fa authored
Change-Id: I92d4962354559990e346df7efae272ae1f74e528 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431467Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Etienne Pierre-doray authored
This is a reland of 9e8c54f8 Safe to reland as-is with fix in AcquireTaskId https://chromium-review.googlesource.com/c/v8/v8/+/2401964 Additional changes are made in the reland: -TRACE_GC is be split for background/foreground scope. -New IndexGenerator is used for dynamic work assignement. Original change's description: > [Heap] ScavengerCollector use Jobs. > > No yielding is necessary since the main thread Join()s. > > max concurrency is determined based on either > remaining_memory_chunks_ or global pool size > (copied_list_ + promotion_list_) > > Change-Id: Ie30fa86c44d3224b04df5d79569bce126ce7d96b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354390 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69746} Change-Id: Id9d7a5bf3b2337ae4cf1e76770f4b14ebb8ca256 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2399041Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#70135}
-
Andreas Haas authored
In atomic.wait we overwrote the register which stored the index, without checking if it was still in use or not. R=clemensb@chromium.org Bug: v8:10898 Change-Id: Iab6e1a84c71887af81d307c4ca795109ce2fdfc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428928 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70134}
-
Mythri A authored
CallOrConstructWithArrayLike and CallOrConstructWithSpread builtins expect only Smi in the array length field. This is true when we have fast elements kind, but for dictionary mode we can have HeapNumbers This cl fixes by moving the loading of length fields after the check on elements kind to avoid loading length fields on dictionary mode JSArrays. Change-Id: I838a260353efa25fb0357e6f03247d3075cebe3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431206 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10933 Change-Id: Ie2f1cdc1cad9e4e68ace0eedfd2456f5487b5107 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428586 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Andreas Haas authored
When stack slots are spilled after the register moves, some registers may get overwritten, e.g. by constants. R=clemensb@chromium.org Change-Id: Ie94aff0fd63cd9c271b90df34895818594cee3b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429032Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:10942 Change-Id: Icbb1d8e054ee924a77f1fbeb9e48cde604ef69b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422001Reviewed-by:
-
- 24 Sep, 2020 21 commits
-
-
Bill Budge authored
- Adds a --harmony-atomics feature to gate Atomics. This allows us to independently add SharedArrayBuffer and Atomics on the global object of Contexts, which is necessary for migration to a COOP+COEP site isolation requirement. Bug: chromium:923807 Change-Id: If80c12eb86dc0251a5e5fad62a6dd5ced3380b5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2340322 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70129}
-
Ng Zhi An authored
f32x4->16x8, 64x2->8x16, and 16x8->8x16. This allows us to pass more spec tests. Bug: v8:10507 Change-Id: I1810ce2d17f93529b2e69cf5c767cb7b480b4b49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429807Reviewed-by:
-
Milad Fa authored
Using the proper `add` operation assures the NAN value is properly propagated to the result register. Change-Id: Icb86193f85534604f2a4a583d177a6f319ca38c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429804Reviewed-by:
-
Dominik Inführ authored
PagedSpace::RefillFreeList() needs to invoke wasted_memory() while holding the lock. Otherwise this races with PagedSpace::FreeLinearAllocationArea() which uses add_wasted_memory() and already holds the lock. Bug: v8:10315 Change-Id: I3a57191529cdd81d75833ec334a57f84a9a59194 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428930Reviewed-by:
-
Andreas Haas authored
In atomic.notify we overwrote the register which stored the index, without checking if it was still in use or not. R=clemensb@chromium.org Bug: v8:10898 Change-Id: I59ed7a2c1f1342ff4252e3c4d33822111caee82c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426616Reviewed-by:
-
evih authored
When loading from the exported function data without pointer compression, wrong load was used before. Bug: v8:10701, chromium:1130385 Change-Id: If66913bcd5284eeb6fb7b795357f1512682a062f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426383 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Junliang Yan authored
On ppc64 and s390x, Liftoff is not implemented yet, so if a Liftoff compilation unit finishes after all top-tier units (hence after the "top tier finished" callback), it will still increase the turbofan counter. R=clemensb@chromium.org, ecmziegler@chromium.org Bug: chromium:1092417 Change-Id: I0b99061f26851288f1abb8fcc3a30ca92a55164e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429564Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This test checks SizeOfObjects after GC, but there might be concurrent allocations in-between. Bug: v8:10315 Change-Id: Id904c8865e44ac5c3b486ff6f1316e536cf20e9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428864Reviewed-by:
-
Clemens Backes authored
The memory offset is read as a u64 in the memory64 proposal, independent of the actual type of the memory. The actual memory size of a module (at runtime) can only be within intptr_t/uintptr_t range though. This assumption was already used when constructing the TurboFan graph, but the C++ types did not reflect it yet. This CL fixes that: 1) Use uint64_t type for bounds checks (only within the method for now, callers still pass a uint32_t). 2) Use uintptr_t for storing the minimum and maximum possible memory size at runtime (in CompilationEnv); clamp memory sizes to values that can actually happen at runtime. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: I6559f9a3abc2aa338eba4618479456f6efb5e772 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426405Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70121}
-
Dominik Inführ authored
Make sure that tests grow the new space in a safepoint. This fixes races with concurrent allocation. Bug: v8:10315 Change-Id: I6fce6740bc3c9385f18bbbcde4b06ba881a03635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428946Reviewed-by:
-
Santiago Aboy Solanes authored
When reading the FixedDoubleArray value and representation, we are reading the same value but bitcasting it diffrently. In this vein, we can read it only once and ask whether it is the hole or not. Bug: v8:7790 Change-Id: I0d7b29ce037b9abb55c5a1332c7e6d06887905e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428587Reviewed-by:
-
Manos Koukoutos authored
Changes: - Add dedicated exception for call_ref invoking a WasmJSFunction. - Small restructuring of read_value_type. - Change HeapType::kLastSentinel to point to the last valid type, update is_valid(). - Remove redundant DCHECK from ValueType constructors. - Rename a few section-related macros in module-decoder-unittest.cc, add a small test. - Rename "Simd128" -> "s128" in error message. - Write some documentation, mostly in value-type.h and wasm-subtyping.h. Bug: v8:7748 Change-Id: I4fc4826fbdeac50e21ef524787c2024d7aa1b3b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424139 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70118}
-
Ulan Degenbaev authored
Change-Id: I5d82528cd07c263bfbedfdd3a090bcd4f67ef55d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428593Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:1130673 Change-Id: I78ae388daa1c4c2b594981bdadd201c2dfb39eb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426618Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70116}
-
Dominik Inführ authored
Avoid data race by only setting FLAG_local_heaps to true if not already enabled. Bug: v8:10315 Change-Id: Ib562b6d525448f5c088da39bf60928debd97db43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426610Reviewed-by:
-
Clemens Backes authored
This unifies {max_initial_mem_pages} and {max_maximum_mem_pages} into {max_mem_pages}. The {CompilationEnv} constructor was incorrectly using the former instead of the latter anyway. This did not really matter though, since they typically have the same value. Also, there is not a single test that sets --wasm-max-mem-pages-growth. R=manoskouk@chromium.org CC=jkummerow@chromium.org Bug: v8:10949 Change-Id: Ib7ab9b4c239d50b72013087eda5a214829c90369 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426619Reviewed-by: -
Emanuel Ziegler authored
Ensure that events are triggered when a module is decoded, compiled, instantiated and tiered-up. This is a reland of Ib5883a338c3756c6f3488fbdd7b6861ecc2ba218. R=clemensb@chromium.org TBR=adamk@chromium.org Bug: chromium:1092417 Change-Id: I803ae3db23a5f71f26e8ec118251eccdfc551353 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2425056 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Marja Hölttä authored
The actual fix is in LoadIC::ComputeHandler (checking lookup_start_object == holder instead of receiver == holder) + the LookupIterator changes for preserving lookup_start_object. The rest is renaming / refactoring. Reland: not relying on the prototype validity cell after all Previous version: https://chromium-review.googlesource.com/c/v8/v8/+/2414039 Bug: v8:9237, chromium:1127653 Change-Id: I1949442f8ddcecb776f0c5d2cf737cb75f80e313 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428588Reviewed-by:
-
Dominik Inführ authored
Use Global instead of Persistent such that GlobalHandle is reset at the end of the function. Persistent doesn't reset in the destructor, which means that the GC resets the GlobalHandle. With --stress-concurrent-allocation this might not happen in the test function itself but when the cctest framework itself works through the event queue. At that point the Persistent isn't live anymore. Bug: v8:10315 Change-Id: If77388ad5acb80538852beca0ab22a4ebaf0b5c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426612 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a first small step for implementing the memory64 proposal: 1. Add a feature flag. 2. Add the 0x04 and 0x05 limits flag for memory64. 3. Read memory limits as LEB-encoded u64 (instead of u32) if a memory64 limit flag was read. 4. Unify {MaximumFlag} and {MemoryFlag}, which was used inconsistently before. 5. Add test for memory limits encoded with >5 bytes. 6. Move some macros from module-decoder-unittest.cc to wasm-macro-gen.h. Note that still the same limits for the maximum number of pages applies as before, i.e. you cannot specify a memory >4GB yet. But you can encode that small number in >5 bytes. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: I90a4f08426ae714a67440281785eb00cfc24a349 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423712 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
gengjiawen authored
Fix: https://github.com/nodejs/node-v8/issues/172 Change-Id: Ibdbee76470ec8a4c20af7650dc5fac4602873430 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414688Reviewed-by:
-
