- 25 May, 2021 7 commits
-
-
Andreas Haas authored
R=victorgomes@chromium.org Change-Id: I2f6ba1d0b127567859c57dd42b73d7e4e0a8d29e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912728Reviewed-by: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74730}
-
Ulan Degenbaev authored
The underlying issue was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2505724 Bug: v8:7605,v8:8296 Change-Id: I4a35fd4b73f86934a9d1339655433e2d4c26bd53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912890Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74729}
-
Ulan Degenbaev authored
The test has a loop that allocates large objects until it gets an allocation failure. The test then asserts that the subsequent allocation should also fail. That however does not necessarily hold because the previously allocated objects may be collected to free up the space. This change creates a handle for each allocated object. It also restricts the size of the heap to 20MB to reduce memory consumption. Bug: v8:11172 Change-Id: Ic3dc1a0f5f235b0313bab2071546b59a77bd55e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912884 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74728}
-
Andreas Haas authored
With this CL it is not possible anymore to initialize a func ref table with extern ref ref.null. R=manoskouk@chromium.org Change-Id: If6023da6fc21844dd813cc6191f2a4ca595f8b00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912577 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74727}
-
Paolo Severini authored
Lite-mode builds were broken by https://chromium-review.googlesource.com/c/v8/v8/+/2805623 [compiler] Generalize CallWithArrayLike optimization This patch fixes the build. Bug: v8:9974 Change-Id: I07530307e321a260a5d8ff59ab2c440764ebfc41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2915678Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#74726}
-
Manos Koukoutos authored
This is required by the register allocator. Bug: v8:11796 Change-Id: I714576fdd89487b88e5c412fe0d2981eb39210d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756538Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74725}
-
Benedikt Meurer authored
Following up on https://crrev.com/c/1946349, this moves the blocklist to the ScopeInfo instead of storing it directly on the DebugEvaluate contexts. This is not the final state that we're looking for, but a small step along the way. Bug: chromium:1027475, v8:9938, chromium:1072939 Change-Id: I529f2fcacaf057a1236847bf0eb8e12cc1686515 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910774Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#74724}
-
- 24 May, 2021 5 commits
-
-
Paolo Severini authored
CallWithArrayLike was optimized in TF only for 'arguments' in inlined functions. Here we add logic to optimize also in non inlined functions, enabling the rewriting of Function.prototype.apply(f, [1, 2, 3]) as f(1, 2, 3). Bug: v8:9974 Change-Id: Icc9ccfc2276f75d06755176b55e7a02ddfdb04ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2805623 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74723}
-
Liu Yu authored
Port e5a53a4c Bug: v8:11767 Change-Id: I4214f844932c4b7b4f91c3c983cd9228c7975891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2914772 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74722}
-
Santiago Aboy Solanes authored
This is a reland of 2c096b53 Relanding as-is. Reason for reland: was speculatively reverted. Original change's description: > [codegen] Add TSAN support for tagged stores in generated code > > Mimics the kArchStoreWithWriteBarrier store in generated code by having > a relaxed store to the same address, with the same value. This is done > in order for TSAN to see these stores from generated code. > > Since it is done only for kArchStoreWithWriteBarrier TSAN will see > tagged stores only. > > Bug: v8:7790, v8:11600 > > Change-Id: I275dd46f5556b3a095c416adc03f2f0ac5bde41c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848470 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74568} Bug: v8:7790 Bug: v8:11600 Change-Id: Id1616a0f65b56cb96ca2ffd25d6ef51d0e7230da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2914874 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74721}
-
Liu Yu authored
In WasmCapiCallWrappers, the address is passed in a register instead of as an immediate, so we reduced 3 instructions to load the address to t9; before: lui + ori + dsll + ori; after: mov; Port: 54d84cf3 Bug: v8:11774 Change-Id: I423e54216ff65f1c12128c2b26443e1838b68003 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2914771 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74720}
-
Jakob Gruber authored
.. for ObjectData creation. Bug: v8:7790 Change-Id: I45ca3d8f404862752c2a9c7e7dc983d8f509624a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909861 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74719}
-
- 21 May, 2021 16 commits
-
-
Michael Achenbach authored
No-try: true Bug: v8:5861 Change-Id: I7d09d796788abeced5cae86ff52c052efc0fa456 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912789 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#74718}
-
Milad Fa authored
Port ec4fd32c Original Commit Message: This ports https://crrev.com/c/2905602 to the other platforms. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I23b4e944440b9189b12ae26d7b6c33bd07a53cbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912781Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74717}
-
Georg Neis authored
Bug: v8:11805 Change-Id: Ieb366a45ef0bdb69a64b4e3cc7b0715d7617141d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912592 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74716}
-
Nico Hartmann authored
Register allocator experienced some issues with multiple nodes for the same parameter, which occurred in a few cases running turboprop. This CL adds caching of Parameter nodes in BytecodeGraphBuilder such that there exists only one node for each parameter index. Bug: v8:11796 Change-Id: I90be5438f43368510ec4c317fa532c92a446e76a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910314 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74715}
-
Clemens Backes authored
This ports https://crrev.com/c/2905602 to the other platforms. R=cbruni@chromium.org Change-Id: Iee941d22449b1e05bc131cc05d87e036e8f223d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912588Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74714}
-
Igor Sheludko authored
... and use the generated WasmObject instance type range for data refs checks. Bug: v8:11804 Change-Id: I855ff76404ff7e3ca919dabec238d35cb39c0baf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910784 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74713}
-
Michael Achenbach authored
This adds a new status file indicator "HEAVY" to mark tests with high resource demands. There will be other tests running in parallel, but only a limited number of other heavy tests. The limit is controlled with a new parameter --max-heavy-tests and defaults to 1. The change also marks a variety of tests as heavy that recently had flaky timeouts. Heavy also implies slow, hence heavy tests are executed at the beginning with a higher timeout like other slow tests. The implementation is encapsulated in the test-processor chain. A new processor buffers heavy tests in a queue and adds buffered tests only if other heavy tests have ended their computation. Bug: v8:5861 Change-Id: I89648ad0030271a3a5af588ecc9c43285b728d6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905767 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#74712}
-
Ross McIlroy authored
They have been disabled for some time and are superseeded by lazy feedback vector allocation. Change-Id: Iafc3989b0c1f866ce7d6295d9b13ccaa5ef1c115 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905609Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74711}
-
Andreas Haas authored
R=ecmziegler@chromium.org Change-Id: Ibe9b1793a60d21ba853501b19c53647be5321288 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910786Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74710}
-
Manos Koukoutos authored
Additional changes: - Clean up liftoff implementation of br_on_*. - Bundle operations everywhere based on operation rather than type. - Remove reference argument from WASM_BR_ON_* macros, to bring them in sync with WASM_BR_ON_CAST. - Add missing function decoding unittests for br_on_*. Bug: v8:7748 Change-Id: I5f5ebfac5b50b5a9a201acb435344d7471326242 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909857Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74709}
-
Mythri A authored
AsmWasmFunctions don't allocate / use feedback vectors. Bug: chromium:1206289 Change-Id: I970d5eaba6603809a844c2fc5753efba411cd719 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909854 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74708}
-
Ulan Degenbaev authored
Dev experiment shows it helps to mitigate crashes on some Android devices. Bug: chromium:889460,v8:11619 Change-Id: I8c836e82e93f6373724d66598448c2610ab188d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910775 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74707}
-
Marja Hölttä authored
Existing tests already exercise KeyedStoreIC; this CL makes them take the fast path instead of the slow path. Bug: v8:11111 Change-Id: I13b84650ae37abe1a8a46d53c9a9b7104bed31de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910315 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#74706}
-
Nico Hartmann authored
Generating C++ source files is very cumbersome using raw ostreams. This CL introduces a few classes und the torque::cpp namespace that build an abstraction of printing/formatting C++ source code (mostly functions for now). This is an initial implementation with a limited set of features and uses. Landing features incrementally shall avoid huge CLs (+reviews) and complex rebasing. Bug: v8:7793 Change-Id: I3ae869755156175c7b37ea9f649e2f9c431ce3a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784688Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74705}
-
Ross McIlroy authored
These don't improve codegen and are unecessary overhead. BUG=v8:9684 Change-Id: I2feb1c1200eb0c347f4a21be5444b6a15924e6de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903162Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74704}
-
Benedikt Meurer authored
Trivial follow up fix for https://crrev.com/c/1946349 which fixes the call to length on a half-initialized ScopeInfo. ScopeInfo::length() looks at the uninitialized fields (i.e. in case of ScopeInfo for module scopes) and would thus crash. Bug: chromium:1027475, v8:9938, chromium:1072939 Change-Id: I7e4e81edfbbde25063ab40b8e7807fd70625a8a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910773 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#74703}
-
- 20 May, 2021 12 commits
-
-
Junliang Yan authored
Change-Id: Ia1b8bf3ada1957c27334e98207d57bb2e644ecdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910796 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74702}
-
Milad Fa authored
This CL adds vector splat byte, word and halfword to codegen, disassembler and the simulator. It also optimizes a number of Simd opcodes by using the added instructions as well as VSX splat immediate (xxspltib). Change-Id: I2c4eba33e81542f901d7cdc669c50b510e48c4c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909525Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74701}
-
Santiago Aboy Solanes authored
Continuing the cleanups and using the tags rather than synchronized_ in the name of the accessors. Bug: v8:7790 Change-Id: I3fe942b1decae3b248f8662547d793777acd0e8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897096 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74700}
-
Sathya Gunasekaran authored
This reverts commit 1186fc50. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/16531/overview Original change's description: > [heap] Disable the young generation in shared heaps > > A shared heap will not have a young generation in the beginning. > > Bug: v8:11708 > Change-Id: I947ddb91a23a72a8cee3aa3e554723dda8146011 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891569 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74697} Bug: v8:11708 Change-Id: I8de67f70b00b5bd3066659e07fb1fd3ecfb76211 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909693 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74699}
-
Ulan Degenbaev authored
This also removes small TODOs that are not worth tracking in a bug Change-Id: If61acd1239ac90a908327694b280846b1f676c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909859Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74698}
-
Dominik Inführ authored
A shared heap will not have a young generation in the beginning. Bug: v8:11708 Change-Id: I947ddb91a23a72a8cee3aa3e554723dda8146011 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891569 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74697}
-
Michael Hablich authored
TBR=machenbach@chromium.org notry=true Change-Id: I9110ef10d6e817b64a377108158014cd9f04ad84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910321Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#74696}
-
Ulan Degenbaev authored
Calling Heap::Print in GC is not safe because the function tries to print the stack and may allocate. Change-Id: I48fe29863076792657e2184c52d355821375f969 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2835239Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74695}
-
Clemens Backes authored
The old code was relying on identical alignment of both the source and the destination of the Relaxed_Memcpy. This is not always given, thus check for alignment of both. R=mlippautz@chromium.org Bug: chromium:1208782, v8:11704 Change-Id: Ic5dca3a5f0ecaea0df6eb123105520bd7785853c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905611Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74694}
-
Michael Lippautz authored
Used include-what-you-use [1] to clean up cppgc API headers. The tool does somewhat work but requires some cleanup afterwards as it cannot nicely deal with `v8config.h` and the defines it generates. [1] https://github.com/include-what-you-use/include-what-you-use/ Bug: chromium:1056170 Change-Id: I7b03797c615f8e033510fc959bbdb792d8b7a4ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2907612Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74693}
-
Ulan Degenbaev authored
Change-Id: Idbe26a82ba0e208985ab2b1e5b85c6f98c3ec925 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844663Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74692}
-
Georg Neis authored
Also make the output more helpful in the error case. Bug: v8:11724 Change-Id: Ibb8bd328f936f3d4f847ba7e14adf9c30b9460f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903158 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74691}
-