- 17 Dec, 2015 1 commit
-
-
neis authored
And remove confusing comment. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1531843003 Cr-Commit-Position: refs/heads/master@{#32935}
-
- 02 Dec, 2015 1 commit
-
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1484393002 Cr-Commit-Position: refs/heads/master@{#32506}
-
- 30 Nov, 2015 1 commit
-
-
mstarzinger authored
This switches several builtin methods to use the ES6 new.target value when determined whether being called as a constructor or not. This is prepatory work for fully deprecating the aforementioned intrinsic. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1477073005 Cr-Commit-Position: refs/heads/master@{#32397}
-
- 22 Oct, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1413173003 Cr-Commit-Position: refs/heads/master@{#31467}
-
- 15 Oct, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1404943002 Cr-Commit-Position: refs/heads/master@{#31285}
-
- 13 Oct, 2015 1 commit
-
-
mstarzinger authored
This moves JavaScript source files that are bundled with V8 into a separate directory. The goal is to improve code readability and also being able to formalize ideal reviewers by subsequently adding the OWNERS file. These files almost exclusively contain implementations of methods fully specified by ES6. Note that files in the "debug" directory as well as the "d8.js" file aren't affected by this change. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1398733002 Cr-Commit-Position: refs/heads/master@{#31230}
-
- 08 Sep, 2015 1 commit
-
-
bmeurer authored
The semantics of the %_CallFunction intrinsic seem to be very unclear, which resulted in a lot of bugs. Especially the combination with %IsSloppyModeFunction is always a bug, because the receiver would be wrapped in the wrong context. So the %IsSloppyModeFunction helper is gone now, and many of the buggy uses of %_CallFunction are also eliminated. If you ever need to call something with a different receiver, then %_Call is your friend now. It does what you want and implements the call sequence fully (and correct). BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1325573004 Cr-Commit-Position: refs/heads/master@{#30634}
-
- 03 Sep, 2015 1 commit
-
-
bmeurer authored
This turns the has_instance_call_handler bit on Map into an is_callable bit, that matches the spec definition of IsCallable (i.e. instances have [[Call]] internal methods). Also fix the typeof operator to properly say "function" for everything that is callable. Also remove the (unused) premature %_GetPrototype optimization from Crankshaft, which just complicated the Map bit swap. R=mstarzinger@chromium.org, rossberg@chromium.org, yangguo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg Review URL: https://codereview.chromium.org/1316933002 Cr-Commit-Position: refs/heads/master@{#30552}
-
- 28 Aug, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org,mlippautz@chromium.org Review URL: https://codereview.chromium.org/1318043002 Cr-Commit-Position: refs/heads/master@{#30438}
-
- 26 May, 2015 2 commits
-
-
erikcorry authored
* Hash code is now just done with a private own symbol instead of the hidden string, which predates symbols. * In the long run we should do all hidden properties this way and get rid of the hidden magic 0-length string with the zero hash code. The advantages include less complexity and being able to do things from JS in a natural way. * Initially, the performance of weak set regressed, because it's a little harder to do the lookup in C++. Instead of heroics in C++ to make things faster I moved some functionality into JS and got the performance back. JS is supposed to be good at looking up named properties on objects. * This also changes hash codes of Smis so that they are always Smis. Performance figures are in the comments to the code review. Summary: Most of js-perf-test/Collections is neutral. Set and Map with object keys are 40-50% better. WeakMap is -5% and WeakSet is +9%. After the measurements, I fixed global proxies, which cost 1% on most tests and 5% on the weak ones :-(. In the code review comments is a patch with an example of the heroics we could do in C++ to make lookup faster (I hope we don't have to do this. Instead of checking for the property, then doing a new lookup to insert it, we could do one lookup and handle the addition immediately). With the current benchmarks above this buys us nothing, but if we go back to doing more lookups in C++ instead of in stubs and JS then it's a win. In a similar vein we could give the magic zero hash code to the hash code symbol. Then when we look up the hash code we would sometimes see the table with all the hidden properties. This dual use of the field for either the hash code or the table with all hidden properties and the hash code is rather ugly, and this CL gets rid of it. I'd be loath to bring it back. On the benchmarks quoted above it's slightly slower than moving the hash code lookup to JS like in this CL. One worry is that the benchmark results above are more monomorphic than real world code, so may be overstating the performance benefits of moving to JS. I think this is part of a general issue we have with handling polymorphic code in JS and any solutions there will benefit this solution, which boils down to regular property access. Any improvement there will lift all boats. R=adamk@chromium.org, verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/1149863005 Cr-Commit-Position: refs/heads/master@{#28622}
-
yangguo authored
Revert of Revert of Hook up more import/exports in natives. (patchset #1 id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} TBR=jkummerow@chromium.org,erik.corry@gmail.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1149773003 Cr-Commit-Position: refs/heads/master@{#28608}
-
- 22 May, 2015 4 commits
-
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Speculative revert for gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > Cr-Commit-Position: refs/heads/master@{#28578} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154743003 Cr-Commit-Position: refs/heads/master@{#28584}
-
yangguo authored
R=jkummerow@chromium.org Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 Cr-Commit-Position: refs/heads/master@{#28573} Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28578}
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #2 id:20001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6943 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154793003 Cr-Commit-Position: refs/heads/master@{#28574}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28573}
-
- 21 May, 2015 1 commit
-
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd Cr-Commit-Position: refs/heads/master@{#28521} Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28533}
-
- 20 May, 2015 2 commits
-
-
jkummerow authored
Revert of Use shared container to manage imports/exports. (patchset #2 id:20001 of https://codereview.chromium.org/1143993003/) Reason for revert: Breaks nosnap bots Original issue's description: > Use shared container to manage imports/exports. > > Also changed string.js and math.js to adapt this change. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd > Cr-Commit-Position: refs/heads/master@{#28521} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1144163002 Cr-Commit-Position: refs/heads/master@{#28523}
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28521}
-
- 15 May, 2015 1 commit
-
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1140053002 Cr-Commit-Position: refs/heads/master@{#28423}
-
- 11 May, 2015 1 commit
-
-
yangguo authored
For the moment, we only pass the global object (the one we are setting up). A few smaller changes were necessary to avoid failures in test-object-observe/DontLeakContextOnObserve. Otherwise the global object would be retained by being context allocated, leading to test failure. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1132513003 Cr-Commit-Position: refs/heads/master@{#28331}
-
- 05 May, 2015 2 commits
-
-
yangguo authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1127693006 Cr-Commit-Position: refs/heads/master@{#28217}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1122033002 Cr-Commit-Position: refs/heads/master@{#28216}
-
- 04 May, 2015 2 commits
-
-
machenbach authored
Revert of Reland "Wrap v8natives.js into a function." (patchset #2 id:20001 of https://codereview.chromium.org/1123703002/) Reason for revert: [Sheriff] Speculative revert for braking arm64 nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/2314 (reverted already titzer's CL which didn't help) Original issue's description: > Reland "Wrap v8natives.js into a function." > > Committed: https://crrev.com/72ab42172979b60a1b784ea0c6a495d7ee2bba67 > Cr-Commit-Position: refs/heads/master@{#28193} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1127543003 Cr-Commit-Position: refs/heads/master@{#28208}
-
yangguo authored
Review URL: https://codereview.chromium.org/1123703002 Cr-Commit-Position: refs/heads/master@{#28193}
-
- 30 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Wrap v8natives.js into a function. (patchset #2 id:20001 of https://codereview.chromium.org/1109343004/) Reason for revert: [Sheriff] Speculative revert for breaking layout tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2682 See. e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/3130/layout-test-results/http/tests/websocket/workers/worker-reload-diff.txt Original issue's description: > Wrap v8natives.js into a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/ee1b39b4303829e6c6805fe8b2f2602b13f6463a > Cr-Commit-Position: refs/heads/master@{#28174} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1121453003 Cr-Commit-Position: refs/heads/master@{#28182}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1109343004 Cr-Commit-Position: refs/heads/master@{#28174}
-
- 17 Apr, 2015 1 commit
-
-
yangguo authored
Review URL: https://codereview.chromium.org/1083083004 Cr-Commit-Position: refs/heads/master@{#27907}
-
- 16 Apr, 2015 4 commits
-
-
machenbach authored
Revert of Migrate error messages, part 2. (patchset #1 id:1 of https://codereview.chromium.org/1086313003/) Reason for revert: [Sheriff]: This changes layout test expectations e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Win/builds/2964 Original issue's description: > Migrate error messages, part 2. > > Motivation for this is reducing the size of the native context. > > Committed: https://crrev.com/d3b788df0a4ccfedbe6e1df5e214cb6ba2792a65 > Cr-Commit-Position: refs/heads/master@{#27878} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1095573002 Cr-Commit-Position: refs/heads/master@{#27889}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1094563002 Cr-Commit-Position: refs/heads/master@{#27879}
-
yangguo authored
Motivation for this is reducing the size of the native context. Review URL: https://codereview.chromium.org/1086313003 Cr-Commit-Position: refs/heads/master@{#27878}
-
yangguo authored
Currently done with two templates, one used from native js, one from runtime. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1087633005 Cr-Commit-Position: refs/heads/master@{#27864}
-
- 13 Apr, 2015 1 commit
-
-
arv authored
{Map, Set, WeakMap, WeakSet}.length should be 0. BUG=v8:4021 LOG=N R=adamk@chromium.org Review URL: https://codereview.chromium.org/1073233002 Cr-Commit-Position: refs/heads/master@{#27798}
-
- 10 Apr, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1065863003 Cr-Commit-Position: refs/heads/master@{#27760}
-
- 18 Mar, 2015 1 commit
-
-
rossberg authored
R=dslomov@chromium.org BUG=460083,v8:3970,v8:3971 LOG=Y Review URL: https://codereview.chromium.org/1018923002 Cr-Commit-Position: refs/heads/master@{#27272}
-
- 24 Feb, 2015 1 commit
-
-
arv authored
This is to reduce code duplication but also to get the correct behavior when we make for-of handle abrupt completion correctly. BUG=None LOG=N R=adamk Review URL: https://codereview.chromium.org/956623003 Cr-Commit-Position: refs/heads/master@{#26834}
-
- 23 Feb, 2015 1 commit
-
-
arv authored
The adder should be gotten before the iterator. Motivation: Once this is done we should be able to use a for-of loop instead which leads to cleaner code and correct behavior once the for-of loop correctly supports abrupt completion. BUG=None LOG=N R=adamk Review URL: https://codereview.chromium.org/949933002 Cr-Commit-Position: refs/heads/master@{#26803}
-
- 19 Feb, 2015 1 commit
-
-
arv authored
BUG=None LOG=N R=adamk Review URL: https://codereview.chromium.org/936793003 Cr-Commit-Position: refs/heads/master@{#26759}
-
- 19 Nov, 2014 1 commit
-
-
dslomov authored
Per Nov 2014 TC39 decision. R=adamk@chromium.org LOG=Y Review URL: https://codereview.chromium.org/739303002 Cr-Commit-Position: refs/heads/master@{#25429}
-
- 21 Oct, 2014 1 commit
-
-
dslomov@chromium.org authored
Updates Object.prototype.toString() to use algorithm described in harmony drafts. Currently, the behaviour is essentially the same as ES262's version, however this changes when internal structures such as Promise make use of symbolToStringTag (as they are supposed to, see v8:3241), and changes further once Symbol.toStringTag is exposed publicly. BUG=v8:3241, v8:3502 LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/546803003 Patch from Caitlin Potter <caitpotter88@gmail.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Aug, 2014 1 commit
-
-
yangguo@chromium.org authored
R=verwaest@chromium.org BUG=403717 LOG=N Review URL: https://codereview.chromium.org/470083003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-