- 28 Sep, 2016 40 commits
-
-
gdeepti authored
- Store instruction with an offset bigger than GrowMemory offset should handle out of bounds correctly - Refactor to separate runnning from compile so arguments can be passed in to module builder tests. BUG=chromium:644670 R=ahaas@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2373613004 Cr-Commit-Position: refs/heads/master@{#39840}
-
hlopko authored
BUG= LOG=no Review-Url: https://codereview.chromium.org/2379623002 Cr-Commit-Position: refs/heads/master@{#39839}
-
ulan authored
Reland "[heap] New heuristics for starting of incremental marking. (patchset #9 id:160001 of https://codereview.chromium.org/2364923002/ )" This reverts commit a5440d11. BUG=chromium:616434 TBR=hpayer@chromium.org LOG=NO Review-Url: https://codereview.chromium.org/2379663002 Cr-Commit-Position: refs/heads/master@{#39838}
-
georgia.kouveli authored
BUG= Review-Url: https://codereview.chromium.org/2375933003 Cr-Commit-Position: refs/heads/master@{#39837}
-
bradnelson authored
Several of the asm.js tests were disabled and wrong (mismatched number of args on the stdlib functions). Fixing issue around negation and float + doubles. Renaming function for IsNegate to IsInvert (to reflect what it actually does). Added tests for negate and invert. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 R=aseemgarg@chromium.org,jpp@chromium.org Review-Url: https://codereview.chromium.org/2377903002 Cr-Commit-Position: refs/heads/master@{#39836}
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2379613002 Cr-Commit-Position: refs/heads/master@{#39835}
-
verwaest authored
BUG= Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177 Review-Url: https://codereview.chromium.org/2374963002 Cr-Original-Commit-Position: refs/heads/master@{#39809} Cr-Commit-Position: refs/heads/master@{#39834}
-
machenbach authored
Revert of [heap] New heuristics for starting of incremental marking. (patchset #9 id:160001 of https://codereview.chromium.org/2364923002/ ) Reason for revert: OOMs in nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/9572 Original issue's description: > [heap] New heuristics for starting of incremental marking. > > The motivation for this patch is to move more marking work to tasks. > This is done by postponing the start of incremental marking until > a marking task is running. > > This patch introduces a soft and a hard limits for incremental marking. > When the soft limit is reached, the marking task is scheduled. > If the hard limit is reached before the task is running, then > incremental marking is started without waiting for the task. > > BUG=chromium:616434 > LOG=NO > > Committed: https://crrev.com/55683ddd2a32e0dfb8df66271fbf53e3618cce9d > Cr-Commit-Position: refs/heads/master@{#39831} TBR=hpayer@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616434 Review-Url: https://codereview.chromium.org/2375983002 Cr-Commit-Position: refs/heads/master@{#39833}
-
leszeks authored
Adds a fast-path test and branch for the turbofan graph generated by BytecodeGraphBuilder for dynamic local lookups. BUG=v8:5263 Review-Url: https://codereview.chromium.org/2378653003 Cr-Commit-Position: refs/heads/master@{#39832}
-
ulan authored
The motivation for this patch is to move more marking work to tasks. This is done by postponing the start of incremental marking until a marking task is running. This patch introduces a soft and a hard limits for incremental marking. When the soft limit is reached, the marking task is scheduled. If the hard limit is reached before the task is running, then incremental marking is started without waiting for the task. BUG=chromium:616434 LOG=NO Review-Url: https://codereview.chromium.org/2364923002 Cr-Commit-Position: refs/heads/master@{#39831}
-
mvstanton authored
Cleanup. BUG= Review-Url: https://codereview.chromium.org/2379573002 Cr-Commit-Position: refs/heads/master@{#39830}
-
nikolaos authored
This patch moves the following parsing method to ParserBase: - ParseClassDeclaration - ParseClassLiteral - ParseNativeDeclaration R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/7818355363b7a66ff7709e33c72bfdef5eb21450 Review-Url: https://codereview.chromium.org/2368083002 Cr-Original-Commit-Position: refs/heads/master@{#39814} Cr-Commit-Position: refs/heads/master@{#39829}
-
verwaest authored
Previously we'd have a scope in the main zone, and another in the temp zone. Then we carefully copied back data to the main zone. This CL changes it so that the scope is just fixed up to only contain data from the main zone. That avoids additional copies and additional allocations; while not increasing the care that needs to be taken. This will also make it easier to abort preparsing while parsing using a temp zone. BUG= Committed: https://crrev.com/f41e7ebd62b32e861b6aa14ad8bfce3018d03c3c Review-Url: https://codereview.chromium.org/2368313002 Cr-Original-Commit-Position: refs/heads/master@{#39800} Cr-Commit-Position: refs/heads/master@{#39828}
-
ulan authored
This patch simplifies code for speeding up marking and removes write barrier counter. The step size is now computed based in two parts: - bytes to mark in order to keep up with allocation, - bytes to mark in order to make progress. BUG=chromium:616434, chromium:646139, chromium:644819 LOG=NO Review-Url: https://codereview.chromium.org/2359903002 Cr-Commit-Position: refs/heads/master@{#39827}
-
ulan authored
This patch replaces cumulative counters with the counters for the current GC cycle. It also replaces the ring buffer of record incremental marking speeds with a single variable. Review-Url: https://codereview.chromium.org/2361563004 Cr-Commit-Position: refs/heads/master@{#39826}
-
mlippautz authored
BUG=chromium:581412 R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2374023002 Cr-Commit-Position: refs/heads/master@{#39825}
-
hlopko authored
This cl introduces reporter to the embedder heap tracer. Heap tracer uses reporter to report reachable objects from embedder heap. This refactoring is a step towards being able to take heap snapshots with wrapper tracing. LOG=no BUG=468240 Review-Url: https://codereview.chromium.org/2371733002 Cr-Commit-Position: refs/heads/master@{#39824}
-
ishell authored
BUG=chromium:650973 Review-Url: https://codereview.chromium.org/2374003002 Cr-Commit-Position: refs/heads/master@{#39823}
-
bmeurer authored
As of https://codereview.chromium.org/2348493003 there are no users of this intrinsic left in the code, and we don't want to have any new users of it. The runtime function remains as it serves as a fallback for the optimized code (Crankshaft code actually). BUG=v8:5049 R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2378693002 Cr-Commit-Position: refs/heads/master@{#39822}
-
verwaest authored
Revert of Don't use different function scopes when parsing with temp zones (patchset #11 id:200001 of https://codereview.chromium.org/2368313002/ ) Reason for revert: Revert due to asm.js slowdown Original issue's description: > Don't use different function scopes when parsing with temp zones > > Previously we'd have a scope in the main zone, and another in the temp zone. Then we carefully copied back data to the main zone. This CL changes it so that the scope is just fixed up to only contain data from the main zone. That avoids additional copies and additional allocations; while not increasing the care that needs to be taken. This will also make it easier to abort preparsing while parsing using a temp zone. > > BUG= > > Committed: https://crrev.com/f41e7ebd62b32e861b6aa14ad8bfce3018d03c3c > Cr-Commit-Position: refs/heads/master@{#39800} TBR=marja@chromium.org,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2379533003 Cr-Commit-Position: refs/heads/master@{#39821}
-
verwaest authored
Revert of [parser] Refactor of ParseClass* and ParseNativeDeclaration (patchset #7 id:120001 of https://codereview.chromium.org/2368083002/ ) Reason for revert: Blocks reverting https://codereview.chromium.org/2368313002 Original issue's description: > [parser] Refactor of ParseClass* and ParseNativeDeclaration > > This patch moves the following parsing method to ParserBase: > > - ParseClassDeclaration > - ParseClassLiteral > - ParseNativeDeclaration > > R=adamk@chromium.org, marja@chromium.org > BUG= > LOG=N > > Committed: https://crrev.com/7818355363b7a66ff7709e33c72bfdef5eb21450 > Cr-Commit-Position: refs/heads/master@{#39814} TBR=adamk@chromium.org,marja@chromium.org,nikolaos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2380663002 Cr-Commit-Position: refs/heads/master@{#39820}
-
baptiste.afsa authored
R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2376963002 Cr-Commit-Position: refs/heads/master@{#39819}
-
franzih authored
Add documentation for Has(), HasOwnProperty(), and HasRealNamedProperty() that points out their differences and links to the other functions. BUG=v8:5433 Review-Url: https://codereview.chromium.org/2365403003 Cr-Commit-Position: refs/heads/master@{#39818}
-
jgruber authored
TurboFan lowering (see [0]) of ConsString creation cannot ensure that the first part of the cons string is non-empty without introducing a phi and negatively impacting performance. This modifies ConsStringIterator to allow empty first parts of ConsStrings. BUG=v8:5440 Review-Url: https://codereview.chromium.org/2377983002 Cr-Commit-Position: refs/heads/master@{#39817}
-
cbruni authored
BUG= NOTRY=true Review-Url: https://codereview.chromium.org/2380643002 Cr-Commit-Position: refs/heads/master@{#39816}
-
verwaest authored
Revert of Preparse top-level functions in discardable zones (patchset #2 id:20001 of https://codereview.chromium.org/2374963002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/2368313002 which slows down asm.js code Original issue's description: > Preparse top-level functions in discardable zones > > BUG= > > Committed: https://crrev.com/ff8cfa9e5e8495165291ddf6e01dba3f8cb5a177 > Cr-Commit-Position: refs/heads/master@{#39809} TBR=marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2375013002 Cr-Commit-Position: refs/heads/master@{#39815}
-
nikolaos authored
This patch moves the following parsing method to ParserBase: - ParseClassDeclaration - ParseClassLiteral - ParseNativeDeclaration R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2368083002 Cr-Commit-Position: refs/heads/master@{#39814}
-
jkummerow authored
When the inline lookup on a fast-property receiver doesn't find anything, try a stub cache lookup before going into the runtime. This is much faster for properties loaded from the receiver's prototype chain. BUG=chromium:650236 Review-Url: https://codereview.chromium.org/2373683002 Cr-Commit-Position: refs/heads/master@{#39813}
-
bmeurer authored
Revert of [stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged. (patchset #2 id:20001 of https://codereview.chromium.org/2380543002/ ) Reason for revert: Tanks ai-astar in Kraken pretty badly (some deopt loop). Original issue's description: > [stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged. > > Add a CanonicalizationMode to CodeStubAssembler::ChangeFloat64ToTagged, > so clients can request Smi canonicalization when desired, but otherwise > get Crankshaft/Fullcodegen compatible behavior of just boxing the double > into a HeapNumber. > > R=verwaest@chromium.org > BUG=v8:5268 > > Committed: https://crrev.com/06eef6e6d8199df8317df8469d767092472f3fe0 > Cr-Commit-Position: refs/heads/master@{#39804} TBR=verwaest@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5268 Review-Url: https://codereview.chromium.org/2373253003 Cr-Commit-Position: refs/heads/master@{#39812}
-
mlippautz authored
BUG= Review-Url: https://codereview.chromium.org/2371133002 Cr-Commit-Position: refs/heads/master@{#39811}
-
zhengxing.li authored
[tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in Class derived from Platform Class. The CL #39789 (https://codereview.chromium.org/2367603002 ) caused the Gcc compilation fail for v8 debug mode. The error message was: In file included from .././include/libplatform/v8-tracing.h:13:0, from .././src/libplatform/default-platform.h:14, from ../src/libplatform/default-platform.cc:5: .././include/v8-platform.h:169:20: error: ‘virtual uint64_t v8::Platform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, unsigned int)’ was hidden [-Werror=overloaded-virtual] virtual uint64_t AddTraceEvent( ^ In file included from ../src/libplatform/default-platform.cc:5:0: .././src/libplatform/default-platform.h:55:12: error: by ‘virtual uint64_t v8::platform::DefaultPlatform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, std::unique_ptr<v8::ConvertableToTraceFormat>*, unsigned int)’ [-Werror=overloaded-virtual] uint64_t AddTraceEvent( ^ This CL fixed this issue by adding "using Platform::AddTraceEvent;" before all declarations of AddTraceEvent functions in Classes derived from Platform Class. BUG= Review-Url: https://codereview.chromium.org/2380583002 Cr-Commit-Position: refs/heads/master@{#39810}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2374963002 Cr-Commit-Position: refs/heads/master@{#39809}
-
ishell authored
BUG=v8:4915 Review-Url: https://codereview.chromium.org/2372513003 Cr-Commit-Position: refs/heads/master@{#39808}
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2378613002 Cr-Commit-Position: refs/heads/master@{#39807}
-
cbruni authored
- Select Total group by default, this way graphs show up immediately - Groups can now be toggled much like pages and versions BUG= NOTRY=true Review-Url: https://codereview.chromium.org/2368393005 Cr-Commit-Position: refs/heads/master@{#39806}
-
bmeurer authored
R=jarin@chromium.org BUG=v8:5268 Review-Url: https://codereview.chromium.org/2375863002 Cr-Commit-Position: refs/heads/master@{#39805}
-
bmeurer authored
Add a CanonicalizationMode to CodeStubAssembler::ChangeFloat64ToTagged, so clients can request Smi canonicalization when desired, but otherwise get Crankshaft/Fullcodegen compatible behavior of just boxing the double into a HeapNumber. R=verwaest@chromium.org BUG=v8:5268 Review-Url: https://codereview.chromium.org/2380543002 Cr-Commit-Position: refs/heads/master@{#39804}
-
bmeurer authored
This matches current Crankshaft/fullcodegen behavior more closely and thus reduces the chances that we run into unnecessary polymorphism due to the field representation tracking in our object model. Drive-by-fixes: Make sure the JSRegExp::lastIndex field stays Smi if possible (otherwise we tank the regexp benchmark in Octane). CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_mac64_rel,v8_mac64_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca99c0ef Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd Review-Url: https://codereview.chromium.org/2367593003 Cr-Original-Original-Commit-Position: refs/heads/master@{#39692} Cr-Original-Commit-Position: refs/heads/master@{#39748} Cr-Commit-Position: refs/heads/master@{#39803}
-
bmeurer authored
Even after https://codereview.chromium.org/2371963002 we still did not always store a Smi into the JSTypedArray::length field, the runtime function %TypedArrayInitializeFromArrayLike was still storing whatever it got from the JavaScript code, which is highly dependent on internal decisions of the ICs and the representation selection in the optimizing compilers, so that's pretty fragile. R=verwaest@chromium.org BUG=chromium:650933 Review-Url: https://codereview.chromium.org/2377943002 Cr-Commit-Position: refs/heads/master@{#39802}
-
v8-autoroll authored
Rolling v8/build to 5e4ffb5c8928fe5afacd1b1b0f2bb732cdc0d77c Rolling v8/third_party/WebKit/Source/platform/inspector_protocol to 5258fd5cfb62ec917c9258ce9089c62e17aee5dc Rolling v8/tools/clang to f991b268a2441c4bc09b9cafdb3af797a13729fe TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2380523002 Cr-Commit-Position: refs/heads/master@{#39801}
-