- 04 Mar, 2016 16 commits
-
-
mstarzinger authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1727953004 Cr-Commit-Position: refs/heads/master@{#34486}
-
bmeurer authored
Add StringLessThanStub, StringLessThanOrEqualStub, StringGreaterThanStub and StringGreaterThanOrEqualStub, based on the CodeStubAssembler, and hook them up with TurboFan (and Ignition). The stubs are currently essentially comparable with the StringCompareStub, which is now obsolete. We can later extend these stubs to cover more interesting cases (i.e. two byte sequential string comparisons, etc.). R=epertoso@chromium.org Review URL: https://codereview.chromium.org/1765823002 Cr-Commit-Position: refs/heads/master@{#34485}
-
ishell authored
This CL also disables inlining of calls at tail position. This is a preparational step. Tail call elimination itself is neither enabled nor supported yet. BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1761023003 Cr-Commit-Position: refs/heads/master@{#34484}
-
bmeurer authored
According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all the undetectable bit (for document.all) only affects comparisons with undefined and null. In particular comparisons with other values are not affected, so we can actually simplify the handling of undetectable a lot by only checking it when null or undefined might be involved (this is actually in line with what the CompareIC does). CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1764613004 Cr-Commit-Position: refs/heads/master@{#34483}
-
machenbach authored
Revert of [wasm] Update {i32,i64}.const to use signed leb128 (patchset #3 id:40001 of https://codereview.chromium.org/1765673002/ ) Reason for revert: [Sheriff] Breaks chromium win compile: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/3844/steps/compile/logs/stdio Original issue's description: > [wasm] Update {i32,i64}.const to use signed leb128 > > R=titzer@chromium.org > R=bradnelson@chromium.org > LOG=n > > Committed: https://crrev.com/4b613a67e0aa4e073946f5f0dd95ee9366c8ca86 > Cr-Commit-Position: refs/heads/master@{#34471} TBR=bradnelson@chromium.org,titzer@chromium.org,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1760363003 Cr-Commit-Position: refs/heads/master@{#34482}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#34481}
-
machenbach authored
Revert of Introduce v8::MicrotasksScope. (patchset #6 id:100001 of https://codereview.chromium.org/1741893003/ ) Reason for revert: [Sheriff] Speculative. Seems to break a bunch of webkit tests and causes timeouts: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5103 Please rebase upstream if intended. Original issue's description: > Introduce v8::MicrotasksScope. > > This scope is used to control microtasks execution when MicrotasksPolicy::kScoped is engaged. > > BUG=chromium:585949 > LOG=Y > TEST=ScopedMicrotasks > > Committed: https://crrev.com/db77cec242dbdf8ee26da8232fa930270429f253 > Cr-Commit-Position: refs/heads/master@{#34472} TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:585949 Review URL: https://codereview.chromium.org/1762943002 Cr-Commit-Position: refs/heads/master@{#34480}
-
zhengxing.li authored
port 2689548e (r34459) original commit message: These new stubs perform exactly the same job as the string equality case for the CompareIC, but are platform independent and usable outside of fullcodegen and Crankshaft. We use them in the StrictEqualStub and the StrictNotEqualStub instead of falling back to the runtime immediately for String comparisons, and we also use them in TurboFan to perform String equality or inequality comparisons. These stubs currently handle only internalized and one byte strings w/o going to C++, but it should be easy to add support for more string cases later, i.e. utilizing already flattened cons strings or comparing two byte strings as well. BUG= Review URL: https://codereview.chromium.org/1760343002 Cr-Commit-Position: refs/heads/master@{#34479}
-
zhengxing.li authored
port 18b9c1ce (r34461) original commit message: Per ProxyCreate() (https://tc39.github.io/ecma262/#sec-proxycreate), a Proxy is only given a [[Call]] slot if the target has a [[Call]] slot as well. This was previously implemented correctly for [[Construct]], but not for [[Call]]. BUG= Review URL: https://codereview.chromium.org/1754593007 Cr-Commit-Position: refs/heads/master@{#34478}
-
bradnelson authored
BUG= TBR=titzer@chromium.org LOG=N NOTRY=true Review URL: https://codereview.chromium.org/1761273002 Cr-Commit-Position: refs/heads/master@{#34477}
-
bradnelson authored
Frames entering of inside wasm don't have a function or context argument. Adding distinct wasm frame and function types to express this. Fixes a GC issue on several embenchen wasm tests, reenabling them. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/wasm/embenchen R=titzer@chromium.org,aseemgarg@chromium.org,jfb@chromium.org,yangguo@chromium.org LOG=N Review URL: https://codereview.chromium.org/1764603003 Cr-Commit-Position: refs/heads/master@{#34476}
-
v8-autoroll authored
Rolling v8/tools/clang to 3183208ae119c48012bed71645cb2ca537120811 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1768453002 Cr-Commit-Position: refs/heads/master@{#34475}
-
adamk authored
BUG=v8:3699, chromium:588803 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1749353004 Cr-Commit-Position: refs/heads/master@{#34474}
-
mtrofin authored
Do not emit 2 operations for int64 add with overflow. BUG= Review URL: https://codereview.chromium.org/1764013002 Cr-Commit-Position: refs/heads/master@{#34473}
-
dgozman authored
This scope is used to control microtasks execution when MicrotasksPolicy::kScoped is engaged. BUG=chromium:585949 LOG=Y TEST=ScopedMicrotasks Review URL: https://codereview.chromium.org/1741893003 Cr-Commit-Position: refs/heads/master@{#34472}
-
binji authored
R=titzer@chromium.org R=bradnelson@chromium.org LOG=n Review URL: https://codereview.chromium.org/1765673002 Cr-Commit-Position: refs/heads/master@{#34471}
-
- 03 Mar, 2016 21 commits
-
-
littledan authored
ES2015 generally bans FunctionDeclarations in positions which expect a Statement, as opposed to a StatementListItem, such as a FunctionDeclaration which constitutes the body of a for loop. However, Annex B 3.2 and 3.4 make exceptions for labeled function declarations and function declarations as the body of an if statement in sloppy mode, in the latter case specifying that the semantics are as if the function declaration occurred in a block. Chrome has historically permitted further extensions, for the body of any flow control construct. This patch addresses both the syntactic and semantic mismatches between V8 and the spec. For the semantic mismatch, function declarations as the body of if statements change from unconditionally hoisting in certain cases to acquiring the sloppy mode function in block semantics (based on Annex B 3.3). For the extra syntax permitted, this patch adds a flag, --harmony-restrictive-declarations, which excludes disallowed function declaration cases. A new UseCounter, LegacyFunctionDeclaration, is added to count how often function declarations occur as the body of other constructs in sloppy mode. With this patch, the code generally follows the form of the specification with respect to parsing FunctionDeclarations, rather than allowing them in arbitrary Statement positions, and makes it more clear where our extensions occur. BUG=v8:4647 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1757543003 Cr-Commit-Position: refs/heads/master@{#34470}
-
adamk authored
CallSite depends on using the function name to get ahold of the property name from which an exception was thrown. This fix properly handles the ES2015 names for getters and setters. The new tests pass both with --harmony-function-name off and on. BUG=v8:3699 LOG=n Review URL: https://codereview.chromium.org/1751403004 Cr-Commit-Position: refs/heads/master@{#34469}
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/wasm/embenchen R=titzer@chromium.org,aseemgarg@chromium.org LOG=N NOTRY=true Review URL: https://codereview.chromium.org/1758373002 Cr-Commit-Position: refs/heads/master@{#34468}
-
alan.li authored
This CL fixes the bugs caused by the following CL: 50a394df -- MIPS64: Fix 'MIPS: use DAHI/DATH for li macro on mips64r6.' Port 1f5b84e4 MIPS: use DAHI/DATH for li macro on mips64r6. LUI instruction would sign extend into higher 32bits, in that case we might need to use DAHI, DATI to overwrite the extension. The bug will occur when we are loading some addresses such as 0x00007fffffffxxxx. BUG= TEST=test-run-native-calls/Run_Int32_Select_*, test-run-native-calls/Run_Int32_WeightedSum_*, test-run-native-calls/Run_Int32_WeightedSum_*, test-run-native-calls/Run_Int32_Select_* Review URL: https://codereview.chromium.org/1763733002 Cr-Commit-Position: refs/heads/master@{#34467}
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1758893002 Cr-Commit-Position: refs/heads/master@{#34466}
-
mbrandy authored
Port 18b9c1ce Original commit message: Per ProxyCreate() (https://tc39.github.io/ecma262/#sec-proxycreate), a Proxy is only given a [[Call]] slot if the target has a [[Call]] slot as well. This was previously implemented correctly for [[Construct]], but not for [[Call]]. R=caitpotter88@gmail.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4797, v8:4796, v8:1543 LOG=N Review URL: https://codereview.chromium.org/1758283002 Cr-Commit-Position: refs/heads/master@{#34465}
-
jfb authored
Sets the code up so it'll be easier to have section names as strings instead of hard-coded numbers. Using strings will require synchronizing with sexpr-wasm. Mostly NFC (besides now skipping *all* unknown sections). R=titzer@chromium.org Review URL: https://codereview.chromium.org/1743773002 Cr-Commit-Position: refs/heads/master@{#34464}
-
bmeurer authored
This adds new code stubs for abstract relational comparison, namely LessThanStub, LessThanOrEqualStub, GreaterThanStub and GreaterThanOrEqualStub, and hooks them up for Ignition and TurboFan. These stubs implement the full compare operation without any unpredictable bailouts. Currently they still go to C++ for string comparisons, and also use the %ToPrimitive_Number runtime entry, as we still lack a stub for the ToPrimitive operation. These issues will be addressed separately in follow-up CLs. Drive-by-fix: Add support for deferred code in the RawMachineAssembler and CodeStubAssembler. A block can be marked as deferred by marking its Label as deferred, which will then make the register allocator penalize this block and prefer better register assignments for the other blocks. R=epertoso@chromium.org Review URL: https://codereview.chromium.org/1759133002 Cr-Commit-Position: refs/heads/master@{#34463}
-
mbrandy authored
Port 2689548e Original commit message: These new stubs perform exactly the same job as the string equality case for the CompareIC, but are platform independent and usable outside of fullcodegen and Crankshaft. We use them in the StrictEqualStub and the StrictNotEqualStub instead of falling back to the runtime immediately for String comparisons, and we also use them in TurboFan to perform String equality or inequality comparisons. These stubs currently handle only internalized and one byte strings w/o going to C++, but it should be easy to add support for more string cases later, i.e. utilizing already flattened cons strings or comparing two byte strings as well. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1763723002 Cr-Commit-Position: refs/heads/master@{#34462}
-
caitpotter88 authored
Per ProxyCreate() (https://tc39.github.io/ecma262/#sec-proxycreate), a Proxy is only given a [[Call]] slot if the target has a [[Call]] slot as well. This was previously implemented correctly for [[Construct]], but not for [[Call]]. BUG=v8:4797, v8:4796, v8:1543 LOG=N R=cbruni@chromium.org, neis@chromium.org, adamk@chromium.org, littledan@chromium.org Review URL: https://codereview.chromium.org/1752133004 Cr-Commit-Position: refs/heads/master@{#34461}
-
epertoso authored
Changes MacroAssembler::GenerateSwitchTable to make sure that 'ra' is properly restored. BUG= Review URL: https://codereview.chromium.org/1761863002 Cr-Commit-Position: refs/heads/master@{#34460}
-
bmeurer authored
These new stubs perform exactly the same job as the string equality case for the CompareIC, but are platform independent and usable outside of fullcodegen and Crankshaft. We use them in the StrictEqualStub and the StrictNotEqualStub instead of falling back to the runtime immediately for String comparisons, and we also use them in TurboFan to perform String equality or inequality comparisons. These stubs currently handle only internalized and one byte strings w/o going to C++, but it should be easy to add support for more string cases later, i.e. utilizing already flattened cons strings or comparing two byte strings as well. Review URL: https://codereview.chromium.org/1761823002 Cr-Commit-Position: refs/heads/master@{#34459}
-
bmeurer authored
This is more consistent with the current naming scheme (i.e. IsCallable for callable bit on map, IsConstructor for constructor bit on map, and now IsUndetectable for undetectable bit on map). Also simplify the fallthrough case for Object::Equals, because we don't need to check for Null or Undefined or Undetectable, as both Null and Undefined already have the undetectable bit set on their maps. R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1756413003 Cr-Commit-Position: refs/heads/master@{#34458}
-
machenbach authored
This reverts commit 2608ecc7. Revert "Specialize helper methods in the LookupIterator by is_element." This reverts commit 6eb483f8. Revert "Avoid SetPropertyInternal if the LookupIterator is NotFound" This reverts commit ca5bd8d4. Revert "Inline fast-bailout-checks for LookupIterator::UpdateProtector" This reverts commit d98570a1. This breaks layout tests with timeouts: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5060 It also seems to break jsfunfuzz: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/7930 The other three CLs are reverted to be able to revert the first. BUG=v8:4798 LOG=n TBR=verwaest@chromium.org Review URL: https://codereview.chromium.org/1761593003 Cr-Commit-Position: refs/heads/master@{#34457}
-
ishell authored
The support was already removed from the Crankshaft and this CL removes the last piece. Review URL: https://codereview.chromium.org/1764593002 Cr-Commit-Position: refs/heads/master@{#34456}
-
weiliang.lin authored
BUG= Review URL: https://codereview.chromium.org/1755013003 Cr-Commit-Position: refs/heads/master@{#34455}
-
zhengxing.li authored
port 4acb492e (r34423) original commit message: Initial version of a new StrictEqualStub written as TurboFan code stub, that implements the full strict equality comparison and is usable for both TurboFan and Ignition (and soon for the generic CompareIC case too). The stub is not fully optimized yet, i.e. we still go to the runtime for string comparisons, but that'll be addressed in a follow-up CL. BUG= Review URL: https://codereview.chromium.org/1762533002 Cr-Commit-Position: refs/heads/master@{#34454}
-
zhengxing.li authored
port c129aa4d (r34239) original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG= Review URL: https://codereview.chromium.org/1762483003 Cr-Commit-Position: refs/heads/master@{#34453}
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org,yangguo@chromium.org LOG=N Review URL: https://codereview.chromium.org/1729833002 Cr-Commit-Position: refs/heads/master@{#34452}
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=wasm-fuzzer R=titzer@chromium.org,kcc@chromium.org LOG=N Review URL: https://codereview.chromium.org/1760033002 Cr-Commit-Position: refs/heads/master@{#34451}
-
dtc-v8 authored
BUG= Review URL: https://codereview.chromium.org/1597163002 Cr-Commit-Position: refs/heads/master@{#34450}
-
- 02 Mar, 2016 3 commits
-
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1756693003 Cr-Commit-Position: refs/heads/master@{#34449}
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1756303002 Cr-Commit-Position: refs/heads/master@{#34448}
-
mbrandy authored
Newly added tests cause failures on 32-bit bigendian and are skipped until a solution is found. R=titzer@chromium.org, ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1761573002 Cr-Commit-Position: refs/heads/master@{#34447}
-