- 06 May, 2021 10 commits
-
-
Clemens Backes authored
This is a reland of 296fa964. The fix is to dynamically check for alignment instead of relying on {alignof(ElementType)}. I updated the comment to state that independent of pointer compression we do not guarantee the alignment that the compiler assumes (hence we rely on undefined behaviour here). Original change's description: > [elements] Avoid racy data reads/writes > > Instead of annotating those racy reads / writes to be ignore by TSan, > just use relaxed atomics. This makes us not rely on undefined behaviour, > and is unlikely to introduce noticeable overhead. > > This removes the only uses of TSAN_ANNOTATE_IGNORE_WRITES_BEGIN and > friends, which allows us to remove the whole tsan.h header. > > R=ulan@chromium.org > CC=mlippautz@chromium.org > > Bug: v8:11704 > Change-Id: Ie6694c0ae5b40856b56fb97253ce626ec1f4c263 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859957 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74321} Bug: v8:11704 Change-Id: If75674785ca776dac06ed821f0032f865793dd77 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Cq-Include-Trybots: luci.v8.try:v8_odroid_arm_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867479Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74402}
-
Georg Neis authored
Make code more readable, mainly by using MakeRef & co. and their overloads. Bug: v8:7790 Change-Id: Id45a69857a1be106c152615ac6dbc2f8a42fb7e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874398Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74401}
-
Ulan Degenbaev authored
Bug: v8:11732 Change-Id: I9156ad031d15f3c2054c16b5fb1f767b39165183 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867481Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74400}
-
Kim-Anh Tran authored
This returns a server error on setting breakpoints if the agent is disabled. Also-by: bmeurer@chromium.org Fixed: chromium:1202534 Change-Id: I87c80a4bd785fa5c59a8dd0d5ac5f4b31b015ed8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874662 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#74399}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I9b4ae95e2caf23e6574d2b48ec8796fcf82cfcc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874656Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74398}
-
Ross McIlroy authored
Order the bytecodes to enable range-based checks for IsWithoutExternalSideEffects. Also remove the now unecessary macro definitions for Jump bytecodes. BUG=v8:9684 Change-Id: Id2d7e2e0141b57864c65a752bc233f004f86f760 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2875208 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#74397}
-
Georg Neis authored
This is a simplification and cleanup. Bug: v8:7790 Change-Id: I93a3ed2c9ddce4e300f25032be2085aef915ed8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874655 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c5571d5..a5d4757 Rolling v8/third_party/aemu-linux-x64: Q9wrtYCFy4whHc75FrdwzygrqI5DSmX_tuj8UJUcrckC..QpXtlWg0Hrksvqhm2JkK5cg7xWznHgNj3aHSgOF-cCkC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1ae270e..5185110 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3da9171..5009fd6 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie9e6882480df3a07faf077f35ae7225ca62fc8e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876372Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74395}
-
Frank Tang authored
Spec: https://tc39.es/proposal-intl-locale-info/ Design Doc: https://docs.google.com/document/d/1OwEsvs8VQwvR-ug01xLyIwpgcvUfaP24u9owc7aBKJ4/edit# https://www.chromestatus.com/feature/5566859262820352 Behind flag --harmony_intl_locale_info Bug: v8:11638 Change-Id: Ie616b3394d047c99d95ae46f112b5f0b367afe74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2570218 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74394}
-
Frank Tang authored
Design Doc: https://docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit# https://chromestatus.com/feature/5407573287108608 Bug: v8:7051 Change-Id: I880ca0b67f745283037226ce816a74d02128bfc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874950Reviewed-by:
-
- 05 May, 2021 27 commits
-
-
Ng Zhi An authored
We have a scratch available, so we can use it instead of asking for a temporary register from the register allocator. We can also relax the unique register requirement, since we are careful not to overwrite src0 or src1 in the codegen. Bug: chromium:1204071 Change-Id: Ia7775167e323b3bca80f63304687cdbd425af0e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2873227Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#74392}
-
Georg Neis authored
Change-Id: I5fcf6ca7974d2af9ab59b1d82dc6996322794f73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874446 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#74391}
-
Nico Hartmann authored
Change-Id: I0f732a3e7e970c02925c0ba4e93273a27605dec3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2875206Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74390}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/85859d6..c5571d5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d4ee032..1ae270e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6b022d1..3da9171 Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/33c133a..d0c227c TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifa5ee873b9133ceb50147d80cd40f3d271cd2680 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874931Reviewed-by:
-
Milad Fa authored
This compilation error might happen without the header: error: 'unique_ptr' in namespace 'std' does not name a template type Change-Id: I103ce0496eff5dda85557410b4e7863c1c65aad0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2873446Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74388}
-
Michael Lippautz authored
- Take HeapHandle& parameter to allow a use case of free() on an already dead object during sweeping. - Change free() from T* to T& which forces an object and allows the caller to place the nullptr check before retrieving a heap handle. Bug: chromium:1056170 Change-Id: I80689d27d3abe410d177cd8c86b31ff2fe579a77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874461 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74387}
-
Santiago Aboy Solanes authored
This field has been used with atomically relaxed semantics due to a race with layout_descriptor [1]. Even though layout_descriptor doens't exist anymore, this race is still present presumably because the transition to a new map happens on StoreIC. We can set it as atomic for non-cm and atomic relaxed for cm like we did with the other Map's fields. Note that originally, this field was relaxed so we are reverting it back to what it was for concurrent marking. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/555210/ Bug: v8:7790, v8:11696 Change-Id: I5d8c18bedb84b4bd5dc771e87310bc14409cfed8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874454Reviewed-by:
-
Georg Neis authored
... in favour of an optional return type for MapRef::prototype(). This also eliminates one kind of use of ShouldHaveBeenSerialized(), which I want to get rid of entirely. Bug: v8:7790 Change-Id: I031f067d644570e5c8aaeaf94c5ff69ff0515a99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874456 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I039fa3cc1c236027d8e44cd5d9f2d713099911fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874452Reviewed-by:
-
Ross McIlroy authored
Effect control linearization already does splitting on most constant nodes it introduces, and we don't get much benifit otherwise for what is a fairly BUG=v8:9684 Change-Id: I74301058d157cc163762722576f9301088f8e72a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874460Reviewed-by:
-
Benedikt Meurer authored
As per WebAssembly Web API[1], the engine should only consider names from the name section to synthesize function names in the context of call stacks. We previously also added support to harvest the exports table here in an attempt to improve the DevTools debugging experience, but that needs a separate fix specifically for the inspector (which should also take into account the imports to harvest names). [1]: https://webassembly.github.io/spec/web-api/index.html#conventions Fixed: chromium:1164305 Change-Id: I4bde5c8398a5164f1d8ac9060ad3743ed494c41e Bug: chromium:1159307, chromium:1164241, chromium:1071432 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874464 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74382}
-
Camillo Bruni authored
The IC_BUILTIN and IC_BUILTIN_PARAM macro prevent code navigation and they only avoid very simple, non-performance critical code. Change-Id: Ic9d10a9c53a1890149d86b43a6989afae7f1d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871464Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74381}
-
Michael Achenbach authored
Bug: chromium:1205004 Change-Id: Ib97dbc06ac62d7d1392d610651ccd15daf12bb89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2872825 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit 305aa12f. Reason for revert: Breaks MSVC compilation: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20msvc/17718/overview Original change's description: > cppgc: Save xmm registers on the stack > > Microsoft x86_64 ABI considers XMM6-XMM15 as non-volatile > (callee-saved), which means that the compiler can store pointers in them. > We need to make sure they are pushed onto the stack inside the stack > scanning trampolines. > > Bug: v8:11710 > Change-Id: Ida804fe49d3d3b6f179ec276903a42ec8d3d86be > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865745 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Auto-Submit: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74376} Bug: v8:11710 Change-Id: I9593e55b5c935619a6707f3c00f9ac295475b30d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874462 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74379}
-
Antonio Sartori authored
This change makes it possible to enable SharedArrayBuffer per Context, controlling whether it should be enabled or not with a callback. The previous implementation of the reverse origin trial for SharedArrayBuffer was broken, since the feature could only be enabled globally per process, and only if the feature flag is set early enough in the v8 initialization. This does not play well with how origin trials work. The implementation is similar to the callbacks that already exist for the origin trials for WebAssembly simd and exceptions. SharedArrayBuffer is still controlled by the flag harmony_sharedarraybuffer. If that flag is disabled, then SharedArrayBuffer is disabled unconditionally. On top of that, this CL introduces a new flag for enabling SharedArrayBuffer per context. If that flag is set, a callback is used to determine whether SharedArrayBuffer should be enabled. Note that this only controls whether the SharedArrayBuffer constructor should be exposed on the global object or not. It is always possible to construct a SharedArrayBuffer using new WebAssembly.Memory({ shared:true, initial:0, maximum:0 }).buffer.constructor; There are few things which I do not like of this approach, but I did not have better ideas: 1. The complex logic of dobule flag + callback. However, this seemed the best way to me to not break embedders which rely on that flag being enabled by default. 2. The fact that what actually matters is just whether the callback returns `true` once. It would be good to check that the callback gives a consistent return value, or to provide a better API that cannot be missunderstood. Bug: chromium:923807,chromium:1071424,chromium:1138860 Change-Id: Ibe3776fad4d3bff5dda9066967e4b20328014266 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867473Reviewed-by:Leszek Swirski <leszeks@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#74378}
-
Nico Hartmann authored
This CL adds a new %VerifyType compiler intrinsic that can be used by tests and fuzzers to generate a runtime type check of the given input value. Internally, %VerifyType is lowered to %AssertType which is why checks are currently limited to range types. tests to be const-correct. Drive-by: Add a few consts to NodeProperties accessors to allow Bug: v8:11724 Change-Id: I06842062d0e8278a5ba011d5a09947fe05b6e85e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859959 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Anton Bikineev authored
Microsoft x86_64 ABI considers XMM6-XMM15 as non-volatile (callee-saved), which means that the compiler can store pointers in them. We need to make sure they are pushed onto the stack inside the stack scanning trampolines. Bug: v8:11710 Change-Id: Ida804fe49d3d3b6f179ec276903a42ec8d3d86be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865745 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74376}
-
Thibaud Michaud authored
We potentially emitted the same gap move multiple times to satisfy slot constraint of live ranges defined by a constant. Avoid this by keeping track of already spilled ranges for a given instruction. This is not expected to cause any regression because this case is rare. If it does, a better approach to save allocations would be to re-use the same vector by storing it somewhere that survives the function calls, e.g. in the ConstraintBuilder. Drive-by: Remove unused functions. R=sigurds@chromium.org CC=nicohartmann@chromium.org Bug: chromium:1204748 Change-Id: I75a838a8b27775ecdeddb4c60cf72c56d5f1c2a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871462Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#74375}
-
Manos Koukoutos authored
Main changes: - Allow global.get in elements segments with expressions-as-elements. - Allow element segments with types other than funcref. Detailed changes: - Move WasmInitExpr to its own file. Add stream opearator << support. - Simplify type of PrintCollection. - Make WasmElemSegment use an array of WasmInitExpr's over the previous ad-hoc implementation. Move null_index to WasmModuleBuilder. - Refactor consume_element_segment_header. Make it return a WasmElemSegment. - Refactor consume_element_expr. Make it return a WasmInitExpr. - Refactor DecodeElementSection. Make it invoke consume_element_segment_header, then populate its element array. - Update module-instantiate.cc to handle global.get elements. - Fix bug in wasm-objects.cc where the wrong type index was passed into module()->has_signature() - Adapt and add tests. Change-Id: I5abfbe424dbb750ee2dca59f91c451ffcb79f95f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857959 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Simplifies the traversal of nodes in Scheduler::PrepareUses to avoid having to carefully order stack traversal for pre/post ordering visits. Instead simply pre visit when pushing a node onto the stack, then post visit the node when popping it from the stack and then visiting it's inputs. This keeps the same invariants required, but reduces visit overhead. In addition, move checking for CoupledControlEdges out of Increment/DecrementUnscheduledUseCounts such that the coupled control edge calculation only needs to be done once per node, rather than once for every input of the node. Also remove unecessary recursion from these functions. All told, these optimizations reduce the PrepareUses overhead by 40-50%. BUG=v8:9684 Change-Id: I934523a732892a1f66d7e77f8d04e200169080f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2863602 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74373}
-
Jakob Gruber authored
This is the final part of a CL series that establishes MakeRef/TryMakeRef as the bottleneck for Ref construction. We do this by converting direct constructor uses to (Try)MakeRef calls, and then marking the ctor as protected. Bug: v8:7790 Change-Id: I41bfa226d48cbdfee53b434ec52004eb6507e67a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874166 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is part of a CL series that establishes MakeRef/TryMakeRef as the bottleneck for Ref construction. We do this by converting direct constructor uses to (Try)MakeRef calls, and then marking the ctor as protected. Bug: v8:7790 Change-Id: I26faa6bc1934662c81ae127dee64bddffa428de9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874165Reviewed-by:
-
Manos Koukoutos authored
WasmModules were not removed from the global type judgement cache when they were deleted. This created problems if another module got allocated in the same location as a previously deleted module, by creating false positive cache hits. This CL fixes this issue by removing WasmModule from the cache as part of its destructor. Bug: v8:11700 Change-Id: I4948e361dd681040807f35d759b647d1bce585dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859863 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Daniel Dromboski authored
These should all be forward/backward compatible with Python 2/Python 3. [tools] Tweak statusfile.py for Python 3 .iteritems() does not exist in Python 3, only .items(). (While .iteritems() was meant to be an optimization over .items() in Python 2, .items() should work fine, and it is forward/backward compatible.) [tools] Fix another Python 3 issue in mb.py sys.platform used to return e.g. 'linux2', which is 'linux' plus whatever the first digit of `uname -r` was when Python was built. As of Python 3.3, it always returns just 'linux' for Linux OSes. Use `sys.platform.startswith('linux')` for forward/backward compatibility. [tools] Make base_runner.py Python 3 compatible dict.keys() returns a dict_keys in Python 3, whereas it used to return a simple array. list() is forward/backward compatible with identical results on Python 2/3 (returns array). (Tested on Linux x64, trying to recreate NodeJS's CI workflow.) [tools] Make tools/dev/v8gen.py work with Python 3 dict.keys() returns a dict_keys in Python 3, whereas it used to return a simple array. list() is forward/backward compatible with identical results on Python 2/3 (returns array). Comparing a None-type value numerically used to result in the None-type value always being considered "less than" the thing it is compared to. As of Python 3, numerically comparing against None or None-typed values results in an error. Check if a value is truthy before numerically comparing it, for forward/backward compatibility. print() used to transparently decode byte strings in Python 2. In Python 3, they must be explicitly decoded first. (Tested on Linux 64-bit, trying to recreate NodeJS's CI workflow.) Bug: v8:9871 Change-Id: I059bf98577a67649bbe7ec49848989d468da96b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867270Reviewed-by: -
Manos Koukoutos authored
Element segments and tables in tests used an ad-hoc mechanism to describe the different types of initializer expressions, e.g. an number which could denote either the value of a constant or the index of a global. This CL tidies up and generalizes the test infrastructure by directly using WasmInitExpr in those cases. Additional changes: - Introduce WasmElemSegment class. - Remove obsolete --experimental-wasm-bulk-memory flag from tests. - Rename WasmInitExpr.type -> kind. - Remove dependency of wasm-module-builder from mjsunit.js (except in assertTraps). Change-Id: I716254a04ceea9ceb8ac6b848e12e1637f618f0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857638 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is part of a CL series that establishes MakeRef/TryMakeRef as the bottleneck for Ref construction. We do this by converting direct constructor uses to (Try)MakeRef calls, and then marking the ctor as protected. Bug: v8:7790 Change-Id: I36c07f69378f3a630462c216ef5da284cfd3972f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871449 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b057259..85859d6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/785c56f..d4ee032 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0292793..6b022d1 Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/ba9a763..33c133a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/84ada2d..dbcffda TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4968f10cd978198caa4dc523aef60a9a6a81092 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2873071Reviewed-by:
-
- 04 May, 2021 3 commits
-
-
Shu-yu Guo authored
Bug: v8:11460 Change-Id: I97a21d158ad057334cc7fe5f53edc5c6c23d1355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2861711 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Pointer cage reserved another register and inadvertently broke speculation poisoning by aliasing kSpeculationPoisonRegister with kInterpreterBytecodeArrayRegister (r12). This CL changes kInterpreterBytecodeArrayRegister to r11. Note that this changes it from being callee-save to caller-save, which required code reshuffling in a baseline builtin. Bug: v8:11726 Change-Id: Ic2a1bd6b3a2cb4c480c84375dd3274f2efedc81f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2869985 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Ng Zhi An authored
We don't have memory alignment yet, so using memory operands will cause segv if we try to access the unaligned operands (on non-AVX systems). The fix here is kept simple (the logic can be cleaned up a bit and optimized to not use unique registers), in order to keep the cherry-pick and back-merge as small and safe as possible. Bug: chromium:1204071 Change-Id: Ieda23dcc097a06c6db20b952d7061708c3be0d24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2869986Reviewed-by:
-
