- 26 Feb, 2020 33 commits
-
-
Victor Gomes authored
This adds static types to the argument class that accesss the arguments in the stack. kRuntime arguments are used by runtime functions and kJS arguments are used to access the JS stack (eg. builtins). The distinction allows the reversal of arguments in the JS stack without changing the runtime arguments order. Bug: v8:10201 Change-Id: I7c08164d53c4071c7910836fa733dee8ff7fa680 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066985 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#66470}
-
Clemens Backes authored
The method was deprecated in favor of {IsWasmModuleObject}. R=adamk@chromium.org Bug: v8:10155 Change-Id: Id21a1b74dde5576c2c82cc209555c22209a9e5d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2033170Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66469}
-
Clemens Backes authored
This is a reland of 0dc598df Original change's description: > [wasm] Refactor callback triggering > > 1) Instead of passing three boolean values to |TriggerCallbacks|, pass > one EnumSet which contains all events to trigger. > 2) Remember which events already happened, to avoid triggering them > again. > 3) Compute triggered events once after the loop in |OnFinishedUnits|, > instead of checking for every finished unit. > 4) When a new callback is registered, trigger all previous events > immediately. This solves issue v8:10217. > 5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now. > 6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were > compiled (this is a minor performance optimization; we save taking > and releasing a lock). > 7) Drive-by: Make the |EnumSet| constructor really constexpr (by making > |Mask| constexpr). > > R=ahaas@chromium.org > > Bug: v8:10217 > Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66459} Bug: v8:10217 Change-Id: I9f7ca424fa7f1d0379dabe230bebf62522dfc857 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074501Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66468}
-
Milad Farazmand authored
Change-Id: I3da840cdabf6d0ed8c4d823855acb999a0167167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073206Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66467}
-
Georg Neis authored
It used to print the elements kind as a byte, thus producing \000 etc. This also broke the json produced by --trace-turbo. Change-Id: I2f9ce5cb5815ab30fd7866e52fa5ab2732904e1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074640 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#66466}
-
Seth Brenith authored
This reverts commit 4dc1fb4e. Reason for revert: the regression from the original change was likely due to unlucky factors like code alignment. Original change's description: > Revert "[torque] Support bitfield structs stored within Smis" > > This reverts commit e5e4ea96. > > Reason for revert: mysterious performance regression chromium:1052756 > > Original change's description: > > [torque] Support bitfield structs stored within Smis > > > > This change moves the definition of the bits stored in DebugInfo::flags > > to Torque, and updates the only Torque usage of that field to use more > > natural syntax. This is intended as an example of common patterns found > > in various other classes. Several supporting changes are required: > > > > 1. Add a new type representing a bitfield struct stored within a Smi. It > > is currently called SmiTagged, but I'm open to suggestions. > > 2. Add an enum-style output for Torque bitfield structs whose bitfields > > occupy only one bit each. > > 3. Add a new case to MachineOperatorReducer that makes the generated > > code for IncBlockCounter match with what was generated before this > > change. > > 4. Add support for reporting these bitfields in the postmortem debugging > > API. The format matches existing bitfields but with an offset value > > that includes the SMI shift size. > > > > Bug: v8:7793 > > Change-Id: Icaecbe4a162da55d2d9a3a35a8ea85b285b2f1b7 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2028832 > > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#66182} > > Bug: chromium:1052756, v8:7793 > Change-Id: I9e2897efbb6321124bf4952cf09de2f179f7310d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062569 > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66349} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1052756, v8:7793 Change-Id: I6087928aa14c8551ebd294513bd8d6ffa402a0d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070635Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66465}
-
Nico Hartmann authored
Bug: v8:7790 Change-Id: Ib5fe2727e52a62931cb1bd5ae84fa423a9f6c670 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071262Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:10201 Change-Id: Ie6dbd43ff776b7a5b777923d659edf3038783567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074498 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a first step to make {WasmCode} objects smaller. Many code offsets are currently stored in {size_t} even though there were originally (during assembly) an int. Others are stored in {uint32_t}. This CL switches the function index and all code lengths and offsets to int, because a) bigger code is not supported anyway, and b) the style guide recommends int over unsigned types. This makes the {WasmCode} 24 bytes smaller on x64 (from 144 to 120 bytes). R=ahaas@chromium.org Bug: v8:10254 Change-Id: I8f78bf4be64d59cf9393e3b6662d9d3bd153d387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074217Reviewed-by: -
Clemens Backes authored
This reverts commit 0dc598df. Reason for revert: Fails the wasm-cache-test blink test. Original change's description: > [wasm] Refactor callback triggering > > 1) Instead of passing three boolean values to |TriggerCallbacks|, pass > one EnumSet which contains all events to trigger. > 2) Remember which events already happened, to avoid triggering them > again. > 3) Compute triggered events once after the loop in |OnFinishedUnits|, > instead of checking for every finished unit. > 4) When a new callback is registered, trigger all previous events > immediately. This solves issue v8:10217. > 5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now. > 6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were > compiled (this is a minor performance optimization; we save taking > and releasing a lock). > 7) Drive-by: Make the |EnumSet| constructor really constexpr (by making > |Mask| constexpr). > > R=ahaas@chromium.org > > Bug: v8:10217 > Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66459} TBR=ahaas@chromium.org,clemensb@chromium.org Change-Id: I564b053e898db5f7b51cefa4626c0625a225c89a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074638Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66461}
-
Dominik Inführ authored
Switch the flag to true to enable ArrayBufferExtensions by default. The last CL (https://crrev.com/c/2065088) that tried to enable this was reverted because of alignment issues on ARM64 (fixed in https://crrev.com/c/2071256). Bug: v8:10064 Change-Id: I47f478c978094fb5038113eb452865748956b42e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074157Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#66460}
-
Clemens Backes authored
1) Instead of passing three boolean values to |TriggerCallbacks|, pass one EnumSet which contains all events to trigger. 2) Remember which events already happened, to avoid triggering them again. 3) Compute triggered events once after the loop in |OnFinishedUnits|, instead of checking for every finished unit. 4) When a new callback is registered, trigger all previous events immediately. This solves issue v8:10217. 5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now. 6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were compiled (this is a minor performance optimization; we save taking and releasing a lock). 7) Drive-by: Make the |EnumSet| constructor really constexpr (by making |Mask| constexpr). R=ahaas@chromium.org Bug: v8:10217 Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Richard Townsend authored
Bug: v8:10012 Change-Id: I8d2d95090bd45c560cbc208737f037adc433facb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072741Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#66458}
-
Dominik Inführ authored
The JSArrayBuffer::extension-field might not be aligned with pointer compression enabled. However on AArch64 pointers need to be aligned if you perform atomic operations on them. Therefore split extension into two 32-bit words that each get updated atomically. There is no ABA problem here since the extension field only transitions from NULL --> value --> NULL. After Detach(), Attach() isn't invoked anymore. Bug: v8:10064 Change-Id: If987ed51f0528ca7313980f3d36ffca300b75fdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071256 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
When iterating objects on a page add CHECKs that we actually load a map and ensure the object ends within the current chunk. Bug: chromium:1055252 Change-Id: I8f2d5f08229cb1a2fce64af6e22988de87d1b572 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072744Reviewed-by:
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: Iaf1399a0ccc94f8f96cfdab4364eb918d58659d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073758Reviewed-by:
-
Clemens Backes authored
1) Merge |AddBaselineCompilationUnits| into |InitializeRecompilationProgress|. 2) Rename |InitializeRecompilationProgress| to |InitializeRecompilation|. 3) Unify the update of |ReachedRecompilationTierField| in |compilation_progress_|. R=ahaas@chromium.org CC=duongn@microsoft.com Bug: v8:9654 Change-Id: I58324b553bf226cacb355e387c235841fdea82d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071863 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Marcin Wiącek authored
Before: running different suites is removing non-related master data After: different suites have separate master data files Change-Id: Iab46d663fdf2a1d709aeb7da77a443c2ed1bdcc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071870Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#66453}
-
Georg Neis authored
This reverts commit b12ba06e. Reason for revert: After further discussion we decided to stick with fdlibm. Original change's description: > [builtins] stop using imprecise fdlibm pow > > This CL reinstates the old pow implementation which calls out to the > system implementation of pow. > > Bug: v8:9622 > Change-Id: I3df997888ced3fb8b5bd4b810098e967649aaa55 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1774898 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66303} TBR=yangguo@chromium.org,neis@chromium.org,hpayer@chromium.org,me@gus.host # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9622 Change-Id: I941f70c7432cd2fab86e0eadcb2e1a9ec8195e91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072746 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Backes authored
This extends EnumSet by 1) adding element-wise operations (without first creating an EnumSet of that element in the caller), 2) adding arithmetic assignment operators, and 3) adding a subtraction operation which removes all elements in another EnumSet, or a single element. R=mlippautz@chromium.org Change-Id: Ibe694e9e111e506ad09cf9729fa0b0ba38430b79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071874 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66451}
-
Clemens Backes authored
In {InitializeRecompilationProgress}, we already have logic in place to call the callback (all callbacks really) if no compilation units were added. In that case, the callback in fact does not need to be added to the list of callbacks. Instead, it's enough to just call this one callback and then discard it. R=ahaas@chromium.org Bug: v8:9654 Change-Id: I60bab2d67d67d10964404d897d13ffd628ff9964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071861 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Georg Neis authored
This reverts commit 73f91a2d. Reason for revert: Reverting b12ba06e Original change's description: > [builtins] Replace V8_INFINITY with its definition > > V8_INFINITY is not defined here. > "src/common/globals.h" is also not allowed to be included > in this source file. > > Change-Id: Ia3b14db8ac5099b6ce65839eb0fc59340dc59555 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062930 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#66336} TBR=neis@chromium.org,clemensb@chromium.org,me@gus.host,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia43c3f7f735dfb622d4f5464a52a142d19ddeb26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072745Reviewed-by:
-
Emanuel Ziegler authored
Added a type field to elements to distinguish anyref, funcref and nullref elements and do a proper type checking at compile time as the spec requires. R=ahaas@chromium.org Change-Id: I31be7aa1170439859ca7ec5e20aabb2720c290b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069330 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Clemens Backes authored
EnumSet hold a single integral field, hence it should be passed by value. All users already do this, we are just inconsistent within the declaration of EnumSet itself. R=mlippautz@chromium.org Change-Id: Ic2cac35fbd8fe3e98c1fe135bd334547dca30ab5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071872Reviewed-by:
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: I0773d60e5cd3d3b181446c11943eb19d5336b420 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066982 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This CL fixes two unrelated issues in Turbofan that contributed to non-determinism: - Most importantly, external references included their address in the node hash, but they're unpredictable due to ASLR. Fix by only looking at the lowest bits assuming a 4K page size. - BranchElimination didn't properly trigger revisits for the IfTrue/IfFalse projections. Bug: chromium:1046815 Change-Id: I9ba3535cc748890708e4638017e245a3f4e2a7d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069332 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: Icafeeccdcbe854d6986d3930ec6fcb2c856d274a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072743 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#66444}
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/31f1bb5a..6d4b62614 Bug: v8:7834 Change-Id: Iecb139feb3db4001bc87d662f5acc006a521caad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073380 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#66443}
-
Ng Zhi An authored
Implements i8x16.abs, i16x8.abs, and i32x4.abs. Bug: v8:10233 Change-Id: I350ceca7ee75037615985ea955c5f17997996aac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067842 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#66442}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/11be0fc..9dba72c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8fd825d..d2b5e78 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9aa1a96..227d510 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/493c55d..2457e41 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/9f40209..49ee7b1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8085056f080300b80449bc2ec186acc37746a9ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073019Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#66441}
-
Ng Zhi An authored
Implements i8x16.abs, i16x8.abs, and i32x4.abs. Bug: v8:10233 Change-Id: Iefe3c70bdc229c6da6a0ef07273ca654ca1e937e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063200Reviewed-by:
-
Ng Zhi An authored
Move load splat and load extend ops into the list of SIMD memory opcodes, since they similarly take an i32 and an memarg. This fixes the OpcodeLength calculation in function-body-decoder-impl.h. And in turn, fixes the mjsunit test code that the fuzzer generates. See the regress-1055692.js file for the weird S8x16LoadSplat followed by 2 kExprUnreachable, where the kExprUnreachable really is a memarg {0x0, 0x0}. This bug was caught by the fuzzer, and that was the generated test (with small fixes to add kExprDrop), so leaving it as it is. Bug: chromium:1055692 Change-Id: I743b6beb82350b5fea22c8dd10b546a02741cfed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071401Reviewed-by: -
Ng Zhi An authored
FMA tests that are running on Liftoff can use fused results, since the tests will fall back to TurboFan. Bug: v8:9415 Change-Id: I02edea5ce1447263f7bc7574573418b0055aef8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063202Reviewed-by:
-
- 25 Feb, 2020 7 commits
-
-
Shu-yu Guo authored
The deprecated legacy FinalizationGroup APIs are left unchanged for compat. Bug: v8:8179 Change-Id: I9bdcaa92360db318c96fc8524c04163ece25118e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071236 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Milad Farazmand authored
LoadMem already does the proper sign extension based on the passed memtype, so all is left is splatting it to the desired number of lanes. Change-Id: I54317b6e2b4d3daf2e980315198577f61c3f556a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2068031Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port cc12e947 R=georgia.kouveli@arm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I58e35c6fc007b01db4a51f93bff995ce8c14c37a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071512Reviewed-by:
-
Z Nguyen-Huu authored
We want to be consistent with wasdk/wasmparser. The names used in V8 should follow the WAT convention and always start with a dollar, both for names from the "names" section as well as generated names. Bug: v8:10242 Change-Id: If4dbd4c38208c9dd9377dd2f79120635a531d881 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070637 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#66434}
-
Clemens Backes authored
This extends the existing test to also print scope information on every break. Note that the currently printed information is not correct, since register values are not reconstructed yet. We just always print {-11} for register values. Thus the expected output will change with follow-up CL. R=thibaudm@chromium.org Bug: v8:10222 Change-Id: I7be13ecb02957454c875a4280cec154a08c2deb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062403Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66433}
-
Victor Gomes authored
Context: This is part of a bigger CL: https://chromium-review.googlesource.com/c/v8/v8/+/2043840 In order to get rid of the arguments adaptor frame, we will reverse the JS arguments in the stack. Some macros will need to reverse its arguments as well, we will do that using helper macros in another CL (see src/builtins/builtins-descriptors.h in 2043840). For that we need to stringify the name kDontAdaptArgumentsSentinel, which cannot be done if '::' is in its name. This CL should not have any impact performace/memory on V8. Bug: v8:10201 Change-Id: If76b7f457c179fbddddfe1a0ae038d2f1210ad2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066969Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Andreas Haas authored
This is a reland of 03d5a7ba Nothing changed here compared to the original test. The tests on the blink side were invalid, I fixed them in https://crrev.com/c/2066907. Original change's description: > [wasm] The name of a custom section can cause a validation error > > The WebAssembly spec defines that the name of a custom section can cause > a validation error. The streaming decoder, however, used a separate > Decoder object to decode the name, and thereby avoided a validation > error. With this CL the streaming decoder uses the main decoder to > decode the name of the custom section. > > In addition this CL removes the test mjsunit/regress/wasm/regress-789952. > This test defined an invalid WebAssembly module and expected it to > compile. As it is a regression test, it makes no sense to fix the test. > The module is invalid because it defines the length of the custom section > to be '0', so there are no bytes in the custom section for its name. > > R=clemensb@chromium.org > CC=thibaudm@chromium.org > > Bug: v8:10126 > Change-Id: I8cfc77c9a5916570d5362d5922e0179a29774da8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2041446 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66348} Bug: v8:10126 Change-Id: I48aaed8eb9899da1703030fb6809fe46a6e66191 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069325 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
