- 08 May, 2020 4 commits
-
-
Michael Lippautz authored
This patch provides infrastructure to pin object types to specific spaces. This allows embedders to create mutual exclusive arenas for certain (base) types. In future, this will also be used to provide sliding-window compaction on certain custom spaces. We mainly preserve the existing infrastructure with the difference that spaces are now slightly more dynamic than in Blink as they are kept in a vector instead of a fixed-size array. The mechanism differs from Blink in that it does not allow the user object to call allocation methods directly but instead provides a trait that can be overridden to specify a custom space. The patch preserves templatization for objects that do not go into custom spaces to safe a branch in the allocation hot path. Change-Id: I08aa6932348e2d6258e19c4a32d189865f459f02 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187611 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67666}
-
Yolanda Chen authored
When pick state from predecessor, we should consider live ranges that were split out by the backwards spilling heurisitics and already end before the predecessor does. Bug: chromium:1066869 Change-Id: I9ff85e73059a7c07f1e212fdc041450c79a4d70c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174337Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Yolanda Chen <yolanda.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#67665}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4b54ad3..2ec959d Rolling v8/third_party/aemu-linux-x64: u-v5JkP8oS3BCzku9SpOrrUqZvzXDXE3MqO_M0oKrX4C..MeLYn-hjraOzvUMXrfer2KnMsBnC4w6qg8ctTIpuFcgC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ce41a35..06f14d9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f7df9c4..9a73531 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie811dc60dac7a7c60ee4f23fd2f69e99a07443fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2189794Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67664}
-
Joyee Cheung authored
To rehash JSMap and JSSet, we simply replace the backing store with a new one created with the new hash. Bug: v8:9187 Change-Id: I90c25b18b33b7bc2b6ffe1b89fe17aa5f978b517 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143983 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#67663}
-
- 07 May, 2020 30 commits
-
-
Shu-yu Guo authored
Normative change in ecma262 [1]. Errors thrown by GetMethod(iterator, "return") are suppressed in favor of the original exception. [1] https://github.com/tc39/ecma262/pull/1408 Bug: v8:10397 Change-Id: I0dea8bd677c557cced7103c846416bd81f06f482 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183400 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67662}
-
Milad Farazmand authored
Change-Id: Ic71dda9c487b6afa95ba2525518c923f2608fd7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187003Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67661}
-
Michaël Zasso authored
This is necessary for the pthread_attr_get_np function. Change-Id: I01cfe075a7c86909e8cf37eb7f7c5d44fa044975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2188310 Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Michaël Zasso <mic.besace@gmail.com> Reviewed-by:
-
Ng Zhi An authored
Implement conversion of an i8x16 node to a f32x4 node. Bug: v8:10507 Change-Id: Ifefffb779dbf25b57eae278afe41c11b41c949ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185472Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67659}
-
Ng Zhi An authored
Move them all into wasm-macro-gen.h, other opcodes have their macros there as well. This will make reusing these macros easier when we have other test files for SIMD. (An upcoming one is for scalar lowering tests.) Change-Id: I6c21100ce490abbc26f80a0d204815687fd62f00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185471Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ie946a19d567f4b0d09fe61f5efbc3f62f2156b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2186634Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67657}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I81813a500a1651672862c6311c35ccc0a55ce775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2186633Reviewed-by:
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: I6b43374a3f5c3b0bc5a51acb0b5e0daad7d3c801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185969Reviewed-by:
-
Omer Katz authored
This reverts commit dc1af6a2. Reason for revert: Diff in patchset 2 Original change's description: > Revert "cppgc: Initial marking loop" > > This reverts commit fb9a19fe. > > Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11028 > > Original change's description: > > cppgc: Initial marking loop > > > > This CL introduces: > > - Worklist > > - MarkingHandler to manage gc marking phase > > - Integration into CollectGarbage for atomic pause GC > > - MarkingVisitor for main thread marking > > > > Still missing from this CL: > > - Proper handling for stack scanning > > - Handling of previously not fully constructed objects > > > > Bug: chromium:1056170 > > Change-Id: I70ac8534dfb898777cf3a06e3119cac8072174fd > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170526 > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67642} > > TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org > > Change-Id: I666481f44119771be685bf2555aa0dd5eda83a01 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1056170 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187502 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67643} TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org,nicohartmann@chromium.org # Not skipping CQ checks because this is a reland. Bug: chromium:1056170 Change-Id: I54e963e2aeaaf16069bdcdb019c0ac65e28ef6e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187733Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
When the memory reducer decides whether to do the next GC or not, it takes into account the number of detached contexts. This may lead to redundant GCs if the detached contexts are leaking and stay reachable. With the unified heap all unreachable detached contexts are freed in one GC, so this heuristic is no longer necessary. Bug: chromium:1072746 Change-Id: I869fd6ca2008135dfea39e7ceeb01fdc9ead22be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187493Reviewed-by:
-
Omer Katz authored
Bug: chromium:986235 Change-Id: If7c990dd143fd5331d264dcf2c5349525d1321b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187731 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Bug: chromium:1078825 Change-Id: I0cfa7dcef0efef8a066ee0e9a85d8d0f27343b1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187495 Auto-Submit: Marja Hölttä <marja@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#67651}
-
Jakob Gruber authored
In upcoming work these flags will be used to configure the experimental native context independent code feature. Build-time flags: v8_enable_nci_code Defines: V8_ENABLE_NCI_CODE Runtime flags: --turbo-nci --turbo-nci-as-highest_tier --print-nci-code --trace-turbo-nci Drive-by: Remove unused embedded builtins and jitless defines. Bug: v8:8888 Change-Id: I4466b440634a787bd84b052fe2466b22540216a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184295Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67650}
-
Jakob Gruber authored
The snapshot's Checksum function internally uses adler32, which appears to be significantly faster than base::hash_range and almost as fast as doing nothing at all. Test times, measured with $ time tools/run-tests.py --outdir out/release-with-dchecks/ --exit-after-n-failures=1 --quickcheck base::hash_range: 1m35s adler32: 1m15s nop: 1m13s Bug: chromium:1047818 Change-Id: I8def62f6276a3d06d06911abf5368f59331245ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187492Reviewed-by:
-
Jakob Kummerow authored
When the garbage collector needs to get a struct's type information, it must be prepared to deal with forwarding pointers, as those will only get cleaned up at the end of the GC cycle. Bug: v8:7748 Change-Id: Ifdfdffcef27d1dbe07c86a3abd17711f46c1b900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187732 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Nico Hartmann authored
The code generated by TurboFan was incorrect when comparing to non-oddball undetectables using abstract equality. In particular, %GetUndetectable() == %GetUndetectable() did not return false. Bug: chromium:1051008 Change-Id: Ib62adc72a20aa6cca9ef6499d5fe7429f04623cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187498 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Georg Neis authored
R=nicohartmann@chromium.org Change-Id: I55ef4e0713e0aa583ea01f1a86fee9cf0ef2c17a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184296 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67646}
-
Nico Hartmann authored
This CL cleans up CompareOperationFeedback by replacing it with a composable set of flags. The interpreter is changed to collect more specific feedback for abstract equality, especially if oddballs are involved. TurboFan is changed to construct SpeculativeNumberEqual operator instead of the generic JSEqual in many more cases. This change has shown a local speedup of a factor of 3-10, because the specific operator is way faster than calling into the generic builtin, but it also enables additional optimizations, further improving runtime performance. Bug: v8:5660 Change-Id: I856752caa707e9a4f742c6e7a9c75552fb431d28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162854Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org,ahaas@chromium.org Bug: v8:10408 Change-Id: Id4f5136e36ab41a18a240e31c7a43bf634be2e44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179384 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67644}
-
Nico Hartmann authored
This reverts commit fb9a19fe. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11028 Original change's description: > cppgc: Initial marking loop > > This CL introduces: > - Worklist > - MarkingHandler to manage gc marking phase > - Integration into CollectGarbage for atomic pause GC > - MarkingVisitor for main thread marking > > Still missing from this CL: > - Proper handling for stack scanning > - Handling of previously not fully constructed objects > > Bug: chromium:1056170 > Change-Id: I70ac8534dfb898777cf3a06e3119cac8072174fd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170526 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67642} TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: I666481f44119771be685bf2555aa0dd5eda83a01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187502Reviewed-by:
-
Omer Katz authored
This CL introduces: - Worklist - MarkingHandler to manage gc marking phase - Integration into CollectGarbage for atomic pause GC - MarkingVisitor for main thread marking Still missing from this CL: - Proper handling for stack scanning - Handling of previously not fully constructed objects Bug: chromium:1056170 Change-Id: I70ac8534dfb898777cf3a06e3119cac8072174fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170526 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Mike Stanton authored
We know the array CodeGenerator::deoptimization_literals_ is corrupted somehow. Additional checks in place to validate. Bug: chromium:1027130 Change-Id: Ie0146003f096d24e67aeb382372bca8472548c2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182636 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I6805441fa24c80776cf94d18ff389c4c67bb5abd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2186635 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67640}
-
Clemens Backes authored
Currently WebAssembly breakpoint information survive disabling and re-enabling the debugger. This is different from JavaScript, where they are all removed. The frontend is expected to re-set the breakpoint then. Thus this CL remembers all wasm scripts where breakpoints have been set in the Debug object, and clears them all when the debugger gets disabled. R=bmeurer@chromium.org Bug: v8:10403 Change-Id: I5f8a8f3123727c954921920897ee7bf3b73f0ae8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184969 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#67639}
-
Simon Zünd authored
After sorting the work array but before writing the values back into the actual receiver, we have an accessor check. This accessor check needs to be stricter, in order to catch Array prototype protector cell invalidations. R=jgruber@chromium.org Bug: chromium:1077508 Change-Id: I3c3bd4711f9019f9d4423701724319eee9d800a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187171Reviewed-by:
-
Stefano Sanfilippo authored
Rollforward [compiler,api] Pass non-strings to the modifying callback when unconditional codegen is on. Original change reviewed in https://chromium-review.googlesource.com/c/v8/v8/+/1917147. Added an expect fail/pass for the tests that caused a revert in https://chromium-review.googlesource.com/c/chromium/src/+/2184229. This reverts commit dd1b1de1. Bug: chromium:1024786 Change-Id: I7db6faa4c17c232a0fafd389fc4a26e8116852c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183910 Auto-Submit: Stefano Sanfilippo <ssanfilippo@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#67637}
-
Marja Hölttä authored
There's no need for them to be in NativeContext. This CL moves the minimal subset of SFIs related to async iterators. Bug: v8:10482 Change-Id: I80a34a886387398e6565afe77ab99f389d2ccabd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184233Reviewed-by:
-
Anton Bikineev authored
Returned LABs can be of size less than sizeof(FreeListEntry). Bug: chromium:1056170 Change-Id: Ib4094701472ce7cb5ee20b9fe632651570832dc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183051 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Yang Guo authored
R=szuend@chromium.org Fixed: chromium:1078205 Change-Id: I16f8e19a249692fd16fd53a9a56a8f4cfed8b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185134 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#67634}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3c7540e..4b54ad3 Rolling v8/third_party/aemu-linux-x64: J3cO22hWB2vC_byojuODbkHgkNGvxvrCAEPaKGOx3GwC..u-v5JkP8oS3BCzku9SpOrrUqZvzXDXE3MqO_M0oKrX4C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c5ffb21..ce41a35 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4de5413..f7df9c4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/116e3ee..54f2e0d TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ia694918582c7894c5d0c762c88e59f83751ed4ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187049Reviewed-by:
-
- 06 May, 2020 6 commits
-
-
Michael Lippautz authored
Destructors are allowed to allocate without triggering recursive garbage collections. This changes NoGCScope to provide a soft-bailout for garbage collections to avoid introducing yet another scope. Bug: chromium:1056170 Change-Id: I0fe51a21977ae954221b6b64b2f6e938ff6d3264 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185131 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds a public method that embedders can use to trigger garbage collections. Such garbage collections are always required to have a source and reason specifying which components calls it why. Change-Id: I6ae983f99227febc1b7f0dd15c191d5b1eaaf3f3 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181332Reviewed-by:
-
Gus Caplan authored
RunSingleMicrotask calls Runtime::ReportMessage, but the implementation of ReportMessage would unconditionally discard these exceptions. This CL removes all of the intermediate logic and directly calls MessageHandler::ReportMessage, restoring the ability of RunSingleMicrotask to report exceptions that occur in microtasks. Bug: v8:8326 Change-Id: I493de74383b2ab191d786611fb9eba9d27e7a243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162121 Commit-Queue: Gus Caplan <me@gus.host> Reviewed-by:
-
Junliang Yan authored
Bug: v8:7703 Change-Id: If2d5c2da1d653247f49e5dfb2e50850b97119b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170798Reviewed-by:
-
Ross McIlroy authored
BUG=chromium:1076569 Change-Id: I178e12e20f48dc4216c3f108352425e0aa91047f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185130 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67628}
-
Milad Farazmand authored
This CL introduces VOR and VSRO opcodes which get used for implementing F64x2Splat, I64x2Splat and F32x4Splat. Change-Id: I64b4cd340fbe9ecf6a789a91e3219b6ad83ce3f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184830Reviewed-by:
-
