- 02 Feb, 2018 13 commits
-
-
Pierre Langlois authored
Replace hard-coded uses of `kScratchDoubleReg`, `kScratchDoubleReg2` and `kScratchQuadReg` with the safer `UseScratchRegisterScope`. The reason for doing this is to be able to safely use these scratch registers inside the assembler without having to worry about the code generator using them too. For instance, using this scope showed us that `TryInlineTruncateDoubleToI` is using a FP scratch register while the caller, the `DoubleToI` stub, is using it too. We are safe only because the stub passes the scratch register to `TryInlineTruncateDoubleToI` as an input. Using the scope forces us to explicitely use the input register instead of acquiring a new scratch. Bug: v8:6553 Change-Id: I84c53cd851d31ea33b0e3ef398d7a858b7e3e3c4 Reviewed-on: https://chromium-review.googlesource.com/895460Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#51061}
-
Michael Achenbach authored
This reverts commit ef06fede. Reason for revert: path problems when building cctest in chromium: https://build.chromium.org/p/client.v8.fyi/builders/Linux%20Snapshot%20Builder/builds/10415 Original change's description: > Reland "[builtins] Add .incbin cctest" > > This is a reland of b0128161. > > Original change's description: > > [builtins] Add .incbin cctest > > > > Just to ensure this is portable across all platforms. > > > > Credits go to https://github.com/graphitemaster/incbin, bits of the > > .incbin code were taken from there. Thanks! > > > > Reland of https://crrev.com/c/881181 > > > > Bug: v8:6666 > > Change-Id: I5c0dbf56b1c987fd88607dca69b39d65b59cdefc > > Reviewed-on: https://chromium-review.googlesource.com/895597 > > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#51042} > > Cq-Include-Trybots: luci.v8.try:v8_win64_msvc_compile_rel > Bug: v8:6666 > Change-Id: I8fc0963e28996a84ed56c2e740d895e26611abf0 > Reviewed-on: https://chromium-review.googlesource.com/897630 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51054} TBR=machenbach@chromium.org,jgruber@chromium.org Change-Id: I312f427ab3bc9750af17cd08ef3f1f39077a01a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Cq-Include-Trybots: luci.v8.try:v8_win64_msvc_compile_rel Reviewed-on: https://chromium-review.googlesource.com/897764Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51060}
-
Clemens Hammacher authored
Especially "invalid function" and "invalid type" could contain much more information. Drive-by: Remove unused WasmTrapInvalidIndex. R=ahaas@chromium.org Change-Id: I7fd72c095eaad94e3e2d9bfe6ab4a9ce0bb4798b Reviewed-on: https://chromium-review.googlesource.com/897526Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51059}
-
Clemens Hammacher authored
We were generating sequences of instructions for generating i32, i64, f32 and f64 values, but not for generating an instruction without a result value. This CL adds that. R=ahaas@chromium.org Change-Id: I5c17d4182dfc6a827c7cdaa611ba7941b9c5d12f Reviewed-on: https://chromium-review.googlesource.com/897790Reviewed-by:
-
Yang Guo authored
Debug info carries more information than just break points. It also carries debugging-related flags and data for block coverage and type profiling. In production we won't run into the situation where debug info is created with the debugger not enabled. But this way seems a bit more robust. Bug: v8:7396 Change-Id: I6989bbab82a3c597a43dde382a74114f945adf5f Reviewed-on: https://chromium-review.googlesource.com/898923Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51057}
-
Franziska Hinkelmann authored
Small cleanup. Change-Id: I80f7ede4de1aed3e37c2b20cb3706cb9ef3aa9be Reviewed-on: https://chromium-review.googlesource.com/897810Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#51056}
-
Clemens Hammacher authored
R=ahaas@chromium.org Change-Id: I373bcf852d6d850a6269a0fd24d474606e836dfc Reviewed-on: https://chromium-review.googlesource.com/897568Reviewed-by:
-
jgruber authored
This is a reland of b0128161. Original change's description: > [builtins] Add .incbin cctest > > Just to ensure this is portable across all platforms. > > Credits go to https://github.com/graphitemaster/incbin, bits of the > .incbin code were taken from there. Thanks! > > Reland of https://crrev.com/c/881181 > > Bug: v8:6666 > Change-Id: I5c0dbf56b1c987fd88607dca69b39d65b59cdefc > Reviewed-on: https://chromium-review.googlesource.com/895597 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51042} Cq-Include-Trybots: luci.v8.try:v8_win64_msvc_compile_rel Bug: v8:6666 Change-Id: I8fc0963e28996a84ed56c2e740d895e26611abf0 Reviewed-on: https://chromium-review.googlesource.com/897630 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
For stack frame types that don't provide their own Print function, we used to print nothing at all. Now we print at least the type and the pc. Bug: Change-Id: I8453d705589bc83c284ce4eb4e981f2ad32ee901 Reviewed-on: https://chromium-review.googlesource.com/897425 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This method is now dead code since we introduced PromiseReaction chains as linked lists. Bug: v8:7253, v8:7310 Change-Id: I505a23d9ba4de456dbeeba9e603e70218cf6e767 Reviewed-on: https://chromium-review.googlesource.com/897515Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51052}
-
Michael Starzinger authored
R=adamk@chromium.org Change-Id: Ib6b66003aaf8694c1e5eed6db7d2537322eddad8 Reviewed-on: https://chromium-review.googlesource.com/897498Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#51051}
-
Yang Guo authored
R=jgruber@chromium.org Bug: chromium:803591/ Change-Id: I3f2d1126df4362c2f434551a28953a1bdebfeff5 Reviewed-on: https://chromium-review.googlesource.com/894523Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51050}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8222c43..5aa28c4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f384e37..744dac9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3d55f9c..2a49b96 Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/d882048..ff0709d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic6c29711b62f4b056b4ed50e022edca5a33ce0b7 Reviewed-on: https://chromium-review.googlesource.com/898702Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#51049}
-
- 01 Feb, 2018 27 commits
-
-
Hannes Payer authored
This is a preparation CL for OOL free-lists. Bug: chromium:774108 Change-Id: Ied7853d1d625f650ced135faec4b729d880961c3 Reviewed-on: https://chromium-review.googlesource.com/897809 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#51048}
-
Georg Neis authored
Bug: v8:7387 Change-Id: I831bf8f580d4112d7e0f48d90bbe2f44eff73225 Reviewed-on: https://chromium-review.googlesource.com/897326Reviewed-by:
-
Michael Achenbach authored
TBR=ulan@chromium.org Bug: v8:6972 Change-Id: Ibc8405184828337f9a102cbde437c69ec9542816 Reviewed-on: https://chromium-review.googlesource.com/897366Reviewed-by:
-
Ulan Degenbaev authored
The flag is enabled by default and provides a quick way to switch between the old RetainerInfo and the new EmbedderGraph snapshoting in local testing. Bug: chromium:749490 Change-Id: I36406597a289090879cfa5051037c8cf35988e59 Reviewed-on: https://chromium-review.googlesource.com/897532Reviewed-by:
-
Michael Achenbach authored
This reverts commit b0128161. Reason for revert: Still breaks the bot: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/1217 Original change's description: > [builtins] Add .incbin cctest > > Just to ensure this is portable across all platforms. > > Credits go to https://github.com/graphitemaster/incbin, bits of the > .incbin code were taken from there. Thanks! > > Reland of https://crrev.com/c/881181 > > Bug: v8:6666 > Change-Id: I5c0dbf56b1c987fd88607dca69b39d65b59cdefc > Reviewed-on: https://chromium-review.googlesource.com/895597 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51042} TBR=machenbach@chromium.org,jgruber@chromium.org Change-Id: I41a48908b6e0ff6a28beb8b28a1a9a739302081a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/897788Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7270 Change-Id: Ia7fcd230adbf0f81a99a7f34b554c00c07649bfa Reviewed-on: https://chromium-review.googlesource.com/888742Reviewed-by:
-
jgruber authored
Just to ensure this is portable across all platforms. Credits go to https://github.com/graphitemaster/incbin, bits of the .incbin code were taken from there. Thanks! Reland of https://crrev.com/c/881181 Bug: v8:6666 Change-Id: I5c0dbf56b1c987fd88607dca69b39d65b59cdefc Reviewed-on: https://chromium-review.googlesource.com/895597 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Change-Id: I9c64f70585592bb46e993041a275b989ea71489d Reviewed-on: https://chromium-review.googlesource.com/897529 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=ulan@chromium.org NOTRY=true Bug: v8:6972 Change-Id: I78d15094499d134b97903d97249c667c0c244291 Reviewed-on: https://chromium-review.googlesource.com/897365Reviewed-by:
-
Tobias Tebbi authored
Change-Id: I963215506a87945ae863427c572989c857bca2ff Reviewed-on: https://chromium-review.googlesource.com/897608Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#51039}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I2fb63e05336798606dee558d4adc253d5aace040 Reviewed-on: https://chromium-review.googlesource.com/897807Reviewed-by:
-
Michael Lippautz authored
No-try: true Bug: v8:7266 Change-Id: I65e5cdfcb3d15c4b9ebb1e5da5e69de79032a5d3 Reviewed-on: https://chromium-review.googlesource.com/897609 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#51037}
-
Benedikt Meurer authored
Instead of inlining NewPromiseCapability everywhere, we should have it as a separate builtin that can be called. The motivation for doing so is to reduce the overhead of the builtins and just share the slow-path handling in a single place, plus this way we can also utilize the NewPromiseCapability functionality from TurboFan optimized code eventually. Also remove the unused %new_promise_capability intrinsic and the builtin backing it. Bug: v8:7253 Change-Id: Ic7c916a11f12d063a645e2c25cc4120badee5640 Reviewed-on: https://chromium-review.googlesource.com/897804Reviewed-by:
-
Daniel Clifford authored
Bug: chromium:802060 Change-Id: I032930af26f7eab8d5d3469ad273bdcdff85b045 Reviewed-on: https://chromium-review.googlesource.com/897723Reviewed-by:
-
Clemens Hammacher authored
The wasm call fuzzer is superseded by the wasm compile fuzzer, thus remove it. The chromium side will land in https://crrev.com/c/895531. R=ahaas@chromium.org Change-Id: I211d9f8ad2ca5432dbbc6ecce0b6e13760f1af60 Reviewed-on: https://chromium-review.googlesource.com/895534Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I6bfea537347fb236d41b31f0c6c64c108928bf28 Reviewed-on: https://chromium-review.googlesource.com/897784Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6972 Change-Id: I3fe7a5450470256c81e027371c1e977c29e5cc6a Reviewed-on: https://chromium-review.googlesource.com/897785 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
There's now only a single caller to InternalPromiseThen left, which is the Promise.prototype.then implementation, so there's no need to have a separate helper function. Bug: v8:7253 Change-Id: I0e1ea674c942f735dd069137182232f34d16a729 Reviewed-on: https://chromium-review.googlesource.com/897762Reviewed-by:
-
Michal Majewski authored
Only test processors code left. It enabled to move more stuff to the base runner, like progress indicators creation. Bug: v8:6917 Change-Id: Ie6dd211cec561a07d92bcc4431ea88eb1842c8fa Reviewed-on: https://chromium-review.googlesource.com/897624Reviewed-by:
-
Peter Marshall authored
Where the value we are switching on is a constant, we can just look through each IfValue case and replace the switch and go straight to the appropriate case. If no case matches, expect and go to the IfDefault. For the (unrealistic) example in the linked bug, this improves performance ~1.5x. Bug: v8:7389 Change-Id: I7ffe209bda9ed22571ea106396b18e0bcf9a1e22 Reviewed-on: https://chromium-review.googlesource.com/893141 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#51029}
-
Benedikt Meurer authored
Use the base::bits::SignedAddOverflow32() function instead, which performs an addition and checks for overflow. Bug: v8:5267, v8:7109 Change-Id: I20a5316957a3f72131d318282e8b8e8bb500b4a7 Reviewed-on: https://chromium-review.googlesource.com/797451Reviewed-by:
-
Gabriel Charette authored
It was already always high-resolution on POSIX but was never high resolution on Windows. Windows does support low latency high-resolution timers for the majority of our user base. TimeTicks::HighResolutionNow() was only explicitly requested in testing frameworks. As such I left the call in place but made it DCHECK that it's running on a Windows machine on which high-resolution clocks are used. This confirms that none of our test fleet has regressed with this change (the previous HighResolutionNow() used to be slightly more aggressive and also do it in a few configurations where we now fallback to low-resolution now). This implementation was copied as-is (modulo minor v8 API compatibility tweaks). These implementations were the same in the past but had diverged when, sadly, the same bug was fixed separately years apart, in Chromium and V8: chromium: https://codereview.chromium.org/1284053004 + https://codereview.chromium.org/2393953003 v8: https://codereview.chromium.org/1304873011 This is a prerequisite to add metrics around parallel task execution (low-resolution clocks are useless at that level, but we also don't want to incur high-latency clocks on machines that can't afford it cheaply). Bug: chromium:807606 Change-Id: Id18e7be895d8431ebd0e565a1bdf358fe7838489 Reviewed-on: https://chromium-review.googlesource.com/897485Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#51027}
-
Tobias Tebbi authored
Change-Id: I2e9a6e706d75a579033a3bdaf275a5af4512c8d1 Reviewed-on: https://chromium-review.googlesource.com/897492Reviewed-by:
-
Michal Majewski authored
System tests updated to pass. I will cleanup the code in a separate CL removing the old code. Bug: v8:6917 Change-Id: Ie49efe06c43faade846e322b35c4a2068137a88b Reviewed-on: https://chromium-review.googlesource.com/897565Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ibc6a7e049a17b8f9bef6b2f5cb187c11f89cf638 Reviewed-on: https://chromium-review.googlesource.com/897564Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id5a7b41502dfd4be43496b1edb958522a8eb0c31 Reviewed-on: https://chromium-review.googlesource.com/895588 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Michaël Zasso authored
See https://chromium-review.googlesource.com/c/v8/v8/+/869932 Bug: v8:6972 Change-Id: I012210a31265adb7f7038a9b447f24e2d40ebca7 Reviewed-on: https://chromium-review.googlesource.com/895762Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Reviewed-by:
-
