- 28 May, 2022 2 commits
-
-
Shu-yu Guo authored
This reverts commit ea9a1f1c. Reason for revert: arm64 pointer alignment issue https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8812962856609920785/+/u/Check/mutex-workers Original change's description: > [shared-struct] Add Atomics.Mutex > > This CL adds a moving GC-safe, JS-exposed mutex behind the > --harmony-struct flag. It uses a ParkingLot-inspired algorithm and > each mutex manages its own waiter queue. > > For more details, please see the design doc: https://docs.google.com/document/d/1QHkmiTF770GKxtoP-VQ1eKF42MpedLUeqiQPfCqus0Y/edit?usp=sharing > > Bug: v8:12547 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Change-Id: Ic58f8750d2e14ecd573173d17d5235a136bedef9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595460 > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80789} Bug: v8:12547 Change-Id: I226e16b743dc4b157fac33a9cbabab4d72cf290b Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673353 Owners-Override: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80790}
-
Shu-yu Guo authored
This CL adds a moving GC-safe, JS-exposed mutex behind the --harmony-struct flag. It uses a ParkingLot-inspired algorithm and each mutex manages its own waiter queue. For more details, please see the design doc: https://docs.google.com/document/d/1QHkmiTF770GKxtoP-VQ1eKF42MpedLUeqiQPfCqus0Y/edit?usp=sharing Bug: v8:12547 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Change-Id: Ic58f8750d2e14ecd573173d17d5235a136bedef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595460 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80789}
-
- 27 May, 2022 22 commits
-
-
Frank Tang authored
Also change some AO's return type from MaybeHandle to Handle and call ToHandleChecked() on the right spot. Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.toinstant https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.toplaindate https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.toplaintime https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.toplaindatetime Bug: v8:11544 Change-Id: I140b6a7053d00837bc48fb70980d69778715c0c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3385603 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Also add AO CalendarEquals, CompareISODateTime Remove Isolate from CompareISODate argument Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.compare https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.equals https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.compare https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.equals https://tc39.es/proposal-temporal/#sec-temporal-calendarequals https://tc39.es/proposal-temporal/#sec-temporal-compareisodatetime Bug: v8:11544 Change-Id: I5505c7923e3c1f76d44e292135b489ea20fbf13c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534458Reviewed-by:
-
Shu-yu Guo authored
This refactors ConvertToRelativeIndex into a clamping version and a version that takes OOB labels for the upcoming implementation of Array#with and TypedArray#with. Also gets rid of the the "to" in the name, because these macros are actually converting _from_ a relative index to an absolute one, not the other way around. Bug: v8:12764 Change-Id: I8bf1c16ce73008164acbd6b849f4259fb9315274 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669655Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:12764 Change-Id: I51130143494e6442b335660d2fdcbc75f289fd92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671759Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80785}
-
Shu-yu Guo authored
This reverts commit 68a7736b. Reason for revert: Broke Bazel and gcc builds https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20bazel%20-%20builder/2237/overview https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20gcc%20-%20builder/2103/overview Original change's description: > [snapshot] Rename embedded*.S files to .asm > > We want to use llvm-ml to assemble files on Windows, but it only > recognizes .asm files as input files. See > https://chromium-review.googlesource.com/c/v8/v8/+/3668287. > > Change-Id: I34ff6d2693a34653c8e22a7c2d093853505cd455 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672420 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80782} Change-Id: I92f4435aca26da16555734b95b9aabe3271af15c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673428 Commit-Queue: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80784}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.prototype.toplaindate https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.prototype.toplaindate Bug: v8:11544 Change-Id: I506efe3fa3685f621596fa34301a73d8c57ded38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3566114 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
We want to use llvm-ml to assemble files on Windows, but it only recognizes .asm files as input files. See https://chromium-review.googlesource.com/c/v8/v8/+/3668287. Change-Id: I34ff6d2693a34653c8e22a7c2d093853505cd455 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672420Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80782}
-
Seth Brenith authored
This cleanup is expected to have no observable effects. This is a partial reland of https://crrev.com/c/3597106 Bug: v8:12808 Change-Id: I6b3846f84b804b4a82b2b8601b4c6c93e2779084 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3664015Reviewed-by:
-
Marja Hölttä authored
Without this fix, the byte length for GSABs is probably serialized wrong. A failing test is omitted since it would be pretty involved (currently this code path is only hit with --stress-snapshot). Bug: v8:11111 Change-Id: If7df98263cec9f82766c2fa6ba095b98b53a6fde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657431Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80780}
-
Hao Xu authored
Bug: v8:12484 Change-Id: I0844b550838265496c59d5bcf05edb3f7c9ccf99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3615216Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#80779}
-
Manos Koukoutos authored
We introduce wasm types to Turbofan. They are represented by a new subtype of {TypeBase}. Types are attached to nodes during graph generation, as nodes are assigned to wasm values. Therefore, phi nodes corresponding to merges are not typed. Missing types will be computed, and assigned types will be narrowed as much as possible, in a retyping phase that will be introduced later. Bug: v8:7748 Change-Id: I943559cf1d512edfab3bb2d22f8748c072cb1911 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660248Reviewed-by:Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Leszek Swirski authored
LoadHandler can also contain Code handlers (for StringLength and FunctionPrototype). Fixed: v8:12911 Change-Id: I2fd2dcb65a3283e9a748a1b1cf382f6eeef1f263 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669253 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80777}
-
Leszek Swirski authored
This reverts commit 5f0e7dd4. Reason for revert: Turns out this isn't true: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/ic/ic.cc;l=946 Original change's description: > [ic] Shadow smi_handler on LoadHandler to always be Smi > > StoreHandlers can store either a Code object or a Smi, so the > smi_handler field on DataHandler is a Code|Smi. But, LoadHandlers can > only store Smis here so add a shadowing smi_handler definition which > only allows / returns Smis. > > Change-Id: Icc1c508db268950990b9c84b9e682b9a9b1f43e5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663745 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80775} Change-Id: Ia2c14141ab5929be3ded883f0cecb40645a72dfd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672419 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80776}
-
Leszek Swirski authored
StoreHandlers can store either a Code object or a Smi, so the smi_handler field on DataHandler is a Code|Smi. But, LoadHandlers can only store Smis here so add a shadowing smi_handler definition which only allows / returns Smis. Change-Id: Icc1c508db268950990b9c84b9e682b9a9b1f43e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663745 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
The cctest test-code-generator/FuzzAssembleMove fuzzes codegen for a random list of sequential moves by simulating the moves on a FixedArray, and comparing the result to the output of the generated code. Add a variant of this test that resolves parallel moves first, to also test integration with the gap resolver. Bug: chromium:1313647 Change-Id: I02f385a957dafc89d91a4ab2216e0ac72147536d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660252Reviewed-by:
Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80774}
-
Leszek Swirski authored
This reverts commit ab76ffc8. Reason for revert: Breaks on UBSan: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/21444/overview Original change's description: > [builtins] use SIMD IndexOf/includes on large arrays > > Change-Id: If751e813c7f45a4d18b84e8c0314a54c84894d61 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639203 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Darius Mercadier <dmercadier@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80771} Change-Id: I62dd4249df122af567680cbaa18deb3c9ed44c90 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672416 Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80773}
-
Alan Zhao authored
Currently, llvm-ml only assembles files that have the .asm extension, so push_registers_masm.S fails to get assembled. This CL changes the extension of the x86 and x64 push_registers_masm.S files to .asm. I'll work on a patch to support assembling files with the .S extension in llvm-ml, but in the meantime, we should probably rename the files as it is customary for Intel syntax assembly files to have the .asm extension[0]. ARM assembly files don't use llvm-ml, so we don't need to rename them. [0]: https://stackoverflow.com/a/34098830 Change-Id: Ie4db42b78dd358c3ec0de83e9518aa5c60f6d175 Bug: chromium:762167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668287 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Darius M authored
Change-Id: If751e813c7f45a4d18b84e8c0314a54c84894d61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639203Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80771}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/1c67b4e..1658259 Cherry-Pick PR2096 to fix TimeZone name (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/1658259 Cherry-pick PR2100 (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/5b063af Cherry-pick PR2086 to fix out-of-bound result from Calendar::get() (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/4c1a868 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I4251dcf0096500302ceaae58feafd44ff32661aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671978 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80770}
-
Frank Tang authored
Refactor ToTemporalTimeRecord to a new routine ToTemporalTimeRecordOrPartialTime to share code with ToPartilTime Change the return type of ToTemporalTimeRecord, RegulateTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.with https://tc39.es/proposal-temporal/#sec-temporal-topartialtime Bug: v8:11544 Change-Id: I214147f497a405ee48e264833c7c0b9401596c01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3665269Reviewed-by:
-
QiuJi authored
Also remove useless comment in test-assembler-riscv64 Change-Id: I28451386449f15542b02383d8bf1aa9c4539469c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669660 Auto-Submit: ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80768}
-
Frank Tang authored
Also add AO: ToPartialDuration Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-topartialduration https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.with Bug: v8:11544 Change-Id: I43282f5285a3c884229445547add6db2cde4fbe4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380102Reviewed-by:
-
- 26 May, 2022 10 commits
-
-
Adam Klein authored
This test had been skipped since it was added in 4a416dbb. Bug: v8:9380 Change-Id: I700f83fa4242baf44dd260fbc74520abf05101dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3670052 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80766}
-
Milad Fa authored
This CL adds a check to all integer/and fp load/store operations, if the offset fits in an `is_int16` and if alignment requirements are met (specific to lwa, ld and std) then a non prefixed load/store instruction will be used. Note that operation mode (MRI vs MRR) gets set during instruction selection. Change-Id: I68e2aa1d559c7ff058d715e6e577a14b590b632b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669186Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80765}
-
Frank Tang authored
Also add AO: ConsolidateCalendars Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaindate https://tc39.es/proposal-temporal/#sec-temporal-consolidatecalendars Bug: v8:11544 Change-Id: I98084f7cc92a837f6401a88ad10389a7c5df8b3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563541 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit dec192fd. Reason for revert: broke gcc builds because of [[nodiscard]] Original change's description: > Roll inspector_protocol to 87e75896dcfcafda7869b0c9714db9b6cdc4c765 > > This lets us accept spec-compliant CBOR tag for message envelopes. > > This also includes a change in v8-inspector-session-impl.cc that > relaxes an envelope check to allow spec-compliant envelopes. > > Change-Id: Id77c1e0fc4b62d78e8580f81ef38d50e3eb54a1d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662540 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80761} Change-Id: Iaa0cc65510c9af6391a2c7d0ef7baf903335a328 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669468 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#80763}
-
Manos Koukoutos authored
We inline array allocation for wasm-gc in the TF graph by using AllocateRaw nodes. Additionally, we use memset to initialize large, zero-initialized arrays. These changes give measurable speedup in some benchmarks. Bug: v8:7748 Change-Id: Icbd37d0fe673c673379139b96d0e1c175e95e357 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666618Reviewed-by:
-
Andrey Kosyakov authored
This lets us accept spec-compliant CBOR tag for message envelopes. This also includes a change in v8-inspector-session-impl.cc that relaxes an envelope check to allow spec-compliant envelopes. Change-Id: Id77c1e0fc4b62d78e8580f81ef38d50e3eb54a1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662540Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#80761}
-
Rob Paveza authored
Initialization after reset + unnecessary use of handle scope appear to be the culprit here. Most of the other functions in debug::Script do not use HandleScope, so this reconciles these differences. Additionally, the call to obtain and initialize the hash within ActualScript::Initialize was inconsistent: all of the other fields were initialized prior to resetting the script and source. These reconciliations appear to fix this crash. Bug: chromium:1325036 Change-Id: Ia86e83b6c99955a3ac80a4a8845c0df0172e991c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648082 Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Auto-Submit: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
-
Lu Yahan authored
Port commit 22a16bda Change-Id: I1a6815ca22f4b931ffd2468d8aeb82dc7a1e2bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669661 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80759}
-
Jakob Kummerow authored
We can simply trap in the runtime, instead of returning sentinels. Bug: v8:7748, v8:12425 Change-Id: I179c8675fabd3cb730f002ba99ba8cf942a9d4ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669108Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80758}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.toplaindatetime Bug: v8:11544 Change-Id: I95bab9814471bb9347101d654f6dc902159f8fe3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3538670Reviewed-by:
-
- 25 May, 2022 6 commits
-
-
Shu-yu Guo authored
IsCompiledScope retains code to be safe against bytecode flushing, but %PrepareFunctionForOptimization isn't currently initializing it with the function's current compiled state. IOW, it's only retaining freshly compiled code and is causing flakes for already-compiled functions. Bug: v8:12697 Change-Id: Ie82a4adb8a136da708b3ae0ce27a42f5c277d324 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668318Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-date.prototype.totemporalinstant Bug: v8:11544 Change-Id: I65315152333291f76edc05cc41a528912a185d02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3609214 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.startofday Bug: v8:11544 Change-Id: I475e03fa9ba43290896a906524414cfbddd1f7bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3385610 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Milad Fa authored
ip holds the jump table slot. Change-Id: Ia56bf62835155d58ef10e57d761088d0b9a9710d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668285Reviewed-by:
-
Milad Fa authored
Port 22a16bda Original Commit Message: The Runtime_WasmCompileLazy function was returning a ptr-sized address, wrapped in an Object. This worked because no GC is triggered between the return from the runtime function and the point where we jump to the returned address. In a pointer-compressed world though, generated code assumes that all objects live in the same 4GB heap, so comparisons only compare the lower 32 bit. On a 64-bit system, this can lead to collisions where a comparison determines that the returned address equals a heap object, even though the upper 32-bit differ. This happens occasionally in the wild, where the returned function entry pointer has the same lower half than the exception sentinel value. This leads to triggering stack unwinding (by the CEntry stub), which then fails (with a CHECK) because there is no pending exception. This CL fixes that by returning a Smi instead which is the offset in the jump table where the kWasmCompileLazy builtin should jump to. The builtin then gets the jump table start address from the instance object, adds the offset that the runtime function returned, and performs the jump. We do not include a regression test because this failure is very spurious and hard to reproduce. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I92907b97a9d44d8cf42bb356ef350a22f7c5d5e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666249 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:12907 Change-Id: I8a6da86b4c88b5cfcc9bbb349841c422ac81b64e No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667082 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
