Skip to content

V
V8
Switch branch/tag
  1. 31 May, 2018 15 commits
  3. 30 May, 2018 20 commits
  5. 29 May, 2018 5 commits
    • Daniel Bratell's avatar
      Rename local macro CHECK_RECEIVER -> CHECK_RECEIVER_OBJECT · f95d7bcb
      Daniel Bratell authored 
      builtins_util.h declares a macro named CHECK_RECEIVER and in some
extreme jumbo build configurations, that macro will end up in the
same translation unit as runtime-dataview.cc

Bug: v8:7792
Change-Id: I6db865b6061afd6bf1c74b3a172485d68c749929
Reviewed-on: https://chromium-review.googlesource.com/1075052
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53430}
      f95d7bcb
    • Anna Henningsen's avatar
      [SAB] Document and tighten FutexEmulation `mutex_` scope · edd6803f
      Anna Henningsen authored 
      Document what pieces of data the global `FutexEmulation::mutex_`
mutex protects from concurrent access, and reduce the scope
in which said mutex is locked during `FutexEmulation::Wait()`
to match that description more closely.

Change-Id: I0764efabac06814d83ed5c4af4eb7da34af47cab
Reviewed-on: https://chromium-review.googlesource.com/1074689
Commit-Queue: Ben Smith <binji@chromium.org>
Reviewed-by: 's avatarBen Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53429}
      edd6803f
    • Andreas Haas's avatar
      [wasm] Do not restart compilation tasks after compilation failed · 2301ffe7
      Andreas Haas authored 
      This CL fixes a bad interleaving that can happen between the
CompilationState and streaming compilation. In that particular
interleaving, streaming compilation tries to restart compilation tasks
after compilation failed already, which fails with a check in the
CancelableTaskManager. The problem is the following:

The CompilationState notifies the streaming decoder of compilation
errors. After receiving the notification, the streaming decoder
ignores all subsequent incoming bytes. However, the CompilationState
does not notify the streaming decoder directly, it posts a task
which will notify the streaming decoder. This means that between the
failing of compilation and the notification of the streaming decoder
there is a time window in which compilation already failed but the
streaming decoder can still restart compilation tasks. The crash
happened when this time window was hit.

With this CL we check that compilation did not fail before we restart
compilation tasks. I was never able to reproduce this crash, so I don't
really know if this particular issue caused the crash.

R=titzer@chromium.org

Bug: chromium:840713
Change-Id: Ic522b1c21a7d7749c1e7f6097aa450a09fb271cc
Reviewed-on: https://chromium-review.googlesource.com/1075787Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53428}
      2301ffe7
    • Junliang Yan's avatar
      PPC/s390: [masm] Don't push CodeObject when entering INTERNAL frames · aeb8f324
      Junliang Yan authored 
      Port 75763183

Original Commit Message:

    The code slot of internal frames seems to be basically unused.
    As always, there are exceptions:

    1. In elements.cc we check whether the current code object is the apply
    builtin. We can use a heap lookup through the frame's pc instead.
    2. In isolate.cc we store a reference to the frame's code object to try
    and pack it into the minidump. This can safely be skipped.

    Remaining use-sites in frames.cc all skip INTERNAL frames by using the
    JavaScriptFrameIterator.

R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: I3612b206f25b9e53645d2e1bc726a5e318a1f4be
Reviewed-on: https://chromium-review.googlesource.com/1076505Reviewed-by: 's avatarJoran Siu <joransiu@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#53427}
      aeb8f324
    • Junliang Yan's avatar
      PPC/s390: [wasm] Introduce specialized WasmCompileLazy frame type. · 8993cff5
      Junliang Yan authored 
      Port b2abe2cf

Original Commit Message:

    This makes the WasmCompileLazy builtin push a new WASM_COMPILE_LAZY
    frame type. We can thereby remove the workaround to return a relocated
    instance from the underlying runtime function. It also removes the last
    remaining embedded code objects from {WasmCode} objects.

R=mstarzinger@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: Icdc1ee06a1fade4bb805ae0fadf8219316731cd7
Reviewed-on: https://chromium-review.googlesource.com/1076529Reviewed-by: 's avatarJoran Siu <joransiu@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#53426}
      8993cff5