- 25 Jun, 2019 17 commits
-
-
Nico Hartmann authored
This CL introduces the necessary infrastructure to generate speculative BigInt operations in case of BigInt feedback. In particular, the JSAdd operator is lowered to a speculative call to the BigIntAdd builtin, with a deopt bailout in case of exceptions or violated assumptions. Bug: v8:9213 Change-Id: I05796336eef9a4389fc31d59cad2d69f75512647 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657916 Commit-Queue: Nico Hartmann <nicohartmann@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62362}
-
Andreas Haas authored
In the context of the reference types proposal, the imaginary sub type of all types was called "bot". With this CL we use this name now also in V8. R=clemensh@chromium.org Bug: v8:9396 Change-Id: I65a2a177ae2af97e66549e7a5b1457595b04a1d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675950 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62361}
-
Georg Neis authored
Change-Id: I386882ba9a95a7eeaa7995423a9d981850680d95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675957Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#62360}
-
Michael Achenbach authored
Currently, probabilities for extra flags are calculated in the correctness fuzzer harness, which makes the RNG fragile when bisecting backwards, when the script's config changes during bisection. This adds the possibility to pass extra flags on command line to the script. After a grace period, we will migrate the flag calculation to clusterfuzz. NOTRY=true Bug: chromium:813833 Change-Id: I515181847474515089b847f8aaffc7c6560d9390 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675945Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62359}
-
Sathya Gunasekaran authored
Perform a best-effort check for module context and provide an appropriate error. As seen from the import-blah-script.js test, we could have invalid import expressions in a script context that could result in an error saying "Cannot use import statement outside a module" which isn't the ideal error because the error is an incorrect import expression. But, when the developer changes to a module context, the correct error is thrown. To fix this, we'd have to refactor and call ParseImportDeclaration, and then throw an appropriate error, which seems like a lot of overhead for not enough gain. Bug: v8:9392, v8:6513 Change-Id: I520ebb490fff4d95743a7c751d4095db9a35d41b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675948Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Seth Brenith authored
This will prevent unnecessary recompilation effort on the subsequent build, and avoids a common issue on Windows where format-torque replaces all of the line endings in a .tq file without changing any actual content. Bug: v8:8805 Change-Id: Id695351c242739d92aef47cd09e651bfbe3c8f9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1673456Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Tamer Tas authored
testrunner assumes that each test suite has a single extension for base tests. ".mjs" extension can be used for ECMAScript modules in addition to the standard extension ".js" we use for the base tests. This CL generalizes the {TestLoader} to accept multiple extensions for a single test suite. R=mathias@chromium.org TBR=machenbach@chromium.org CC=gsathya@chromium.org Bug: v8:9395 Change-Id: Ibc155f4963472fe9f989458cd839f3642ffbddea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675961Reviewed-by:Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Change-Id: Ie5dbbf7cd17571c6ad1b0e83613bce605d0b9257 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675956Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62355}
-
Andreas Haas authored
This CL refactors the type-checking for br_table instructions. Originally, we iterated over all targets of br_table and checked if the values on the stack match the types expected by the target's signature. However, this caused problems with type checking unreachable br_table instructions where some stack values are unavailable. According to the anyref proposal, the expected type of br_table is the greatest lower bound of all its targets. With the existing implementation, the expected types were the types of the first target. With this CL, we first calculate the expected types of br_table, and only then inspect the stack if matching values are available. R=titzer@chromium.org Bug: v8:7581 Change-Id: I12208323bda88c363e28ffb0e002d59ef9a6b9d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649791 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This is a reland of 93b6c866 The bug that caused the test failures has been fixed in https://chromium-review.googlesource.com/c/v8/v8/+/1667417 Original change's description: > [csa] add hint to CAST error message to break in mksnapshot > > Change-Id: I51a22de5d6367c38056ea91eface4f69f6651993 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664069 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62274} TBR=mvstanton@chromium.org, ulan@chromium.org Change-Id: I7bb0b4237b6eada82456bc9cf2f293d5986f0d65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675954Reviewed-by:
-
Tobias Tebbi authored
In this bug, we might replace a phi node with the Dead node even though it still has uses. DeadCodeElimination picks this up and inserts a runtime crash into the code. Bug: chromium:974474 Change-Id: Iea685913c8666806972719bbfb0891e516207d4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1669693 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This reverts commit 77476cb2. Reason for revert: This is no longer necessary. Let's continue getting test coverage for new elements kinds. Original change's description: > Temporarily disable frozen/sealed elements kinds > > ... to prepare for merging this back to stable chanel. > > Bug: chromium:972921 > Change-Id: I04ced1c81b5f8730014ecee8935799fccc377a49 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1667006 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62283} TBR=ishell@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:972921 Change-Id: I3686bd0f45d354f4826711671a10f1ef7b915e20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675953Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62351}
-
Tobias Tebbi authored
This fixes the test SmallOrderedHashMapAllocate in test-code-stub-assembler.cc, which uses memcmp to check SmallOrderedHashMap objects for equality: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20nosnap%20-%20debug/24470 Change-Id: I1c1ad2e8923322c856191fac30f109a4e671b98e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1667417 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Maciej Goszczycki authored
Shared read-only heap means that all isolates within a process must share the same snapshot. Pass the back-end snapshot to the front-end runner to fix that. Bug: v8:7464 Change-Id: I0ec591a919d4d462ef38e372907592df3c759521 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1669691 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#62349}
-
Igor Sheludko authored
... in addition to existing Xxx::yyy(). The idea is to use these getters in hot C++ code since passing isolate explicitly makes it trivial to compute isolate root value and reduces the C++ code size. For full-pointer mode the unused isolate argument will be optimized away by the compiler, so full-pointer mode should not be affected in any sense. Bug: v8:9353 Change-Id: If6c43e3d5b3cbfc0db8b9eccee49dd8c4d168822 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674035Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62348}
-
Mythri A authored
To correctly fuzz the behaviour of optimized code and ICs we need to allocate feedback vectors. So for the configurations testing these we should turn off lazy feedback allocation. It is also good to fuzz without lazy feedback allocation on other configurations to flush out any other issues. So we also fuzz this with 0.35 chance. We also fuzz aggressive lazy feedback allocation (allocate feedback vectors on first branch / return) with 0.05 chance to test corner cases related to lazy feedback allocation. Bug: v8:9342 Change-Id: Id0761d1396bfc0866988abb8fb20168b86a5da20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672939 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62347}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/074e5c6..fa4e56c Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/8c2657f..80b545b Rolling v8/buildtools/linux64: git_revision:8c7f49102234f4f4b9349dcb258554675475e596..git_revision:972ed755f8e6d31cae9ba15fcd08136ae1a7886f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/566ad95..304e510 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd2737e..2cfafaf TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I409526520c064ae4f8a70b6159414c256a352fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674830Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62346}
-
- 24 Jun, 2019 21 commits
-
-
Santiago Aboy Solanes authored
This is a CL that aims to do a general cleanup of DecompressionElimination to make it easier for devs to look at it, and to create new test cases. Combined direct decompression & compression tests since they can be summarized with a for loop in just one test that tries out all the combinations. Also created 'global' accesses to stop repeating them in every test. Same for compression and decompression ops. Added EXPECT in test cases that had none. Added dots after comments. Variables now use underscore instead of camelCase. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, v8:9183 Change-Id: I38a5c6549e0b4ff89c3271ead23b626e8b6b4843 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1628788Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62345}
-
Dan Elphick authored
Bug: v8:9183 Change-Id: I40c1cd1f55efc353af19cdee48e85ddc8085586c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664059 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#62344}
-
Michael Lippautz authored
Tbr: ulan@chromium.org Bug: chromium:948807, chromium:978050 Change-Id: I73d4ca4ca43b9c9bfa57502676bab9f60b052229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674036 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#62343}
-
Junliang Yan authored
Bug: v8:9355 Change-Id: I317bb52952ad5b347d627d4f6096f251bca1a815 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1652558 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#62342}
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I5c98af1745ed765ec060b2fd70006a3bd57d523a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645317 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Peter Marshall authored
There is a generated file config.descriptor which is an output file for a particular target. When we try to add this to sources, it breaks as GN no longer silently accepts files with invalid types as sources. This breakage was due to recently-rolled changes to fix crbug.com/gn/77 Similar fixes have been used here: crbug.com/964411 Change-Id: Ica9272647c6d1ed31780a6319cf098a083a3cc57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674032 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62340}
-
Mathias Bynens authored
It shipped in Chrome 73. Bug: v8:8021 Change-Id: I72a4e7fd3cd9ae8f960471a97100054d761d926b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593461 Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62339}
-
Jaroslav Sevcik authored
Address a TODO: Use EmitIdentity instead of kArchNop. Bug: v8:7947 Change-Id: Idd7de1bcffaf56f7eaf5d65be4dae3257d085ea8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674031Reviewed-by:
-
Mathias Bynens authored
We currently use the class name “JSValue” for JSObjects that wrap primitive values. This name is a common source of confusion. This patch switches to a name that’s more clear. In addition to manual tweaks, the patch applies the following mechanical global replacements: before | after --------------------------------|-------------------------------------- if_valueisnotvalue | if_valueisnotwrapper if_valueisvalue | if_valueiswrapper js_value | js_primitive_wrapper JS_VALUE_TYPE | JS_PRIMITIVE_WRAPPER_TYPE JSPrimitiveWrapperType | JSPrimitiveWrapper type jsvalue | js_primitive_wrapper JSValue | JSPrimitiveWrapper _GENERATED_JSVALUE_FIELDS | _GENERATED_JSPRIMITIVE_WRAPPER_FIELDS Change-Id: I9d9edea784eab6067b013e1f781e4db2070f807c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672942Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#62337}
-
Clemens Hammacher authored
We have a global test/OWNERS that has "file://COMMON_OWNERS". This CL removes redundant OWNERS files in test/ subdirectories and removes redundant entries from OWNERS files we need to keep for special per-file entries. R=yangguo@chromium.org, machenbach@chromium.org CC=jkummerow@chromium.org Bug: v8:9247 Change-Id: Ic2e8cbe8e379d7d23c86c6164305e65807f28ed3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674024Reviewed-by:
-
Igor Sheludko authored
... in addition to existing [Heap]Object::IsXXX(). The idea is to use these getters in hot C++ code since passing isolate explicitly makes it trivial to compute isolate root value and reduces the C++ code size. For full-pointer mode the unused isolate argument will be optimized away by the compiler, so full-pointer mode should not be affected in any sense. Bug: v8:9353 Change-Id: I405cd54e8895b58f60f797fdb1c1b5654acb56f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664337 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... as its existence gives us nothing. Bug: v8:9183 Change-Id: I80234e4ca8b0c9f596a7a3ff79a926d0dda98db8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672937Reviewed-by:
-
Georg Neis authored
We tried to pass the load mode even for stores. Bug: chromium:977670 Change-Id: I2527a5ca755dba343b75f54383d17e22be0a20a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672940 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Dan Elphick authored
Pass correct stream to the print for the constant_pool so the debug print doesn't go the stdout. Change-Id: I12952e5fa52e4890beaa490601f053128fd2b89a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672938 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9183 Change-Id: Ib17445fe22da683c5be4c3f0249a31502040c2dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672935Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62331}
-
Michael Lippautz authored
The default values ensure that the controller doesn't change scheduling if no values are reported from the embedder. This allows for switching the flag on the embedder side. Bug: chromium:948807 Change-Id: Ib478adc1185ed5e56d06ba4404d6cafb196cff78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672930Reviewed-by:
-
Leszek Swirski authored
Bug: chromium:976939 Bug: chromium:977089 Change-Id: I93153dcf8c38e8b0b202597f5b27ce736c0552ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672936Reviewed-by:
-
Sigurd Schneider authored
This change reduces accumulated constant pool size on Octane2.1 from 296kb (74170 32bit words) to 125 kb (31311 32bit words), a 57.7% reduction. Bug: v8:8054 Change-Id: I7d6f24dadf9e11b49d028df10970fd0bc6229ad6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672932Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62328}
-
Stephen Kyle authored
This affects VisitChangeUint32ToUint64 and VisitTruncateInt64ToInt32. The geometric mean of changes across octane, ares6-1.0.1, jetstream2, and web-tooling-0.5.3, was an improvement of 1.2% when running on a Cortex-A53. Change-Id: Ib551641fb78ce4060100129e12f23cd02b0b3b27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1669690Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/538dcba..074e5c6 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ide7d847764834995c17483b79b9ac0d180435321 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1673668Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/baf52dc..538dcba TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I7bed7749675df466b9a229be43d91339a9a32695 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1673601Reviewed-by:
-
- 23 Jun, 2019 2 commits
-
-
Sigurd Schneider authored
This CL deduplicates entries in constant pools based on handle location. This works well because we already use CanonicalHandleScope in the right places. The CL gives a ~2% speed-up on octane for arm64. The code size is reduced significantly as well: Before the change all generated code spend on constant pools during an Octane run on arm64 was 723kb (90398 64bit words) before this change, and after this change only spend 189kb (23615 64bit words) were spend on constant pools. This is a 73.8% reduction. Change-Id: If0bb83453a45c0df0d1b0fee591c04c621341af1 Bug: v8:8054, v8:8977, v8:7703 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672924 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#62324}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ccf6a3..baf52dc Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6f3775a..8c2657f Rolling v8/buildtools/linux64: git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9..git_revision:8c7f49102234f4f4b9349dcb258554675475e596 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/94c77e7..566ad95 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/125f7cc..dd2737e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a8fe285..fb60bb4 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I1e73c86275dcc3c5fda64fd932edccc52d367dd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1673186Reviewed-by:
-
