- 21 Jun, 2018 28 commits
-
-
Toon Verwaest authored
Change-Id: I142735622cb741fa8d84ec1036febb720a467363 Reviewed-on: https://chromium-review.googlesource.com/1109918Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#53928}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754 Change-Id: I6f86d8d835009d864ba059055ee5bade4a52ab2e Reviewed-on: https://chromium-review.googlesource.com/1109917Reviewed-by:
-
Clemens Hammacher authored
Other fuzzers already have this ability. This CL adds it to the fuzzer. The input has to be valid bytes, otherwise we cannot generate the text representation. R=titzer@chromium.org CC=gdeepti@chromium.org Change-Id: If1ba8accc707bee3b042e93f4201949f0233c90e Reviewed-on: https://chromium-review.googlesource.com/1109794 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This completes the transition to Assembler::Options, which reduces the assemblers's dependency on isolates, and there is now only one way to create an Assembler, which is to use the options. Note that some operations on assemblers still need an isolate, such as GetCode(), and in these cases, the isolate is an additional argument to the method. R=jgruber@chromium.org CC=mstarzinger@chromium.org Change-Id: I413209d816c63a7c3640f1c226764693dcad1e7f Reviewed-on: https://chromium-review.googlesource.com/1106169 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53925}
-
Toon Verwaest authored
[unibrow] -1 used by kNoPreviousCharacter and kEndOfInput isn't a valid Lead/Trail char. Drop superfluous check. Change-Id: Ie6b8e61230e25ab0321d0672d71f64fd593714bf Reviewed-on: https://chromium-review.googlesource.com/1109829 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53924}
-
Peter Marshall authored
For bounds accesses, we definitely want to see these dchecks fire in all configurations. Change-Id: I54516794e32aaf0b00a2b1d88ffaf449f5a20b7b Reviewed-on: https://chromium-review.googlesource.com/1109835 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
For consistency with the existing Validate/Complete methodology. Drive-by: Use it in {PrintRawWasmCode}. R=titzer@chromium.org Bug: v8:7754 Change-Id: I6f08ad7456ded2bdb9b06bb9f288e2609d4010e7 Reviewed-on: https://chromium-review.googlesource.com/1109793Reviewed-by: -
Peter Marshall authored
Change-Id: If133fe47a086ed273446ee7e8f8af85bf9fc8389 Reviewed-on: https://chromium-review.googlesource.com/1108203 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I98ac4de406630c14280927240e9471049af3e790 Reviewed-on: https://chromium-review.googlesource.com/1108118Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53920}
-
Clemens Hammacher authored
This is a reland of c2f1090d, fixing jumbo builds. Original change's description: > [wasm] Move serialization tests to own file > > Move out all serialization related tests to > {test-wasm-serialization.cc}, to reduce the size of > {test-run-wasm-module.cc}. > > R=titzer@chromium.org > > Bug: v8:7754 > Change-Id: I0b2133baf69e2557df27d1733cc267d1d4cf7452 > Reviewed-on: https://chromium-review.googlesource.com/1107980 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53909} TBR=titzer@chromium.org Bug: v8:7754 Change-Id: Ic0bb02b1b782676c6100daa2d588adce8b54c388 Reviewed-on: https://chromium-review.googlesource.com/1109838Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53919}
-
Rodrigo Bruno authored
Bug: chromium:852748 Change-Id: Iac1c52d45e84af190415aeae5df167ab501b4bc4 Reviewed-on: https://chromium-review.googlesource.com/1109821Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#53918}
-
Simon Zünd authored
All other sorting benchmarks use arrays of roughly the same length. This CL adds a set of benchmarks that sort arrays of various lengths. Two data configurations are used for each length: Completely random and already sorted. R=jgruber@chromium.org Bug: v8:7382 Change-Id: Ib80a3421a68029c8e4f823605bab7b2d7fe1ae34 Reviewed-on: https://chromium-review.googlesource.com/1109509 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Clemens Hammacher authored
The {parameter_count} is always equal to {kParameterCount}, so just use {kParameterCount} directly. R=ishell@chromium.org Bug: v8:7754 Change-Id: I136387b5f2da3af10bb36215f947ff0e0d872928 Reviewed-on: https://chromium-review.googlesource.com/1109820Reviewed-by:Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53916}
-
Peter Marshall authored
Currently we have to access the unreachable ArrayBuffer object to get the backing store pointer when we want to free it. This means we need the original ArrayBuffer object to stay alive until we collect all of the pointers to free (currently done sequentially after marking). We want to move this step to a background task that does not block GC finishing - to do that we need the backing store pointers so that the original page (where the ArrayBuffers live) can be freed. Change-Id: Ifaf070d777939cb23c46da637a25d75f9c863bd8 Reviewed-on: https://chromium-review.googlesource.com/1102434 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit c2f1090d. Reason for revert: breaks jumbo build: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20Jumbo%20-%20limited/1309 Original change's description: > [wasm] Move serialization tests to own file > > Move out all serialization related tests to > {test-wasm-serialization.cc}, to reduce the size of > {test-run-wasm-module.cc}. > > R=titzer@chromium.org > > Bug: v8:7754 > Change-Id: I0b2133baf69e2557df27d1733cc267d1d4cf7452 > Reviewed-on: https://chromium-review.googlesource.com/1107980 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53909} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: I2c6ce0c128b34cc28c1f87e02bb584f2a79428e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7754 Reviewed-on: https://chromium-review.googlesource.com/1109837Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53914}
-
Simon Zünd authored
This CL adds sorting of a randomized array to the PreSorted benchmark to act as a baseline/reference point. R=jgruber@chromium.org Bug: v8:7382 Change-Id: I45b77a6584d5d9a4f14a807f3796af7197673eaa Reviewed-on: https://chromium-review.googlesource.com/1109508Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7754 Change-Id: I5de3f1fb1c1c44312238c05f53257ca75136d093 Reviewed-on: https://chromium-review.googlesource.com/1109690 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL reverts commit 38bec2ea and implements the same functionality via Assembler::RecordRelocInfo. Bug: v8:6666 Change-Id: I2e6b60697f68e956257f4c0877342da1bffca361 Reviewed-on: https://chromium-review.googlesource.com/1107710 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Creddy authored
Change-Id: I02710e807fa2cd36849b4ab9d76cde2e99f02911 Reviewed-on: https://chromium-review.googlesource.com/1107983 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53910}
-
Clemens Hammacher authored
Move out all serialization related tests to {test-wasm-serialization.cc}, to reduce the size of {test-run-wasm-module.cc}. R=titzer@chromium.org Bug: v8:7754 Change-Id: I0b2133baf69e2557df27d1733cc267d1d4cf7452 Reviewed-on: https://chromium-review.googlesource.com/1107980Reviewed-by: -
Ivica Bogosavljevic authored
Byteswap operations are used a lot in WASM on big endian architecture. This CL removed unused 1-byte swapping, rewrite tests so they have better coverage and cleans up some other minor things. TEST=cctest/test-run-wasm/RunWasmTurbofan_I32DivSOnDifferentRegisters Change-Id: I60466bbd5fe3f64e8e55684265dc43e92fcabc2c Reviewed-on: https://chromium-review.googlesource.com/1106379 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53908}
-
Igor Sheludko authored
Bug: v8:7754, v8:6600 Change-Id: I4db943d4a4a02a14bba670f89661ea98c5e306dd Reviewed-on: https://chromium-review.googlesource.com/1107919 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This is a reland of 2c1e4aa9 Original change's description: > [test] Initialize slow-dcheck runtime flag with compile time value > > This makes sure slow dchecks are part of the snapshot when the compile > time flag is set. It'll also obviate the need to set the runtime flag > in general, making configurations simpler. > > It's still possible to opt out at runtime for the non-snapshot dchecks > using the negated runtime flag. > > Bug: v8:7853 > Change-Id: Iadfc46ed691d32e9d39717e2ea0383e784660d1d > Reviewed-on: https://chromium-review.googlesource.com/1105050 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53819} TBR=jgruber@chromium.org Bug: v8:7853 Change-Id: I21d82ea907c0beead4ad2bc90fecc4dc9036dc1b Reviewed-on: https://chromium-review.googlesource.com/1109418Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
jgruber authored
The assertion is invalid if dst aliases src, which is the case in InterpreterOnStackReplacement: __ SmiUntag(x1, FieldMemOperand(x1, FixedArray::OffsetOfElementAt( DeoptimizationData::kOsrPcOffsetIndex))); This didn't fail so far because slow asserts in snapshotted code are never executed. Bug: v8:7853 Change-Id: I5b2dad780da94b5821aa9a624a3fcb9d083b3aa3 Reviewed-on: https://chromium-review.googlesource.com/1109503Reviewed-by: -
Rodrigo Bruno authored
Bug: chromium:852748 Change-Id: Ifdadf3188815fe38741e6f0e817070972e7f445b Reviewed-on: https://chromium-review.googlesource.com/1108205 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Georg Neis authored
It doesn't depend on anything from PropertyAccessBuilder other than CompilationDependencies. Move it there instead. R=jarin@chromium.org Bug: v8:7790 Change-Id: I0545a990829f4591ebf5089b6a9e8c1a96899b93 Reviewed-on: https://chromium-review.googlesource.com/1107797Reviewed-by:
-
Michael Achenbach authored
This reverts commit 8e0f67be. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/20949 Original change's description: > Reland "[async] Expose async hooks to d8" > > This is a reland of 3c4d0316 > > Original change's description: > > [async] Expose async hooks to d8 > > > > This implementation follows the Node.js API as a guideline. > > > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > > Reviewed-on: https://chromium-review.googlesource.com/1065818 > > Commit-Queue: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53551} > > Change-Id: If2114db2ff179c6b07a40bc0c2dac3a41f37aea9 > Bug: chromium:850530 > Reviewed-on: https://chromium-review.googlesource.com/1088890 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53901} TBR=ofrobots@google.com,sergiyb@chromium.org,gsathya@chromium.org,bmeurer@chromium.org,mslekova@chromium.org Change-Id: Id55809a46bc5118103391fdbdfb52415182d3fd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:850530 Reviewed-on: https://chromium-review.googlesource.com/1109038Reviewed-by:
-
Maya Lekova authored
This is a reland of 3c4d0316 Original change's description: > [async] Expose async hooks to d8 > > This implementation follows the Node.js API as a guideline. > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > Reviewed-on: https://chromium-review.googlesource.com/1065818 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53551} Change-Id: If2114db2ff179c6b07a40bc0c2dac3a41f37aea9 Bug: chromium:850530 Reviewed-on: https://chromium-review.googlesource.com/1088890 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53901}
-
- 20 Jun, 2018 12 commits
-
-
Maya Lekova authored
This is a reland of 21c0d77e Original change's description: > [async] Optimize await and AsyncFromSyncIterator > > Simplify the promise wrapping in await and > %AsyncFromSyncIteratorPrototype%.next/return/throw to reuse the PromiseResolve > primitive. Now await takes 1 tick instead of 3 on the microtask queue. > > Change-Id: I7e99b8689eb8fcb09c48915b11c1e06684dc0f1a > Reviewed-on: https://chromium-review.googlesource.com/1090272 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53853} Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifa5b2fb8b2fb84b635b2dc1b6455d6aaf154cbfd Reviewed-on: https://chromium-review.googlesource.com/1106977 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
Extracted from https://chromium-review.googlesource.com/c/v8/v8/+/1105493 R=dgozman@chromium.org Bug: v8:7862 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibd2fb5341e617929b07b26abea31a1579a456d93 Reviewed-on: https://chromium-review.googlesource.com/1107312Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53899}
-
Aseem Garg authored
R=gdeepti@chromium.org BUG=v8:6020 Change-Id: Ibdeb926ef3e2884b9a3f0831e9482ebe2da227ac Reviewed-on: https://chromium-review.googlesource.com/1105464Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#53898}
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: I80d67bdceacc9829855dc62ddd599d88a055c3a8 Reviewed-on: https://chromium-review.googlesource.com/1108537Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53897}
-
Sathya Gunasekaran authored
Bug: chromium:854476 Change-Id: I5f477327f303732c3482c47141b794c8d77d9786 Reviewed-on: https://chromium-review.googlesource.com/1108340Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53896}
-
Brian Stell authored
Change-Id: I741d53f3e132a4770fa738b7e902c1f24eafd594 Reviewed-on: https://chromium-review.googlesource.com/1107237 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This is a preliminary step for adding support for additional flags and return types. Bug: v8:7754, v8:6600 Change-Id: I1f65ec41f22b61a9471eb7105033007744563e91 Reviewed-on: https://chromium-review.googlesource.com/1107917 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Predrag Rudic authored
Port of 733b7c82 Original description: > [wasm] Introduce jump table > > This introduces the concept of a jump table for WebAssembly, which is > used for every direct and indirect call to any WebAssembly function. > For lazy compilation, it will initially contain code to call the > WasmCompileLazy builtin, where it passes the function index to be > called. > For non-lazy-compilation, it will contain a jump to the actual code. > The jump table allows to easily redirect functions for lazy > compilation, tier-up, debugging and (in the future) code aging. After > this CL, we will not need to patch existing code any more for any of > these operations. > > R=mstarzinger@chromium.org, titzer@chromium.org > > Bug: v8:7758 > Change-Id: I45f9983c2b06ae81bf5ce9847f4542fb48844a4f > Reviewed-on: https://chromium-review.googlesource.com/1097075 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53805} Change-Id: Ifa7c2abe89a6dc5dbb03a547db2fab68e292f344 Reviewed-on: https://chromium-review.googlesource.com/1107630 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
-
Simon Zünd authored
This CL fixes a bug where execution would continue on a fast-path even though a previous recursion step bailed to the slow path. This would allow possibly illegal loads that could leak to JS. Drive-by change: Instead of bailing to the slow-path on each recursion step, we now bail completely and start the slow-path afterwards. R=cbruni@chromium.org, jgruber@chromium.org Bug: chromium:854299, v8:7382 Change-Id: Ib2fd5d85dbd0c3894d7775c4f62e053c31b5e5d1 Reviewed-on: https://chromium-review.googlesource.com/1107702 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Alexey Kozyatinskiy authored
Extracted from https://chromium-review.googlesource.com/c/v8/v8/+/1105493/ R=yangguo@chromium.org Bug: v8:7862 Change-Id: I804a444a43047e3303b5f1b0140522b4f609f3ba Reviewed-on: https://chromium-review.googlesource.com/1107393 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This CL attempts to simplify the Assembler's dependency on the isolate, in particular on a global "serializer_enabled" mode contained therein. The "serializer_enabled" condition enabled and disabled a number of things in both the assemblers and macro assemblers. To make these dependencies explicit, the Assembler::IsolateData is refactored to be a proper Assembler::Options struct that controls specific assembler behaviors, with default settings easily computable from the isolate. This also helps make the contract for compiling WASM code more explicit (since WASM code needs to have reloc info recorded for external references) we can explicitly enable this recording without trying to "trick" the assembler using "serializer_enabled". R=jgruber@chromium.org CC=mstarzinger@chromium.org, herhut@chromium.org Change-Id: I7a8ba49df7b75b292d73ec2aa6e507c27a3d99c8 Reviewed-on: https://chromium-review.googlesource.com/1105982 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
When encountering a LoadStackPointer input to a comparison, generate a register LocationOperand that points to the stack pointer. This can avoid unnecessary spilling of the stack pointer. Since sp is a special register for arm64, we need to add a mechanism to print its name in RegisterConfiguration. This is a port of https://chromium-review.googlesource.com/1055568 that made the same change for arm. It also ports the tests added in https://chromium-review.googlesource.com/1099068 to arm and arm64. Bug: v8:7844 Change-Id: I5adc672ff877b9888ef755e8e60e4eabbc61061b Reviewed-on: https://chromium-review.googlesource.com/1107810Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#53889}
-
