- 05 Sep, 2018 14 commits
-
-
Hai Dang authored
This is a reland of 1c48d52b. It turned out that IterableToList doesn't always behave according to the ES operation with the same name. Specifically, it allows holey arrays to take its fast path, which produces an output array with holes where actually "undefined" elements should appear. This CL changes the version of IterableToList that is used for spreads (IterableToListWithSymbolLookup) such that holey arrays take the slow path. It also includes tests for such situations. Original change's description: > [interpreter] Add bytecode for leading array spreads. > > This CL improves the performance of creating [...a, b] or [...a]. > If the array literal has a leading spread, this CL emits the bytecode > [CreateArrayFromIterable] to create the literal. CreateArrayFromIterable > is implemented by [IterableToListDefault] builtin to create the initial > array for the leading spread. IterableToListDefault has a fast path to > clone efficiently if the spread is an actual array. > > The bytecode generated is now shorter. Bytecode generation is refactored > into to BuildCreateArrayLiteral, which allows VisitCallSuper to benefit > from this optimization also. > For now, turbofan also lowers the bytecode to the builtin. > > The idiomatic use of [...a] to clone the array a now performs better > than a simple for-loop, but still does not match the performance of slice. > > Bug: v8:7980 > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ibde659c82d3c7aa1b1777a3d2f6426ac8cc15e35 > Reviewed-on: https://chromium-review.googlesource.com/1181024 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Commit-Queue: Hai Dang <dhai@google.com> > Cr-Commit-Position: refs/heads/master@{#55520} Bug: v8:7980 Change-Id: I0b5603a12d2b588327658bf0a9b214bd0f22e237 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1201882 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55639}
-
jgruber authored
GCC may be buggy in how it handles visibility in this case. The previous nested implementation resulted in a 'lambda1 declared with greater visibility than the type of its field lambda2' error. Unnesting the inner lambda works around the error. Bug: v8:8126 Change-Id: Id822ca80fec9af27c4adc7ff53be3b6d9478f0d7 Reviewed-on: https://chromium-review.googlesource.com/1206310Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55638}
-
Camillo Bruni authored
Bug: v8:7926 Change-Id: I1c3b831bb19c70e1e7c99f45ae50dbd1351ce2a7 Reviewed-on: https://chromium-review.googlesource.com/1202105 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55637}
-
Camillo Bruni authored
Bug: v8:7926 Change-Id: I62e05240fd2bb165ddf8965b77763ec11a40a609 Reviewed-on: https://chromium-review.googlesource.com/1202543 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
🎉 Mathias Bynens authoredThis is a reland of 4dac9872 Original change's description: > Ship globalThis
🎉 > > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > Bug: v8:5537 > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > Reviewed-on: https://chromium-review.googlesource.com/1195494 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55543} TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org No-Presubmit: true Bug: v8:5537 Change-Id: I9776c24952e472c59861ee07f78b6456b19e6f2a Reviewed-on: https://chromium-review.googlesource.com/1203894 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#55635}
-
Clemens Hammacher authored
GCC complained about these. R=mstarzinger@chromium.org Change-Id: I36d69b4191b63ae4373a9b96893cf98650acd7e9 Reviewed-on: https://chromium-review.googlesource.com/1206291Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55634}
-
Daniel Clifford authored
Change-Id: I9dc6a387ce5c9b97e21d20297b59b910daea3c6d Reviewed-on: https://chromium-review.googlesource.com/1199503Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#55633}
-
Matheus Marchini authored
As discussed in https://github.com/nodejs/llnode/issues/156, we need postmortem metadata for Symbols to properly print Symbol property names in postmortem debugging tools. Patch suggested by Ben Noordhuis (https://github.com/nodejs/llnode/issues/156#issuecomment-350467852). R=bmeurer@google.com, yangguo@google.com Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118 Reviewed-on: https://chromium-review.googlesource.com/1205052Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55632}
-
andrew-cc-chen authored
Corrected register calling syntax in assembler-s390.cc and test-platform.cc. Generate_CEntry in builtins-s390.cc expects return buffer to be preserved in r2, but when built with clang r2 isn't preserved, which breaks 300+ tests. It is fixed by writing r2's value into r8 (preserved) and loading the value back to r2 after the operation. Change-Id: I184f0111944b6ad8c0ccc8b97407d702dd97d9d8 Reviewed-on: https://chromium-review.googlesource.com/1204530Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55631}
-
Yang Guo authored
This reverts commit 5107ec2a. Reason for revert: Test is very flaky: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64 Original change's description: > Add external backing store JS test > > Allow mocking the limits for ArrayBuffer allocation to simulate operating > system OOM. > > Bug: chromium:845409 > Change-Id: I38bf56a3677e1db547c774223c81e913f56cb631 > Reviewed-on: https://chromium-review.googlesource.com/1203895 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55616} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I633988dba1b0a87b652e72e0e667e90122e00f6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1206290Reviewed-by:
-
Michaël Zasso authored
Since there is no `Value::IsInteger` method in the API, we in the Node.js project are going to rely on what looks like an implementation detail of the Integer class. It is currently possible to to call `Integer::Value` on any Number and the value is cast to an integer. This commit adds tests for this behavior. Change-Id: I4de09e7c6e0beac7909e5477f7bfe2ed4c9415b9 Reviewed-on: https://chromium-review.googlesource.com/1200983 Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6773a0d..4ca6fa3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/88dc49a..70783e3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e323bd9..f215ae6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7c97c65f0f13e103f174ed0002b679710e330e9b Reviewed-on: https://chromium-review.googlesource.com/1205616 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55628}
-
Ujjwal Sharma authored
Port CreateBreakIterator and BreakIterator.prototype.resolvedOptions to C++, refactoring the entire class into another one called JSV8BreakIterator that would be a subclass of JSObject. TBR: benedikt@chromium.org Bug: v8:8111 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9bd1d82ec34b210c8ed59ea6576548d45a34b8d5 Reviewed-on: https://chromium-review.googlesource.com/1198946 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55627}
-
Frank Tang authored
Move Unwrap,FormatDateTime,DateTimeFormat,ToDateTimeOptions,ToLocaleDateTime to JSDateTimeFormat Bug: v8:8066 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: I4d83cc96ea280ab8f77df5a431b877b76b05f1ac Reviewed-on: https://chromium-review.googlesource.com/1198142 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
- 04 Sep, 2018 26 commits
-
-
Frank Tang authored
Bug: v8:8066 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: I74fe09bb6bb4428d57c66811b77f5f35144f717f Reviewed-on: https://chromium-review.googlesource.com/1186153 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
tzik authored
As a step of Context-associated MicrotaskQueue [1], this CL adds a stub for v8::internal::MicrotaskQueue. [1]: https://docs.google.com/document/d/1oNNhXF66dmwyj5S6Ri_g1vmBZltK8rWvZo1Tgqj64Z0/edit?usp=sharing Tbr: bmeurer@chromium.org Bug: v8:8124 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie3d86ca49d46749660ec1316e4ae051528076e97 Reviewed-on: https://chromium-review.googlesource.com/1192803 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: Id2ba591deb39428d9c788a9c9dcfd15bb8581bd0 Reviewed-on: https://chromium-review.googlesource.com/1205330Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55623}
-
Frank Tang authored
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Bug: v8:7979 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic390fbde6e04e86b8e284975c13c1eff8dc59e90 Reviewed-on: https://chromium-review.googlesource.com/1205411Reviewed-by:
-
Frank Tang authored
Bug: v8:7979 TBR: benedikt@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: I9d5181c15b56de3bc5288d11bd83e55157c7a610 Reviewed-on: https://chromium-review.googlesource.com/1168518 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I0bd15f4769e9ab09aec3f479af0ee50fc81fd6dc Reviewed-on: https://chromium-review.googlesource.com/1204950Reviewed-by:
-
Michael Lippautz authored
Reocord UMA counters for the following phases: - Scavenging roots - Scavenging object graph in parallel Bug: chromium:850508 Change-Id: I07210271179ce6801ea6daf3b486b4ce237a3261 Reviewed-on: https://chromium-review.googlesource.com/1199302 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Hai Dang authored
Since the benchmark is very fast, a warmup is useful to reduce the noise created by optimization. Change-Id: I4902c5c1695099be766d0fcc563c2f5d0892d3a9 Reviewed-on: https://chromium-review.googlesource.com/1204112 Commit-Queue: Hai Dang <dhai@google.com> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Bill Budge authored
Bug: v8:8015 Change-Id: Ic6d3b4f927095ba2e78509c1ba07e5b9258426e2 Reviewed-on: https://chromium-review.googlesource.com/1198182Reviewed-by:
-
Michael Lippautz authored
Allow mocking the limits for ArrayBuffer allocation to simulate operating system OOM. Bug: chromium:845409 Change-Id: I38bf56a3677e1db547c774223c81e913f56cb631 Reviewed-on: https://chromium-review.googlesource.com/1203895Reviewed-by:
-
Michael Starzinger authored
This fixes an off-by-one in the ordering restriction check for exception sections in a module. It also adds proper testing for exception handling of indirect calls. This in turn adds a table section that triggers the aforementioned bug. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions,unittests/WasmModuleVerifyTest BUG=v8:8091 Change-Id: Ie44ad4dee1b0c623f069fca7661c4282492b52d6 Reviewed-on: https://chromium-review.googlesource.com/1203993Reviewed-by:
-
Clemens Hammacher authored
{go} sounds active, as if the state would be changed. {reached} sounds like an accessor. Drive-by: Make the accessor const to further clarify that this is just an accessor. R=titzer@chromium.org Bug: v8:8015 Change-Id: I80d5223b9573345d3de386d68871a9e828621fc0 Reviewed-on: https://chromium-review.googlesource.com/1203992Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55614}
-
Benoît Lizé authored
Utf*Characterstream caches the data pointer of ExternalStrings through ExternalStringStream, so lock the strings in ExternalStringStream. Bug: chromium:877044 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I241caaf64e109b33e2f9982573e11c514410509c Reviewed-on: https://chromium-review.googlesource.com/1194003 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Florian Sattler authored
This is a reland of 5bbd1921 Original change's description: > [scanner] Inlining ScanIdentifier and Token check > > This improves parse time for code-load and other benchmarks. > > Bug: v8:7926 > Change-Id: I9c8017f2e7f73dd952c025db5abe8e4062e6ef9b > Reviewed-on: https://chromium-review.googlesource.com/1196506 > Commit-Queue: Florian Sattler <sattlerf@google.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55521} TBR=verwaest@chromium.org,marja@chromium.org Bug: v8:7926 Change-Id: I35f265a2a2189325daaf4a361bda35bf82758b16 Reviewed-on: https://chromium-review.googlesource.com/1203731Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55612}
-
🎉 Mathias Bynens authoredThis reverts commit 0e78aceb. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Ship globalThis
🎉 " > > This reverts commit f7df60d5. > > Original change's description: > > Revert "Ship globalThis🎉 " > > > > This reverts commit 4dac9872. > > > > Reason for revert: Speculative revert for layout test failures: > > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25970 > > > > E.g.: > > virtual/service-worker-servicification/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html > > > > Original change's description: > > > Ship globalThis🎉 > > > > > > Proposal repository: > > > https://github.com/tc39/proposal-global > > > > > > Intent to ship: > > > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > > > > > Bug: v8:5537 > > > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > > > Reviewed-on: https://chromium-review.googlesource.com/1195494 > > > Reviewed-by: Adam Klein <adamk@chromium.org> > > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > > Commit-Queue: Mathias Bynens <mathias@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#55543} > > > > TBR=adamk@chromium.org,gsathya@chromium.org,mathias@chromium.org > > > > Change-Id: Iacb484d36ba2c8002336038660450b240006e0ab > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: v8:5537 > > Reviewed-on: https://chromium-review.googlesource.com/1199743 > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55564} > > TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org > > Change-Id: I7912be09ab68ef956a8cc164fa8bbd937efb58c5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:5537 > Reviewed-on: https://chromium-review.googlesource.com/1200722 > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55606} TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org Change-Id: Id41dbefc3b2015e66f71a0410bebae632692f178 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5537 Reviewed-on: https://chromium-review.googlesource.com/1203893Reviewed-by: -
Mike Stanton authored
Before, splice was implemented with a C++ fast path and a comprehensive JavaScript version. This impl. is entirely in Torque with a fastpath for SMI, DOUBLE and OBJECT arrays, and a comprehensive slow path. The same level of "sparse" array support as given by the array.js implementation is included. This reland addresses several issues: * Removed "sparse" array support from splice. * Addressed ClusterFuzz issue 876443: The test and code that uses the fix is in this CL. The fix in isolation can be seen here: https://chromium-review.googlesource.com/c/v8/v8/+/1199403 * Removed dead code in elements.cc BUG=chromium:876443, v8:8131, v8:1956, v8:7221 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2d4a66c24ba1edabeca34e27e6ff8ee6136ed5f1 Reviewed-on: https://chromium-review.googlesource.com/1201783 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Since https://crrev.com/c/1112003, the memory size is stored as size_t instead of uint32_t in order to support 4GB memories. Loading it as uint32_t only works on little-endian systems, and only for memory sizes <4GB. This CL fixes this to load and process the memory size as pointer-sized value. Additional platform-specific methods are added to perform a shift by a constant value. This can be reused to improve the generated code for other shifts. R=titzer@chromium.org Bug: v8:8130, v8:6600 Change-Id: Ifa688a3ed0e2809190571f24bdf47a7f53880b3d Reviewed-on: https://chromium-review.googlesource.com/1203950 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Stephan Herhut authored
Bug: v8:8015 Change-Id: I6540104f58acd819d5a57edae49f8b909aa1a065 Reviewed-on: https://chromium-review.googlesource.com/1203892Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I6539bef4a0caa01bffaad85332c31681176c24d6 Reviewed-on: https://chromium-review.googlesource.com/1204110Reviewed-by:
-
🎉 Mathias Bynens authoredThis reverts commit f7df60d5. Original change's description: > Revert "Ship globalThis
🎉 " > > This reverts commit 4dac9872. > > Reason for revert: Speculative revert for layout test failures: > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25970 > > E.g.: > virtual/service-worker-servicification/http/tests/serviceworker/webexposed/global-interface-listing-service-worker.html > > Original change's description: > > Ship globalThis🎉 > > > > Proposal repository: > > https://github.com/tc39/proposal-global > > > > Intent to ship: > > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > > > Bug: v8:5537 > > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > > Reviewed-on: https://chromium-review.googlesource.com/1195494 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Commit-Queue: Mathias Bynens <mathias@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55543} > > TBR=adamk@chromium.org,gsathya@chromium.org,mathias@chromium.org > > Change-Id: Iacb484d36ba2c8002336038660450b240006e0ab > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:5537 > Reviewed-on: https://chromium-review.googlesource.com/1199743 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55564} TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org Change-Id: I7912be09ab68ef956a8cc164fa8bbd937efb58c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5537 Reviewed-on: https://chromium-review.googlesource.com/1200722Reviewed-by: -
Michael Starzinger authored
R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions BUG=v8:8091 Change-Id: I866430e1f3d3e7b93001a4375a869f19de75e65e Reviewed-on: https://chromium-review.googlesource.com/1203954Reviewed-by:
-
Yang Guo authored
Also extend the API to reflect this new feature. R=jgruber@chromium.org, szuend@google.com, ulan@chromium.org Bug: v8:8125 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic7a7604a8c663ba04b324eb8902ff325a25654e7 Reviewed-on: https://chromium-review.googlesource.com/1202087Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Change-Id: I28553eb80f78359e6aeb5bb05a1ea39467e164c9 Reviewed-on: https://chromium-review.googlesource.com/1203830Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55603}
-
Michael Starzinger authored
This fixes exception creation (by the WebAssembly throw operation) so that it is not observable by JavaScript. Internal properties are now stored with symbol names instead of string names, which also prevents them from being accessed or monkey-patched directly by JavaScript. R=clemensh@chromium.org TEST=mjsunit/regress/wasm/regress-8094 BUG=v8:8094 Change-Id: I33cb27f4373114cd4db28d9aef23560093e55242 Reviewed-on: https://chromium-review.googlesource.com/1203951 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Stephan Herhut authored
WebAssembly.Instantiate would silently fail when the passed in memory object did not have guard regions even though the compiled module assumes so. This lead to an inconsitent state and a DCHECK error. Instead, now throw a LinkError. Change-Id: I68bab842bcc40d3325aea4b19979d80054ed407c Reviewed-on: https://chromium-review.googlesource.com/1180892 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55601}
-
Clemens Hammacher authored
Bug: v8:8126 R=sattlerf@google.com CC=jgruber@chromium.org, titzer@chromium.org Change-Id: I32ec94fd913def346d1e783b2ffd0ec7d16e5df5 Reviewed-on: https://chromium-review.googlesource.com/1203730Reviewed-by:
-
