- 27 Feb, 2020 15 commits
-
-
Milad Farazmand authored
Change-Id: Ib13c5cd2230d29321b9502e85f9ac035e2618250 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078313Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66486}
-
Sathya Gunasekaran authored
This reverts commit 1f35c165. Reason for revert: speculative revert for TSAN failure: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/12179 Original change's description: > [objects] Update JSArrayBuffer::extension-field in two steps > > The JSArrayBuffer::extension-field might not be aligned with pointer > compression enabled. However on AArch64 pointers need to be aligned if > you perform atomic operations on them. Therefore split extension into > two 32-bit words that each get updated atomically. There is no ABA > problem here since the extension field only transitions from > NULL --> value --> NULL. After Detach(), Attach() isn't invoked anymore. > > Bug: v8:10064 > Change-Id: If987ed51f0528ca7313980f3d36ffca300b75fdc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071256 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66457} TBR=ulan@chromium.org,dinfuehr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10064 Change-Id: I2107a4d49d2b127dc65ce11b3b61ccc592fb0736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078579Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#66485}
-
Georg Neis authored
Change-Id: Ie7b9323d7491d1105a8a5b14b341ab023b0a59eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078572 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66484}
-
Tamer Tas authored
Recently the callstats runner started crashing due to scipy imports. This CL moves the import to mitigate the crashes. TBR=machenbach@chromium.org Bug: v8:10269 Change-Id: I67c2093f12ae287354a59e9cd32b79c6288b8edd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078571Reviewed-by:
-
Emanuel Ziegler authored
Added implementations for ia32, arm, arm64. mips/mips64 will be committed in separate CL once the build is green again in order not to stall this CL with the supported architectures. Drive-by: Fixed issues with kScratchRegister being overwritten in case of RegExp compilation by using alternative temp register for x64. Drive-by: Added missing NoRootArrayScope to ia32, arm and arm64 RegExp macro assemblers. R=clemensb@chromium.org R=petermarshall@chromium.org R=jgruber@chromium.org Bug: chromium:1045860 Change-Id: I716d852b9bf780ae7b8d61376c6505dd3af96a50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071866 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#66482}
-
Igor Sheludko authored
This reverts commit aa984947. Reason for revert: Unexpectedly regresses SixSpeed benchmarks. Will reland a fix without refactoring. Original change's description: > [ptr-compr] Fix 32-bit smis on non-ptr-compr builds > > Bug: v8:10047, v8:10257 > Change-Id: Ifcc65235726420fe753e26707d84061400d5d2b1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050384 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66415} TBR=ishell@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10047, v8:10257 Change-Id: Ic3253652adcce457cf0810baa0eb09cc9a383ceb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2077913Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#66481}
-
Jakob Kummerow authored
The bots don't have enough memory for this test. No-try: true Bug: v8:10280 Change-Id: I2f6dfa80d0337d2e96445577e39b4c894ae84acc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2077680 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: Ic57b38cefbdc21045d71601c67995d3568634c27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069400 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#66479}
-
Clemens Backes authored
Most function signatures are created once and never changed. Hence pass them as const pointer. This makes it clear in function signatures that these parameters will not be modified. This also avoids a few ugly const_casts where we were passing pointers to constexpr FunctionSigs via non-const pointers. R=jkummerow@chromium.org Bug: v8:10155 Change-Id: Ieb658ab5582bff276f76babdaf7ddb8f72bd4790 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072739Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66478}
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: I6f0b027d02b4d6a128a81584d40a30b1c5c518f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069399 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is a reland of 7d1f95d6 The reland fixes a performance issue in that we incorrectly marked every pattern containing a backslash as needing to be escaped, resulting in a new string allocation instead of reusing the existing string. Original change's description: > [regexp] Correctly escape a backslash-newline sequence > > When printing the source string, a backslash-newline sequence ('\\\n', > '\\\r', '\\\u2028', '\\\u2029') should be formatted as '\n', '\r', > '\u2028', '\u2029', respectively. Prior to this CL it was formatted as > a backslash followed by the literal newline character. > > Bug: v8:8615 > Change-Id: Iac90195c56ea1707ea8469066b0cc967ea87fc73 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016583 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65986} Bug: v8:8615,chromium:1046678 Change-Id: I5d75904f1ea543ec679649668e54749821116442 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074159 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#66476}
-
Milad Farazmand authored
Fixing a compilation error: 'Arguments' requires template arguments Change-Id: I6857adadea655dffdf40250f845f76bc1832b785 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076297 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66475}
-
Camillo Bruni authored
Drive-by-fix: improve table layout. Change-Id: If566e93b7f96d402a8f21715b7e6d3132817a20b No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074642Reviewed-by:
-
Shu-yu Guo authored
https://github.com/tc39/test262/commit/f6b2ccdd091ff82da54150796297c3a96d7edb41 Bug: v8:7834 Change-Id: I826a5218d9a7629adffeaa840e996575b50e1606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076689 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#66473}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9dba72c..ff66038 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d2b5e78..624dae6 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/227d510..005269a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/eeaa53b..f5a3941 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I4d0529e4298f7413de68584d67af582261aefdad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2077057Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#66472}
-
- 26 Feb, 2020 25 commits
-
-
Seth Brenith authored
This allows Torque code to refer to these bitfields (not currently relevant for any of these classes), and allows the postmortem debugging API to provide details about these bitfields. Change-Id: I79c74a3c5ef1f77e839720a4e8ee1f8482a576ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049870 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Victor Gomes authored
This adds static types to the argument class that accesss the arguments in the stack. kRuntime arguments are used by runtime functions and kJS arguments are used to access the JS stack (eg. builtins). The distinction allows the reversal of arguments in the JS stack without changing the runtime arguments order. Bug: v8:10201 Change-Id: I7c08164d53c4071c7910836fa733dee8ff7fa680 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066985 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Clemens Backes authored
The method was deprecated in favor of {IsWasmModuleObject}. R=adamk@chromium.org Bug: v8:10155 Change-Id: Id21a1b74dde5576c2c82cc209555c22209a9e5d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2033170Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66469}
-
Clemens Backes authored
This is a reland of 0dc598df Original change's description: > [wasm] Refactor callback triggering > > 1) Instead of passing three boolean values to |TriggerCallbacks|, pass > one EnumSet which contains all events to trigger. > 2) Remember which events already happened, to avoid triggering them > again. > 3) Compute triggered events once after the loop in |OnFinishedUnits|, > instead of checking for every finished unit. > 4) When a new callback is registered, trigger all previous events > immediately. This solves issue v8:10217. > 5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now. > 6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were > compiled (this is a minor performance optimization; we save taking > and releasing a lock). > 7) Drive-by: Make the |EnumSet| constructor really constexpr (by making > |Mask| constexpr). > > R=ahaas@chromium.org > > Bug: v8:10217 > Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66459} Bug: v8:10217 Change-Id: I9f7ca424fa7f1d0379dabe230bebf62522dfc857 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074501Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66468}
-
Milad Farazmand authored
Change-Id: I3da840cdabf6d0ed8c4d823855acb999a0167167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073206Reviewed-by:
-
Georg Neis authored
It used to print the elements kind as a byte, thus producing \000 etc. This also broke the json produced by --trace-turbo. Change-Id: I2f9ce5cb5815ab30fd7866e52fa5ab2732904e1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074640 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#66466}
-
Seth Brenith authored
This reverts commit 4dc1fb4e. Reason for revert: the regression from the original change was likely due to unlucky factors like code alignment. Original change's description: > Revert "[torque] Support bitfield structs stored within Smis" > > This reverts commit e5e4ea96. > > Reason for revert: mysterious performance regression chromium:1052756 > > Original change's description: > > [torque] Support bitfield structs stored within Smis > > > > This change moves the definition of the bits stored in DebugInfo::flags > > to Torque, and updates the only Torque usage of that field to use more > > natural syntax. This is intended as an example of common patterns found > > in various other classes. Several supporting changes are required: > > > > 1. Add a new type representing a bitfield struct stored within a Smi. It > > is currently called SmiTagged, but I'm open to suggestions. > > 2. Add an enum-style output for Torque bitfield structs whose bitfields > > occupy only one bit each. > > 3. Add a new case to MachineOperatorReducer that makes the generated > > code for IncBlockCounter match with what was generated before this > > change. > > 4. Add support for reporting these bitfields in the postmortem debugging > > API. The format matches existing bitfields but with an offset value > > that includes the SMI shift size. > > > > Bug: v8:7793 > > Change-Id: Icaecbe4a162da55d2d9a3a35a8ea85b285b2f1b7 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2028832 > > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#66182} > > Bug: chromium:1052756, v8:7793 > Change-Id: I9e2897efbb6321124bf4952cf09de2f179f7310d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062569 > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66349} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1052756, v8:7793 Change-Id: I6087928aa14c8551ebd294513bd8d6ffa402a0d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070635Reviewed-by:
-
Nico Hartmann authored
Bug: v8:7790 Change-Id: Ib5fe2727e52a62931cb1bd5ae84fa423a9f6c670 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071262Reviewed-by:
-
Victor Gomes authored
Bug: v8:10201 Change-Id: Ie6dbd43ff776b7a5b777923d659edf3038783567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074498 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a first step to make {WasmCode} objects smaller. Many code offsets are currently stored in {size_t} even though there were originally (during assembly) an int. Others are stored in {uint32_t}. This CL switches the function index and all code lengths and offsets to int, because a) bigger code is not supported anyway, and b) the style guide recommends int over unsigned types. This makes the {WasmCode} 24 bytes smaller on x64 (from 144 to 120 bytes). R=ahaas@chromium.org Bug: v8:10254 Change-Id: I8f78bf4be64d59cf9393e3b6662d9d3bd153d387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074217Reviewed-by: -
Clemens Backes authored
This reverts commit 0dc598df. Reason for revert: Fails the wasm-cache-test blink test. Original change's description: > [wasm] Refactor callback triggering > > 1) Instead of passing three boolean values to |TriggerCallbacks|, pass > one EnumSet which contains all events to trigger. > 2) Remember which events already happened, to avoid triggering them > again. > 3) Compute triggered events once after the loop in |OnFinishedUnits|, > instead of checking for every finished unit. > 4) When a new callback is registered, trigger all previous events > immediately. This solves issue v8:10217. > 5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now. > 6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were > compiled (this is a minor performance optimization; we save taking > and releasing a lock). > 7) Drive-by: Make the |EnumSet| constructor really constexpr (by making > |Mask| constexpr). > > R=ahaas@chromium.org > > Bug: v8:10217 > Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66459} TBR=ahaas@chromium.org,clemensb@chromium.org Change-Id: I564b053e898db5f7b51cefa4626c0625a225c89a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074638Reviewed-by:
-
Dominik Inführ authored
Switch the flag to true to enable ArrayBufferExtensions by default. The last CL (https://crrev.com/c/2065088) that tried to enable this was reverted because of alignment issues on ARM64 (fixed in https://crrev.com/c/2071256). Bug: v8:10064 Change-Id: I47f478c978094fb5038113eb452865748956b42e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074157Reviewed-by:
-
Clemens Backes authored
1) Instead of passing three boolean values to |TriggerCallbacks|, pass one EnumSet which contains all events to trigger. 2) Remember which events already happened, to avoid triggering them again. 3) Compute triggered events once after the loop in |OnFinishedUnits|, instead of checking for every finished unit. 4) When a new callback is registered, trigger all previous events immediately. This solves issue v8:10217. 5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now. 6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were compiled (this is a minor performance optimization; we save taking and releasing a lock). 7) Drive-by: Make the |EnumSet| constructor really constexpr (by making |Mask| constexpr). R=ahaas@chromium.org Bug: v8:10217 Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Richard Townsend authored
Bug: v8:10012 Change-Id: I8d2d95090bd45c560cbc208737f037adc433facb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072741Reviewed-by:
-
Dominik Inführ authored
The JSArrayBuffer::extension-field might not be aligned with pointer compression enabled. However on AArch64 pointers need to be aligned if you perform atomic operations on them. Therefore split extension into two 32-bit words that each get updated atomically. There is no ABA problem here since the extension field only transitions from NULL --> value --> NULL. After Detach(), Attach() isn't invoked anymore. Bug: v8:10064 Change-Id: If987ed51f0528ca7313980f3d36ffca300b75fdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071256 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
When iterating objects on a page add CHECKs that we actually load a map and ensure the object ends within the current chunk. Bug: chromium:1055252 Change-Id: I8f2d5f08229cb1a2fce64af6e22988de87d1b572 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072744Reviewed-by:
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: Iaf1399a0ccc94f8f96cfdab4364eb918d58659d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073758Reviewed-by:
-
Clemens Backes authored
1) Merge |AddBaselineCompilationUnits| into |InitializeRecompilationProgress|. 2) Rename |InitializeRecompilationProgress| to |InitializeRecompilation|. 3) Unify the update of |ReachedRecompilationTierField| in |compilation_progress_|. R=ahaas@chromium.org CC=duongn@microsoft.com Bug: v8:9654 Change-Id: I58324b553bf226cacb355e387c235841fdea82d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071863 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Marcin Wiącek authored
Before: running different suites is removing non-related master data After: different suites have separate master data files Change-Id: Iab46d663fdf2a1d709aeb7da77a443c2ed1bdcc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071870Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#66453}
-
Georg Neis authored
This reverts commit b12ba06e. Reason for revert: After further discussion we decided to stick with fdlibm. Original change's description: > [builtins] stop using imprecise fdlibm pow > > This CL reinstates the old pow implementation which calls out to the > system implementation of pow. > > Bug: v8:9622 > Change-Id: I3df997888ced3fb8b5bd4b810098e967649aaa55 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1774898 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66303} TBR=yangguo@chromium.org,neis@chromium.org,hpayer@chromium.org,me@gus.host # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9622 Change-Id: I941f70c7432cd2fab86e0eadcb2e1a9ec8195e91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072746 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Backes authored
This extends EnumSet by 1) adding element-wise operations (without first creating an EnumSet of that element in the caller), 2) adding arithmetic assignment operators, and 3) adding a subtraction operation which removes all elements in another EnumSet, or a single element. R=mlippautz@chromium.org Change-Id: Ibe694e9e111e506ad09cf9729fa0b0ba38430b79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071874 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66451}
-
Clemens Backes authored
In {InitializeRecompilationProgress}, we already have logic in place to call the callback (all callbacks really) if no compilation units were added. In that case, the callback in fact does not need to be added to the list of callbacks. Instead, it's enough to just call this one callback and then discard it. R=ahaas@chromium.org Bug: v8:9654 Change-Id: I60bab2d67d67d10964404d897d13ffd628ff9964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071861 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Georg Neis authored
This reverts commit 73f91a2d. Reason for revert: Reverting b12ba06e Original change's description: > [builtins] Replace V8_INFINITY with its definition > > V8_INFINITY is not defined here. > "src/common/globals.h" is also not allowed to be included > in this source file. > > Change-Id: Ia3b14db8ac5099b6ce65839eb0fc59340dc59555 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062930 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#66336} TBR=neis@chromium.org,clemensb@chromium.org,me@gus.host,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia43c3f7f735dfb622d4f5464a52a142d19ddeb26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072745Reviewed-by:
-
Emanuel Ziegler authored
Added a type field to elements to distinguish anyref, funcref and nullref elements and do a proper type checking at compile time as the spec requires. R=ahaas@chromium.org Change-Id: I31be7aa1170439859ca7ec5e20aabb2720c290b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069330 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Clemens Backes authored
EnumSet hold a single integral field, hence it should be passed by value. All users already do this, we are just inconsistent within the declaration of EnumSet itself. R=mlippautz@chromium.org Change-Id: Ic2cac35fbd8fe3e98c1fe135bd334547dca30ab5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071872Reviewed-by:
-
