- 17 Feb, 2022 11 commits
-
-
Michael Lippautz authored
There's only a single callsite that performs retries after allocations which already can determine the proper GC to invoke without requiring threading the space backwards. Bug: v8:12615 Change-Id: I5d5d886162b3eca33eb2fe7bde1e113cd08a094c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468905Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79143}
-
Camillo Bruni authored
Avoiding handles in tight loops and setup code improves performance and reduces code size. This CL also makes more non-allocating mode more explicit by adding more DisallowGarbageCollection scopes. Change-Id: I95b5b1a29204c27a23c42ccd67fff150b3fa4a3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460740Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79142}
-
Omer Katz authored
Outside of unittests, if someone tried to delete a GCed object manually they would get a silent crash without a stacktrace or any error messages. This CL replaces the silent crash with an informative message. Change-Id: Ied8895dab43ce7e3a9bf778b13e77d377d269fce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468346 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79141}
-
Jakob Kummerow authored
which the "no-wasm" build refactoring had accidentally disabled. Bug: v8:11238 Change-Id: Ia2a4be89024f0bc22a1548dcef21e065e4bb5268 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468341Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#79140}
-
Clemens Backes authored
In order to create less tasks that each need to swap permissions for writing to the code space, merge the two {CopyAndRelocTask} and {PublishTask} into a single {DeserializeCodeTask}. This also makes the code a lot shorter, and removes stress from the scheduler. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: I8866bf7225b0bc2dd4caef79e64cacca9de15519 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468902Reviewed-by: -
Michael Lippautz authored
Avoid the lookup via heap()->incremental_marking() and instead cache the marking state on GlobalHandles itself. Change-Id: I2665681ad38983bf16d22e0a82dd10743877e520 Bug: chromium:1294661 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468903Reviewed-by:
-
Manos Koukoutos authored
Changes: - Simplify GetRefTypeName. - Simplify WasmModuleDebug::GetWasmValue. - Fix some signature issues in tests. Change-Id: I61b9a48c0fbce0bc9cc74771412bdb8977880697 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468344Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79137}
-
V8 Autoroll authored
Change-Id: I2c4bcabe00d85188675441dc242cd2efc90c5fca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470561Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#79136}
-
Clemens Backes authored
Publishing Wasm code often happens in a loop (in particular for deserialization), so hold the {CodeSpaceWriteScope} outside that loop to avoid repeated switching between writable and executable. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: Ic4bf859685e66c4ba297fed968d0df6ae7d24cba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468896Reviewed-by: -
Camillo Bruni authored
Historically the tool only combined files where the run number was separate by a hash: domain#1.txt , domain#2.txt... Fix this to allow for underscores and/or abitrary number suffixes. Change-Id: I85253a1b871eb75fce60fef9a61b7d50afe72abd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468900Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79134}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/62a6377..996f747 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/169eef5..f413334 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/b323ac8..1e0047c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6fbe580..7504934 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d6a3040..e293d3d Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/9538f41..901a5d9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/62e2cd9..0a9dd77 Rolling v8/tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858 Rolling v8/tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Icd4bf05c19d156a1266ce51b4b8ab9af0d4782ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468735 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79133}
-
- 16 Feb, 2022 23 commits
-
-
Milad Fa authored
Change-Id: I45f3379b3656ee2bc939c97c37d3f15bd730de5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3469177Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79132}
-
Samuel Groß authored
The new shared memory API should only be used on macOS, but platform-macos.cc was also included on iOS, causing build failures. This CL splits platform-macos.cc into platform-xnu.cc (common code for macOS and iOS) and platform-macos.cc (the macOS specific parts) Bug: chromium:1218005 Change-Id: Iab332865ffd8990ddd246bb9c08802909464d7e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468895Reviewed-by:
-
Camillo Bruni authored
Don't print command line invocations by default. Change-Id: Ie67c883c92557a645fc8a681722f49a2c7c4bd17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468901Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79130}
-
Nico Hartmann authored
Bug: v8:12633 Change-Id: I4bb98b9f93f7c4a13f7374c732f47aaffedd4a14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468897 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#79129}
-
Milad Fa authored
Change-Id: I0d6258cae0e75b6bd4916cb4c559161f7eac2170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3465739Reviewed-by:
-
Camillo Bruni authored
This is a reland of 9ae463bc - Don't run the heap stats during bootstrapping Original change's description: > [heap-stats] Fix heap-stats with ptr-cage > > - Heap-stats was trying to load the map without explicitly passing in > the PtrComprBase causing failures with Code objects in external code > space > - Extend the debugPrint.js tests to run with some more debugging and > testing flags to prevent future regressions > > Change-Id: I1f0d03cb31480f316fe533b507ff98fe3befbe8e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3432386 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Auto-Submit: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78919} Bug: chromium:1297436 Change-Id: Ib42ae7b8c5f4a427abbce633a1b3ac36ad32994b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437046Reviewed-by:
-
Michael Lippautz authored
The flag is required to allow passing in more debug information when necessary. Change-Id: I34e407ba57786c242aac8b6f6af258969de43efd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468894Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79126}
-
Paolo Severini authored
Allow Wasm to generate calls directly to Fast API C functions. Also fixes a problem when calling a Fast Api C function with no FastApiCallbackOptions from JS. This is a rebase of https://chromium-review.googlesource.com/c/v8/v8/+/3364356, which was a rebase of the work originally done by devsnek in: https://chromium-review.googlesource.com/c/v8/v8/+/2718666. Bug: chromium:1052746, chromium:1292333 Change-Id: Ic56268e7723f80f7ea9e6799e777786d3a50222f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440694Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79125}
-
Camillo Bruni authored
- Add build flag and disable runtime-call-stats by default - Partially fix trap-handler includes for 64-bit android Change-Id: I1c22dbb2a30b7d11ae332ee5b7964a6119ab1188 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3461933Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79124}
-
Samuel Groß authored
This API allows allocating shared memory mappings inside a virtual address space from a platform-specific handle to a shared memory object. This will make it possible to allocate shared memory inside the sandbox, for example as backing memory for ArrayBuffers. Bug: chromium:1218005 Change-Id: I4f1f50baec50734e846496cff78046e4fffe75c5 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3383777Reviewed-by:
-
Michael Lippautz authored
The information was previously kept heap-global but is really only used by spaces when refilling their LABs. Bug: v8:12615 Change-Id: Iee256d35ffa0112c93ec721bc3afdc2881c4743b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3465898Reviewed-by:
-
Camillo Bruni authored
Change-Id: Icb77604d55353064cb793224b3f9c5b691503852 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3466794Reviewed-by:
-
Michael Lippautz authored
Drive-by: Simplify pause logic. Bug: v8:12615 Change-Id: I64e44bff1de1419f1290c9f79cf5bdfe65d8903f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3466796Reviewed-by:
-
Samuel Groß authored
These should not be allowed inside the sandbox as they could be corrupted by an attacker, thus posing a security risk. Furthermore, executable pages require MAP_JIT on macOS, which causes fork() to become excessively slow, in turn causing tests to time out. Due to this, the sandbox now requires the external code space. In addition, this CL adds a max_page_permissions member to the VirtualAddressSpace API to make it possible to verify the maximum permissions of a subspace. Bug: v8:10391 Change-Id: Ib9562ecff6f018696bfa25143113d8583d1ec6cd Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460406Reviewed-by:
-
Manos Koukoutos authored
The reason mentioned for requiring python2 is no longer valid. Bug: chromium:1292013, chromium:1292016 Change-Id: Id8fc938d32c8e967fff74239ccba8ad79e517c57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3464034Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Now that different tiers use dedicated interrupt_budgets (which determine how often the runtime profiler (now tiering manager) is called), I don't see a meaningful way to use results from this counter. Bug: v8:7700 Change-Id: I2ec2242d3c7f6c2b9deab075a6f0500cc1350e96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3467595Reviewed-by:
-
Jakob Gruber authored
TierUpCheck and UpdateInterruptBudget were only used by Turboprop (likewise feedback_cell_node). Bug: v8:12552 Change-Id: Ic73d44a5734e183bc1a2eda58cdf85163220e4d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3463954 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This predicate is just confusing - it's a renamed version of HasBytecodeArray; but HasBytecodeArray also returns true if the SFI has attached Sparkplug code - and is thus not interpreted. Simply replace it by HasBytecodeArray. Bug: v8:7700 Change-Id: Id4be2048a625142ade1096044133d9cd2896b51d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3461935Reviewed-by:
-
Camillo Bruni authored
- Simplify HeapObject::IsArrayList check - Dehandlify ArrayList initialization - Prevent auto-formatting of v8heapconst.py Change-Id: I9849ad82dae1a2dc671433e8d5eb8ec63ed830c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447906Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Jakob Gruber authored
- bbudge - delphick - gsathya - mvstanton - sigurds - zhin + tebbi in src/torque/OWNERS Change-Id: I81ff27860cede273f1874b6079fa89e09486a99a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3461937Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79113}
-
Lu Yahan authored
Change-Id: I5b17019a991f1540c0ecc1db0a94097334e5e335 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3463060Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#79112}
-
Michael Achenbach authored
This ports: https://crrev.com/c/3321055 No-Tree-Checks: true Bug: chromium:1292013 Change-Id: I2ab939c43744725885329330f52dce1ef0a48ab7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3466795 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d5f9249..62a6377 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/01efcb5..738dc10 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7bede42..6fbe580 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4e4a2b8..d6a3040 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/03f3212..9538f41 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ad74e59..62e2cd9 Rolling v8/tools/luci-go: git_revision:fbbb5b9748a05dd16fe621f7ea48a4ece1913874..git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa Rolling v8/tools/luci-go: git_revision:fbbb5b9748a05dd16fe621f7ea48a4ece1913874..git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7ac51800087314d5c0bf5e6a186c63b059305f3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3465720 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79110}
-
- 15 Feb, 2022 6 commits
-
-
Clemens Backes authored
Even though this is not a perfect protection, it will make it harder to write to the wasm code space because it's not permanently RWX. After optimizations (see https://crbug.com/v8/11974) the performance is good enough that it's worth just enabling it. R=ahaas@chromium.org Bug: v8:11974 Change-Id: I82786e932387732863c3c5e3aa743f7836cc45e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3464035Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79109}
-
Milad Fa authored
Change-Id: I809ebfb3e7c11a7cf61873043abae85dc069ed66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3464914Reviewed-by:
-
Jakob Gruber authored
This was mostly unused. We should simply be able to use CodeKind plus related predicates instead. Replace FeedbackVector::optimization_tier with maybe_has_optimized_code, which states whether the optimized code cache is filled. The value is updated lazily and may lag behind the actual code cache state. We only use this field for quick cache-empty? checks from generated code. Bug: v8:7700,v8:12552 Change-Id: Ibfc5c0128eac56167a68ecba5690eab2e9369640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460741Reviewed-by:
-
Clemens Backes authored
Data segments were missing in the output of --wasm-fuzzer-gen-test. R=manoskouk@chromium.org Bug: v8:11863 Change-Id: I40e60ef8626125ca9df6bead688607215d9e5b58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3461932Reviewed-by:
-
Thibaud Michaud authored
Split small chunks of assembly instructions into separate functions. This makes the code easier to follow and to maintain, especially for register allocation. Drive-by: simplify stack-switching test. R=ahaas@chromium.org Bug: v8:12191 Change-Id: Id7544a3b2d16085540d9f1863a0eabd1f72f22bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3461929Reviewed-by:
-
Dominik Inführ authored
LocalAllocator was already renamed to EvacuationAllocator some time ago. Rename files now as well. Bug: v8:10315 Change-Id: I337f693998aaf5187a5ba05842cdb2474837b68d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3463719 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
