- 16 Mar, 2016 14 commits
-
-
jkummerow authored
along with "[arm64] Fix i/d cache line size confusion typo" and "Fix a warning about inline asm source/destination mismatches..." which were building on it. This reverts the following commits: 8d7399f9 474e6a3d c3ff68b6 Reason for revert: We're getting a large number of crash reports from arm64 devices that are obviously related to cache flushing after code patching. Bisection results say that the problems started at revision c3ff68b6. Since I can't find a bug in that CL except for the typo that I've fixed in 474e6a3d (which made some of the crashes go away but not all of them), we have no choice but to revert the changes in order to get stability under control while we investigate. BUG=chromium:594646 LOG=n Review URL: https://codereview.chromium.org/1806853002 Cr-Commit-Position: refs/heads/master@{#34816}
-
machenbach authored
TBR=jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1807883002 Cr-Commit-Position: refs/heads/master@{#34815}
-
neis authored
R=littledan@chromium.org BUG=v8:3455 LOG=n Review URL: https://codereview.chromium.org/1772343008 Cr-Commit-Position: refs/heads/master@{#34814}
-
zhengxing.li authored
The CL #34701 (https://codereview.chromium.org/1779123002/) added the Run_WasmF32SConvertI64/Run_WasmF64SConvertI64 test cases and X87 failed at them. The reason is same as the CL #33630 (Issue 1649323002: X87: Change the test case for X87 RunRoundInt32ToFloat32), please refer: https://codereview.chromium.org/1649323002. Here is the key comments from CL #33630: Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. For CHECK_EQ(a, b) function, if a and b are double or float, it will has similar behaviors like CheckFloatEq(...) and CheckDoubleEq(...) function when compiled by GCC and causes the test case fail. So we add the following sentence to do type case to keep the same precision for Run_WasmF32SConvertI64/Run_WasmF64SConvertI64. Such as: volatile double expect = static_cast<float>(*i). ahaas put those codes in CHECK_FLOAT_EQ and CHECK_DOUBLE_EQ macros in CL #34534 (https://codereview.chromium.org/1773513002 ). So this CL replaced the CHECK_EQ in Run_WasmF32SConvertI64/Run_WasmF64SConvertI64 to CHECK_FLOAT_EQ/CHECK_DOUBLE_EQ for x87 can pass Run_WasmF32SConvertI64/Run_WasmF64SConvertI64 tests. BUG= Review URL: https://codereview.chromium.org/1784813004 Cr-Commit-Position: refs/heads/master@{#34813}
-
verwaest authored
This speeds up element normalization. BUG= Review URL: https://codereview.chromium.org/1802733002 Cr-Commit-Position: refs/heads/master@{#34812}
-
ahaas authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1806593003 Cr-Commit-Position: refs/heads/master@{#34811}
-
ishell authored
This fix removes unnecessary nops from function prolog and seems to recover performance regression on some of SunSpider benchmarks. TBR=bmeurer@chromium.org BUG=chromium:531369 LOG=N Review URL: https://codereview.chromium.org/1800233003 Cr-Commit-Position: refs/heads/master@{#34810}
-
ahaas authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1810473002 Cr-Commit-Position: refs/heads/master@{#34809}
-
ahaas authored
Int64Sub is lowered to a new turbofan operator, Int32SubPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the subtraction. The implementation is very similar to the implementation of Int64Add. @v8-arm-ports: please take a careful look at the implementation of sbc in the simulator. R=titzer@chromium.org, v8-arm-ports@googlegroups.com Review URL: https://codereview.chromium.org/1778893005 Cr-Commit-Position: refs/heads/master@{#34808}
-
jkummerow authored
The monomorphic case already carefully ensures that we don't try to use a regular elements load stub on string wrapper elements. The polymorphic path must perform an equivalent check. BUG=chromium:594955 LOG=n R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1806543002 Cr-Commit-Position: refs/heads/master@{#34807}
-
bmeurer authored
Add EqualStub and NotEqualStub, based on the CodeStubAssembler, and hook them up with TurboFan and Ignition. The stubs are a full implementation of abstract equality for ES6 plus the current SIMD.js draft, unlike the generic version of the CompareIC, which only implements a subset with funky runtime fallbacks. Drive-by-fix: Introduce some common helper methods. R=epertoso@chromium.org BUG=chromium:592690 LOG=n Review URL: https://codereview.chromium.org/1795793002 Cr-Commit-Position: refs/heads/master@{#34806}
-
Hannes Payer authored
BUG=chromium:595092 LOG=n R=hablich@chromium.org Review URL: https://codereview.chromium.org/1803313002 . Cr-Commit-Position: refs/heads/master@{#34805}
-
machenbach authored
The feature was removed from the bots a while ago. It was superseeded by the flaky-test detection which reruns tests. Remaining tests still marked as flaky most certainly pass since a while. Referencing all the bugs whose expectations lines get removed by this. BUG=v8:3838,v8:3525,v8:3125 LOG=n Review URL: https://codereview.chromium.org/1802983002 Cr-Commit-Position: refs/heads/master@{#34804}
-
zhengxing.li authored
port 1b230799 (r34747) original commit message: Int64Add is lowered to a new turbofan operator, Int32AddPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the addition. BUG= Review URL: https://codereview.chromium.org/1806833002 Cr-Commit-Position: refs/heads/master@{#34803}
-
- 15 Mar, 2016 26 commits
-
-
adamk authored
This part of Scope has existed since V8's initial check in, but from what I can tell it's not required to implement "with". The only tests that depend upon it are tests of the debugger and the Scope mirrors, but the resulting test behavior after removing the bit still seems perfectly reasonable to me. In fact, with the included fix for scope name collection, the scope mirror is actually improved with this change. As a bi-product, this fixes the attached bug, about the contains_with bit having inconsistent values in some arrow function compilation scenarios. BUG=chromium:592353 LOG=n CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1804783002 Cr-Commit-Position: refs/heads/master@{#34802}
-
littledan authored
src/js/regexp.js was one of the few files that was left in sloppy mode. The ES2017 draft specification requires that writes to lastIndex throw when the property is non-writable, and test262 tests enforce this behavior. This patch puts that file in strict mode. BUG=v8:4504 R=yangguo@chromium.org LOG=Y Review URL: https://codereview.chromium.org/1776883005 Cr-Commit-Position: refs/heads/master@{#34801}
-
joransiu authored
Add support for S390 to GDB-JIT. R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1804193002 Cr-Commit-Position: refs/heads/master@{#34800}
-
fmeawad authored
The current trace scoping failed to accomplish what it intended to do it failed in 2 aspects: First, when new trace events were added in https://codereview.chromium.org/1770353002/ they escaped the scopes. Secondly, a webgl code interacts with the V8 Objects directly using the EXECUTION_PRIMITIVE context that does not generate any TRACE_EVENTs resulting in a lot of empty scopes (breaking analysis on TBM webgl benchmarks) https://crbug.com/590761. I am removing the calls for now until figuring out a better approach for both issues. BUG=590761,v8:4565 LOG=N Review URL: https://codereview.chromium.org/1807433002 Cr-Commit-Position: refs/heads/master@{#34799}
-
cbruni authored
Array.prototype.concat did not work correct with complex elements on the receiver or the prototype chain. BUG=chromium:594574 LOG=y Review URL: https://codereview.chromium.org/1804963002 Cr-Commit-Position: refs/heads/master@{#34798}
-
mbrandy authored
Port 1b230799 Original commit message: Int64Add is lowered to a new turbofan operator, Int32AddPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the addition. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1803113002 Cr-Commit-Position: refs/heads/master@{#34797}
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1797383002 Cr-Commit-Position: refs/heads/master@{#34796}
-
jyan authored
R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1805533002 Cr-Commit-Position: refs/heads/master@{#34795}
-
adamk authored
BUG=v8:4247 LOG=y Review URL: https://codereview.chromium.org/1803903002 Cr-Commit-Position: refs/heads/master@{#34794}
-
alph authored
Use script_url when the script name is not available. BUG=chromium:463108 LOG=N Review URL: https://codereview.chromium.org/1796353002 Cr-Commit-Position: refs/heads/master@{#34793}
-
ofrobots authored
Stub code traces should also be redirected to the file specified by the user. R=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1795873002 Cr-Commit-Position: refs/heads/master@{#34792}
-
titzer authored
R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1806533002 Cr-Commit-Position: refs/heads/master@{#34791}
-
mythria authored
Updates InlineTwice to declare a function and then return a function instead of using function expressions by wrapping a function with '(' and ')'. The earlier implementation would cause the function to compile immediately instead of lazy compile. Also updates cctest.status BUG=v8:4280,v8:4837,v8:4680 LOG=N Review URL: https://codereview.chromium.org/1800073002 Cr-Commit-Position: refs/heads/master@{#34790}
-
jyan authored
R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1802343002 Cr-Commit-Position: refs/heads/master@{#34789}
-
rmcilroy authored
BUG=v8:4680 LOG=N TBR=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1801033002 Cr-Commit-Position: refs/heads/master@{#34788}
-
jyan authored
Upstream S390 platform specific code to latest lkgr from the past 2 weeks. R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1799893002 Cr-Commit-Position: refs/heads/master@{#34787}
-
yangguo authored
Sometimes v8.log entries are cut off, and leave an unpaired quote. Since the log is piped into d8 to run the tick processor, that quote is interpreted to escape a line break. This fix makes sure that we break lines even with unpaired quotes. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1802303002 Cr-Commit-Position: refs/heads/master@{#34786}
-
ahaas authored
The implementation is done by storing to and then loading from memory. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1801013002 Cr-Commit-Position: refs/heads/master@{#34785}
-
ahaas authored
The implementation is done by storing to and loading from memory. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1804953002 Cr-Commit-Position: refs/heads/master@{#34784}
-
ishell authored
This should recover a part of the regression caused by 7f11fba7 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N Review URL: https://codereview.chromium.org/1793293003 Cr-Commit-Position: refs/heads/master@{#34783}
-
ahaas authored
The tests require the implementation of Int32PairAdd and Word32PairShl. R=titzer@chromium.org, v8-mips-ports@googlegroups.com Review URL: https://codereview.chromium.org/1804913002 Cr-Commit-Position: refs/heads/master@{#34782}
-
yangguo authored
R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1802903002 Cr-Commit-Position: refs/heads/master@{#34781}
-
ishell authored
[turbofan] Fix double object allocation when inlining a construct call of a derived class or an Api function. Review URL: https://codereview.chromium.org/1798373002 Cr-Commit-Position: refs/heads/master@{#34780}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1792283007 Cr-Commit-Position: refs/heads/master@{#34779}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1806443002 Cr-Commit-Position: refs/heads/master@{#34778}
-
ahaas authored
Word64Popcnt is lowered to Word32Popcnt(low-word) + Word32Popcnt(high_word). Since the optional Word64Popcnt operator does not exist on 32 bit platforms, I introduced a new operator "Word64PopcntPlaceholder" which is generated in the WasmCompiler and then lowered in the Int64Lowering. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1803453003 Cr-Commit-Position: refs/heads/master@{#34777}
-