- 09 Jul, 2020 17 commits
-
-
Z Nguyen-Huu authored
With this change, if we pass --trace-turbo-stack-accesses, output will be something like: === Stack access counters === Number of functions: xx Name: wasm-function#1, Loads: xx, Stores: xx ... Total Loads: xx, Total Stores: xx This only applies to optimized/wasm functions. Bug: v8:10663 Change-Id: I0b08e3fa321b76dc53942c8fbffd14759978c7b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2283913 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68765}
-
Camillo Bruni authored
TryCatch creates normal handles for Exception and Message objects. Bug: v8:10537 Change-Id: I6ccd531242bfdc7a97ff5d8314d2f31086a28b07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284490Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68764}
-
Milad Farazmand authored
Change-Id: I52fc8025a4a878e4494ef9134a8c2bd1cec25fe1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289903Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68763}
-
Dominik Inführ authored
This reverts commit d6a14abe. Reason for revert: Caused TSAN failures. Original change's description: > [heap] Move start of incremental marking in allocation > > Move start of incremental marking out of > RefillLinearAllocationAreaFromFreeList. This avoids a potential > safepoint while holding allocation_mutex_. > > Bug: v8:10315 > Change-Id: Ieb60ac68f26199eea7b6b7ad6d874851382f3d69 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287496 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68751} TBR=ulan@chromium.org,dinfuehr@chromium.org Change-Id: Ic928413884115ac01917a8db591af83cbbc9cc5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289977Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#68762}
-
Dominik Inführ authored
This reverts commit 273f4e42. Reason for revert: Based on another need that needs to be reverted because of TSAN failures. Original change's description: > [heap] Avoid ParkedMutexGuard during allocation > > Since main thread allocation does not start incremental marking anymore > while holding allocation_mutex_, background allocation does not need > ParkedMutexGuard anymore to avoid deadlocks. > > This also means background thread allocation isn't paused anymore to > perform a GC, which already resulted in subtle bugs (e.g. in > ExpandBackground with incremental marking). We also do not > stop-the-world anymore while holding allocation_mutex_. > > Bug: v8:10315 > Change-Id: Iadf00bc26434c765722b82a10497ab06151f15cc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289771 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68754} TBR=ulan@chromium.org,dinfuehr@chromium.org Change-Id: I3a16c13626c891e8063564fc05fd2d3fc427d159 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289975Reviewed-by:
-
Jakob Kummerow authored
A Wasm module's start function might be imported from JavaScript, and as such might contain calls to Blink. For such a case, we must make sure that an "incumbent context" is available. See microtask queue handling for a similar example. Bug: chromium:1096558 Change-Id: I2e3c0fc20d4e3581e490822c3ac63ce2c5e1e990 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284982Reviewed-by:
-
Manos Koukoutos authored
Motivation: With rtt.sub now allowed in constant expressions, we have to generalize WasmInitExpr to be able to handle expressions with operands. This CL prepares the ground for this change and adds no functionality. Changes: - ValueType::heap_representation and HeapType::representation now return HeapType::Representation. - Add ValueType::is_rtt(). - WasmInitExpr: - Make kind private. Rename val -> operator, make it private. Add accessors. - Rename kGlobalIndex -> kGlobalGet. - Squash global_index and function_index into index. - Add heap_type Immediate. Use it for RefNullConst. TypeOf in module-decoder.cc can now fully determine the type of a WasmInitExpr. - Add class constructors/static method constructors for each Operator kind. - Delete copy constructor. WasmInitExpr will use std::unique_ptr for its operands. - consume_init_expr now uses a stack. - A few minor improvements. Bug: v8:7748 Change-Id: I3ba3ee7ac2d6bc58e887790c37110ceb80658985 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284483 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68759}
-
Seth Brenith authored
In previous change https://crrev.com/c/2274308 , I attempted to fix an issue where FindOptimalSpillingPos could sometimes fail to find the LiveRange that covers the top of the loop. However, I misunderstood how TopLevelLiveRange::GetChildCovers behaves, so I introduced a different case where FindOptimalSpillingPos would fail to find the right LiveRange. This change updates GetChildCovers to do what I had thought it would do, so it can find the right LiveRange in all cases. chromium:1102243 Bug: chromium:1101958, chromium:1101954, chromium:1102257, Change-Id: If91c642c3f7f5e3a8b4cfaa3b3577865c84afcb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288660Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#68758}
-
Jakob Gruber authored
After native-context-independent codegen, verify that the resulting Code object does not embed any nc-dependent objects, and that no code dependencies have been created. Bug: v8:8888 Change-Id: I894e74b27e86e7727ff17aa0dbfdd908373a5e55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284498 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68757}
-
Georg Neis authored
Change-Id: I3800486f18a3693c9e2d3ace0a6f8ee626efc84e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289780 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68756}
-
Jakob Kummerow authored
By introducing a globally known map for each generic type. These maps are never used to allocate objects, they only serve as sentinels for generic heap types. Bug: v8:7748 Change-Id: I950a8c712dc1510759a833fe9122b9e9a6222dc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288860 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Since main thread allocation does not start incremental marking anymore while holding allocation_mutex_, background allocation does not need ParkedMutexGuard anymore to avoid deadlocks. This also means background thread allocation isn't paused anymore to perform a GC, which already resulted in subtle bugs (e.g. in ExpandBackground with incremental marking). We also do not stop-the-world anymore while holding allocation_mutex_. Bug: v8:10315 Change-Id: Iadf00bc26434c765722b82a10497ab06151f15cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289771Reviewed-by:
-
Camillo Bruni authored
The tool is no longer supported since we migrated to Turbofan. Change-Id: I55b911f47867b2a6985ce14f973cd837f71ec4b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288859Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68753}
-
Clemens Backes authored
For 64-bit binary operations, Liftoff on arm made the assumption that register pairs are always ordered, i.e. the register code for the low word is lower than the register code for the high word. Ensuring this was only implemented in {GetUnusedRegister} in https://crrev.com/c/2168875. Other cases were missing though, e.g. return values, but also different places were we construct register pairs internally. Thus, this CL removes this constraint again and instead handles unordered register pairs in 64-bit binary operations on arm. R=thibaudm@chromium.org Bug: chromium:1101304 Change-Id: I4cd9fb1577f82ab06d34c9dde6533cf04a2cade7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287870Reviewed-by: -
Dominik Inführ authored
Move start of incremental marking out of RefillLinearAllocationAreaFromFreeList. This avoids a potential safepoint while holding allocation_mutex_. Bug: v8:10315 Change-Id: Ieb60ac68f26199eea7b6b7ad6d874851382f3d69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287496 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Change-Id: I90612ae0e54b46e7147d9a3392783f56da598b2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287499 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68750}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4222272..2f694ac Rolling v8/third_party/aemu-linux-x64: Cht8VcqmH1adKCbBa1TuNhvNv-lMJJ0W5LvFyKpchi8C..Y1_xyAnxWY49mUT2otmospCKTrX01gsjJxt9x-qV0RsC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7cbda52..5d5af4e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e62496b..6402141 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/faaecad..77b632f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2abc382797809382a8c6a28cf8bd3d0e97ae3305 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288599Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68749}
-
- 08 Jul, 2020 22 commits
-
-
Frank Tang authored
Reflect recent change to the proposal http://tc39.es/proposal-intl-DateTimeFormat-formatRange/#sec-intl.datetimeformat.prototype.formatRange Bug: v8:10681 Change-Id: Ie2e0e85816aeaeb2615d482ccd3ea345a5056c93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286813 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68748}
-
Milad Farazmand authored
Change-Id: I997abb5576224d4e7fe00ef593afa0265ef80e16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288428Reviewed-by:
-
Ng Zhi An authored
This rounds up all SIMD instructions as included in the proposal as of https://github.com/WebAssembly/simd/commit/9f1295a494b4db98ad7e93cd6368239218233b3e. Bug: v8:10180 Change-Id: Icd4cb0aeddede6a611de6f8f3916dc036977c499 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285789 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#68746}
-
Ng Zhi An authored
And removed the ifdef guards around instruction-selector and tests since v128.const is now implemented for x86, x64, arm, arm64. Bug: v8:8460 Change-Id: I0ed8aede0a07db2fd286bf0c3385eba1079558f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285149 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:8425 Change-Id: I3a2485e9983ed14c25bde705a5906c50a78c651d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1768873Reviewed-by:
-
Milad Farazmand authored
Change-Id: Ic60a47a931c8c359dce27ea5c774592bed1d4762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287230 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Victor Gomes authored
The second argument of FromParameterIndex should be the parameter count, including the receiver. Previously it worked by chance, because the code was trying to access the receiver but did not include it in the parameter count, accessing the first argument. This does not work anymore when the arguments are reversed (V8_REVERSE_JSARGS). Change-Id: I8ca9054a99d074c130f9a9b444e7b8a379840991 Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282531Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Clemens Backes authored
--trace-wasm-decoder should not imply --single-threaded, as --single-threaded implies --no-liftoff. Hence we cannot trace the decoder in Liftoff mode. R=thibaudm@chromium.org Change-Id: I3e4f0ea119288ef88c4b00dd2f2a11244b77c204 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287492Reviewed-by:
-
Clemens Backes authored
Instead of having one decoder method per opcode, make all load and store opcodes use the same method, and load the necessary information from a static array. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I27daf52b9cb0af6a288a5642913c132e20f0eabd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287489Reviewed-by:
-
Frank Tang authored
Bug: v8:10684 Change-Id: Id686d9f4d0b08d00ecf63217493e71f608d61b5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286812Reviewed-by:
-
Zeynep Cankara authored
This CL attempts to hide panels from the user view until data upload event to help users read instructions more easily. Screenshots: https://imgur.com/a/qFgIKI8 Bug: v8:10665 Change-Id: Ida666aa850b80cff3f428e1789cc92592ec79a6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278474Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#68738}
-
Manos Koukoutos authored
Bug: chromium:1103161 Change-Id: I8b6155ec4f1033eb7024d798a08cd6f55f5f609d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287502Reviewed-by:
-
Ulan Degenbaev authored
Bug: v8:10315 Change-Id: I6be83e742a3ef488e09ac44a379e028592a5ff64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287493 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Georg Neis authored
Due to an optimization in how resumable functions are compiled, we can actually see another Oddball type as StrictEquality inputs. I'm giving up on getting the DCHECK right and removing it entirely. Bug: chromium:1102683 Change-Id: Ia210777c66641e898e96900713710a51ebed311d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287494 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... into src/zone/scoped-list.h src/zone/zone-hashmap.h src/zone/zone-list.h src/zone/zone-fwd.h zone-fwd.h header contains zone-related forward type declarations. Bug: v8:10506 Change-Id: Ic61b6717b3034afa24bdd49fbc0ce758a0e93c75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284987 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68734}
-
Peter Ralbovsky authored
Goal is to include coverage of builtin functions into coverage bitmap send to Fuzzilli fuzzer. In order to do this, after each REPRL loop, coverage data of bitmaps are retrieved from JS heap and stored into coverage bitmap. Additionally, there is an option, to print out statistics about how many of edges from builtin functions were turned on by the program inputted into REPRL loop. This commit introduces two flags: --no-fuzzilli-enable-builtins-coverage - when enable-builtins-coverage turned of, builtins coverage will not be exported to fuzzilli --fuzzilli-coverage-statistics - when turned on, d8 prints statistics into covlog.txt file after each loop Change-Id: I8f9cf8dc693b952467b108c6d6bc00134125bc5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2263154 Commit-Queue: Peter Ralbovsky <ralbovsky@google.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#68733}
-
Clemens Backes authored
Instead of having one method with a big switch, and specializing that method for each single opcode, we now have one proper method per opcode. This makes the code way more readable, and also reduces the compile time of liftoff-compiler.cc significantly. Unfortunately, we cannot use template specializations for this, since GCC does not support specializing the methods within an unspecialized templated class. Hence, we need to have another dispatch per opcode when generating the opcode handler table. I left a comment explaining why we do it this way. The upside of this is that we get nicer method names. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I8c7026177490893711c999217eeb1e4f2fbb5e36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282533 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Change-Id: I1a7afc332dc2f1c4d4087650f116484437f7a09a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285851 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#68731}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f89ea875..281eb10 Bug: v8:7834 Change-Id: I9a8bcd56b09092999430f568edb0f841b417c955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285850Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68730}
-
Zeynep Cankara authored
This CL attempts to change System Analyzer to fit to the dark theme by Material Design. Link dark theme: https://material.io/design/color/dark-theme.html Screen Shots: https://imgur.com/a/xWJo1Xb Change-Id: Ib921febfaaee7aa362495031a174875f442af3a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282596Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#68729}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/89943b9..4222272 Rolling v8/third_party/aemu-linux-x64: LQ_bftKUbwaforl6s7QhdVirfTBttP4-yogIN0A6CcoC..Cht8VcqmH1adKCbBa1TuNhvNv-lMJJ0W5LvFyKpchi8C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9ef36d0..7cbda52 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/81923d6..e62496b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b49c12a..faaecad TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id1e21a8f8d9687f18206e393348c453878fbf474 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286649Reviewed-by:
-
Gus Caplan authored
Bug: v8:9891 Change-Id: I559ee50a09a2c8530c3d75a650b383b7d987f6f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282713 Commit-Queue: Gus Caplan <me@gus.host> Reviewed-by:
-
- 07 Jul, 2020 1 commit
-
-
Jakob Gruber authored
Native context independent code generation should, at the moment, not use any collected feedback. We implement this by returning InsufficientFeedback from the heap broker's ReadFeedbackForX methods if currently compiling nci code. Thus all feedback.IsInsufficient() calls inside the compiler will return true (disabling feedback-based optimizations). FeedbackSource::IsValid() (used in generic lowering) can still return true. Bug: v8:8888 Change-Id: I198b6457276073e7376c777b206c50726f1b3645 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284494 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68726}
-
