- 12 Jun, 2020 14 commits
-
-
Frank Tang authored
https://tc39.es/proposal-intl-datetime-style/ (Jun 10, 2020) fix extra s in message Bug: v8:10613 Change-Id: I2ef4f4004c1e8f0a58bf4409578876d1553de59b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242258 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68329}
-
Andreas Haas authored
We want to enable the wasm-bigint implementation by default. However, at the moment there exist several tests which fail when wasm-bigint gets enabled. With this CL we adjust or delete these tests so that they pass once wasm-bigint gets enabled. At the same time we disable these tests for now, and re-enable them in the CL that flips the flag. R=jkummerow@chromium.org Bug: v8:7741 Change-Id: I733bfe7ff19e403913b143e6ea86ab13602ab993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243212 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ng Zhi An authored
This default constructor is used in a couple of places (e.g. compilation-cache.cc) to hold a default value that is later overwritten. See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: Ibe4741cebdcf7c350580de3e6b0bd10fd8b7be73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2240504Reviewed-by:
-
Etienne Pierre-doray authored
To investigate jank found in UMA sampling profiler. Bug: chromium:1081433 Change-Id: I457731380505af5a4d7a0c30d01b4049ffd2b436 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242037 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68326}
-
Milad Farazmand authored
Port 4559bd69 Original Commit Message: Implements f32x4 and f64x2 ceil, floor, trunc, nearestint, arm64. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I055b5d9c725c51df9e2e3e8274ed8c6a57e7dfad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242140Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68325}
-
Seth Brenith authored
The graph verifer caught this bug. The offset in a load instruction should be pointer-sized. Bug: v8:10605 Change-Id: I816165c9c9ef4f0d7fbdcaf9c70faf845dbbb9fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238016Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#68324}
-
Manos Koukoutos authored
Change-Id: I959409fb1a4f2d427c252f3904b197b71e335825 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241520Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68323}
-
Ulan Degenbaev authored
This also removes unused free list classes. Change-Id: I705ca3aca94e404cf388e6c9bac2ff9f3c38fe10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241525 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#68322}
-
Manos Koukoutos authored
This function wasm created as a partial subtyping check after the subtyping refactoring for wasm-gc, but is really not needed. Change-Id: I5f3a38dba599f1571e26d29254eb0f8614c16a8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241519Reviewed-by:
-
Daniel Bevenius authored
This issue was seen in Node.js when compiling with GCC. It can also been see if building V8 using GCC and enabling -Wcast-function-type in BUILD.gn: "-Wcast-function-type", There are unit tests in V8 that produce this warning, for example test/cctest/test-global-handles.cc (formatted to fit the commit message width): g++ -MMD -MF obj/test/cctest/cctest_sources/test-global-handles.o.d ... In file included from ../../include/v8-inspector.h:14, from ../../src/execution/isolate.h:15, from ../../src/api/api.h:10, from ../../src/api/api-inl.h:8, from ../../test/cctest/test-global-handles.cc:28: ../../include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak( P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = v8::Global<v8::Object>; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<v8::Global<v8::Object> >&) ]’: ../../test/cctest/test-global-handles.cc:292:47: required from here ../../include/v8.h:10750:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<v8::Global<v8::Object> >::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<v8::Global<v8::Object> >&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type] 10750 | reinterpret_cast<Callback>(callback), type); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This commit suggests adding a pragma specifically for GCC to suppress this warning. Bug: v8:8735 Change-Id: I5dd2dccf215a7fd2f6dd14993368cc5cbb6c71e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080361Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68320}
-
Thibaud Michaud authored
Attempt to fix regressions introduced by: https://chromium-review.googlesource.com/c/v8/v8/+/2235117 {current_hint_position_} is not precise enough and can be null even if the range contains hints. Instead, repurpose it during register allocation so that it always holds the last hint position found for this top level live range. This ensures that each use position is visited at most once even when the range is split. R=neis@chromium.org CC=sigurds@chromium.org Bug: v8:10533, chromium:1093435 Change-Id: I21f3f12f061c3e4c7e845d161b19de7499200c0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239568 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
For DescriptorArrays with more than 8 elements, we do a BinarySearch on the main thread. For background thread, BinarySearch is unsafe and we have to fall back to LinearSearch. Bug: v8:7790 Change-Id: I7136b616ae31f509e56cf5ceb5afd659d13e0d81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237142 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Georg Neis authored
The condition was too strong since we never store Smis into {previously_materialized_objects}. Bug: chromium:1094132 Change-Id: I680eb7f175f12d3c44882fd8a9eff0d062eda55f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241517 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68317}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3405bae..8038ef2 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/1b066f0..574cbd5 Rolling v8/buildtools/linux64: git_revision:d0a6f072070988e7b038496c4e7d6c562b649732..git_revision:9a0496a74efd13c1bb2abd866d8a227404615068 Rolling v8/third_party/aemu-linux-x64: Ov029PFraVEmOQQeqY3kUZj6ERgYTsBY7XgdZYAw76IC..57_eaFwoIK_Q_ctYaumI8hKikv527lQj5R7ctUOZBz4C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/eb9f481..d3a5699 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1dcaaa7..44de5e3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9f3f85f..5e1d63a TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13e7a541ae0a9600c44718ceb7fe8bd6e4d048b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242020Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68316}
-
- 11 Jun, 2020 5 commits
-
-
Michael Lippautz authored
Since the registration requires calling into the library, there's no reason to get the heap through a magic getter on API level. Bug: chromium:1056170 Change-Id: I8d2b1d0fcee8c855908bd26c71a22826c493ed29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238568 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68315}
-
Ng Zhi An authored
Making them private was a way to hide the functions, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I0d185063e6e282109627f25b732108905ed36833 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2223233Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7ad9ac5..3405bae Rolling v8/third_party/aemu-linux-x64: pcue74MrtwdptQfnABqz12W-F6Br8-PlTN1pD5o_aQsC..Ov029PFraVEmOQQeqY3kUZj6ERgYTsBY7XgdZYAw76IC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/03e7ff4..eb9f481 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dcb5c85..1dcaaa7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6ddf849..9f3f85f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60847ebd591bafce6640cc7a137ab82bfc07acd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237960Reviewed-by:
-
Ng Zhi An authored
The constructor of ByteData isn't doing anything interesting, so can be removed. Bug: v8:10488 Change-Id: Ic114b947ff6471075c7df49c98ea7c59c5b522bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233978 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68312}
-
Ng Zhi An authored
Match opcodes proposed in https://github.com/WebAssembly/simd/pull/127, and also move them into the list of MVP opcodes. Bug: v8:10553 Change-Id: I02d839002673ac4aad3f863579607aaa17a52338 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2240489Reviewed-by:
-
- 10 Jun, 2020 21 commits
-
-
Michael Lippautz authored
Unified heap support in V8 requires having another (at least internal) heap that implements a unfied garbage collection strategy. This will not re-use the already existing cppgc::Heap because there should be no way in creating such a heap externally or scheduling stand-alone garbage collections. In order to have a common token, this CL introduces AllocationHandle which can be passed to MakeGarbageCollected to allocate C++ objects. V8 (soon) and the stand-alone heap both have methods to retrieve such a handle. This works around a problem with creating diamond class hierarchies when a base class would be exposed on the public API level. Fast paths for Blink are still possible because allocation handles can be cached the same way (e.g. global, or TLS) as a heap can be cached. Tbr: yangguo@chromium.org Bug: chromium:1056170 Change-Id: I8e9472a2c24ef82d1178953e8429b1fd8a2344bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238027 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Implements f32x4 and f64x2 ceil, floor, trunc, nearestint, arm64. Bug: v8:10553 Change-Id: I346c6e60719ea953ff1adc9d8791768838e57cb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213083Reviewed-by:
-
Ng Zhi An authored
Making them private was a way to hide the functions, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I3d3227c3a87ee4de983b0d4a52f46203729b99f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233983Reviewed-by:
-
Ng Zhi An authored
Off-by-one error - valid shuffle values are [0..31] (inclusive). Bug: chromium:1092013 Change-Id: Ic9edd79acb148fd2061869a1765b9a50e38403ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239754Reviewed-by:
-
Bill Budge authored
Bug: v8:9891 Change-Id: I601dd2a4e1c7d1e3818a55b92e83ce6b072c7ad0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238486Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#68306}
-
Milad Farazmand authored
Change-Id: Iae7b56504366c7867439b7d7956f1202b2a8dc5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239369Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68305}
-
Ng Zhi An authored
This is a reland of f7f72b7b This was reverted because of a test timing out on slow_path variant (https://crrev.com/c/2237131 for details). Turns out the test is just really slow, and was skipped on this variant in https://crrev.com/c/2237628. Relanding without changes. Original change's description: > [wasm-simd] Prototype f64x2 rounding instructions > > Implements f64x2 ceil, floor, trunc, nearestint, for interpreter and > x64. > > Bug: v8:10553 > Change-Id: I12a260a3b1d728368e5525d317d30fc9581cae04 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213082 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68241} Tbr: tebbi@chromium.org Bug: v8:10553 Change-Id: I4cdc23d0556f11310d32fa066f40b057fd49d2d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237350 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68304}
-
Ng Zhi An authored
unsigned is (uint32_t) in both branches, so the cast can be removed. See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Bug: v8:10488 Change-Id: I6d669e36509049fde449d8455c34d140f95b9b8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233989 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Recommended by clang-tidy's modernize-use-nullptr. Bug: v8:10488 Change-Id: I03a6af87f281c52edd01f3ad91f9ec6e28d398d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233985Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Change-Id: Ib5a3bb8873bc6d050c4d0abe36a3ae813bbd448a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233987Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Change-Id: Ic40a585e034e804da9ded1563e85f6dd44506da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233988Reviewed-by:
-
Santiago Aboy Solanes authored
This CL adds a linear search test in a DescriptorArray in a known flat object in the background thread, while the main thread exercises the same DescriptorArray. Also sets the foundation for the follow-ups tests in background threads. Bug: v8:7790 Change-Id: I0e99508204808baaf605161d2eeb717eabe712fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207147 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#68299}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ic885590553364db58259ed1d211b3ace4bfe9d23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233984Reviewed-by:
-
Ng Zhi An authored
vld1 was calling set_neon_register with the wrong size for register. We follow the pseudocode implementation in the manual, by splatting the value into a d register, and writing to the list of registers in a loop. Bug: chromium:1092059 Change-Id: I2ce594594cd59347c20b88926f8ecc18ef9d5514 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238506Reviewed-by:
-
Victor Gomes authored
Change-Id: I3a624b9cb164dd4a49606f311f71ea0115afe30a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238572 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68296}
-
Tamer Tas authored
This CL fixes the UnboundLocalError in wasm-api-tests testsuite TBR=machenbach@chromium.org Bug: chromium:1091200 Change-Id: I3830153b5bd04c3bbe8bedaa8ed79f79c5139a5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238574Reviewed-by:
Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#68295}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10549 Change-Id: I516d35b0810ce147b568c1b8e32eb084753614e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235697 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68294}
-
Jakob Gruber authored
... for more consistent naming and less boilerplate. Getters now use the `lower_case_flag()` style. Setters now use the `set_lower_case_flag()` style. Bug: v8:8888 Change-Id: I5af35b13a013bf303c4ca8d86f926754af28bfce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237139 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
Foozie came up with a mind-boggling example hitting a similarly mind-boggling bug: object construction (JSObject::New) wants to create the constructor's function initial map (JSFunction::GetDerivedMap -> JSFunction::EnsureHasInitialMap). To do so, it calls JSFunction::CalculateExpectedNofProperties. This harmless sounding function triggers compilation of the function. Since we're running with --always-opt, this is an optimizing compilation. Turbofan ends up depending on the function's "prototype" property, for which it wants to create the initial map so that it can install the code dependency. That is, EnsureHasInitialMap is reentered. At this point there is no further compilation attempt because the bytecode now exists. The initial map is created and installed on the function, and TF records the code dependency on that map. When CalculateExpectedNofProperties returns control to the outer EnsureHasInitialMap, yet another initial map is created and set on the function, forgetting the previous one and thus the code dependency. I'm not sure if this bug can only be observed with --always-opt. The fix is general. Bug: chromium:1092011 Change-Id: I8b972748e49b9eb8f06fa17ea9ca037de2bd7532 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238570Reviewed-by:
-
Jakob Gruber authored
Before: DebugPrint: 0x2f950804030d: [String] in ReadOnlySpace: #undefined ... After: DebugPrint: 0x2f950804030d: [Oddball] in ReadOnlySpace: #undefined ... Bug: v8:10581 Change-Id: I21aebc40426fb17cea41a31195aa5cb553c07e2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239570 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Several uc32 (= int32_t) fields were incorrectly treated as uc16 (= uint16_t): CharacterRange::from() CharacterRange::to() QuickCheckDetails::Position::mask QuickCheckDetails::Position::value Bug: v8:10568 Change-Id: I9ea7d76e4a0cbc6ee681de2136c398cdc622bca2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230527 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
