- 18 Oct, 2018 16 commits
-
-
Georg Neis authored
I had forgotten to upload this to my previous CL. TBR: mslekova@chromium.org Change-Id: I1195ffd947ad82226af41cd7103b389a6733f4e4 Reviewed-on: https://chromium-review.googlesource.com/c/1288590Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56766}
-
Sigurd Schneider authored
Change-Id: I4464932425f1fa0f05a644983262742fe7f25364 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1286679 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#56765}
-
Peter Marshall authored
Change-Id: I42697b4692ff30c390ded25568b8d424b03bbf19 Reviewed-on: https://chromium-review.googlesource.com/c/1288450Reviewed-by:
-
Creddy authored
Adding test to confirm that no one-shot optimizations are not done for functions enclosed in parentheses but not immediately invoked in an assignment. Bug: v8:8072 Change-Id: I282132a7cc570b59290f2ec314462be060d48e5a Reviewed-on: https://chromium-review.googlesource.com/c/1238576 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#56763}
-
Michael Achenbach authored
Flags are copied from infra side's builders.py. They will be removed afterwards with: https://crrev.com/c/1288412 NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:830557 Change-Id: If9794e4f9f396770219cf0563a37d6304b6a96ff Reviewed-on: https://chromium-review.googlesource.com/c/1288589Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56762}
-
Georg Neis authored
This lets us remove the unsafe object<T>() getter. Bug: v8:7790 Change-Id: Ie438c68d4c96f1525eee5afd252523b222dc8f53 Reviewed-on: https://chromium-review.googlesource.com/c/1288411Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56761}
-
Toon Verwaest authored
Change-Id: I8f5da41d11df5fce7df4f7757717fb165a6043d9 Reviewed-on: https://chromium-review.googlesource.com/c/1288391Reviewed-by:
-
Hai Dang authored
AllocateJSArray always allocates in new space, so we bailout of the fast path for strings if the new array does not fit in new space. Bug found by ClusterFuzz. Regression test added. This also switches to the BranchIf pattern to avoid materialize a bool. Bug: chromium:895860, v8:7980 Change-Id: Ic7c41268c394ac2796b7694252390ab50fd74838 Reviewed-on: https://chromium-review.googlesource.com/c/1286337Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
We can strength-reduce JSResolvePromise(p,v) to JSFulfillPromise(p,v) if the v is known to be a primitive. This not only avoids the dynamic checks for v inside JSResolvePromise, but also removes the need to have a frame state, as the JSFulfillPromise operation cannot call back into arbitrary JavaScript, and thus cannot deoptimize lazily. This triggers for example for async functions where the return value is known (to TurboFan) to be a primitive value. Bug: v8:7253 Change-Id: I4698d6026e0632ab3e2fef6c7f4aaacf6c2a508c Reviewed-on: https://chromium-review.googlesource.com/c/1288449 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Frank Tang authored
Design doc https://goo.gl/fgc2Cp Bug: v8:6891 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8bc5ea3137fd1b66213403ae9ea3461f40efc977 Reviewed-on: https://chromium-review.googlesource.com/c/1257923 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56757}
-
Georg Neis authored
We use the object<T>() getter to extract the handle from an ObjectRef instance and cast it to Handle<T>. In DEBUG mode, the cast does a type check which accesses the heap. We must not access the heap though. This CL is a quick fix that skips the type check. Eventually we should replace the templatized accessor with a subclass-specific one to have some safety. Bug: v8:7790, v8:8316 Change-Id: I71048be2bc36570cce33b0e680824dd6bc407d14 Reviewed-on: https://chromium-review.googlesource.com/c/1282963 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Toon Verwaest authored
We'll automatically figure out that we can't parse an expression at the EOS anyway. Change-Id: I663e3b9d030ee048b28472710071778bfc511747 Reviewed-on: https://chromium-review.googlesource.com/c/1286681Reviewed-by:
-
Takuto Ikuta authored
This is a preparation CL to remove -Wno-unused-lambda-capture warning suppression. Bug: chromium:681136 Change-Id: Iacd0933363cfe7e4a17191f83f567f2834dee6aa Reviewed-on: https://chromium-review.googlesource.com/c/1288209 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Non-Android platforms are protected in Chrome by site isolation, therefore we can disable the untrusted code mitigations. We still enable them on Android, and on simulator builds since that is where we do much of the correctness testing for Android. Mitigations for ia32 are disabled since they conflict with upcoming work on an ia32 root register. BUG=chromium:860429, v8:6666 Change-Id: I7831071ec1c4490b7d303314c53c27078fa04979 Reviewed-on: https://chromium-review.googlesource.com/c/1276470Reviewed-by:
-
Georg Neis authored
We forgot to eliminate the read accesses of these two cells. Bug: v8:7790, v8:8315 Change-Id: Id175e4d96461f88759b2d29ab1d407ba4c54e733 Reviewed-on: https://chromium-review.googlesource.com/c/1286680Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4ebebc9..5839d1c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b273e0c..5195651 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/9647596..6f8b55e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6c47e8fbe111eed904cc368adef9c1825d41801 Reviewed-on: https://chromium-review.googlesource.com/c/1288189Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56751}
-
- 17 Oct, 2018 24 commits
-
-
Michael Lippautz authored
Adds reporting for - V8.GCMarkCompactor as sum of V8 mark-compact events Bug: chromium:843903 Change-Id: I5e8a80c8d1a9c5bf696635b54659ac56403f52d5 Reviewed-on: https://chromium-review.googlesource.com/c/1256764 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56750}
-
Frank Tang authored
This reverts commit 30729e82. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Intl] Move Intl.getCanonicalLocales to C++ > > Bug: v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I20dc0e7eda58f2d9211d0e569d553dd6fcc14fd3 > Reviewed-on: https://chromium-review.googlesource.com/c/1275807 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56747} TBR=jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org Change-Id: I236e183288f0546b8bbdca4804a1d02421c8c714 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1286955Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#56749}
-
Junliang Yan authored
Change-Id: I4f4c95c92925c8778ce915d5b37517ad6e0a6145 Reviewed-on: https://chromium-review.googlesource.com/c/1286538Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56748}
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I20dc0e7eda58f2d9211d0e569d553dd6fcc14fd3 Reviewed-on: https://chromium-review.googlesource.com/c/1275807 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Bill Budge authored
This reverts commit a12203c6. Reason for revert: Breaks isolate_tests https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/36777 Original change's description: > [wasm] Add a new wasm-js testsuite to run js-api tests > > These changes were necessary to run with the new style of jsapi tests > introduced in https://github.com/WebAssembly/spec/pull/883. > > Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e > Reviewed-on: https://chromium-review.googlesource.com/c/1277724 > Commit-Queue: Ben Smith <binji@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56745} TBR=binji@chromium.org,machenbach@chromium.org,yangguo@chromium.org,ahaas@chromium.org,clemensh@chromium.org,mathias@chromium.org Change-Id: I2edd0ca94cb5990322571879c81671fa835f3ecd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1286526Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#56746}
-
Ben Smith authored
These changes were necessary to run with the new style of jsapi tests introduced in https://github.com/WebAssembly/spec/pull/883. Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e Reviewed-on: https://chromium-review.googlesource.com/c/1277724 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56745}
-
Sigurd Schneider authored
Bug: v8:6666 Change-Id: I3e89fd09e2c8de568bf5dffdad3a5d8a9ef39ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1286676 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Hans Wennborg authored
From what I understand, it's been slated for removal for a long time, and more accutely, Clang recently started warning about it being shadowed by another kWeak enum: ../../v8/include/v8-profiler.h:369:5: warning: declaration shadows a variable in namespace 'v8' [-Wshadow] kWeak = 6 // A weak reference (ignored by the GC). ^ ../../v8/include/v8-util.h:29:3: note: previous declaration is here kWeak = kWeakWithParameter // For backwards compatibility. Deprecate. ^ Bug: chromium:895475 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I07de1418aea2d68ef5641ece4ab13f71b6d5ec7f Reviewed-on: https://chromium-review.googlesource.com/c/1285189Reviewed-by:Marja Hölttä <marja@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#56743}
-
Predrag Rudic authored
Failing test are: cctest/cctest/test-run-wasm/RunWasmLiftoff*. Test started to fail after this commit: 56b8ab5d This patch also fixes MIPS big endian build failure. Change-Id: I333450f2a8f9c9a61db9aea18e5e973f48742d52 Reviewed-on: https://chromium-review.googlesource.com/c/1286348Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#56742}
-
Jakob Gruber authored
Some confusion has crept in over time, specifically around the distinction between an offset to an external reference's address and an offset to its entry in the external reference table. This CL unifies naming and interfaces. Drive-by: Fix formatting in macro-assembler-x64. Bug: v8:6666 Change-Id: Iade98ca28a7304aba0254b92b553343826a08e41 Reviewed-on: https://chromium-review.googlesource.com/c/1286674 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Peter Marshall authored
Currently ProfilerListener channels the code events to Processor via CpuProfiler - we don't need this indirection and can just hook it up directly. This also makes it easier to test because we don't need a CpuProfiler object just to test the Processor. Drive-by cleanup: - Remove NUMBER_OF_TYPES from CodeEventRecord as it is not used. - Remove Isolate* parameter from AddDeoptStack and AddCurrentStack as a Processor object is only ever for one Isolate. Store the Isolate* on the ProfilerEventsProcessor object itself. - Remove the default case from switch in ProcessCodeEvent(). Bug: v8:5193 Change-Id: I26c1a46b0eec34b5248b707d1997c3a9409a9604 Reviewed-on: https://chromium-review.googlesource.com/c/1286341Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56740}
-
Jakob Gruber authored
Drive-by: Fix ExternalReferenceAddressAsOperand. Now it correctly returns an operand to within the external reference table. Bug: v8:6666 Change-Id: I8226257f27a2747584d37fd948d66c6e9b0d7ecf Reviewed-on: https://chromium-review.googlesource.com/c/1286671 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This is cleanups that I forgot to include in the previous CLs or that did not fit in any of them. This is the eighth CL in a series to improve our module decoder tests and make them more readable. R=titzer@chromium.org Bug: v8:8238 Change-Id: I0db04288f1efd9bb4642478d22c0edc8ac17e024 Reviewed-on: https://chromium-review.googlesource.com/c/1286669 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56738}
-
Clemens Hammacher authored
This is the seventh CL in a series to improve our module decoder tests and make them more readable. R=titzer@chromium.org Bug: v8:8238 Change-Id: Ib8bd2cc3f2fdb23b39511657a4af99f6fa781172 Reviewed-on: https://chromium-review.googlesource.com/c/1286346 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Currently, the empty function bodies actually contain the byte 0, which is the unreachable opcode. This CL fixes this to be empty function bodies, and uses the macros more consistently. This is the sixth CL in a series to improve our module decoder tests and make them more readable. R=titzer@chromium.org Bug: v8:8238 Change-Id: I5f029210b4589797ee194e4082afec2c7bc31561 Reviewed-on: https://chromium-review.googlesource.com/c/1286343Reviewed-by:
-
Toon Verwaest authored
Change-Id: I4ceb1455875cc27c193554681b9bb3aa07bd805e Reviewed-on: https://chromium-review.googlesource.com/c/1286345 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8290 Change-Id: Ic82b1f0c8a76f6c046bcc74d0296d7447f773335 Reviewed-on: https://chromium-review.googlesource.com/c/1286675Reviewed-by:
-
Georg Neis authored
This will also be useful for JSCallReducer. In order to avoid extra work, the CL restricts one path of the JSCall lowering to functions from the own native context. Bug: v8:7790 Change-Id: I9f3a478969d641da59661ff196fdedae8195d680 Reviewed-on: https://chromium-review.googlesource.com/c/1286335Reviewed-by:
-
Georg Neis authored
This enables by the default the export * as foo from "bar" syntax in modules. Bug: v8:8101 Change-Id: I98b07d217ae08ff6a556e69cb3bf6e8f4bd46a07 Reviewed-on: https://chromium-review.googlesource.com/c/1282972Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:8290 Change-Id: I422788cbcf1464616a556aebbcdfe92da4822908 Reviewed-on: https://chromium-review.googlesource.com/c/1286347 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56731}
-
Toon Verwaest authored
Change-Id: I25250eefe4ab3bbc007c9943a4a4420a8e573a8b Reviewed-on: https://chromium-review.googlesource.com/c/1286342Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Change-Id: Idef28a62e250fafb04c3dd0de29429a75a924df0 Reviewed-on: https://chromium-review.googlesource.com/c/1283110Reviewed-by:
-
Jakob Gruber authored
This bundles a bunch of miscellaneous things to make more builtins isolate-independent (e.g.: using tasm::Move instead of asm::mov methods). Drive-by: The isolate-independence whitelist was changed to a blacklist. Bug: v8:6666 Change-Id: I7e0fbe8bb2ca3dc751ad070f1a92aebb88b43125 Reviewed-on: https://chromium-review.googlesource.com/c/1286331Reviewed-by:
-
Takuto Ikuta authored
This is a preparation CL to remove -Wno-user-defined-warnings warning suppression. Bug: chromium:683349 Change-Id: If883c24ebac66292329abaf01c5d328bfd51c5c9 Reviewed-on: https://chromium-review.googlesource.com/c/1286391Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#56727}
-
