- 11 Nov, 2019 24 commits
-
-
Clemens Backes authored
They were there to avoid a GCC bug. Now that we do not support GCC 4 any more, we can remove this workaround. R=ahaas@chromium.org Bug: v8:9810 Change-Id: I9346671cc1c5f0c83b47d0cfbd313cd1eb2179a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910104Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64893}
-
Tobias Tebbi authored
This creates a .tq file in src/objects for each src/objects/*.h file with Torque-defined classes and moves the object definitions and corresponding helpers/macros there. In addition, we create files convert.tq and cast.tq in src/builtins to move the casts and conversions to. Since Torque-generated .cc files end up as .o files in the same directory, there cannot be two .tq files of the same name. Thus it was necessary to rename src/builtins/arguments.tq and src/builtins/string.tq to not clash with the new files in src/objects. This is a mechanical change that only moves code. Design doc: http://doc/1fh4OUMjQMnQdJm3aiAPXQUNdgbQugkRGdJzDh8hmyzk Bug: v8:9861 v8:9810 v8:7793 Change-Id: I9c54cb50f32b9ae0fb41752199515133eb59ea5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910100Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64892}
-
Milad Farazmand authored
Port 80dc6a33 Original Commit Message: Since smi-corrputing, TaggedSigned (aka known smis) only have the lower bits used. This renders CompressedSigned useless. R=solanes@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia3daa8e8fe60e8046784436b3dfcdad63b6597c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1907442Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64891}
-
Santiago Aboy Solanes authored
There were a couple of low-hanging fruits in code-stub-assembler. Tried to keep it short to avoid conflicts with other CLs. Bug: v8:9810 Change-Id: If23e16019116c22ddd6282867d9dd0b2e65a23f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906570 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64890}
-
Michael Achenbach authored
Produces too many spurious errors with tests that normally get skipped in jitless variant. TBR=clemensb@chromium.org No-Try: true Change-Id: Iddf0e39e4c454a3b17568ba17a014e8d38922052 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910107Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
The function-entry stack check should dominate all other instructions in a function. Prior to this CL it was possible to create paths not including a stack check due to SwitchOnGeneratorState: the generator-creation branch had a stack check, while generator-resume branches did not. 0 : af fb 00 01 SwitchOnGeneratorState r0, [0], [1] { 0: @22 } 4 : 27 fe fa Mov <closure>, r1 7 : 27 02 f9 Mov <this>, r2 10 : 64 0a fa 02 InvokeIntrinsic [_CreateJSGeneratorObject], r1-r2 14 : 26 fb Star r0 16 : a7 StackCheck 17 : b0 fb fb 01 00 SuspendGenerator r0, r0-r0, [0] 22 : b1 fb fb 01 ResumeGenerator r0, r0-r0 [... no stack check here ...] This CL moves the stack check to the beginning of the bytecode array, i.e. before SwitchOnGeneratorState. Bug: chromium:1020031 Change-Id: I8ba8cba99611ddbe50c76023129d926cc84b1d5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903440Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:9810 Change-Id: I915e0b1f903e8c5aa75280965819b2efb9fdc6dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906206Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Maya Lekova authored
When the serializer encounters a JSConstruct, it now serializes the initial map of the new_target to enable further opitmizations in JSNativeContextSpecialization. Add regression tests as well. Bug: v8:7790 Change-Id: Ifab2b58c64a341744e833ed063e9695d74a5cdce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1900457 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 6e90f2f2 Original Commit Message: Including but not limiting to removing: * BitcastCompressedXXX * CheckedCompressedXXX * ChangeXXXToCompressedYYY * ChangeCompressedXXX As a note, ChangeTaggedToCompressed can't be removed just yet as it is still in use. R=solanes@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I0974b300654f61d152ea65016a0e278ea4ba1b60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1907440Reviewed-by:
-
Michael Achenbach authored
This adds a selection of flags to numfuzz that are already used for different testing variants or on clusterfuzz for correctness testing. No-Try: true Change-Id: I79745b281b001f57d2b24977f3a8e9ce3bbab2a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906573 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Since smi-corrputing, TaggedSigned (aka known smis) only have the lower bits used. This renders CompressedSigned useless. Bug: v8:7703 Change-Id: Id59aaebc24d670ed32c483ceecf77fd194405ee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903445 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64883}
-
Dominik Inführ authored
This reverts commit 5e97378f. Reason for revert: Caused multiple regressions. Original change's description: > [heap] Promote young objects by default in MC > > Start experiment to promote all young live objects during mark-compact. > > The last CL https://crrev.com/c/1879938 got reverted because of a flaky > test, see v8:9192. > > Change-Id: I16897f45fffeafbb7e70c21899976a4c026e69ba > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903432 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64832} TBR=ulan@chromium.org,dinfuehr@chromium.org Bug: chromium:1023308, chromium:1022708 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie551f0765fb54a36e52c20da8b026e2c0ebf0451 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906385Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#64882}
-
Ross McIlroy authored
Also Tnodifies TryPrototypeChainLookup. Bug: v8:9810 Change-Id: I4950ad3bbcfcf3528589d343282517ee0b57e65f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906375Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64881}
-
Santiago Aboy Solanes authored
Including but not limiting to removing: * BitcastCompressedXXX * CheckedCompressedXXX * ChangeXXXToCompressedYYY * ChangeCompressedXXX As a note, ChangeTaggedToCompressed can't be removed just yet as it is still in use. Bug: v8:7703 Change-Id: I98cf88a32adfa976d419e69702d1cac4d3e811a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903435 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:9810 Change-Id: Ic7909dcec624fdd95548a32f2fa760d5e9c67636 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906567Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Liviu Rau authored
When a test fails the exit code of the process is printed in the logs in the decimal format. On Windows searching for the actual error is pretty difficult in this format since we are dealing with negative values errors. We print now the hex format of the same exit value next to the original one. Example failure of a test: https://ci.chromium.org/p/v8/builders/try/v8_win64_dbg/b8897355488287117696 https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8897355488287117696/+/steps/Check/0/stdout https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8897355488287117696/+/steps/Check/0/logs/RunWasmInterpreter_Int32Const_many/0 Bug: v8:9810 Change-Id: I51b65d6105bda6516707a764dbd41fd36c9dfc80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903975 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#64878}
-
Andreas Haas authored
I changed the verification algorithm of switch nodes from a quadratic algorithm to a linear one. On my machine this speeds up the test from 17 seconds to 2 seconds in the x64.optdebug build. R=mslekova@chromium.org Bug: v8:9810 Change-Id: I952d3fcc641b4e269b8ebac8f65fe545c6062587 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905768 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64877}
-
Tobias Tebbi authored
Overview: - Change basic type hierarchy to split Tagged into StrongTagged (= Object) and and WeakHeapObject. This enables to emit the right CSA types (Object, MaybeObject). - The new Weak<T> type encodes a possibly cleared weak bit pattern that points to type T if it's not cleared. - Make TNode<Object> a subtype of TNode<MaybeObject> so that the generated code compiles on the C++ side. Drive-by change: simplify a few CSA helpers by using MaybeObject as a common supertype of MaybeObject and Object. - Port CreateObjectWithoutProperties and LoadMapPrototypeInfo. Bug: v8:7793 Change-Id: I895a6501ce3e287ea8cf4065aaff3a5535245ab4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889870Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64876}
-
Dan Elphick authored
Also fixes its uses in interpreter-generator.cc and accessor-assembler.cc. Bug: v8:9810 Change-Id: Ie9817f3e53c54588a4ad28c2c98da1a48ac73681 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906571Reviewed-by:
-
Michael Achenbach authored
TBR=tmrts@chromium.org No-Try: true Bug: chromium:1021522 Change-Id: I1f5f9bb4f9feb6eae34e62667421a8956c4d007e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906382 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This fixes MSVC Windows builds that were broken due to a missing deps definition. Bug: v8:9954 Change-Id: I19c5112226caadae6a0221acee7bcf19cf0abbc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906379 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Live sets represent sets of live virtual registers at block entry and exit points. They are usually sparsely populated; for example, a sample taken from Octane2 shows 80% of sampled live sets with a fill ratio of 10% or less. Prior to this CL, live sets were implemented as a statically-sized bit vector. This is fine for low-ish virtual register counts, but becomes wasteful at higher numbers. This CL attempts to address this issue through an adaptive implementation. Small live sets remain bit vectors, while larger sets switch to a PersistentMap-based implementation. PersistentMap has very memory-efficient add/remove/copy operations. Of course, with adaptive data structures we enter the territory of parameter fiddling. In this case, two parameters are used: kMaxSmallSetSize controls when to switch implementations, and kMaxDeletionsBeforePrune controls when pruning (= managing the # of deleted entries in the map) sets in. On the (degenerate) test case from the linked bug, the register allocation zone shrinks from 1008MB to 475MB. For more realistic cases I expect savings on the order of 10s of KB. Bug: v8:9574 Change-Id: Id903bbe23f030b418e8d887ef4839c8d65126c52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1891693Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64872}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1023247 Change-Id: I23abb26425d7adcd69d07af906738a69bac8688d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906380 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e6adad9..789c8f5 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ibb2f7b826ec35925c3ddaef2b8549e7cd5a1ce6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1908650Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64870}
-
- 10 Nov, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/184cee3..e6adad9 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I82f851809195a2137618b58c36932f4fa509e1a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1908648Reviewed-by:
-
- 09 Nov, 2019 2 commits
-
-
Zhao Jiazhong authored
port b6edadc0 https://crrev.com/c/1872930 Original Commit Message: [wasm-simd] Implement f64x2 comparisons for arm Change-Id: If0fab2307a7f6da75f27ecd90cef6e15945214dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903290Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#64868}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3cf8d94..184cee3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f9004ee..56af378 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1917f7a..ea1884b TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I10e6a47cc088ff8e1ed1e74595d2bd1a4ae12301 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906234Reviewed-by:
-
- 08 Nov, 2019 13 commits
-
-
Ng Zhi An authored
Implements v32x4.load_splat and v64x2.load_splat. Bug: v8:9886 Change-Id: I18f3b012f9980d258985edf2ff26577fe495eff5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903747Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64866}
-
Dan Elphick authored
Shrink RO_SPACE since it contains Immortal immovable objects and is otherwise reporting a virtual size of 256KB when only half of that will ever be used. Bug: v8:9230, v8:7464 Change-Id: I68c17bb6c4ff12170774bad6a07dbb8b9d49cce1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906207 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64865}
-
Dan Elphick authored
Bug: v8:9810 Change-Id: Ie2cba5da240f53f7be7d6aee0426489d972a22a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906569Reviewed-by:
-
David Carlier authored
Using proper register (RIP) on this platform. Change-Id: Iaa0a25e328bd82c152db0ef3632523fd7d621020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1857221Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: chromium:1021463 Change-Id: I15d45a51b7341b5767d8eb4c16e7d41508a2811b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906568Reviewed-by:
-
Dan Elphick authored
Exception variables can be Object (e.g. throw 4) so loosen the type from HeapObject. Bug: v8:9810 Change-Id: I14600978ed5159b2b661bd09e69ad6d6530553ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906566 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port: 05918654 Change-Id: I758bd32868186fd3257f88e2c0eb1179332d52d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1904851Reviewed-by:
-
Milad Farazmand authored
All the data types defined under ArgValue are 8 bytes expect "bool as_bool". When casting to <uint64_t> under "tracing/trace-event.h", boolean gets placed on the lower byte of the memory on LE, and on the higher byte on BE machines. When using a "Union" to read back the value as a boolean, only the lower byte of the memory location is read which makes it fine on LE machines, however the value will not be present on BE machines. Using an 8 byte data type as boolean will assure the entire filed is read instead of only the lower byte. Change-Id: I0740b9c019588c963a4c7878af60c6df04827141 TBR: petermarshall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1896835 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This combines flags switching off CPU-features randomly with all other flags on the numfuzz fuzzers. In a follow up we can add also other interesting flags for testing more features. Bug: chromium:1021463 No-Try: true Change-Id: Ia27d1b8b82dff2bf497242b30ec0b6ef2dfd722d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905846 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:4153 Change-Id: Ieea327828a364ae1934f1a342f361dc68d7bbab6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903433Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64857}
-
Dan Elphick authored
Move the API from Isolate to V8 and add better memory fields. Bug: v8:7464 Change-Id: Ic82c7c74ac8f20a2f2cb896dc0203fdd0b5d8d5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905546Reviewed-by:
-
Michael Starzinger authored
This removes the support to emit runtime calls in Liftoff code and uses WebAssembly runtime stubs instead. Calls to such stubs are smaller and more efficient. They also use embedded builtins directly instead of the on-heap {Code} object trampolines. This also removes the last use of a runtime call that passes a dynamically loaded CEntry builtin from the macro assembler. R=clemensb@chromium.org Change-Id: I9fa9f3b7a2b66cb76a677b70ce3cee49cb340f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903443 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Clemens Backes authored
A minor optimization to the four bit rotation functions. Drive-by: Make them constexpr. R=ahaas@chromium.org Bug: v8:9810 Change-Id: Ic563310030aa487f976017032291a553705d1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903972Reviewed-by:
-
