- 09 Apr, 2019 28 commits
-
-
Benedikt Meurer authored
Bug: v8:8834 Change-Id: I6cf045b835256c27a196372093ceb302ab22f8d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559856Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60717}
-
Clemens Hammacher authored
The test is working since some time. It was blocked on the jump table, and patching it correctly when redirecting imported functions to the interpreter. R=mstarzinger@chromium.org Bug: v8:7767 Change-Id: Id3a16de9c6403cab0321958b681ff18f216fe978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559852Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60716}
-
Michael Starzinger authored
This adds support for passing/returning reference type parameter/return values when the interpreter is calling extern functions. It expands the existing test coverage to the interpreter. R=clemensh@chromium.org TEST=mjsunit/wasm/anyref-interpreter,mjsunit/wasm/anyfunc-interpreter BUG=v8:8091,v8:7581 Change-Id: I377e9d28aa36866c0441683ffd6a48160b721ec1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559853Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60715}
-
Clemens Hammacher authored
Since wasm optimizations are independent of JS optimizations, we can just combine the "no_liftoff" variant with the existing "stress" variant (which has the similar "--always-opt" option for JS), and add a "Liftoff only" variant as part of "nooptimization". This gives more coverage to find bugs like https://crrev.com/c/1543354 more easy. R=mstarzinger@chromium.org, machenbach@chromium.org Change-Id: I81bb22074c59dcb650a05252da43a4170cd467ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559740 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60714}
-
Jakob Gruber authored
This changes debug builds [1] to compile src/compiler sources twice: 1. with optimizations, used in mksnapshot to improve performance. 2. without optimizations, linked into d8 and v8 libraries. While this adds ~200 compilation targets, these can be built in parallel and should not add much time overall. This brings mksnapshot runtime back down to 11 seconds on my machine. [1] The full condition is: is_debug && !v8_optimized_debug && v8_enable_fast_mksnapshot Cq-Include-Trybots: luci.chromium.try:android_arm64_dbg_recipe Cq-Include-Trybots: luci.chromium.try:fuchsia_x64 Bug: v8:8767 Change-Id: Iac57bf8331395d9eda9be5d192e8eeeded182ae6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532335 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2c7bf07..e7cb8dd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6145021..072a6f1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1fb0463..224e075 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I77ccd5ff5542e9d64cef6c284cd2dacaa5c15a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559838Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60712}
-
Jakob Gruber authored
Rename the (mksnapshot-specific) --ebt-os flag to --target-os. This flag specifies the target os for mksnapshot-generated files, specifically for embedded.S. In the future we should base all of embedded-file-writer.cc on this (and an upcoming --target-arch) flag and remove other current cross-compilation workarounds (e.g.: V8_TARGET_OS_WIN, V8_TARGET_OS_FUCHSIA). Bug: chromium:945659,v8:9103 Change-Id: I814fa8c5d4ee9ca0542f63dcae790086d887bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559748 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60711}
-
Anton Bikineev authored
This change aims to simplify RawMachineAssembler::CallCFunction interface by use of variadic templates. Change-Id: Ie7081f692f62674f891f09abfd7149e8d95eeb81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526015 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60710}
-
Georg Neis authored
Instead optimize based on the name feedback. This simplifies matters for concurrent optimization. Drive-by: Rename "index" to "key" for clarity where appropriate. Bug: v8:7790 Change-Id: Id6db1174c7840c24044bc655e0ffee6a5b0de21c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559742 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60709}
-
Sigurd Schneider authored
The new @generatePrint annotation automatically generates ...Print methods for objects from their Torque class definition. While this is mostly geared towards objects derived from Struct, it works on any Torque class. Bug: v8:7793 Change-Id: Iaa772879d397b95c7853dafdd9f09a85dbde8e35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557152 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:933093 Change-Id: I3187f4aedb0c7fbbac9385172c301c4058f71214 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559745Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020, chromium:676417 Change-Id: Iadb46d8877ef9f85f0e444be563a94ccf0f8209f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541054 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
Drive-by fix: In ProcessFeedbackForGlobalAccess, we had forgotten to return the feedback when it already existed. Bug: v8:7790, v8:9094 Change-Id: Ie4be6cef5755bbdd9d8ed472caaa2e32d243893d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554680Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60705}
-
Clemens Hammacher authored
The {remaining_uncommitted_code_space} method is only used for testing. This CL removes it, and replaces all uses by {committed_code_space}. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: Icb50471da3564a5cd114b15836c8b346b932a108 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559735 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sigurd Schneider authored
Change-Id: I2855af444db5dad910d99acc8179aef75e56d000 Bug: v8:9020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559734Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
We currently store the {remaining_uncommitted_code_space_}. This CL switches this to store {total_committed_code_space_} plus the maximum allowed (in {max_committed_code_space_}). This counter will be used by the GC to decide when to trigger a GC. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I5946bbd3ba18e9fcbca4631afb942cd5b82834f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558084Reviewed-by: -
Michael Starzinger authored
This adds support for loading and storing mutable imported globals having a reference type in the interpreter. It expands existing test coverage to the interpreter. R=clemensh@chromium.org TEST=mjsunit/wasm/anyref-globals-interpreter BUG=v8:8091,v8:7581 Change-Id: I78e0c5c73664a183e1d92ec91eadf8b9a93e4787 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559743Reviewed-by:
-
Simon Zünd authored
Removing the 'native' flag from ParseInfo removed the last use-site of this flag. R=jgruber@chromium.org Bug: v8:9043 Change-Id: I0e28d77c571c25c7925e8e372e631a9630492c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550705Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in src/snapshot to 'using' declarations. R=jgruber@chromium.org Bug: v8:8834 Change-Id: Ie555e9ac7e1ec04c20d411647f8ab70f671c1cb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545903 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in src/debug to 'using' declarations. R=jgruber@chromium.org Bug: v8:8834 Change-Id: I205e14a0b230a26119e5b209a2bcec493a8815e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545901Reviewed-by:
-
Maya Lekova authored
Fixing the computation of the foreground time after original CL: https://chromium-review.googlesource.com/c/v8/v8/+/1547864/ Bug: v8:7790, v8:9074 Change-Id: Ic6af4f17aa6e30f9810bd36b0e9f7151ccb57538 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559737 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Frederik Gossen authored
When compilation hints are disabled (they are by default) the decoder failed on custom sections with the name 'compilationHints'. This is fixed and a test is added. Bug: v8:9003 Change-Id: I5d25c019a702a722d8baf497d1bcd3a578a2d4bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557150 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
-
Michael Starzinger authored
This adds support for handling reference types when loading/storing globals. Support for imported mutable globals is still missing and will be done in a follow-up change. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-global-interpreter BUG=v8:8091,v8:7581 Change-Id: I0d14919b1ce7f49c4a0541e3d6a99ee203cfb311 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558086 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Jakob Gruber authored
In mksnapshot, we only need to ensure we generate counter code in (embedded) builtins, if needed. The counter function does not need to do anything useful as long as it returns unique pointers for each counter, and we don't need to dump counters. Tbr: petermarshall@chromium.org Change-Id: I94a53ef5193b89365948d0395e1908e6d3c6e396 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549159Reviewed-by:
-
Mike Stanton authored
Just set the flag --use-osr to false by default. If it's set to true on the command line, then it'll be on. I'd like to get some performance metrics on various tests spread throughout our performance bot infrastructure. Change-Id: I1ebc33264505af080901e531dca625452880f81b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558089Reviewed-by:
-
Benedikt Meurer authored
In RecordVirtualBytecodeArrayDetails() check whether the BytecodeArray has a source position table before accessing it, otherwise it will just crash with --enable-lazy-source-positions. Bug: v8:8510 Change-Id: I1250e89faf836a8d5976ca98c14b6b7314bacb98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559730 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60692}
-
Milad Farazmand authored
Removing NumberToSize on PPC and S390. Port ad44c258 Change-Id: Ic5d3132f1bb396f07a26399d2e3f6aca4689aa3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554227 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7db6cfc..2c7bf07 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/979fc35..6145021 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0b62ed7..1fb0463 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I769bbaa03b4d71b2aad521e64c48bafa12ef27fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559195Reviewed-by:
-
- 08 Apr, 2019 12 commits
-
-
Francis McCabe authored
This reverts commit a1fdd521. Reason for revert: <INSERT REASONING HERE> Original change's description: > Torquefy a few more types > > WeakFixedArray, WeakArrayList, JSFinalizationGroup, JSFinalizationGroupCleanupIterator, WeakCell, JSWeakRef, BytecodeArray, SourcePositionWithFrameCache > > Bug: v8:8952 > > Change-Id: I9708b08e11603977aeab7bce94b8233a41700ccb > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504433 > Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60688} TBR=rmcilroy@chromium.org,jgruber@chromium.org,irinayat@microsoft.com Change-Id: I55b3571763ea054e47d8bef855769e8ca9a1545d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8952 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559210Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#60689}
-
Irina Yatsenko authored
WeakFixedArray, WeakArrayList, JSFinalizationGroup, JSFinalizationGroupCleanupIterator, WeakCell, JSWeakRef, BytecodeArray, SourcePositionWithFrameCache Bug: v8:8952 Change-Id: I9708b08e11603977aeab7bce94b8233a41700ccb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504433 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#60688}
-
Tom Anderson authored
See the changes in BUILD.gn for an explanation of why a new flag is necessary. It's likely that current usages of V8_TARGET_OS_* and V8_TARGET_ARCH_* also need to change, but this is good enough for now to ensure both Win/cross/x86 and Win/cross/x64 build. BUG=chromium:945659 R=machenbach,thakis TBR=jgruber Change-Id: Ie2765db91a1c0d8c72ccf42c9d7fece792d9b252 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542500 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This changes the existing cctest/test-field-type-tracking tests to use actual Code objects and proper code dependencies to test that the runtime actually does the right thing (aka deoptimizes the Code objects correctly). Before it was using the CompilationDependencies, which as of now no longer check whether the runtime actually deoptimized or not. This is a prerequisite for changing the way we handle field representation changes, specifically going from Smi or HeapObject to Tagged. Bug: v8:8749, v8:8865 Change-Id: I260294217550cee2b42f7ba7e9c92bf0d1db0b8c Doc: http://bit.ly/v8-in-place-field-representation-changes Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557149 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60686}
-
Sigurd Schneider authored
Change-Id: I5fda56fb53fb5a7daa45b08ad18848e849ef7128 Bug: v8:9020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557145Reviewed-by:
-
Michael Starzinger authored
This adds preliminary support for references types as argument or return values to functions that are redirected to the interpreter. The current interpreter entry stub remains unchanged, using one buffer area that is hidden from the GC. The corresponding {Runtime_WasmRunInterpreter} now correctly boxes/un-boxes reference types into handles. This switch to a handlified representation happens before any method that potentially triggers a GC is called. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-anyref-interpreter BUG=v8:8091,v8:7581 Change-Id: I41c766ed5ac877042d5964e72f3fd7df390c4e98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557147 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Benedikt Meurer authored
This CL contains a bunch of different improvements to the existing object stats, namely: - Introduce DEPRECATED_DESCRIPTOR_ARRAY_TYPE virtual instance type to also estimate the memory overhead of DescriptorArrays for deprecated Maps. - Do proper over-allocation computating for inobject fields in JSObjects. - Introduce OBJECT_PROPERTY_ARRAY_TYPE virtual instance type and properly compute over-allocation for PropertyArrays - Compute over-allocation for JSObject/JSArray elements properly. - Correctly report JSFunction and JSCollection like the other JSObjects, specifically report over-allocation properly for the instances itself and for the elements/properties backing stores. - Implement correct over-allocation computation for hash tables in ObjectStatsCollectorImpl::RecordHashTableVirtualObjectStats(). Bug: v8:7266 Change-Id: I9cadd703266dc90911a8e7420c3b00dcee82b06d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557139 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Seth Brenith authored
Flag syntax is explained in a comment in flags.h, but we can make d8 easier to learn for new people if we also expose that explanation in the --help text. Change-Id: I7fd9ad0e545c2d9110119c0283bb14d665bcf19e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1555061Reviewed-by:
-
Benedikt Meurer authored
For CheckNonEmptyString we not only need to rule out that the input is not the empty string, but also make sure that the input is actually a string, hence we need to do a proper instance type check in the general case. Bug: chromium:949996, chromium:947949, v8:8834, v8:8931, v8:8939, v8:8951 Change-Id: Icc260d735d19337bba4bb71570a6c6385e47c310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557146 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Maya Lekova authored
The JSInliningHeuristic is now completely heap-access free. JSInliner still includes Allow* guards and will be brokerized as a follow-up CL. R=neis@chromium.org Bug: v8:7790 Change-Id: I6df5d8515bb8bd8d512e8442e4f4dba9ebe9dd2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528437Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ib3affef6a02a017ade2468dff58c58320e1cde42 Bug: v8:9020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557144Reviewed-by:
-
Dan Elphick authored
Marks following previously annotated V8_DEPRECATE_SOON methods as V8_DEPRECATED: Value::ToBoolean Value::ToNumber Value::ToString Value::ToObject Value::ToInteger Value::ToInt32 String::NewFromTwoByte String::NewExternal Date::DateTimeConfigurationChangeNotification Bug: v8:7279, v8:7281 Change-Id: I54778ac42bd43afd2fa4f08ffc9f55e71fa43775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552788Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#60678}
-
