- 12 Oct, 2021 32 commits
-
-
Igor Sheludko authored
... as a result of merging RelocInfo::target_object() with RelocInfo::target_object_no_host(PtrComprCageBase), where the cage base is used for accessing compressed embedded pointers. There are two reasons for this change: 1) the parameterless version used to compute the cage base value from the host Code object, however, when external code space is enabled such a base value will not work for non-Code objects, since they require different cage base for decompressing, 2) when external code space is enabled, there must be no need to embed compressed Code objects at all because CodeDataContainers must be used instead. In addition this CL introduces DCHECKs to enforce (2). Bug: v8:11880 Change-Id: I5b504f91dea87c2bcaa1165d2dbfaada70cba7be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211998Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77361}
-
Toon Verwaest authored
This guarantees that if it's context-allocated, it'll be the first slot in the context. That in turn allows us to drop a special index on scope-info pointing at the receiver entry; once we update arguments object handling to take the receiver possibly being there into account. Change-Id: Idfd06cf172e6905b02c8d17a962382e2a9ea0874 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211999 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77360}
-
Milad Fa authored
Port 12ecb4f5 Original Commit Message: No functional changes. - Removed unused Isolate* argument from regexp extrefs. - Added const where possible. - Removed unused functions. - Shuffled declarations for better readability. - ... R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I58f21f9f75a7c7bb592b7b07dedd9c32ae8a270c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3216034Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77359}
-
Leszek Swirski authored
We forgot to add statistic reporting for off-thread finalization -- this needs to be done during the main-thread fix-ups since it can call embedder callbacks. Change-Id: I3959a1512166cbdea028799c771f733a6c8a6163 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217198 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77358}
-
Victor Gomes authored
The functions definitions were removed here: https://chromium-review.googlesource.com/c/v8/v8/+/3136453 Bug: v8:12158 Change-Id: I8213dd399b51f95d4f6553b6a1b663a6d3370813 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218986 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77357}
-
Jakob Kummerow authored
Walking the dominator tree can be slow when that tree is very deep, and since it's typically done at least once for every BasicBlock, overall cost is approximately quadratic. With some (sparse) caching, we can get significant speedups for very little extra memory consumption. In the specific function I looked at, tree depth was around 11,500, and this patch speeds up the Scheduling phase from 42 seconds to 0.2 seconds, while increasing its memory consumption from 113.1 to 113.4 megabytes. Change-Id: Iaa32d249a30f62269858d090fbd8924d16d3a9f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218157 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77356}
-
Nico Hartmann authored
Bug: v8:12261 Change-Id: I685428cf689c4edcf1fda8e299cad29e31f6b12d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218160 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77355}
-
Maria Tîmbur authored
We add support for i31.new, i31.get_u and i31.get_s to the fuzzed module. Bug: v8:11954 Change-Id: Ic6cdb5ced1b56507083d91e5c0c7f21d59a18acf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218980Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77354}
-
Nico Hartmann authored
This reverts commit 67b22d10. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Fuchsia%20-%20debug%20builder/10882/overview Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/64ad2a1..ed0a6d9 > > Rolling v8/buildtools/clang_format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format/+log/99803d7..99876ca > > Rolling v8/buildtools/linux64: git_revision:0153d369bbccc908f4da4993b1ba82728055926a..git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148 > > Rolling v8/third_party/aemu-linux-x64: -dh4A1LzldRT2V-3X5pbC7DZsxgQ01JhKIFo6Bx5WP4C..oT0j0p3wnLGyIs4qDcea3sRhW4YKoAhTY2LDWkJ4T4QC > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ee3f2f4..876bab7 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7cdf142..4a06fb5 > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/bffc82b..edc0e06 > > Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 > > Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 > > Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: Ibb094d77652d05496ae7edfe50667e6b5a7ad8e2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3216203 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77352} Change-Id: Ie9bfc563bff0a9e4834baef3218e9f6411bef419 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218988Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77353}
-
Nico Hartmann authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/64ad2a1..ed0a6d9 Rolling v8/buildtools/clang_format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format/+log/99803d7..99876ca Rolling v8/buildtools/linux64: git_revision:0153d369bbccc908f4da4993b1ba82728055926a..git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148 Rolling v8/third_party/aemu-linux-x64: -dh4A1LzldRT2V-3X5pbC7DZsxgQ01JhKIFo6Bx5WP4C..oT0j0p3wnLGyIs4qDcea3sRhW4YKoAhTY2LDWkJ4T4QC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ee3f2f4..876bab7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7cdf142..4a06fb5 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/bffc82b..edc0e06 Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ibb094d77652d05496ae7edfe50667e6b5a7ad8e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3216203Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77352}
-
Liu Yu authored
Port commit b4aa41d0 Change-Id: I00e7b81450a1a751b536d29bc4bb4b69ad57b7c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218720 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77351}
-
Clemens Backes authored
Those types have different definitions depending on the platform and the standard library implementation, and require different format strings for printing. Thus just use the default {float} and {double} types. R=ecmziegler@chromium.org Bug: chromium:1251165 Change-Id: I8253dd3d1d917a8f66e44a84e5fc8662036ffa0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218162 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/main@{#77350}
-
Dominik Inführ authored
Change ThreadState representation from a fixed set of values to either Parked or Running with two additional flags (or bits) that are used when either a collection or a safepoint requested. Setting either of these flags forces Park(), Unpark() and Safepoint() into their slow path. Currently we use the CollectionRequested flag on the main thread, while SafepointRequested is used on background threads. In case the slow path sees the CollectionRequested flag, it will perform a GC. When encountering the SafepointRequested flag, the background thread will participate in the safepoint protocol and park itself for the duration of the safepoint operation. This CL is a prerequisite for supporting safepoints across multiple isolates. When safepointing multiple isolates, the main thread will use both the CollectionRequested and SafepointRequested flag. This isn't possible with the current system. Design Doc: https://docs.google.com/document/d/1y6C9zAACEr0sBYMIYk3YpXosnkF3Ak4CEuWJu1-3zXs/edit?usp=sharing Bug: v8:11708 Change-Id: I16b88740182d9c13bce54be163b334761529a5f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211894Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77349}
-
Michael Lippautz authored
Adds support for double-word aligned, i.e., 8 bytes on 32-bit platforms and 16 bytes on 64-bit platforms, objects in Oilpan. Changes: - Adds generic alignment APIs and overrides. - Internal logic to support double-word aligned allocations on LABs. - Adjusts natural alignment of large objects to follow double-word. - Adds a new static_assert() that suggests users file a bug if higher alignment is required. - Statically checks that no allocations with non-default alignment target custom spaces that support compaction. Bug: v8:12295 Change-Id: I05766ce2349055d5d78b68919be00e7ee91d5505 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218150Reviewed-by: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77348}
-
Nico Hartmann authored
This reverts commit 9fe53c4f. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/17044/overview Original change's description: > [flags] Skip --random-seed in FlagList::Hash > > Node and friends use --random-seed to temporary reset the seed for > predictable code-cache creation. To allow custom random seeds at runtime > the flag is reset for encoding the FlagList::Hash in the snapshots. > > We will soon disallow changing flags via the API after V8 has been > initialized. In order to make node work we will exclude --random-seed > from the FlagList::Hash calculation. > > Drive-by-fix: > * Lazily initialize flag_hash instead of calculating it after every call > to SetFlagsFromString / EnforceFlagImplications. > * Simplify hash string source creation since out << flag now includes > the full flag information > > Bug: v8:12309 > Change-Id: I1a168f4702d8c4d160ff12fdbea881731e4ea8b6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218159 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77345} Bug: v8:12309 Change-Id: I5e431c3e3ccccaab2ef7aa025b51d42f837f08b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218979Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77347}
-
Andreas Haas authored
R=ecmziegler@chromium.org Change-Id: I8519d4b14d6d5a03c568a19202cc34a73bab1375 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218154Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77346}
-
Camillo Bruni authored
Node and friends use --random-seed to temporary reset the seed for predictable code-cache creation. To allow custom random seeds at runtime the flag is reset for encoding the FlagList::Hash in the snapshots. We will soon disallow changing flags via the API after V8 has been initialized. In order to make node work we will exclude --random-seed from the FlagList::Hash calculation. Drive-by-fix: * Lazily initialize flag_hash instead of calculating it after every call to SetFlagsFromString / EnforceFlagImplications. * Simplify hash string source creation since out << flag now includes the full flag information Bug: v8:12309 Change-Id: I1a168f4702d8c4d160ff12fdbea881731e4ea8b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218159Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77345}
-
Nico Hartmann authored
Bug: v8:9407 Change-Id: Icc3130a028003f146e733b13b05568b434b530fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218153 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77344}
-
Liu Yu authored
Port commit 12ecb4f5 Change-Id: I7dab9491ad1216515f0a45f026419a55c7cda86a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218719Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77343}
-
Patrick Thier authored
This reverts commit d87e5f42. Reason for revert: Causes issues by eliminating stores that can be observed by GC. Flagging stores as "initializing" needs better handling than what was done in this CL. Original change's description: > [turbofan] Handle Allocations in StoreStoreElimination > > Previously, StoreStoreElimination handled allocations as > "can observe anything". This is pretty conservative and prohibits > elimination of repeated double stores to the same field. > With this CL allocations are changed to "observes initializing stores". > This way it is guaranteed that initializing stores to a freshly created > object are not eliminated before allocations (that can trigger GC), but > allows elimination of non-initializing, unobservable stores in the > presence of allocations. > > Bug: v8:12200 > Change-Id: I5ef1ca8892a84a3b332e081e2fa6285d0eba9d46 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211585 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77299} Bug: v8:12200 Change-Id: I0f18cbc3e848011f1a998b073b05b3bdbc4e1223 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218158 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77342}
-
Thibaud Michaud authored
Connecting moves can be inserted in the gap of the last instruction of a block by the register allocator. The implicit assumption is that the last instruction does not have any operand, so that the connecting move does not invalidate any use of the destination operand. Deoptimization breaks this assumption as it both terminates its block and has operands. Omit the connecting move in this case to avoid invalidating the deopt operands. R=nicohartmann@chromium.org Bug: v8:12218 Change-Id: Icce8e455949b19338ec7255dbb9b37963e857a6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211572Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77341}
-
Sathya Gunasekaran authored
Bug: v8:11321 Change-Id: I330fb8ee7d915f99f9b82f7187be40ac33043f62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2883625Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77340}
-
Leszek Swirski authored
Used to be needed for streaming but we don't use it anymore. Change-Id: I0947155bec38a6b329452e42204f07170a72c155 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217195 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77339}
-
Liu Yu authored
Port commit 6bd44dfe Port commit 89933af6 Port commit 255aaed9 Port commit 7511020b Port commit aa259e30 Bug: v8:11112 Change-Id: Ia005a5da2d48505926a19a5d238b606826db1135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3215372 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77338}
-
Jakob Gruber authored
.. instead of referring to them through magic chars {s,S,w,W,d,D,n,.,*}. Change-Id: Ib50937a2a7d4229a021377586a54be3db9ed8c1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217196 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77337}
-
Camillo Bruni authored
Bug: v8:12298, chromium:1244145 Change-Id: Ic97fea06cd3ede330ad7c67c00bfb567006c3ac4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211891 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77336}
-
Camillo Bruni authored
Change-Id: I13276e389fa71fb3de2ab3f7b685b021418acb1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211895 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77335}
-
Manos Koukoutos authored
GetUnusedRegister may spill registers and thus modify stack slots. Therefore, we have to call it before fetching stack slots. Bug: v8:7748 Change-Id: If7873efd986d9a7a6869fa8ec156d45affd7a8aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217199 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77334}
-
Kim-Anh Tran authored
The previous implementation would not explicitly send `Debugger.paused` events for instrumentation breakpoints if they were to overlap with breaks due to: * regular breakpoints * OOM * exceptions * asserts This CL is a step towards making sure that a separate `Debugger.paused` event is always sent for an instrumentation breakpoint. In some cases where we have overlapping reasons but only know of one, the 'instrumentation' reason, we still just send out one paused event with the reason being `instrumentation`. Drive-by: send instrumentation notification to all sessions, remember which breakpoints are instrumentation breakpoints Bug: chromium:1229541, chromium:1133307 Change-Id: Ie15438f78b8b81a89c64fa291ce7ecc36ebb2182 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211892Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77333}
-
Frank Tang authored
Land some of the tests for Temporal.PlainDateTime All marked as FAIL at this stage. Bug: v8:11544 Change-Id: I09bf681e61f19d96607c848ddcb6bee06580aff1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3085625 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77332}
-
Lu Yahan authored
Change-Id: I2d9cb95d8b04a96f436b6f8eae1ce87d80df7f6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218710Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77331}
-
Joyee Cheung authored
Bug: v8:10793 Change-Id: Ic01e2073b18d6f56c2ce708e17726c64ec58e141 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3216972Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#77330}
-
- 11 Oct, 2021 8 commits
-
-
Shu-yu Guo authored
Change-Id: I6e1cb91cb0573c64d22ae8de92e950152a8c37b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218194Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77329}
-
Shu-yu Guo authored
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/r6yl8pfmf9s/m/ApOmYIuNBgAJ Also adds findLast and findLastIndex to the list of no-side-effect builtins for the debugger. Bug: v8:11990 Change-Id: I285bf499afc2632ffb4e22cf2ea13c978e21e979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217757Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77328}
-
Ng Zhi An authored
Bug: v8:12284 Change-Id: I3519dfa3302c5851585c7430a9930ccd81507090 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3206502 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#77327}
-
Shu-yu Guo authored
When --shared-string-table is passed, in-place-internalizable strings are promoted into the shared old space to maintain the invariant that in-place internalization can be done without copying. Also some drive-by comment fixes and removal of unnecessary 'explicit' on multi-parameter constructors. Bug: v8:12007 Change-Id: I467d865e41934b1d5cdf85cbecc85c4befbfeb21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3193591 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77326}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: Ic609c486fddcdb9b8171f013eb400dd74926d871 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3213142Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77325}
-
Ng Zhi An authored
Was a clang bug that has since been fixed, https://crbug.com/1163847. Fixed: v8:11134 Change-Id: Idf2c4bcd8f07024e64e38289793e3af74f43e98c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212808Reviewed-by: Milad Fa <mfarazma@redhat.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77324}
-
Zhi An Ng authored
This reverts commit 8838a07e. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Fuchsia%20-%20debug%20builder/10854/overview Original change's description: > Update V8 DEPS. > > Modified original autoroll to remove the icu roll, was: > > "Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/4df07a2..eedbaf7" > > See https://bugs.chromium.org/p/v8/issues/detail?id=12301 > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/64ad2a1..b091468 > > Rolling v8/buildtools/linux64: git_revision:0153d369bbccc908f4da4993b1ba82728055926a..git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ee3f2f4..89d8a1b > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7cdf142..97b5b5f > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/bffc82b..edc0e06 > > Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 > > Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 > > Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Bug: v8:12301 > Change-Id: Iea0e4eef75bc083155a74cba168f0f109461c6f4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3216188 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77322} Bug: v8:12301 Change-Id: I91e972661450662ee52819e4c7a008de3aaa010d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3216259 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77323}
-
v8-ci-autoroll-builder authored
Modified original autoroll to remove the icu roll, was: "Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/4df07a2..eedbaf7" See https://bugs.chromium.org/p/v8/issues/detail?id=12301 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/64ad2a1..b091468 Rolling v8/buildtools/linux64: git_revision:0153d369bbccc908f4da4993b1ba82728055926a..git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ee3f2f4..89d8a1b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7cdf142..97b5b5f Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/bffc82b..edc0e06 Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 Rolling v8/tools/luci-go: git_revision:413d434bd4eee1130614494dfb19f1eba03d71af..git_revision:d1c03082ecda0148d8096f1fd8bf5491eafc7323 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Bug: v8:12301 Change-Id: Iea0e4eef75bc083155a74cba168f0f109461c6f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3216188 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77322}
-