- 15 Jun, 2018 16 commits
-
-
Dominik Inführ authored
Disable parallel ephemeron handling if single-threaded flag is set. Bug: chromium:844008 Change-Id: I96d3daae4a239a5326c6d3394f620697bad1780a Reviewed-on: https://chromium-review.googlesource.com/1102335Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@google.com> Cr-Commit-Position: refs/heads/master@{#53761}
-
Matheus Marchini authored
Change --perf-basic-prof-only-functions to also log builtin code creation events, otherwise InterpretedFunctions generated by --interpreted-frames-native-stack will be filtered out. R=yangguo@google.com Change-Id: Ib0623fca88e25c514473a43de56ebbbdcb146f97 Reviewed-on: https://chromium-review.googlesource.com/1100014Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53760}
-
Georg Neis authored
No longer access the heap directly, as policed by Disallow* scopes in JSContextSpecialization::Reduce. Bug: v8:7790 Change-Id: I40f1c500b04b96152421fd5de631747ba386bca1 Reviewed-on: https://chromium-review.googlesource.com/1101322 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#53759}
-
Clemens Hammacher authored
R=ishell@chromium.org Bug: v8:7754 Change-Id: I122139207ef5be4d7cc9f2a7cbe2a89ea337f77f Reviewed-on: https://chromium-review.googlesource.com/1101324Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53758}
-
Peter Marshall authored
For kUpdateEntry and kRemoveEntry, the ArrayBuffer is no longer present on the current page. These are the two most common cases; kKeepEntry is only used for aborted old-page evacuation candidates. Currently we pay the cost of removing the entry from the array_buffers_ map, even though the page itself will be cleared (for new space) or only aborted evacuation candidates will be kept on the page (for old space). Change-Id: Ib442109d444973a72e378d9072206f404d1c5183 Reviewed-on: https://chromium-review.googlesource.com/1102332Reviewed-by:
-
Yang Guo authored
Revert "[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes." This reverts commit 9e27d473. Reason for revert: Layout Test failures: https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064/24123 Original change's description: > [debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes. > > This CL also bottlenecks all current scope handling in the ScopeIterator, and cleans up frame handling in debug-frames and the deoptimizer. > > Change-Id: I061922a356ce17794262f8d77d5d7c824558fc50 > Reviewed-on: https://chromium-review.googlesource.com/1095094 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53741} TBR=yangguo@chromium.org,jarin@chromium.org,neis@chromium.org,jgruber@chromium.org,verwaest@chromium.org Change-Id: I892856056258e3c68b36409b8b2d69e7686fc385 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1102377 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL fixes a crash when a macro specialization has the wrong number of generic arguments. An error message is printed instead. R=tebbi@chromium.org Bug: v8:7793 Change-Id: I60a55f0452d4188d94640ccccd3f0271a493cb6e Reviewed-on: https://chromium-review.googlesource.com/1102318Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#53755}
-
Daniel Clifford authored
In the process: - Make it possible to add 'otherwise' labels to operators - operators can be defined by non-external macros Bug: v8:7793 Change-Id: Ia16ae7c95a4719703c80a927dee44c74b65c170b Reviewed-on: https://chromium-review.googlesource.com/1100826 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53754}
-
Sergiy Byelozyorov authored
R=mathias@chromium.org Bug: v8:7775 Change-Id: I5a8d100969f47a1768be1ed8098535c0c66434a3 Reviewed-on: https://chromium-review.googlesource.com/1102322 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53753}
-
Simon Zünd authored
R=jgruber@chromium.org Change-Id: I399dadfdd515bdb1e0f16e8f167f102773399d30 Reviewed-on: https://chromium-review.googlesource.com/1101685 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53752}
-
Toon Verwaest authored
Reland "[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes." This is a reland of 9e27d473 Original change's description: > [debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes. > > This CL also bottlenecks all current scope handling in the ScopeIterator, and cleans up frame handling in debug-frames and the deoptimizer. > > Change-Id: I061922a356ce17794262f8d77d5d7c824558fc50 > Reviewed-on: https://chromium-review.googlesource.com/1095094 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53741} Change-Id: I05262fef66d852876b9bb2869339053629c9b51d Reviewed-on: https://chromium-review.googlesource.com/1102297Reviewed-by:
-
Leszek Swirski authored
Change-Id: I98c03061600c1a58e1fde5936c78a877508c2fb4 Reviewed-on: https://chromium-review.googlesource.com/1101695Reviewed-by:
-
Leszek Swirski authored
Under --print-all-exceptions, it's possible for the script Get(Line|Column)Number functions to trigger a GC. This is noted in the function, however there is a raw exception Object* which is live across these calls, and whose object could be moved by the GC. Now the pointer is reloaded from a handle to the exception object. Change-Id: I81a26aebfc983199edc97374242c898131d52934 Reviewed-on: https://chromium-review.googlesource.com/1101031 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53749}
-
Peter Marshall authored
Byte offset can be outside of Smi range and must be loaded as a Number rather than a Smi. Bug: chromium:852258 Change-Id: Ida6e07ba68a050d4f5a9f28500986cc67c619b4c Reviewed-on: https://chromium-review.googlesource.com/1100886Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Change-Id: I1e568ff6da02dfd92b24b8badd665096cf49a13a Reviewed-on: https://chromium-review.googlesource.com/1101321Reviewed-by:
-
Leszek Swirski authored
Add a separate GetIsolate implementation for Context and JSObjects so that we can continue using it on these context-specific types, while eventually removing HeapObject::GetIsolate(). Bug: v8:7786 Change-Id: I86c2e12c6878e060338cbd5c3bbe27dcf978e34b Reviewed-on: https://chromium-review.googlesource.com/1101320 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
- 14 Jun, 2018 22 commits
-
-
Junliang Yan authored
Port 37bc0358 Original Commit Message: Lift the declaration of the heap allocation request list and the method which adds to the list up to AssemblerBase. R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I31d63789c25ce70ee17c48fecb2051ac7a30fd92 Reviewed-on: https://chromium-review.googlesource.com/1101254Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53745}
-
Alexei Filippov authored
Make the progress report aligned with the single pass over the heap. Change-Id: I6a63e7eee86719328daa588e5a0c53a668aca464 Reviewed-on: https://chromium-review.googlesource.com/1099863Reviewed-by:
-
Clemens Hammacher authored
Revert "[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes." This reverts commit 9e27d473. Reason for revert: Fails MSan (use of uninitialized value): https://ci.chromium.org/buildbot/client.v8/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21562 Original change's description: > [debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes. > > This CL also bottlenecks all current scope handling in the ScopeIterator, and cleans up frame handling in debug-frames and the deoptimizer. > > Change-Id: I061922a356ce17794262f8d77d5d7c824558fc50 > Reviewed-on: https://chromium-review.googlesource.com/1095094 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53741} TBR=yangguo@chromium.org,jarin@chromium.org,neis@chromium.org,jgruber@chromium.org,verwaest@chromium.org Change-Id: Ief87c1e79fa2ec40f52fd747ec4ebbacf0da798b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1101377Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7783 Change-Id: Ieb29bcbd7400a84619aaf08ad86f8847e8bd78c3 Reviewed-on: https://chromium-review.googlesource.com/1101023 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53742}
-
Toon Verwaest authored
[debugger] Rewrite the ScopeIterator/DebugEvaluate to use Scope rather than ScopeInfo for inner scopes. This CL also bottlenecks all current scope handling in the ScopeIterator, and cleans up frame handling in debug-frames and the deoptimizer. Change-Id: I061922a356ce17794262f8d77d5d7c824558fc50 Reviewed-on: https://chromium-review.googlesource.com/1095094 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:5269, v8:7703 Change-Id: I3e1f8a7892192a06ce6a71563cc16a47c51f9d89 Reviewed-on: https://chromium-review.googlesource.com/1097487 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7783 Change-Id: I0399d20c990e40b1a6dad8a7c12eb6fbce022d12 Reviewed-on: https://chromium-review.googlesource.com/1101028Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7783 Change-Id: I878e8dd8bcfb7b797515b44bbe4333a7d85e8cc4 Reviewed-on: https://chromium-review.googlesource.com/1101024Reviewed-by:
-
jgruber authored
The stack check instruction sequence is pattern-matched in instruction-selector-{ia32,x64}.cc and replaced with its own specialized opcode, for which we later generate an efficient stack check in a single instruction. But this pattern matching has never worked for CSA-generated code. The matcher expected LoadStackPointer in the right operand and the external reference load in the left operand. CSA generated exactly vice-versa. This CL does a few things; it 1. reverts the recent change to load the limit from smi roots: Revert "[csa] Load the stack limit from smi roots" This reverts commit 507c29c9. 2. tweaks the CSA instruction sequence to output what the matcher expects. 3. refactors stack check matching into a new StackCheckMatcher class. 4. typifies CSA::PerformStackCheck as a drive-by. Bug: v8:6666,v8:7844 Change-Id: I9bb879ac10bfe7187750c5f9e7834dc4accf28b5 Reviewed-on: https://chromium-review.googlesource.com/1099068Reviewed-by:Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Use ItemParallelJob to walk ephemerons in parallel. Bug: chromium:844008 Change-Id: Iffc72422f7577458437764f42d13d3f2ee020758 Reviewed-on: https://chromium-review.googlesource.com/1100825 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I0508596370470068ee07bfd7e441a4e393266c11 Reviewed-on: https://chromium-review.googlesource.com/1099238Reviewed-by:
-
Michael Starzinger authored
This allows WebAssembly runtime stubs implemented as {WasmCode} to be called with regular stub linkage. So far we have only been able to call such stubs with WebAssembly linkage. Also switch two more on-heap builtins over to WebAssembly runtime stubs. R=clemensh@chromium.org BUG=v8:7424 Change-Id: Ifa553b5908ee27a1be780c325a114449d7fe7001 Reviewed-on: https://chromium-review.googlesource.com/1100882Reviewed-by: -
Clemens Hammacher authored
This is a reland of 0909dbe3. Added missing V8_EXPORT_PRIVATE to AndroidLogStream. TBR=mstarzinger@chromium.org Original change's description: > Introduce StdoutStream which prints to Android log or stdout > > The often used construct {OFStream(stdout)} does not work on Android. > This CL introduces an {StdoutStream} which behaves exactly like > {OFStream(stdout)} on non-android platforms, and redirects to the > Android log on appropriate systems and configurations. > > R=mstarzinger@chromium.org > > Bug: v8:7820 > Change-Id: Ia682fdf6d064e37c605c19b032f5a10b96ac825b > Reviewed-on: https://chromium-review.googlesource.com/1088911 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53692} Bug: v8:7820 Change-Id: I8164bad78a401dbe4246c9ffcacd050fe511ed58 Reviewed-on: https://chromium-review.googlesource.com/1100636Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I1da5aea2a67047ea8ed48e2b3080d2b8cbf97100 Reviewed-on: https://chromium-review.googlesource.com/1100878Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53732}
-
Leszek Swirski authored
Bug: v8:7786 Change-Id: Id6a2e38e99fdaeaa619c7ec3e18865c3f64a2a47 Reviewed-on: https://chromium-review.googlesource.com/1095112Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53731}
-
Igor Sheludko authored
Bug: v8:5269 Change-Id: I78678aee42b2ae930b995cd194b4d20516e0d229 Reviewed-on: https://chromium-review.googlesource.com/1098929 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Extract code generation (for the trampoline) from {wasm-code-manager.cc} to a new {JumpTableAssembler}. This prepares a CL to add more logic to the {JumpTableAssembler} to also generate jump tables for lazy compilation and tier up. R=mstarzinger@chromium.org Change-Id: I383585b7e4b5a4af3ca08d07e374b44654c1a09f Reviewed-on: https://chromium-review.googlesource.com/1046585 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Dominik Inführ authored
New flag for disabling of parallel marking after visiting all ephemerons. Bug: chromium:844008 Change-Id: I3dfc4e6a05ffc8e065313ef4955279617246802c Reviewed-on: https://chromium-review.googlesource.com/1100468Reviewed-by:
-
Peter Marshall authored
The allocations vector does not need to be dynamically allocated, we can just std::move it around instead. Change-Id: If38af59deeccc06005397f255e18a2fa1bdf4298 Reviewed-on: https://chromium-review.googlesource.com/1099063 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Stephan Herhut authored
On 64 bit architectures, reading memory in wasm requires a conversion of the 32 bit index into a 64 bit value. For this, we generate a ChangeUint32ToUint64 graph node, which later materializes as a move and hence consumes a register. This generates unneccesary register pressure, especially with gvn enabled. Now, the WasmGraphBuilder will emit a IntPtrConstant node right away if the index is a constant. Change-Id: Id8d7efa90c6bd8e4d7b6419e2075802dfc1eb383 Reviewed-on: https://chromium-review.googlesource.com/1099061 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 0909dbe3. Reason for revert: Blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/1099143 Original change's description: > Introduce StdoutStream which prints to Android log or stdout > > The often used construct {OFStream(stdout)} does not work on Android. > This CL introduces an {StdoutStream} which behaves exactly like > {OFStream(stdout)} on non-android platforms, and redirects to the > Android log on appropriate systems and configurations. > > R=mstarzinger@chromium.org > > Bug: v8:7820 > Change-Id: Ia682fdf6d064e37c605c19b032f5a10b96ac825b > Reviewed-on: https://chromium-review.googlesource.com/1088911 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53692} TBR=mstarzinger@chromium.org,jarin@chromium.org,jgruber@chromium.org,clemensh@chromium.org,bmeurer@chromium.org Change-Id: Iadadd9a0df10dca0fad647138a83db50148e864d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7820 Reviewed-on: https://chromium-review.googlesource.com/1100635Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53725}
-
Wez authored
Commit() and GrowTo() iterate allocating pages, and call RewindPages() if an iteration fails. This is true even if the first iteration fails, in which case there are no pages to rewind, and RewindPages() DCHECKs. Only call RewindPages() if we are on the second or later iteration. Bug: chromium:851626 Change-Id: Ifb644416331b5129c679983bc6af0d21c3ce14d8 Reviewed-on: https://chromium-review.googlesource.com/1099605 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#53724}
-
- 13 Jun, 2018 2 commits
-
-
Junliang Yan authored
Port 98d7b23e Original Commit Message: This uses a WebAssembly runtime stub for the out-of-line {DoubleToI} computation instead of a builtin specific to a certain Isolate. It is another step towards making {WasmCode} independent of the Isolate. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:7424 LOG=N Change-Id: I2f78432134ea150bb00bea339a6e71c11aa625b0 Reviewed-on: https://chromium-review.googlesource.com/1099877Reviewed-by:
-
Aseem Garg authored
This is a reland of 2338a2fd Original change's description: > [wasm] Add simd mem and shift ops to interpreter > > R=clemensh@chromium.org > BUG=v8:6020 > > Change-Id: I5d95e4c23240ae4e174d896d31e1b9b1d89d9418 > Reviewed-on: https://chromium-review.googlesource.com/1096493 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53717} Bug: v8:6020 Change-Id: I38a73f5e389617a05a12e0a9477544c4e3aa2883 Reviewed-on: https://chromium-review.googlesource.com/1099895Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#53722}
-
