- 30 Oct, 2020 3 commits
-
-
Martin Bidlingmaier authored
This commit adds the 'l' (linear) RegExp flag (as in e.g. /asdf|123/l) that forces execution in linear time. These regexps are handled by the experimental engine. If the experimental engine cannot handle the pattern, an exception is thrown on creation of the regexp. The commit also adds a new global V8 flag and changes an existing one: * --enable-experimental-engine, which turns on recognition of the RegExp 'l' flag. Previously this flag also caused all supported regexps to be executed by the experimental engine; this is not the case anymore. * --default-to-experimental-regexp-engine takes over the previous semantics of --enable-experimental-regexp-engine: We execute all supported regexps with the experimental engine. Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Bug: v8:10765 Change-Id: I5622a89b19404105e8be280d454e9fdd63c003b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461244Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Martin Bidlingmaier <mbid@google.com> Cr-Commit-Position: refs/heads/master@{#70892}
-
Leszek Swirski authored
GeneralizeField already calculates the field owner. Change-Id: I0730471479d4289d3d027ea63178ddae659ee2b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507717 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#70891}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/acfd692..b8645e7 Rolling v8/third_party/aemu-linux-x64: zy6Zme4YpIqml3lhXc3o7a0r_gVd0_gcggle2n2j330C..uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC Rolling v8/third_party/android_sdk/public: ijpIFSitwBfaEdO9VXBGPqDHUVzPimXy_whw3aHTN9oC..V__2Ycej-H2-6AcXX5A3gi7sIk74SuN44PBm2uC_N1sC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/15be7eb..24bd418 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f9b4a22..12b3cd3 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8250aad9d82eb7ec2f5da2aa60b2dee040df6612 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507341Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70890}
-
- 29 Oct, 2020 28 commits
-
-
Zhi An Ng authored
The main fix here is on non-AVX builds, the shifts require dst == src. Calling macro-assembler functions like Psrlw assumes that we already met that requirement (which we usually specify in TurboFan's instruction-selector). On Liftoff, we need to do that check manually. This is done by using the helper EmitSimdShiftOpImm which will do this check, and dispatches to AVX if supported, or mov if dst != src. Also fix a couple of places where we forgot to annotate the required SSE extension for the instruction. Bug: v8:11078 Change-Id: Icc31df9ab80c041f4bb3bd48444658368eaa2c91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505251Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70889}
-
Zhi An Ng authored
On AVX, many instructions can have 3 operands, unlike SSE which only has 2. So on SSE we use DefineSameAsFirst on the dst. But on AVX, using that will cause some unnecessary moves. This change moves a bunch of instructions that have single instruction codegen into a macro list which supports the this non-restricted AVX codegen. Bug: v8:9561 Change-Id: I348a8396e8a1129daf2e1ed08ae8526e1bc3a73b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505254Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70888}
-
Leszek Swirski authored
When searching for a target map during map update, attempt to update field representations in-place to the more general representation, where possible. Bug: chromium:1143772 Change-Id: I6a43c94910a1d2d8f8b0ad89048f94b51461f76c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507715 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#70887}
-
Camillo Bruni authored
- Use initial color for TimelineTrack chunks - Use async functions for TimelineTrack setChunkBackgrounds - Introduce timeSelection setter on TimelinePanel - Propagate time selection down to the TimelinePanel - Avoid layout recalculation in TimelineTrack updateSelection drive-by-cleanups: - Add common event listeners only to top-level document - Use console.warn instead of console.error for better debugging in DevTools Bug: v8:10644 Change-Id: Ie4f80f1c6c3f4fa193f8ac01225e0fb76981551d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497175 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70886}
-
Milad Fa authored
Change-Id: I875efc2db384742ca7e6b68099321504ca79a8d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2508689Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#70885}
-
Ulan Degenbaev authored
This allows GC to go slightly over the max heap limit in order to give NearHeapLimitCallback a chance to run and increase the limit. Based on the suggestion by Kenton Varda. Change-Id: I9c084b5a4c8fb7b9ce331b565958391c1be56add Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505724 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70884}
-
Milad Fa authored
We need to load 32 bits into optimization_state. Change-Id: Id6024e33b65c92696366900098c9768b192a7160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507265 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#70883}
-
Clemens Backes authored
Big partners are still hitting the code space limit, especially when debugging larger wasm apps. The limits was bumped to 2GB in August, but we already have security clearance to increase it to 4GB. A limit of exactly 4GB is problematic on 32-bit systems, and also on 64-bit we seem to store the limit in a uint32_t sometimes. Thus choose a limit slighly below 4GB, such that it fits in a 32-bit integer. R=ecmziegler@chromium.org Bug: chromium:1143118 Change-Id: If37f87280264c395cf73b3cc3bf6f7b1b27c46d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505768 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#70882}
-
Shu-yu Guo authored
Fix super calls so that arguments are evaluated before the super constructor is checked to be in fact a constructor. A new bytecode is introduced to split the IsConstructor check out from the current GetSuperConstructor bytecode. Bug: v8:10111 Change-Id: I3af99e32a34d99493806bb01b547d6f671cdc9de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2493077 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70881}
-
Dominik Inführ authored
Merge the list of concurrently swept ArrayBufferExtensions sooner back to the main thread. When appending a new ArrayBufferExtension check whether the concurrent sweeping was already finished and merge the lists if it is. In order to reduce the number of GCs in the linked test case, reset young_bytes_ and old_bytes_ to 0 while sweeping the ArrayBufferExtensions. Surviving extensions will be accounted again when merging lists. As a drive-by change remove scavenge.process_array_buffers from GCTracer. GCTracer also printed the wrong value for fast_promote. Bug: v8:11044 Change-Id: I8a772df895c43a69493015f42336c6f33fe52056 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505764Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70880}
-
Liu Yu authored
The optimization state is a 32-bit value, so we should load it by lw instruction instead of ld. Change-Id: I5845341ea9b87568fda08180ed51ad1a5c0635e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507312Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#70879}
-
Dan Elphick authored
TODO says gcc can't handle Local, but it is using Local. Bug: v8:11074 Change-Id: I4c5045abc319e82eb86f8e23c879db07b4cee13a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505767 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70878}
-
Nico Hartmann authored
This is the 1st step in series of CLs to move the SharedFunctionInfo class to kNeverSerialized and make it concurrently accessible from the background thread. This CL: * Enables direct heap reads for the most basic members of SFI if FLAG_turbo_direct_heap_reads is enabled. * Adds synchronization to SharedFunctionInfo::script_or_debug_info. Bug: v8:7790 Change-Id: Ia7d28033e9053aae5771b1b9b174de40f194534d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461238Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#70877}
-
Frank Emrich authored
This CL changes the "small" versions of ordered hash tables, like SmallOrderedNameDictionary and the corresponding handlers, like OrderedNameDictionaryHandler, to use InternalIndex rather than int as the type used for indices. This is part of an effort to make the interfaces of the ordered and unordered name dictionaries more similar. Bug: v8:7569 Change-Id: I3b6fe79dfd3c6743f58a04cfe82798fe2ef09e19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505720 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#70876}
-
Jakob Gruber authored
These aren't called from or implemented in assembly, thus the exact registers don't matter. We can remove platform-specific definitions. This resolves 56 TODOs! )) Bug: v8:8888 Change-Id: I287fbf7eb3c03d7467ff58a27d614163baf34b3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505761Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70875}
-
Jakob Gruber authored
For-in now collect feedback as well, the test passes. Tbr: neis@chromium.org Bug: v8:8888 Change-Id: I4e2ae41b60aa43132a24f001dc4de460a270a1a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505766Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70874}
-
Frank Emrich authored
This changes the ordered hash data structures in ordered-hash-table.h to use InternalIndex as the type used for indices, rather than int. This makes the interface more similar to the (unordered) hash tables in dictionary.h and hash-table.h Bug: v8:7569 Change-Id: I2389b0c7d103eb7c33c5ed620b16eb198109b54c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2503949 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#70873}
-
Santiago Aboy Solanes authored
Inside of LoopPeeler::PeelInnerLoopsOfTree we call the typer, which inspects heap objects, so we need to unpark the local heap. Reverted in https://chromium-review.googlesource.com/c/v8/v8/+/2502333 Original change's description: > [compiler] Replace Symbol with direct reads > > Bug: v8:7790 > Change-Id: I49120a6349777fd992a97d697940e79b2e71dbd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400988 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69812} Bug: v8:7790, chromium:1137594 Change-Id: I8539175002e19b04b84009eb6b2cc5ced4ee53c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502339 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70872}
-
Andreas Haas authored
This is a reland of 757f0431 There was a bug in a TurboFan optimization that was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2504250 Original change's description: > [wasm] Enable --wasm-opt > > This CL enables basic optimizations in TurboFan for WebAssembly code, > like dead code elimination (DeadCodeElimination), constant folding > (MachineOperatorReducer), and control flow optimizations > (CommonOperatorReducer). > > These optimizations were disabled originally to improve startup time, > at the expense of slower generated code. However, with Liftoff as the > baseline compiler, startup time is not so important anymore for > TurboFan. > > R=clemensb@chromium.org > CC=manoskouk@chromium.org > > Change-Id: I2a81f66929c43fbbdfc3625359772c8ea0f2235f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2488684 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70691} Change-Id: Ia3f6f48649c329b9a49e038264dd12f7d872d275 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504265Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#70871}
-
Alfonso Castaño authored
This CL is a preliminary work to move the description generation of objects that are not V8 specific to the Embedder. Until now, the description for Nodes and Trusted Types was generated by V8 what was problematic, since Blink (not V8) is who has access to the information required for the description. Once the refactoring is complete the existing descriptionForNode and descriptionForTrustedType can be deleted from V8. Corresponding Blink CL: https://chromium-review.googlesource.com/c/chromium/src/+/2502589 Follow-up V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/2502869 Bug: chromium:1048143 Change-Id: Ia30c207697d7355bf3f8b27f7494349ca41266e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502342Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Alfonso Castaño <alcastano@google.com> Cr-Commit-Position: refs/heads/master@{#70870}
-
Zhi An Ng authored
The speedup in https://crrev.com/c/2504853 left out checking the array lengths, this adds that check. Bug: v8:7783 Change-Id: I8de01fa2dff3e051246ee3a268cdce2128ad16ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505252Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70869}
-
Zhi An Ng authored
These were sped up in https://bugs.chromium.org/p/v8/issues/detail?id=7783 comments 65 to 68. Bug: v8:7783 Change-Id: If1bb3db10a418625d13ae3417c009274c39df67d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505249 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#70868}
-
Michael Lippautz authored
This is a reland of e68285e2 Failing wasm tests seemed to recover on their own. Original change's description: > cppgc-js: heap snapshot: Add logic for querying detachedness > > Adds infrastructure to allow embedders specifying a detachedness state > that is queried when encountering an object with a TraceReference that > has a non-zero wrapper class id set. > > Change-Id: Ie7f2f253544ee25a25565eb08d82e9df5f0a74d2 > Bug: chromium:1056170 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502345 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70841} Bug: chromium:1056170 Change-Id: I293a9d38f841b4d0faa4af7408bb57544f11d566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505713 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70867}
-
Mathias Bynens authored
This reverts commit 1eecdf34. Reason for revert: unacceptable binary size increase (+65.5 KiB) We’ll reland once we implement a more efficient way to store the sequences. Original change's description: > Update RegExp sequence property support > > This patch aligns --harmony-regexp-sequence with the latest version of > the corresponding TC39 and Unicode proposals. > > The list of supported properties has been changed: > > - https://github.com/tc39/proposal-regexp-unicode-sequence-properties#proposed-solution > - https://unicode.org/reports/tr18/#Full_Properties > > Furthermore, the Unicode data now uses Unicode v13.0.0 instead of v12.0.0. > > Bug: v8:7467 > Change-Id: I1ac386d87af68d68e84e919cb5ffc1313443844a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497163 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70752} TBR=yangguo@chromium.org,jgruber@chromium.org,mathias@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7467 Change-Id: I6721f4862827dc686d96d79498a1e8fdae4481d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505758Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#70866}
-
Liu Yu authored
Port d7ece57e Bug: v8:9684 Change-Id: I6b103a5331f49a248e56a72d85e79f3d0fd2ef96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505243 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70865}
-
Zhi An Ng authored
Test was skipped because the generated test contains multi-byte opcode, and wasn't correct. Fix up the test with the correct encoding. The fuzzer now generates multi-byte opcodes correctly, and so shouldn't be an issue. Bug: v8:10486 Change-Id: I1f5ad7d456320a30da6c553f65fdca0fc86a291a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505238Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70864}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eef4a9f..acfd692 Rolling v8/third_party/aemu-linux-x64: Cde6_Nup5XVxJODi7chcAAfy5-gsuGDvdepMA2nkfKMC..zy6Zme4YpIqml3lhXc3o7a0r_gVd0_gcggle2n2j330C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/daba508..15be7eb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dfa44da..e8dff37 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/d3c1cdc..c7c91f8 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8313da9064bc7fc86f79b84ebd01763b2a79de44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2506503Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70863}
-
Zhi An Ng authored
This is a reland of 3fb07882 Original change's description: > [wasm-simd][ia32][x64] Only use registers for shuffles > > Shuffles have pattern matching clauses which, depending on the > instruction used, can require src0 or src1 to be register or not. > However we do not have 16-byte alignment for SIMD operands yet, so it > will segfault when we use an SSE SIMD instruction with unaligned > operands. > > This patch fixes all the shuffle cases to always use a register for the > input nodes, and it does so by ignoring the values of src0_needs_reg and > src1_needs_reg. When we eventually have memory alignment, we can > re-enable this check, without mucking around too much in the logic in > each shuffle match clause. > > Bug: v8:9198 > Change-Id: I264e136f017353019f19954c62c88206f7b90656 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504849 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70848} Bug: v8:9198 Change-Id: I40c6c8f0cd8908a2d6ab7016d8ed4d4fb2ab4114 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505250Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70862}
-
- 28 Oct, 2020 9 commits
-
-
Zhi An Ng authored
Introduce a new option for Format, 'size, to print element sizes for Advanced SIMD instructions. Then convert some disassembly to use this new Format option. Bug: v8:10933 Change-Id: I9eab0e3f6d951c315c49b723db01bcdc93dbde02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504856Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70861}
-
Zhi An Ng authored
We can move the esize (element size) calculation into the other scope, since all but 1 instruction share this. Bug: v8:10933 Change-Id: I43cfef46fdf7e962d54c29949488c2a7c0900334 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504854Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70860}
-
Michael Achenbach authored
This reverts commit b16c7e5b. Reason for revert: Suspect for lots of crashes on GPU bots, e.g.: https://ci.chromium.org/p/v8/builders/ci/Mac%20V8%20FYI%20Release%20(Intel)/11228 https://chromium-swarm.appspot.com/task?id=4f88d01781db5a10 Original change's description: > Reland "[Heap]: Convert Sweep to Job" > > This is a reland of 795c0b1c > Reason for revert: > TSAN failures https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33884 > Safe to reland as-is with fix to EagerUnmappingInCollectAllAvailableGarbage > https://chromium-review.googlesource.com/c/v8/v8/+/2502809 > > Original change's description: > > [Heap]: Convert Sweep to Job > > > > max concurrency is inferred from queue size for OLD_SPACE & MAP_SPACE. > > Extra Sweeper::TearDown() in MarkCompactCollector::TearDown() is needed > > to cancel job. > > > > Change-Id: Iafba7d7d24e8f6e5c5a1d5c0348dea731f0ac224 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2480783 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#70767} > > Change-Id: Id9a5baceed4664f53da39597af56a2067e4f3c6f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502808 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70845} TBR=ulan@chromium.org,etiennep@chromium.org Change-Id: Id6e9fe99f016652dd0fedbdbf65662f8e02ed67a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505974Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70859}
-
Junliang Yan authored
Change-Id: I7991225d49797f292c7e565e00c79f418154449f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2506234 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#70858}
-
Leszek Swirski authored
PPC has a larger page size than other platforms, so increase the page size in the test to account for this. Change-Id: I392064e9ef3f87c5bddb7763b35661aee5b4669d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502330 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Milad Fa <mfarazma@redhat.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70857}
-
Mythri A authored
This is a reland of 44f46def with a fix for failures with --turbonci_as_mid_tier Original change's description: > [turboprop] Pass required parameters as value inputs to TierUpCheck node > > TierUpCheck node tail calls interpreter entry trampoline when additional > processing is needed for tiering up. Calling IET requires target, > new_target, input count and context as parameters. Earlier these were > created as parameter nodes in effect-control-linearizer. This causes > problems with Turboprop since TurboProp doesn't use the second scheduler > and cannot reschedule these nodes to the start block. We should instead > create these parameter nodes in bytecode-graph-builder and pass them > as value inputs to TierUpCheck node. > > Bug: v8:9684 > Change-Id: Icfe5a33b4e628d5a3ba9a3121b2b0746be6aed5c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498695 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70790} Bug: v8:9684 Change-Id: Ic1a7d39aab0a599d0dd421f237e7bc640fcd6eb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504258 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#70856}
-
Peter Marshall authored
This has no effect on our normal V8 builds as we don't set an alternate stack. Embedders like Go have to use alt stacks so this makes them work with V8 if they have set up an alt stack themselves. Change-Id: Icf3f4b39c026948875f5b2762ea6ffabaab03e8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505718Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#70855}
-
Milad Fa authored
Port d7ece57e Original Commit Message: Optimization marker and the optimized code used to share the same slot in the feedback vector as they were mutually exclusive. With turboprop we would want to mark the function for tier up to Turbofan while holding the optimized code for Turboprop. So this cl uses the existing padding field to hold the optimization marker instead. As a driveby, removes unused JSFunction::ClearOptimizedCodeSlot function and fixes a minor bug in Runtime_GetOptimizationStatus. R=mythria@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ie635fd05c26f70124076b9c51c0c70a2b948af69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505621Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#70854}
-
Tobias Tebbi authored
This CL splits the class definitions per .tq file, to realize the following relationship: A class defined in src/objects/foo.tq has a C++ definition in src/objects/foo.h. Torque then generates: - torque-generated/src/objects/foo-tq.inc An include file (no proper header) to be included in src/objects/foo.h containing the Torque-generated C++ class definition. - torque-generated/src/objects/foo-tq-inl.inc An include file (no proper header) to be included in src/objects/foo-inl.h containing inline function definitions. - torque-generated/src/objects/foo-tq.cc A source file including src/objects/foo-inl.h that contains non-inline function definitions. Advantages of this approach: - Avoid big monolithic headers and preserve the work that went into splitting objects.h - Moving a definition to Torque keeps everything in the same place from a C++ viewpoint, including a fully Torque-generated C++ class definition. - The Torque-generated include files do not need to be independent headers, necessary includes or forward declarations can just be added to the headers that include them. Drive-by changes: A bunch of definitions and files had to be moved or created to realize a consistent 1:1 relationship between .tq files and C++ headers. Bug: v8:7793 TBR: hpayer@chromium.org Change-Id: I239a89a16d0bc856a8669d7c92aeafe24a7c7663 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2470571 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#70853}
-