- 01 Jul, 2021 8 commits
-
-
Jakob Kummerow authored
We've already been zero-extending 32-bit offset registers since https://chromium-review.googlesource.com/c/v8/v8/+/2917612, but that patch only covered the case where offset_imm == 0. When there is a non-zero offset, we need the same fix. Bug: chromium:1224882,v8:11809 Change-Id: I1908f735929798f411346807fc4f3c79d8e04362 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998582 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75500}
-
Jakob Gruber authored
Bug: v8:7790, chromium:1225521 Change-Id: I4210ca9d3eccdc4de0b5b865bac37dc32b8e6f17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999085 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75499}
-
Clemens Backes authored
We currently only measure the compilation time of individual functions, but that does not include other things that happen for lazy compilation, like switching memory permissions or publishing the code. This CL adds a dedicated counter to measure the complete lazy compilation time. R=jkummerow@chromium.org CC=dlehmann@google.com Bug: v8:11940 Change-Id: I9a87882d2adc7bea6c5258954a642da18b8337ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997106Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75498}
-
Jakob Gruber authored
Bug: v8:7790, chromium:1225300 Change-Id: I36ae331db0abb072ebc597b4682c3983a00d8a1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999084 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b342bb3..969e9b2 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/82a4d60..fd3f3c1 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/79a2e92..8fa8794 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2bc697b..949bca8 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/355d57d..255323c TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I75876b6b9e83f4d5866c0405bb7258f4c709b749 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998385Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75496}
-
John Xu authored
- Updated implementation of platform-starboard - Introducing stack_trace_starboard.cc - Adding Starboard implementation for sys-info, random and memory - Disabling some code in ostream. Bug: v8:10927 Change-Id: I4548a413449fc8e43c5d4ae485b3644c60c07830 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2952864 Commit-Queue: John Xu <johnx@google.com> Auto-Submit: John Xu <johnx@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#75495}
-
Peter Kasting authored
There are still a few cases remaining that seem more controversial; I'll upload those separately. Bug: chromium:1066980 Change-Id: Iabbaf23f9bbe97781857c0c589f2b3db685dfdc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994804 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#75494}
-
Liu Yu authored
Fix a offset error, this is related to commit 38fb1487 Delete cctest/test-run-machops/StackSlotAlignment, this is related to commit a58f812c Change-Id: I3ef1b96d8a3bdba530200cbac4f7a062496ace59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994813Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75493}
-
- 30 Jun, 2021 32 commits
-
-
Manos Koukoutos authored
This is a reland of 071a1acf Changes compared to original: Expect SIMD test to fail if SIMD is not supported. Original change's description: > [wasm] Refactor initializer expression handling > > Design doc: https://bit.ly/3xPxWUe > > This CL introduces two main changes: > - Initializer expressions are now decoded by WasmFullDecoder. With > wasm-gc, initializer expressions are no longer just constants, and > require complex decoding (including stack tracking). This resulted in > extensive code duplication. > - Initializer expressions are not stored explicitly by module-decoder as > an AST (WasmInitExpr), but rather as a WireBytesRef, and are decoded > again during module instantiation. This should reduce memory > consumption for globals and other module elements with initializer > expressions (which has been observed in the 40MB range in some > real-world benchmarks. > > Summary of changes: > - Add a static parameter {kFunctionBody, kInitExpression} to the > WasmDecoder. Use it to specialize validation to function bodies/init. > expressions. > - Introduce a new Interface for the WasmFullDecoder for init. > expressions. > - Differentiate between constant and non-constant opcodes in > WasmFullDecoder. > - Change representation of init. expressions in WasmModule to > WireBytesRef. > - Reimplement EvaluateInitExpression in module-instantiate to re-decode > initializer expressions. > - Remove some now-invalid module decoder tests. > > Pending changes: > - Also refactor initializer expressions for element segment entries. > - Reintroduce deleted tests. > > Bug: v8:11895 > Change-Id: I76512bfe1386c8338667d30fa6db93880a1e4b42 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972910 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75476} Bug: v8:11895 Change-Id: I2dface5ff28d5a2d439a65d3e5cb83135c061bb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997722 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
This reverts commit 0d059e07. Reason for revert: Reverting as CheckHardwareSupportsSimd already contains the SSSE3 check. Original change's description: > [wasm-simd] Pass decode if SSSE3 flag is set > > Change-Id: Iafe2b5635287fea5bd3c687b4ed897edbce4b0aa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2798978 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73781} Change-Id: Ib227af90f2f35a7e63cb64acea8bbca9ff8ddd62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998503 Auto-Submit: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Grouping a couple of small, non-functional fixes: - add a comment to GetStackParameterDelta - small typo fixes to a couple of places I saw while reading related code Bug: v8:11879 Change-Id: I8566c9778fd6268b08ea3aefbdaa84ef894bcd35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997922Reviewed-by:
-
Mike Stanton authored
PropertyArray::get() and a few other functions there call PropertyArray::length() in an assert. These need to be the acquire load version of length() to keep TSAN happy. Bug: chromium:1225277 Change-Id: Ic43bfc1902dea3e87f353be0efd03563c13c1e10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997105Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#75489}
-
Ng Zhi An authored
Bug: v8:11879 Change-Id: Ia0047b701e77b6e766984de527e817874d95f38e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989102Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#75488}
-
Ng Zhi An authored
Currently, running jco gives us an error message like so: (lldb) jco $pc Failed to evaluate command _v8_internal_Print_Code((void*)($pc)) : error: <user expression 0>:1:1: '_v8_internal_Print_Code' has unknown return type; cast the call to its declared return type _v8_internal_Print_Code((void*)($pc)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The fix is to cast the call to (void). I've only used and found this issue with jco, but I think the other commands have the same issue, so fixing those together here. FYI I am using lldb version 11. Bug: v8:11879 Change-Id: Id9d8e8091fd011585e6fea863de5b4d7c9d47c5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994764Reviewed-by:
-
Jakob Gruber authored
No longer needed now that the predicate is fixed. Bug: v8:7790,v8:11779 Change-Id: If585c3692aed77659b53f670182129988ba93130 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996193 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Victor Gomes authored
Change-Id: I4ec51c8f1a0a9b5d9967898c2e89c9ba82ace6c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997107 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#75485}
-
Clemens Backes authored
This reverts commit 071a1acf. Reason for revert: Breaks on nosse: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux/42795/overview Original change's description: > [wasm] Refactor initializer expression handling > > Design doc: https://bit.ly/3xPxWUe > > This CL introduces two main changes: > - Initializer expressions are now decoded by WasmFullDecoder. With > wasm-gc, initializer expressions are no longer just constants, and > require complex decoding (including stack tracking). This resulted in > extensive code duplication. > - Initializer expressions are not stored explicitly by module-decoder as > an AST (WasmInitExpr), but rather as a WireBytesRef, and are decoded > again during module instantiation. This should reduce memory > consumption for globals and other module elements with initializer > expressions (which has been observed in the 40MB range in some > real-world benchmarks. > > Summary of changes: > - Add a static parameter {kFunctionBody, kInitExpression} to the > WasmDecoder. Use it to specialize validation to function bodies/init. > expressions. > - Introduce a new Interface for the WasmFullDecoder for init. > expressions. > - Differentiate between constant and non-constant opcodes in > WasmFullDecoder. > - Change representation of init. expressions in WasmModule to > WireBytesRef. > - Reimplement EvaluateInitExpression in module-instantiate to re-decode > initializer expressions. > - Remove some now-invalid module decoder tests. > > Pending changes: > - Also refactor initializer expressions for element segment entries. > - Reintroduce deleted tests. > > Bug: v8:11895 > Change-Id: I76512bfe1386c8338667d30fa6db93880a1e4b42 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972910 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75476} Bug: v8:11895 Change-Id: I9fcfdedad73ef21beb9632f50305b8e678a2dff6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997582 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75484}
-
Santiago Aboy Solanes authored
Marked as SLOW in https://chromium-review.googlesource.com/c/v8/v8/+/2993538. We can be more specific and not mark it for everything. Bug: v8:7790, v8:11600, v8:11906 Change-Id: I1c238bffb9973ae80a2fcc32f4103215bd019d67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992719Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75483}
-
Clemens Backes authored
FLAG_SCOPE_EXTERNAL can be used outside of the v8::internal namespace, while FLAG_SCOPE can not. This CL refactors FLAG_SCOPE such that it can be used anywhere, and removes the redudant FLAG_SCOPE_EXTERNAL macro. Also, UNFLAG_SCOPE_EXTERNAL is removed in favor of FLAG_SCOPE_VAL, as the word "flag" in the macro name is meant to refer to a flag, and not to the verb or action of "flagging" something, hence "unflag" does not match the terminology. R=ahaas@chromium.org Bug: v8:11879 Change-Id: I2d761012c3e4330abb611bf67130eb57ec5bb964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988920 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#75482}
-
Milad Fa authored
regress-crbug-482998 is skipped and regress-331444 is marked as slow. Bug: v8:11875 Change-Id: I01c14dee704c5179d62b79cca0681f833102680d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996842Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75481}
-
Clemens Backes authored
There are instructions that take 7 bytes, e.g. 4881ec10000000 REX.W subq rsp,0x10 Hence increase the padding from 12 characters to 14 characters to restore alignment. Drive-by: Rewrite the padding loop to make it more readable and add a comment. R=jkummerow@chromium.org Change-Id: Iddd6a721574fc47b4a072fe40c2f5e90cb3d1186 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996200Reviewed-by:
-
Clemens Backes authored
The {EnterFrame} and {LeaveFrame} methods will already emit a (scoped) code comment in the form [ EnterFrame ... instructions ... ] Thus skip the additional code comment emitted by Liftoff. R=ahaas@chromium.org Bug: v8:11879 Change-Id: I488568022cb03b16f07a12c1a575d90613691758 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996197Reviewed-by: -
Clemens Backes authored
Extern ref in Liftoff is enabled since M-90 (https://crrev.com/c/2625886), hence remove the flag to simplify the code. R=ahaas@chromium.org Bug: v8:11879 Change-Id: Ie72dfbc006d6f42e2e9e83d44ff78e3c53a82614 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996195Reviewed-by:
-
Clemens Backes authored
We currently merge i32 binary operations with a subsequent if or br_if, and we merge i32.eqz with a subsequent br_if. The combination i32.eqz + if was missing, even thought there is already support for that in the "if" handler. R=ahaas@chromium.org Change-Id: Id4386d0c5d6dcf3605c72ea1146169d2088abe98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996196Reviewed-by:
-
Manos Koukoutos authored
Design doc: https://bit.ly/3xPxWUe This CL introduces two main changes: - Initializer expressions are now decoded by WasmFullDecoder. With wasm-gc, initializer expressions are no longer just constants, and require complex decoding (including stack tracking). This resulted in extensive code duplication. - Initializer expressions are not stored explicitly by module-decoder as an AST (WasmInitExpr), but rather as a WireBytesRef, and are decoded again during module instantiation. This should reduce memory consumption for globals and other module elements with initializer expressions (which has been observed in the 40MB range in some real-world benchmarks. Summary of changes: - Add a static parameter {kFunctionBody, kInitExpression} to the WasmDecoder. Use it to specialize validation to function bodies/init. expressions. - Introduce a new Interface for the WasmFullDecoder for init. expressions. - Differentiate between constant and non-constant opcodes in WasmFullDecoder. - Change representation of init. expressions in WasmModule to WireBytesRef. - Reimplement EvaluateInitExpression in module-instantiate to re-decode initializer expressions. - Remove some now-invalid module decoder tests. Pending changes: - Also refactor initializer expressions for element segment entries. - Reintroduce deleted tests. Bug: v8:11895 Change-Id: I76512bfe1386c8338667d30fa6db93880a1e4b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972910Reviewed-by:
-
Victor Gomes authored
If the object to be trimmed creates a filler object that is located just before the current LAB, then we can immediately give back the memory. Bug: v8:11872, v8:11883 Change-Id: I9ec37443482334003b3752a3f25fc5dcb6a476fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996643Reviewed-by:
-
Clemens Backes authored
Those flags are old, not commonly used, and redundant. People usually rely on external tools to disassembly wasm functions or modules. Also, the name is misleading as Wasm is not an AST (any more). R=ahaas@chromium.org Bug: v8:11879 Change-Id: I0f90d142ae4c7c6b7ee6013ea033951aad6bf133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996194Reviewed-by:
-
Clemens Backes authored
This will automatically skip the test in the stress_snapshot variant, where Wasm is not supported. R=cbruni@chromium.org Bug: v8:11937 Change-Id: I29078e070a7b1526470e15d8667c5256ea4d8fe1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996642Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75473}
-
Clemens Backes authored
This adds back two spaces that went missing in https://crrev.com/c/2978252, removing the space between offset and instruction bytes. After https://crrev.com/c/2978252: 0x21ea0e1e04a0 055 push rbp 0x21ea0e1e04a1 14889e5 REX.W movq rbp,rsp After this CL: 0x2be7c8c604a0 0 55 push rbp 0x2be7c8c604a1 1 4889e5 REX.W movq rbp,rsp R=delphick@chromium.org Change-Id: I6df35aed9b5909da72965fef622b07120c226fae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996199Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75472}
-
Victor Gomes authored
No-Try: true Bug: v8:11234 Change-Id: I93bf3f096bd82faadd21abf08d61f06c0b823f7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996189 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts: 59b9aaf7 8f84d0bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Change-Id: Ieaca12cad2edcab85517cb4cffb58abb1be50674 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996198 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#75470}
-
Victor Gomes authored
Bug: v8:11872 Change-Id: I8511bec7f4eaed5d154094083b46e3895ac0b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992728Reviewed-by:
-
Yoshisato Yanagisawa authored
Bug: chromium:1222951 Change-Id: I41bf941969b5d94ec28ac728f0fe129d8acb83d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2995611 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
.. and make JSGlobalObjectRef bg-serialized. GetPropertyCell was implemented as: LookupIterator it(holder, isolate, name, LookupIterator::OWN); it.TryLookupCachedProperty(); if (it.state() == LookupIterator::DATA) it.GetPropertyCell(); Due to concurrency requirements, we essentially have to reimplement this entire path for use in a concurrent setting: - Reads in some cases have to use relaxed or acquire semantics. - The IsPendingAllocation predicate must be called on some objects before reading into them. - Repeated reads of the same field must be avoided due to the possibility of concurrent modifications. This CL introduces two new methods: ConcurrentLookupIterator::TryGetPropertyCell implements the outer lookup logic, including the repeated lookup for accessors / cached property names. GlobalDictionary::TryFindPropertyCellForConcurrentLookupIterator is a slightly modified HashTable::FindEntry which follows the above rules. Bug: v8:7790 Change-Id: Ic9a52da766afdfedce8efcbda92876845a17eed9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959616Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: Ie46c575a9f438f25e7db7c1758beaf7bf0e8b39f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992885 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:11872 Change-Id: I16c6c0027b905215a789f8d47b19824b1c1f2491 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992725 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: I54eea2deaaa4823b13f8f66e13a1851f951c63c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991241 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: If558b6db7feed50bd0325a814bcab9e98ebd9493 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991239 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This reverts commit 5fefa970. Reason for revert: They are used via CodeT https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20external%20code%20space%20-%20debug%20-%20builder/124/overview Original change's description: > [compiler] Remove unused CodeDataContainerRef/Data classes > > Bug: v8:7790 > Change-Id: I072823ea40b0bd64aaf4a14882603cef29edcf22 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992722 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75456} Bug: v8:7790 Change-Id: I2c7f65c8a772de9967ce5b3aa78d1f46c9c99866 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996188Reviewed-by:
-
Ross McIlroy authored
Adds support for a seperate dynamic map checks trampoline that takes the feedback vector as an argument rather than reading it from the stack frame, to enable it to work for inlined functions. Plumbs the logic through the compiler to select between these trampolines based on the framestate. BUG=v8:9684,chromium:1224367 Change-Id: Ibc7facdc78930aedec4a102693a926f64f6de7e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992724 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
