- 24 May, 2022 11 commits
-
-
jameslahm authored
... timeout in the big websnapshot tests. Bug: v8:12891 Change-Id: I7837ba985f835e20af294ea0206dfafb5def7619 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660705Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80713}
-
Dominik Inführ authored
Instead of invoking both the generational and marking barrier explicitly, we can just invoke the combined barrier which does both for us. Also we simply use the full write barrier for all writes in the deserializer. While we could avoid the generational barrier in a few cases, this only costs us a single predictable untaken branch without an additional load. Bug: v8:11708 Change-Id: Iebd0af06efe42a3ac4e5725131362600ab16bc7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662900 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80712}
-
Solomon Kinard authored
Change-Id: I924a2b4dc4ab5e7be22fd2a9a1084473ba65fc35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3651039Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80711}
-
Patrick Thier authored
Disable --always-use-string-forwarding-table when --shared-string-table is set. With --shared-string-table we can have parallel GCs in multiple client isolates. With --always-use-string-forwarding-table we can have young generation strings in the forwarding table, requiring table updates when the string gets promoted. This is not supported for parallel GCs. This CL also reverts the incorrect try to fix an issue with these flag combination introduced in https://crrev.com/c/3650719 Bug: v8:12877, v8:12007 Change-Id: I49a2aa300af36b82007a7d215afe9a70ac1ce39e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660258 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80710}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.tozoneddatetime Bug: v8:11544 Change-Id: I758e46efdc33cfc3f336e5c595a402123ae6c485 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3535920Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80709}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.prototype.with Bug: v8:11544 Change-Id: I311d6246646ce18503804352bc95a374af3d8c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565014Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.toplaindatetime Bug: v8:11544 Change-Id: Ie86a5d8a2f1206a44d0e74638392ae26e0f8e900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534454Reviewed-by:
-
Frank Tang authored
Spec text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaintime Bug: v8:11544 Change-Id: I5277fb88675bb6d99b028a289329db06b95cc003 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565026 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Sync to PR2036 https://github.com/tc39/proposal-temporal/pull/2036 Treat -000000 in DateExtendedYear as syntax error Bug: v8:11544 Change-Id: I8cf7a506e85ad2b74d572142d646f3f98cd8bffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3633620 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80705}
-
Lu Yahan authored
Change-Id: Ie6c88a0e371b2ce0bfad6ac887168e08fce26c05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3662541 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80704}
-
Shu-yu Guo authored
Bug: v8:12764 Change-Id: I7e76647be838749b723400914b144b9ec2a27cd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3656520 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
- 23 May, 2022 15 commits
-
-
Andrey Kosyakov authored
This includes conversion of python scripts to python3. Change-Id: I5c05b3ab2aa00711a0dc26f1885a73f0ef4dbd85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3530115Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#80702}
-
Deepti Gandluri authored
Also remove the SKIP statement for relaxed min/max tests Bug: v8:12284 Change-Id: Iff67fe2a1c281295f237fbb95a9a36da668f27e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3651530Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80701}
-
Joyee Cheung authored
Previously the LookupIterator ignores private symbols (including private names) for the access check. This patch removes these exceptions so that they are always checked. Drive-by: removes the unused should_throw parameter in Runtime::DefineObjectOwnProperty() Bug: chromium:1321899 Change-Id: I9677b1e377f01d966daa1603eee1ed9535ffab92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623419Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#80700}
-
Manos Koukoutos authored
Not peeling very large loops gives speedups on some benchmarks. Change-Id: Ifbdf08ddaee0e9c638238a6bcf4a3a5ea319b817 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660243 Auto-Submit: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80699}
-
Leszek Swirski authored
Fix requesting an Int32 from a tagged value that was already converted to Float64 (because it was on one side of Number feedback but was itself a Smi), and DoubleRegister locations in deopts. Bug: v8:7700 Change-Id: I01615a6c520c9e086f3544c2656aa04bf3fc1eaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660254Reviewed-by:
-
Seth Brenith authored
My previous change https://crrev.com/c/3597106 led to some performance regressions in time spent on parsing and compilation. Those regressions might be due to increasing the reuse of old top-level SharedFunctionInfos. If the top-level SFI is old enough that its bytecode can be flushed, then perhaps other SFIs within the script have already been flushed. In that case, discarding information from a background compilation or code cache deserialization could be harmful. Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601 Change-Id: Ia7651bed86eecdbef8878e6132b894ed10163cdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657472 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
-
Benedikt Meurer authored
This was an oversight in https://crrev.com/c/3557234, which led to a really weird developer experience: once a `window.onerror` handler was installed, typing into the Console or other side-effect free debug evaluations triggered this handler. Fixed: chromium:1328008 Bug: chromium:1295750 Change-Id: I4029ff19ceb7cfe0a8eb6afff19c3ef9a4a82e25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3660253 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#80696}
-
Marja Hölttä authored
It sometimes meant just the field and sometimes the computed byte length. This rename makes it less confusing. Bug: v8:11111 Change-Id: I64bb8b6b9be2befb57d53ae5456b6ce8f6472456 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657429Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80695}
-
Leszek Swirski authored
Add an implementation of BranchIfInt32Compare, which is emitted whenever a compare op is immediately followed by a branch. Bug: v8:7700 Change-Id: I2c56d9de199bac8de33b33201f8614aee8e9894e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3647693Reviewed-by:
-
Liu Yu authored
SimulatorBase::ConvertArg should be a protect member so that CallArgument::CallArgument can access it. Change-Id: I60b23b45c2247cd28e73808df7b77e604d154932 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3659057Reviewed-by:
-
Leszek Swirski authored
Add an implementation of compare ops which, like binary ops, speculatively reads integers (but still returns a tagged true/false value). Bug: v8:7700 Change-Id: I38f0ba99f8f7af30c89d0b987e28483c9610463f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657440 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
We weren't always clearing latest_checkpoint_state on merge points, so bottleneck it in a better location. Bug: v8:7700 Change-Id: Iaac5922d769d97d49b85613d5390196a14ad8059 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657437Reviewed-by:
-
Leszek Swirski authored
Deopt InputLocation next_use fields are not initialised, so if a deopt is the last use of a node we won't release it. Fix this by initialising the input location array. Also add a DCHECK to verify that register assignments match what registers a node thinks it's in. Bug: v8:7700 Change-Id: I4003a027489cf8eeef7c4e60fa64f72cebd2c4e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657438Reviewed-by:
-
Nikolaos Papaspyrou authored
Mostly in comments, again, not much to be said... Bug: v8:12425 Change-Id: If0890132606b5ae8d5e173907bfdc063b9811ac6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657428Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b8694ed..b2f1ec8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2f98847..4e6aa25 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220521.3.1..version:8.20220522.3.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ib008d9d40613b94ba54897d10f1a842683498570 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3659712 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80688}
-
- 22 May, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/44ff734..b8694ed Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0e9a7d2..2f98847 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220520.3.1..version:8.20220521.3.1 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2fe249a..80b28c9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ec2da2f..6df1876 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I48af985a9d0f037c7ccdc3e7e6c66f0d0e6e7610 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3658142 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80687}
-
- 21 May, 2022 8 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/399520d..44ff734 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/3e4d383..4ad92ec Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/c9b2288..d03f56b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8111049..a1cf7a2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/bd80a1b..0e9a7d2 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220519.0.1..version:8.20220520.3.1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/bec960d..ec2da2f R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3cfe4f14fa51e977aa3efa79d124aeab74aaad17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3658135 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80686}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.tozoneddatetime Bug: v8:11544 Change-Id: Ic4464e6d4521fb7e006164933df4f38c5d3115b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3554666 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tozoneddatetime https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tozoneddatetimeiso Bug: v8:11544 Change-Id: I452dfbf027e5d58edde9f9691519204ff29d8082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3382058 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Also Add AOs: ToTemporalYearMonth, YearMonthFromFields, ParseTemporalYearMonthString Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.from https://tc39.es/proposal-temporal/#sec-temporal-totemporalyearmonth https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalyearmonthstring https://tc39.es/proposal-temporal/#sec-temporal-yearmonthfromfields Bug: v8:11544 Change-Id: I04b30a4159142a996c765c542f19e66bee593e4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3538666Reviewed-by:
-
Frank Tang authored
Bug: v8:11544 Change-Id: Iaf440009b2abdf9e90de3ed0e6e02eb35060a65b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437889Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.withplaintime Bug: v8:11544 Change-Id: I1c35c1105c9f2cc051d3b17718f52170fbee2a5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565027Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.toplainmonthday https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.toplainyearmonth https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.toplainyearmonth https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.toplainmonthday Bug: v8:11544 Change-Id: Ia97de3b4dde183ae4ee514deb4d13da5d5ff9bae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534451Reviewed-by:
-
Shu-yu Guo authored
TSAN intercepts atomic accesses and uses locking. Since YIELD_PROCESSOR is used in spinlock loops in conjunction with atomic accesses, such spinlock loops can exhibit starvation in TSAN. To work around the problem, have YIELD_PROCESSOR sleep the process for 1ms. Change-Id: I042368cfc6b55abdba5c897a8f23cc633a70ba13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3651514Reviewed-by:
-
- 20 May, 2022 5 commits
-
-
Frank Tang authored
Implement the following methods of ZonedDateTime year, month, monthCode, day, dayOfWeek, dayOfYear, weekOfYear, daysInWeek, daysInMonth, daysInYear, monthsInYear, inLeapYear, era, eraYear Also implement corresponding AOs (CalendarXXX). Spec Text: https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.year https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.month https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.monthcode https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.day https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.dayofweek https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.dayofyear https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.weekofyear https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.daysinweek https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.daysinmonth https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.daysinyear https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.monthsinyear https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.inleapyear https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.era https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.erayear Bug: v8:11544 Change-Id: I7d7008a719f0109836834d170c5f52b49c3ffb7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565028 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Also add AO: TemporalDurationToString Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.tojson https://tc39.es/proposal-temporal/#sec-temporal-temporaldurationtostring Bug: v8:11544 Change-Id: I7dfdb5458b88646a4ac7b7713e7c8e63352f7539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3438375 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Also add AOs: ParseTemporalMonthDayString, MonthDayFromFields, ToTemporalMonthDay Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.from https://tc39.es/proposal-temporal/#sec-temporal-totemporalmonthday https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalmonthdaystring https://tc39.es/proposal-temporal/#sec-temporal-monthdayfromfields Bug: v8:11544 Change-Id: I971b5a0f43b9dbeefe38ebe28035f7c9b1a617ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3538664Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sup-temporal.plaindate.prototype.tostring https://tc39.es/proposal-temporal/#sup-temporal.plaindate.prototype.tolocalestring https://tc39.es/proposal-temporal/#sup-temporal.plainmonthday.prototype.tostring https://tc39.es/proposal-temporal/#sup-temporal.plainmonthday.prototype.tolocalestring https://tc39.es/proposal-temporal/#sup-temporal.plainyearmonth.prototype.tostring https://tc39.es/proposal-temporal/#sup-temporal.plainyearmonth.prototype.tolocalestring Implement toString/toLocaleString as non-intl version. Because toString took options bag in Temporal, we cannot use the same way how we handle Date.prototype.toLocaleString() for non-intl build by just forwarding to it's toString implementation. Change built-ins-defintions.h to always has built-ins for *.toLocaleString , not just in intl build. Change src/init/bootstrapper.cc away of the toLocaleString forward to toString approach. Implement the non-intl version of ToLocaleString in js-temporal-objects.cc for Temporal.Plain(Date|YearMonth|MonthDay) Bug: v8:11544 Change-Id: I202bcf28ef05ed03c337475300cfdfd18b52ffb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3656137Reviewed-by:
-
Andy Wingo authored
Bug: v8:12868 Also adds wtf8.cc, wtf8.h to src/wasm, to implement WTF-8 validation and possibly other utilities. Also fixes a bug when parsing the string literals section; I had misunderstood the way the unordered/ordered sections mechanism worked. Change-Id: I3c4205e0872379a69575f84ba33e0090a9d8d656 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3652789 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
