- 17 Dec, 2015 1 commit
-
-
neis authored
And remove confusing comment. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1531843003 Cr-Commit-Position: refs/heads/master@{#32935}
-
- 22 Oct, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1413173003 Cr-Commit-Position: refs/heads/master@{#31467}
-
- 16 Oct, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org, hpayer@chromium.org Review URL: https://codereview.chromium.org/1411653002 Cr-Commit-Position: refs/heads/master@{#31331}
-
- 13 Oct, 2015 1 commit
-
-
mstarzinger authored
This moves JavaScript source files that are bundled with V8 into a separate directory. The goal is to improve code readability and also being able to formalize ideal reviewers by subsequently adding the OWNERS file. These files almost exclusively contain implementations of methods fully specified by ES6. Note that files in the "debug" directory as well as the "d8.js" file aren't affected by this change. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1398733002 Cr-Commit-Position: refs/heads/master@{#31230}
-
- 23 Sep, 2015 1 commit
-
-
bmeurer authored
Introduce a new macro TO_STRING that maps to %_ToString and use that instead of calling into any of the ToString/NonStringToString JavaScript builtins. Also remove the TO_STRING_INLINE macro, which is basically obsolete with %_ToString. We still have a few uses of ToString left (via the utils export mechanism), where we need to investigate whether we will tank badly if we replace them with TO_STRING as well. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=yangguo@chromium.org BUG=v8:4307 LOG=n Review URL: https://codereview.chromium.org/1323543002 Cr-Commit-Position: refs/heads/master@{#30895}
-
- 03 Sep, 2015 1 commit
-
-
bmeurer authored
Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String, Array and collection iterators, and also for generators). This removes one source of unnecessary polymorphism in for-of loops. It is accomplished by a new intrinsic %_CreateIterResultObject() that should be used to create iterator result objects from JavaScript builtins (there's a matching factory method for C++ code). Also restructure the %StringIteratorPrototype%.next() and %ArrayIteratorPrototype%.next() functions to be a bit more friendly to optimizing compilers. R=ishell@chromium.org Review URL: https://codereview.chromium.org/1302173007 Cr-Commit-Position: refs/heads/master@{#30557}
-
- 02 Sep, 2015 1 commit
-
-
bmeurer authored
The spec says that the "this value" has to be an Object. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1325023003 Cr-Commit-Position: refs/heads/master@{#30533}
-
- 28 Aug, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org,mlippautz@chromium.org Review URL: https://codereview.chromium.org/1318043002 Cr-Commit-Position: refs/heads/master@{#30438}
-
- 21 Aug, 2015 1 commit
-
-
yangguo authored
We currently have several ways to share symbols that are used in both native scripts and the runtime. This change unifies this. We do not use the symbols registry since we don't need the registry any longer after bootstrapping, but the registry stays alive afterwards. R=mlippautz@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1293493004 Cr-Commit-Position: refs/heads/master@{#30280}
-
- 31 Jul, 2015 1 commit
-
-
bmeurer authored
This is the initial (big) step towards a more uniform implementation of the ToObject abstract operation (ES6 7.1.13), where we have a fallback implementation in JSReceiver::ToObject() and a fast (hydrogen) CodeStub to deal with the fast case (we should be able to do more cleanup on this in a followup CL). For natives we expose the abstract operation via a %_ToObject intrinsic, also exposed via a macro TO_OBJECT, that unifies the previous confusion with TO_OBJECT_INLINE, ToObject, TO_OBJECT, $toObject and %$toObject. Now the whole implementation of the abstract operation is context independent, meaning we don't need any magic in the builtins object nor the native context. R=mvstanton@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1266013006 Cr-Commit-Position: refs/heads/master@{#29953}
-
- 26 May, 2015 1 commit
-
-
yangguo authored
Revert of Revert of Hook up more import/exports in natives. (patchset #1 id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} TBR=jkummerow@chromium.org,erik.corry@gmail.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1149773003 Cr-Commit-Position: refs/heads/master@{#28608}
-
- 22 May, 2015 4 commits
-
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Speculative revert for gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > Cr-Commit-Position: refs/heads/master@{#28578} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154743003 Cr-Commit-Position: refs/heads/master@{#28584}
-
yangguo authored
R=jkummerow@chromium.org Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 Cr-Commit-Position: refs/heads/master@{#28573} Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28578}
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #2 id:20001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6943 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154793003 Cr-Commit-Position: refs/heads/master@{#28574}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28573}
-
- 21 May, 2015 1 commit
-
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd Cr-Commit-Position: refs/heads/master@{#28521} Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28533}
-
- 20 May, 2015 2 commits
-
-
jkummerow authored
Revert of Use shared container to manage imports/exports. (patchset #2 id:20001 of https://codereview.chromium.org/1143993003/) Reason for revert: Breaks nosnap bots Original issue's description: > Use shared container to manage imports/exports. > > Also changed string.js and math.js to adapt this change. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd > Cr-Commit-Position: refs/heads/master@{#28521} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1144163002 Cr-Commit-Position: refs/heads/master@{#28523}
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28521}
-
- 15 May, 2015 1 commit
-
-
arv authored
All the builtin iterators as well as the generator objects have an object called %IteratorPrototype% in the spec between them and %ObjectPrototype%. BUG=v8:3568 LOG=N Review URL: https://codereview.chromium.org/1128233008 Cr-Commit-Position: refs/heads/master@{#28426}
-
- 11 May, 2015 1 commit
-
-
yangguo authored
For the moment, we only pass the global object (the one we are setting up). A few smaller changes were necessary to avoid failures in test-object-observe/DontLeakContextOnObserve. Otherwise the global object would be retained by being context allocated, leading to test failure. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1132513003 Cr-Commit-Position: refs/heads/master@{#28331}
-
- 07 May, 2015 1 commit
-
-
yangguo authored
Revert of Revert of Wrap runtime.js in a function. (patchset #1 id:1 of https://codereview.chromium.org/1123353004/) Reason for revert: Failing test has been fixed. Original issue's description: > Revert of Wrap runtime.js in a function. (patchset #2 id:20001 of https://codereview.chromium.org/1126213002/) > > Reason for revert: > [Sheriff] Breaks nosnap: > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2872 > > Original issue's description: > > Wrap runtime.js in a function. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 > > Cr-Commit-Position: refs/heads/master@{#28275} > > TBR=jkummerow@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/62bd294f909ff448d0f876a3d745966a24cdc3f7 > Cr-Commit-Position: refs/heads/master@{#28277} TBR=jkummerow@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1131843002 Cr-Commit-Position: refs/heads/master@{#28287}
-
- 06 May, 2015 2 commits
-
-
machenbach authored
Revert of Wrap runtime.js in a function. (patchset #2 id:20001 of https://codereview.chromium.org/1126213002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2872 Original issue's description: > Wrap runtime.js in a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 > Cr-Commit-Position: refs/heads/master@{#28275} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1123353004 Cr-Commit-Position: refs/heads/master@{#28277}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1126213002 Cr-Commit-Position: refs/heads/master@{#28275}
-
- 05 May, 2015 1 commit
-
-
yangguo authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1127693006 Cr-Commit-Position: refs/heads/master@{#28217}
-
- 04 May, 2015 2 commits
-
-
machenbach authored
Revert of Reland "Wrap v8natives.js into a function." (patchset #2 id:20001 of https://codereview.chromium.org/1123703002/) Reason for revert: [Sheriff] Speculative revert for braking arm64 nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/2314 (reverted already titzer's CL which didn't help) Original issue's description: > Reland "Wrap v8natives.js into a function." > > Committed: https://crrev.com/72ab42172979b60a1b784ea0c6a495d7ee2bba67 > Cr-Commit-Position: refs/heads/master@{#28193} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1127543003 Cr-Commit-Position: refs/heads/master@{#28208}
-
yangguo authored
Review URL: https://codereview.chromium.org/1123703002 Cr-Commit-Position: refs/heads/master@{#28193}
-
- 30 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Wrap v8natives.js into a function. (patchset #2 id:20001 of https://codereview.chromium.org/1109343004/) Reason for revert: [Sheriff] Speculative revert for breaking layout tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2682 See. e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/3130/layout-test-results/http/tests/websocket/workers/worker-reload-diff.txt Original issue's description: > Wrap v8natives.js into a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/ee1b39b4303829e6c6805fe8b2f2602b13f6463a > Cr-Commit-Position: refs/heads/master@{#28174} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1121453003 Cr-Commit-Position: refs/heads/master@{#28182}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1109343004 Cr-Commit-Position: refs/heads/master@{#28174}
-
- 24 Apr, 2015 1 commit
-
-
arv authored
This reverts commit d5565c1f. Getter and setter function names in ES6 are defined as "get foo" and "set foo". This also moves the logic for handling symbols from runtime-function.cc to v8natives.js. BUG=None LOG=N R=adamk@chromium.org Review URL: https://codereview.chromium.org/1093183006 Cr-Commit-Position: refs/heads/master@{#28050}
-
- 17 Apr, 2015 1 commit
-
-
yangguo authored
Review URL: https://codereview.chromium.org/1083083004 Cr-Commit-Position: refs/heads/master@{#27907}
-
- 16 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Migrate error messages, part 2. (patchset #1 id:1 of https://codereview.chromium.org/1086313003/) Reason for revert: [Sheriff]: This changes layout test expectations e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Win/builds/2964 Original issue's description: > Migrate error messages, part 2. > > Motivation for this is reducing the size of the native context. > > Committed: https://crrev.com/d3b788df0a4ccfedbe6e1df5e214cb6ba2792a65 > Cr-Commit-Position: refs/heads/master@{#27878} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1095573002 Cr-Commit-Position: refs/heads/master@{#27889}
-
yangguo authored
Motivation for this is reducing the size of the native context. Review URL: https://codereview.chromium.org/1086313003 Cr-Commit-Position: refs/heads/master@{#27878}
-
- 15 Apr, 2015 1 commit
-
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1090563002 Cr-Commit-Position: refs/heads/master@{#27839}
-
- 14 Apr, 2015 2 commits
-
-
yangguo authored
Revert of Revert of Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1083013002/) Reason for revert: Seems to still break those tests. Original issue's description: > Revert of Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1086683002/) > > Reason for revert: > I don't think this is the cause. > > Original issue's description: > > Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1082703003/) > > > > Reason for revert: > > [Sheriff] Flaky nosnap failures: > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1720 > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3312 > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3313 > > > > Original issue's description: > > > Wrap typed array implementations in functions. > > > > > > R=mvstanton@chromium.org > > > > > > Committed: https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 > > > Cr-Commit-Position: refs/heads/master@{#27784} > > > > TBR=mvstanton@chromium.org,yangguo@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > > > Committed: https://crrev.com/8e3fa7adf20f4f9c9125076a878d601eee7c9f35 > > Cr-Commit-Position: refs/heads/master@{#27789} > > TBR=mvstanton@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/d7fe3b83f5dfa997f0c8a29436a22b999dc49a76 > Cr-Commit-Position: refs/heads/master@{#27803} TBR=mvstanton@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1088863002 Cr-Commit-Position: refs/heads/master@{#27810}
-
yangguo authored
Revert of Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1086683002/) Reason for revert: I don't think this is the cause. Original issue's description: > Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1082703003/) > > Reason for revert: > [Sheriff] Flaky nosnap failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1720 > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3312 > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3313 > > Original issue's description: > > Wrap typed array implementations in functions. > > > > R=mvstanton@chromium.org > > > > Committed: https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 > > Cr-Commit-Position: refs/heads/master@{#27784} > > TBR=mvstanton@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/8e3fa7adf20f4f9c9125076a878d601eee7c9f35 > Cr-Commit-Position: refs/heads/master@{#27789} TBR=mvstanton@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1083013002 Cr-Commit-Position: refs/heads/master@{#27803}
-
- 13 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Wrap typed array implementations in functions. (patchset #1 id:1 of https://codereview.chromium.org/1082703003/) Reason for revert: [Sheriff] Flaky nosnap failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1720 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3312 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3313 Original issue's description: > Wrap typed array implementations in functions. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 > Cr-Commit-Position: refs/heads/master@{#27784} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1086683002 Cr-Commit-Position: refs/heads/master@{#27789}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1082703003 Cr-Commit-Position: refs/heads/master@{#27784}
-
- 10 Apr, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1065863003 Cr-Commit-Position: refs/heads/master@{#27760}
-
- 12 Mar, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1000063002 Cr-Commit-Position: refs/heads/master@{#27161}
-
- 10 Dec, 2014 1 commit
-
-
yangguo authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/789163002 Cr-Commit-Position: refs/heads/master@{#25748}
-