1. 09 Jan, 2017 1 commit
    • littledan's avatar
      [intl] Remove redundant type checking system · 788c96a9
      littledan authored
      Previously, the Intl implementation tracked types two ways:
       - In the intl_initialized_marker_symbol
       - In various named properties of the intl_impl_object_symbol value
      
      As far as I can tell, these will never disagree with each other,
      modulo bugs in Intl itself. This patch removes the second type
      checking system.
      
      This reland includes a fixed type check for
      Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      method which is not bound. All future methods will follow this
      pattern.
      
      The second reland ensures that a newly inserted test is only run
      if Intl is present.
      
      BUG=v8:5751,chromium:677055, v8:4962
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      TBR=yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2623683002
      Cr-Commit-Position: refs/heads/master@{#42152}
      788c96a9
  2. 07 Jan, 2017 2 commits
    • machenbach's avatar
      Revert of [intl] Remove redundant type checking system (patchset #4 id:60001... · b1e4f79e
      machenbach authored
      Revert of [intl] Remove redundant type checking system (patchset #4 id:60001 of https://codereview.chromium.org/2600913002/ )
      
      Reason for revert:
      Breaks noi18n.
      
      Original issue's description:
      > [intl] Remove redundant type checking system
      >
      > Previously, the Intl implementation tracked types two ways:
      >  - In the intl_initialized_marker_symbol
      >  - In various named properties of the intl_impl_object_symbol value
      >
      > As far as I can tell, these will never disagree with each other,
      > modulo bugs in Intl itself. This patch removes the second type
      > checking system.
      >
      > This reland includes a fixed type check for
      > Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      > method which is not bound. All future methods will follow this
      > pattern.
      >
      > BUG=v8:5751,chromium:677055, v8:4962
      > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      >
      > Review-Url: https://codereview.chromium.org/2600913002
      > Cr-Commit-Position: refs/heads/master@{#42118}
      > Committed: https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e594e25
      
      TBR=yangguo@chromium.org,adamk@chromium.org,littledan@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5751,chromium:677055, v8:4962
      
      Review-Url: https://codereview.chromium.org/2617323002
      Cr-Commit-Position: refs/heads/master@{#42119}
      b1e4f79e
    • littledan's avatar
      [intl] Remove redundant type checking system · aa8a2d27
      littledan authored
      Previously, the Intl implementation tracked types two ways:
       - In the intl_initialized_marker_symbol
       - In various named properties of the intl_impl_object_symbol value
      
      As far as I can tell, these will never disagree with each other,
      modulo bugs in Intl itself. This patch removes the second type
      checking system.
      
      This reland includes a fixed type check for
      Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      method which is not bound. All future methods will follow this
      pattern.
      
      BUG=v8:5751,chromium:677055, v8:4962
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      Review-Url: https://codereview.chromium.org/2600913002
      Cr-Commit-Position: refs/heads/master@{#42118}
      aa8a2d27
  3. 27 Dec, 2016 1 commit
  4. 23 Dec, 2016 1 commit
    • littledan's avatar
      [intl] Remove redundant type checking system · 0d5561b6
      littledan authored
      Previously, the Intl implementation tracked types two ways:
       - In the intl_initialized_marker_symbol
       - In various named properties of the intl_impl_object_symbol value
      
      As far as I can tell, these will never disagree with each other,
      modulo bugs in Intl itself. This patch removes the second type
      checking system.
      
      BUG=v8:5751
      
      Review-Url: https://codereview.chromium.org/2591203002
      Cr-Commit-Position: refs/heads/master@{#41941}
      0d5561b6