- 15 Oct, 2015 12 commits
-
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1404943002 Cr-Commit-Position: refs/heads/master@{#31285}
-
mlippautz authored
This reverts commit dc0adc56. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1392853009 Cr-Commit-Position: refs/heads/master@{#31284}
-
jarin authored
Review URL: https://codereview.chromium.org/1398943003 Cr-Commit-Position: refs/heads/master@{#31283}
-
machenbach authored
BUG=v8:4437 LOG=n Review URL: https://codereview.chromium.org/1408693003 Cr-Commit-Position: refs/heads/master@{#31282}
-
mythria authored
Adds support for following operators -Logical and -Logical or -Comma Adds the above bytecodes, support to BytecodeGenerator and BytecodeArrayBuilder to enable it's use, it's implementation and tests. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1399773002 Cr-Commit-Position: refs/heads/master@{#31281}
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1404553003 Cr-Commit-Position: refs/heads/master@{#31280}
-
yangguo authored
R=adamk@chromium.org Review URL: https://codereview.chromium.org/1396323011 Cr-Commit-Position: refs/heads/master@{#31279}
-
littledan authored
An identifier may be parsed in an object literal like {let}, but this was previously left out of lexical name checking. This patch adds that check to prohibit code like let {let} = {let: 1} BUG=v8:4403 LOG=N R=adamk Review URL: https://codereview.chromium.org/1401253003 Cr-Commit-Position: refs/heads/master@{#31278}
-
alph authored
Revert of [x64] Use vcvtlsi2sd when AVX is enabled (patchset #1 id:1 of https://codereview.chromium.org/1404903004/ ) Reason for revert: Caused a crash on Windows Original issue's description: > [x64] Use vcvtlsi2sd when AVX is enabled > > BUG=v8:4406 > LOG=N > > Committed: https://crrev.com/adcbe619a959fe1d8f21d06fbf5984868c4f6b9a > Cr-Commit-Position: refs/heads/master@{#31276} TBR=bmeurer@chromium.org,danno@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4406 Review URL: https://codereview.chromium.org/1396283004 Cr-Commit-Position: refs/heads/master@{#31277}
-
alph authored
BUG=v8:4406 LOG=N Review URL: https://codereview.chromium.org/1404903004 Cr-Commit-Position: refs/heads/master@{#31276}
-
alph authored
R=bmeurer@chromium.org BUG=v8:4406 LOG=N Review URL: https://codereview.chromium.org/1391963005 Cr-Commit-Position: refs/heads/master@{#31275}
-
v8-autoroll authored
Rolling v8/buildtools to ef7f1f539cff0441c4401d8c052e54cfd01bff07 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1396783005 Cr-Commit-Position: refs/heads/master@{#31274}
-
- 14 Oct, 2015 27 commits
-
-
franziska.hinkelmann authored
Section 8.10.5 9a specifies that a property descriptor cannot both have accessors and specify the writability of the property. The previous error message was misleading because it referred to writable rather than specifying the writability (which includes writable: false). BUG=v8:2536 LOG=N Review URL: https://codereview.chromium.org/1399693003 Cr-Commit-Position: refs/heads/master@{#31273}
-
domenic authored
https://codereview.chromium.org/1343113003 introduced a separate InternalPackedArray constructor to the extras utils object, distinct from the one used by natives. However, it omitted the code to set up the methods for that InternalPackedArray. This makes all the basic manipulation methods available. BUG=v8:4276 LOG=Y R=jochen@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1401243003 Cr-Commit-Position: refs/heads/master@{#31272}
-
caitpotter88 authored
Fixes corner case where arrow function ConciseBody expression does not accept 'in' in productions. BUG=v8:4472 LOG=N R=wingo@igalia.com, adamk@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1407633002 Cr-Commit-Position: refs/heads/master@{#31271}
-
domenic authored
When introducing experimental extras I forgot to update this check. That resulted in experimental extras running through the steps normally reserved for non-extra natives: macro and constant expansion, validation, and minification. This causes problems since per the linked bug minification is buggy. R=yangguo@chromium.org, jochen@chromium.org BUG=v8:4064 LOG=N Review URL: https://codereview.chromium.org/1400253002 Cr-Commit-Position: refs/heads/master@{#31270}
-
littledan authored
For an edge case like the following in sloppy mode with ({}) function f() {} a lexical scope needs to be created around the body in order to hold the function declaration, so it can be hoisted according to a loose interpretation of Annex B 3.3 (loose because ES2015 does not permit a function declaration as the body of a with statement). This patch adds that scope. BUG=chromium:542100 LOG=N R=adamk Review URL: https://codereview.chromium.org/1404803002 Cr-Commit-Position: refs/heads/master@{#31269}
-
littledan authored
This patch fixes an obscure edge case for functions defined as the direct body of a for-of/for-in loop, such as the following: for (foo in []) function foo() { return foo; } Here, the first occurrence of foo should point to the outer scope; however, before this patch, it pointed to the inner foo in an invalid way which caused an assertion about the scope chain to fail. This patch fixes the scope chain by inserting an extra scope for the body of the loop, not including the header. BUG=chromium:542099 LOG=N R=rossberg Review URL: https://codereview.chromium.org/1396663004 Cr-Commit-Position: refs/heads/master@{#31268}
-
machenbach authored
BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1402953004 Cr-Commit-Position: refs/heads/master@{#31267}
-
machenbach authored
Revert of Add bailout for large objects when allocating arrays in optimized code. (patchset #1 id:1 of https://codereview.chromium.org/1408553002/ ) Reason for revert: [Sheriff] Breaks deopt fuzzer: http://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/5634 See comment in CL for repro. Original issue's description: > Add bailout for large objects when allocating arrays in optimized code. > > BUG= > > Committed: https://crrev.com/0c81c4e924d7bdb45fce98209c21985d754e047d > Cr-Commit-Position: refs/heads/master@{#31259} TBR=bmeurer@chromium.org,hpayer@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1409543002 Cr-Commit-Position: refs/heads/master@{#31266}
-
jarin authored
This CL re-purposes ValueEffect and Finish as delimiters for regions that are scheduled atomically (renamed to BeginRegion, FinishRegion). The BeginRegion node takes and produces an effect. For the uses that do not care about the placement in the effect chain, it is ok to feed graph->start() as an effect input. The FinishRegion takes a value and an effect and produces a value and an effect. It is important that any value or effect produced inside the region is not used outside the region. The FinishRegion node is the only way to smuggle an effect and a value out. At the moment, this does not support control flow inside the region. Control flow would be hard. During scheduling we do some sanity check, but the checks are not exhaustive. Here is what we check: - the effect chain between begin and finish is linear (no splitting, single effect input and output). - any value produced is consumed by the FinishRegion node. - no control flow outputs. Review URL: https://codereview.chromium.org/1399423002 Cr-Commit-Position: refs/heads/master@{#31265}
-
rmcilroy authored
The AccessorsTable has a non-deterministic iteration order depending on the random seed. This means that the order of the accessor defines could vary and the test which tried to set accessors on two different properties could flakly fail due to the order not being as expected. To fix this I make the test only do a setter on one property (the test-interpreter.cc test does the check on multiple property accessors BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1404793002 Cr-Commit-Position: refs/heads/master@{#31264}
-
martyn.capewell authored
Support negate with shifted input on ARM64 by supporting lhs zero registers for binary operations, and removing explicit Neg instruction support. Review URL: https://codereview.chromium.org/1404093003 Cr-Commit-Position: refs/heads/master@{#31263}
-
rmcilroy authored
Replaces the use of KeyedStoreICGeneric with a vector based KeyedStoreIC for array literal computed stores now that there is a feedback vector slot for these expressions. Removes KeyedStoreICGeneric bytecode since this is no longer necessary. BUG=v8:4280 LOG=N TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1400353002 Cr-Commit-Position: refs/heads/master@{#31262}
-
mbrandy authored
Port f2f46aff Original commit message: The lack of a vector slot for the keyed store operation in filling in non-constant array literal properties led to undesirable contortions in compilers downwind of full-codegen. The use of a single slot to initialize all the array elements is sufficient. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1390353006 Cr-Commit-Position: refs/heads/master@{#31261}
-
adamk authored
Previously, any AstVisitor subclasses which wanted to make use of the shared stack overflow checking code needed to depend on Isolate. With this patch, it will be easy to create a second InitializeAstVisitor overload taking a stack_limit directly, for use in code that has no Isolate available (such as code running in the parser). AstVisitor subclasses which depended upon the isolate() accessor have been fixed to either have their own isolate_ member or get it from somewhere else convenient. Review URL: https://codereview.chromium.org/1387383005 Cr-Commit-Position: refs/heads/master@{#31260}
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1408553002 Cr-Commit-Position: refs/heads/master@{#31259}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1396333004 Cr-Commit-Position: refs/heads/master@{#31258}
-
hpayer authored
BUG=chromium:542823 LOG=n Review URL: https://codereview.chromium.org/1391373004 Cr-Commit-Position: refs/heads/master@{#31257}
-
rmcilroy authored
It is used by AstGraphBuilder (TF) and BytecodeGenerator (Ignition), so is no longer a full-codegen datastructure. Removes full-codegen.h dependency from compiler/ and interpreter/ Review URL: https://codereview.chromium.org/1393393003 Cr-Commit-Position: refs/heads/master@{#31256}
-
bmeurer authored
Perform native context specialization immediately after graph construction (also after inlinee graph construction). This way we can do unified inlining before we go to typing and typed lowering. And we will get better typing due to constants and (checked) type feedback. R=mstarzinger@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1404123002 Cr-Commit-Position: refs/heads/master@{#31255}
-
mvstanton authored
Revert of VectorICs: turn on vectors for STORE and KEYED_STORE ics. (patchset #1 id:1 of https://codereview.chromium.org/1396523005/ ) Reason for revert: Windows crash failure, must be investigated. Original issue's description: > VectorICs: turn on vectors for STORE and KEYED_STORE ics. > > R=jkummerow@chromium.org > BUG= > > Committed: https://crrev.com/52225f39df578e77b4804506ca4bc15e096f5cab > Cr-Commit-Position: refs/heads/master@{#31252} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1398123003 Cr-Commit-Position: refs/heads/master@{#31254}
-
rmcilroy authored
Adds Object literal support to the interpreter. Adds the following bytecodes: - ToName - CreateObjectLiteral. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1386313005 Cr-Commit-Position: refs/heads/master@{#31253}
-
mvstanton authored
R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/1396523005 Cr-Commit-Position: refs/heads/master@{#31252}
-
mstarzinger authored
R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1403613003 Cr-Commit-Position: refs/heads/master@{#31251}
-
machenbach authored
BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1402073003 Cr-Commit-Position: refs/heads/master@{#31250}
-
mstarzinger authored
This is a first prototype for a rudimentary inlining heuristic allowing enabling of general inlining based existing budget flags. Also note that this approach does not yet work for multi-level inlining, for now the list of candidates is processed exactly once. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1406543002 Cr-Commit-Position: refs/heads/master@{#31249}
-
machenbach authored
BUG=v8:2899 LOG=n TBR=jochen@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1396293006 Cr-Commit-Position: refs/heads/master@{#31248}
-
bmeurer authored
R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1401923004 Cr-Commit-Position: refs/heads/master@{#31247}
-
- 13 Oct, 2015 1 commit
-
-
dpranke authored
R=machenbach@chromium.org BUG=chromium:541791 LOG=N Review URL: https://codereview.chromium.org/1396743005 Cr-Commit-Position: refs/heads/master@{#31246}
-