- 01 Dec, 2021 17 commits
-
-
Leszek Swirski authored
Change-Id: I67b62ae71700fab3755f83634fa571b1cea3af4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308890 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78190}
-
Omer Katz authored
The new flags enum had kReduceMemory as the first value, which means it got the value 0 and thus was considered as never set. Bug: v8:12407, chromium:1274954 Change-Id: Ifcce2316c1dcd09a12ad52ef391f513b014aea1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310609Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78189}
-
Leszek Swirski authored
This reverts commit 6aadf0e0. Reason for revert: Maybe add arm64 mac to the CQ next time :) https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release%20builder/7729/overview Original change's description: > [baseline] Add max threads flags for CSP > > Bug: v8:12054 > Change-Id: I49238fe673858b60c2a2a935ed1f45f465269216 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308707 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78187} Bug: v8:12054 Change-Id: I1b53ea3eaaaa39cdb1b9a471aa716b5af7f5e3d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310838 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78188}
-
Victor Gomes authored
Bug: v8:12054 Change-Id: I49238fe673858b60c2a2a935ed1f45f465269216 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308707 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78187}
-
Jakob Gruber authored
When emitting code, character ranges must only specify ranges which the actual subject string (one- or two-byte) may contain. This was not always the case, specifically for ranges with `from <= kMaxUint8` and `to > kMaxUint8`. The reason this is so tricky: 1. not all parts of the pipeline know whether we are compiling for one- or two-byte subjects; 2. for case-insensitive regexps, an out-of-bounds CharacterRange may have an in-bounds case equivalent (e.g. /[Ÿ]/i also matches 'ÿ' == \u{ff}), which only gets added somewhere in the middle of the pipeline. Our current solution is to clamp immediately before code emission. We also keep the existing handling/dchecks of the 0x10ffff marker value which may occur in the two-byte subject case. Bug: v8:11069 Change-Id: Ic7b34a13a900ea2aa3df032daac9236bf5682a42 Fixed: chromium:1275096 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306569 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78186}
-
Omer Katz authored
Enable the prefinalizers scope and add a top level AtomicSweep scope so that prefinalizers are accounted as part of sweeping. Change-Id: I9dade6a2367d30d20395de30c3db84922fee5a49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306567Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78185}
-
Tobias Tebbi authored
We sometimes use ReportError() inside of Torque parser actions. The resulting exception prevented the ParseResultIterator from being consumed completely, which in turn triggered a CHECK failure instead of the correct error message. Change-Id: Ie8dcdf67094e5ad5d68934e8a2921d5f52bd3092 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306973 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78184}
-
Leszek Swirski authored
Add suppose for compiling non-eager, non-top-level inner functions in parallel, using the compiler dispatcher. This behaviour can be enabled with --parallel-compile-tasks-for-lazy. There are a couple of consequences: * To support this we need support for off-thread ScopeInfo deserialization, so this adds that too. * The previous --parallel-compile-tasks flag is renamed to the more descriptive --parallel-compile-tasks-for-eager-toplevel. * Both parallel-compile-tasks flags are moved onto UnoptimizedCompileFlags so that they can be enabled/disabled on a per-compile basis (e.g. enabled for streaming, disabled for re-parsing). * asm.js compilations can now happen without an active Context (in the compiler dispatcher's idle finalization) so we can't get a ContextId for metric reporting; we'd need to somehow fix this if we wanted asm.js UKM but for now it's probably fine. * Took the opportunity to clean up some of the "can preparse" logic in the parser. Change-Id: I20b1ec6a6bacfe268808edc8d812b92370c5840d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3281924 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/main@{#78183}
-
Milad Fa authored
c++17 is being enabled on some platforms: https://crrev.com/c/3306812 which causes gcc to emit the following warning: ``` error: null argument where non-null required (argument 2) memcpy(storage_ + kReturnCount, param_types.data(), ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Unlike clang, gcc is not able to detect if memcpy is actually being executed or not when src is NULL: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=22179 Therefore need to disable this warning at this location. Change-Id: I44da9f698ef724e39bb9c7d4b235d1004d52f491 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308916Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78182}
-
Clemens Backes authored
The {TierUpFunction} method is unused after https://crrev.com/c/3275570. R=jkummerow@chromium.org Bug: v8:12281 Change-Id: I81882a6f1907ff3f4504dea8e9e307cbd674e682 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306980Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78181}
-
Adam Klein authored
MSVC doesn't define __cplusplus appropriately, so use _MSVC_LANG instead. Bug: chromium:1274247 Change-Id: I40ef9f42f4e55b3410f89ff23c228f1b1201c4ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308423 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Adam Klein <adamk@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78180}
-
Leszek Swirski authored
Try blocks (whether catch or finally) will unconditionally create handler tables and start a new basic block for the exception handler. This can accidentally resurrect a dead block when the entire try block is dead (and hence can never enter the exception handler in the first place). Add a deadness check to BuildTryCatch/Finally to fix this. Bug: chromium:1273677 Change-Id: Icda9deb1459e47de5cb83e7b636299e24c3ebe77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306555 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78179}
-
Anton Bikineev authored
Some performance sensitive paths in V8 (compilation/json parsing) or paths with high allocation/freeing throughput can suffer from not being able to reuse recently freed allocations. These paths can also significantly increase the working set and cause large number of page faults. For such paths (at least as an initial measure) we are planning to disable allocation quarantining. The CL provides a way for the embedder to hook in *Scan functions that disable/enable quarantining. It also disables *Scan for json parsing and compilation jobs. Bug: chromium:1249550 Change-Id: I0274f66010435f3d4d091fe70fabcd20f46dc0d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306389 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#78178}
-
Victor Gomes authored
mksnapshot is compiled/ran in the host configuration (usually x64), we need to propagate the flag (using bazel transitions) to tell mksnapshot to generate code to a different architecture. No-Try: true Change-Id: I5923f5895872a8cbf2982925a545855a330c51fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306568 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78177}
-
Nikolaos Papaspyrou authored
Until now, LABs were accessed from generated code via external references, e.g., see NewSpaceAllocationTopAddress() and NewSpaceAllocationLimitAddress(). This patch places them in the IsolateData, so they can be accessed using Isolate-constant offsets. It affects the hot path of all TF generated code. Bug: v8:12428 Change-Id: I7bfd54bea4febead404829d8e0b058b6cf53a374 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3303800 Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78176}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/bf66d37..edf883a CP pull/1948 to rm deprecated/rm header (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/edf883a Silence C++17 deprecation warning on MSVC (Leszek Swirski) https://chromium.googlesource.com/chromium/deps/icu/+/e80c574 icu: Check initialization result (Maksim Ivanov) https://chromium.googlesource.com/chromium/deps/icu/+/e107bc5 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: Iaacec47f0594a38f02f12be412fb4d4e31d733b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310417 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78175}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c829343..99a1dc1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bd8b0c2..5695a84 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8676aa9..5deb9c9 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/1889684..5e0b0d0 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2231b7c..e8c257c R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id9f1b47b5f743886e4d2e2f024e6b790aebf3a5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308834 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78174}
-
- 30 Nov, 2021 23 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e0d5dbf..c829343 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8cf0922..bd8b0c2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/512ca5c..8676aa9 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/e2f3978..bb92160 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9c18fde..401e727 Rolling v8/tools/luci-go: git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f..git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32 Rolling v8/tools/luci-go: git_revision:7422359d33c606e8adb0e9cf461837eb9b49431f..git_revision:e4c95e4e4cdc987f1860e4111589606bcd3a8f32 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ia3f9d9b245812be6b54acbdff4a15bfe5c08a0d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308828 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78173}
-
Frank Tang authored
Implement the changes in https://github.com/tc39/proposal-intl-locale-info/pull/44 So weekInfo will return weekend as an array instead of weekendStart and weekendEnd. Bug: v8:11638 Change-Id: I775b003b36f67179943911faa7f77a323ad9f6f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307685Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78172}
-
Adam Klein authored
This avoids a compile error when building with GCC in C++17 mode. Bug: v8:12449 Change-Id: I14817895d31019fb71fc71b061f2ecf576dbc711 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307102 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78171}
-
Adam Klein authored
This reverts commit 3ee4804f. Reason for revert: breaks blink_unit_tests: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Linux/15074/overview Original change's description: > [top-level-await] Remove --harmony-top-level-await > > TLA has been shipped since v8.9. > > Bug: v8:9344, chromium:1271114 > Change-Id: Ibebf21da8bacb1f0d212390133847495ad8553e5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307103 > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78169} Bug: v8:9344, chromium:1271114 Change-Id: I0874bcaba18fde3b48f5ef7eeae89f2fa4978d51 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308422 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78170}
-
Shu-yu Guo authored
TLA has been shipped since v8.9. Bug: v8:9344, chromium:1271114 Change-Id: Ibebf21da8bacb1f0d212390133847495ad8553e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307103 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78169}
-
Bruce Dawson authored
For years win32-headers.h has "helpfully" set _WIN32_WINNT if it has not already been set. This has caused problems because the value specified in win32-headers.h falls behind that set in the config files. This change removes the fallback and makes it an error to not set this macro in the build config files. This only affects MinGW builds where it has caused confusion. Bug: v8:12099 Change-Id: I013aadc307376fa97afa7b7752910f4fa4a6db82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272648Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#78168}
-
Seth Brenith authored
Currently, JSFinalizationRegistry has a BodyDescriptor that iterates next_dirty as a custom weak field, and it has a WeakListVisitor that cleans up any items from the list that should be removed. However, none of that code is used, because JSFinalizationRegistry objects are created with visitor ID kVisitJSObjectFast. This change gives them a custom visitor ID so that next_dirty can be treated as weak. Bug: v8:12430 Change-Id: I31c1935257ad508b13a3e684662d2ca406d8ed19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307096 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78167}
-
Michael Lippautz authored
Add an approximate bailout for sweeping on allocation to avoid reporting scopes when no work is being done. Bug: v8:12286 Change-Id: I7589429805af702c35d51f9a37eae596268dedc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306983Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78166}
-
Camillo Bruni authored
- Handle empty script sources - Fix list-panel groups, order by count Bug: v8:10644 Change-Id: I03d3915f709d47429040b591c0271e951eca58e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289642 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#78165}
-
Samuel Groß authored
Instead of potentially mapping a larger region than requested, then unmapping parts of it to obtain a mapping with the desired alignment, we now compute the ZX_VM_ALIGN_X constant corresponding to the specified alignment and use that in the call to zx_vmar_map. Bug: chromium:1218005 Change-Id: Ia36de6a06f3f2d625d177320d7e46fd29331f711 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307054Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78164}
-
Camillo Bruni authored
Change-Id: I0df2943f246ea5dc8c56bb196c097dcdd58f1bea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308801Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78163}
-
Camillo Bruni authored
- V8::Deprecate ShutdownPlatform in favor of V8::DisposePlatform - Rename i::V8::TearDown to i::V8::Dispose - Clean up i::V8::Initialize - Remove needless V8::Initialize() calls in cctests - Remove CcTest::DisableAutomaticDispose() - Add checks to Isolate::Allocate and Isolate::Dispose that there is and active platform Change-Id: Iac84f9ade9d1781e9e8b8c88ea8fe74013f51c4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306482 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78162}
-
Igor Sheludko authored
... by using cage-friendly versions of HeapObject::IsBlah(), HeapObject::map(), HeapObject::map_word() and HeapObject::Size() on hot paths. Bug: v8:11880 Change-Id: I70b72e46cc867b6b2ddbc48cd5e6a74ae4208397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308800Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78161}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: chromium:1274976 Change-Id: I7878c44fcf11ef7b8b850ff50cdd1062c6e8122a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306979Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78160}
-
Clemens Backes authored
The logic for printing a safepoint table is currently duplicated for Wasm code and on-heap code, with slight differences. This CL provides a central {SafepointTable::Print} method that is used in both scenarios. The format is slightly changed to explicitly specify which bitmap corresponds to stack slots and which one to registers. R=jkummerow@chromium.org Bug: v8:12401 Change-Id: I67366b1f9a92450a6ebec4210ab4811800a54f34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306976 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#78159}
-
Jakob Gruber authored
--predictable requires deterministic heap allocation sequences. Guarantee these for compilation dependency installation by sorting the dependency list if --predictable is enabled. Bug: v8:12397 Change-Id: Ia4660f2249a1c3390a932ae057a5b4d4537497ab Fixed: v8:12447 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306488 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78158}
-
Leszek Swirski authored
It's deprecated in C++17 and not needed (it was needed for static const, but not for constexpr). It's needed in C++14, but can trigger deprecation errors in C++17, so include it conditionally on __cplusplus. Bug: chromium:1274247 Change-Id: I92524f377bb92ac2aa008f15830920786a1c1432 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308795 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#78157}
-
Igor Sheludko authored
This will allow making HeapObject::IsBlah() checks faster when external code space is enabled. Bug: v8:11880 Change-Id: I68473ba88063c555c90330c9748462adeb35aa0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308797Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78156}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: I557c4d6f83bc3203c115824e26fcb2ecf0473e1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308796 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78155}
-
Tim van der Lippe authored
While debugging, we discovered a Blink misconfiguration in the navigator.mimeTypes object. We fixed the issue in https://crrev.com/c/3303674, but let's also document on the V8 side when you can hit the DCHECK and where to look next. R=yangguo@chromium.org Bug: chromium:1262066 Change-Id: I256331ec4296963deb152485d8c6699b75c42e37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3302804 Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/main@{#78154}
-
Igor Sheludko authored
This will allow making HeapObject::IsBlah() checks faster when external code space is enabled. Bug: v8:11880 Change-Id: Ibee4e19859c23f11316e3cfd7961f58d8e58240a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3301478 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#78153}
-
Leszek Swirski authored
This reverts commit 05da6708. Reason for revert: Guess I was wrong: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20ASAN%20no%20inline%20-%20release%20builder/25729/overview Original change's description: > [turbofan] Remove out-of-line defn of constexpr vars > > It's deprecated in C++17 and not needed (it was needed for > static const, but not for constexpr) > > Bug: chromium:1274247 > Change-Id: If92d7b6300493cb186ff2ade8f6b6a4820d5a264 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306429 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78149} Bug: chromium:1274247 Change-Id: I26f8377b331895363fec5329a08261ebec3696ef No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306431 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78152}
-
Michael Lippautz authored
The CL converts uses of v8::internal::Worklist to heap::base::Worklist which does not require to know the number of tasks working with the work list upfront. heap::base::Worklist is the common implementation for V8's heap and cppgc and should be used/optimized going forward. Bug: v8:12426 Change-Id: Id6ef1aa05df858b01df90d653b6421a9bb68b997 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306382Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78151}
-