1. 12 Jun, 2013 1 commit
  2. 06 Jun, 2013 1 commit
  3. 05 Apr, 2013 1 commit
    • mstarzinger@chromium.org's avatar
      Refactor parser mode configuration for correctness · d7167867
      mstarzinger@chromium.org authored
      This patch refactors the parser and preparser interface to be more
      readable and type-safe.  It has no behavior changes.
      
      Previously, parsers and preparsers were configured via bitfield called
      parser_flags in the Parser constructor, and flags in
      PreParser::PreParseProgram, ParserApi::Parse, and ParserApi::PreParse.
      This was error-prone in practice: six call sites passed incorrectly
      typed values to this interface (a boolean FLAG value, a boolean false
      and a boolean true value).  None of these errors were caught by the
      compiler because it's just an "int".
      
      The parser flags interface was also awkward because it encoded a
      language mode, but the language mode was only used to turn on harmony
      scoping or not -- it wasn't used to actually set the parser's language
      mode.
      
      Fundamentally these errors came in because of the desire for a
      procedural parser interface, in ParserApi.  Because we need to be able
      to configure the parser in various ways, the flags argument got added;
      but no one understood how to use the flags properly.  Also they were
      only used by constructors: callers packed bits, and the constructors
      unpacked them into booleans on the parser or preparser.
      
      The solution is to allow parser construction, configuration, and
      invocation to be separated.  This patch does that.
      
      It passes the existing tests.
      
      BUG=
      
      Review URL: https://codereview.chromium.org/13450007
      Patch from Andy Wingo <wingo@igalia.com>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      d7167867
  4. 02 Apr, 2013 2 commits
  5. 07 Dec, 2012 1 commit
  6. 30 Apr, 2012 1 commit
  7. 12 Mar, 2012 1 commit
  8. 23 Feb, 2012 1 commit
  9. 08 Feb, 2012 1 commit
  10. 13 Jan, 2012 1 commit
  11. 25 Nov, 2011 1 commit
  12. 24 Nov, 2011 1 commit
    • keuchel@chromium.org's avatar
      Introduce extended mode. · 1e9a7267
      keuchel@chromium.org authored
      This CL introduces a third mode next to the non-strict
      (henceforth called 'classic mode') and 'strict mode'
      which is called 'extended mode' as in the current
      ES.next specification drafts. The extended mode is based on
      the 'strict mode' and adds new functionality to it. This
      means that most of the semantics of these two modes
      coincide.
      
      The 'extended mode' is entered instead of the 'strict mode'
      during parsing when using the 'strict mode' directive
      "use strict" and when the the harmony-scoping flag is
      active. This should be changed once it is fully specified how the 'extended mode' is entered.
      
      This change introduces a new 3 valued enum LanguageMode
      (see globals.h) corresponding to the modes which is mostly
      used by the frontend code. This includes the following
      components:
      * (Pre)Parser
      * Compiler
      * SharedFunctionInfo, Scope and ScopeInfo
      * runtime functions: StoreContextSlot,
        ResolvePossiblyDirectEval, InitializeVarGlobal,
        DeclareGlobals
      
      The old enum StrictModeFlag is still used in the backend
      when the distinction between the 'strict mode' and the 'extended mode' does not matter. This includes:
      * SetProperty runtime function, Delete builtin
      * StoreIC and KeyedStoreIC
      * StubCache
      
      Review URL: http://codereview.chromium.org/8417035
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10062 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      1e9a7267
  13. 01 Nov, 2011 1 commit
  14. 27 Oct, 2011 1 commit
  15. 24 Oct, 2011 1 commit
  16. 17 Oct, 2011 2 commits
  17. 12 Oct, 2011 1 commit
  18. 08 Sep, 2011 2 commits
  19. 07 Sep, 2011 1 commit
  20. 16 Aug, 2011 1 commit
  21. 06 Jul, 2011 2 commits
  22. 01 Jul, 2011 2 commits
  23. 24 Jun, 2011 1 commit
  24. 20 Jun, 2011 1 commit
  25. 07 Jun, 2011 1 commit
  26. 24 May, 2011 1 commit
  27. 19 May, 2011 2 commits
  28. 06 May, 2011 1 commit
  29. 04 Feb, 2011 1 commit
  30. 14 Jan, 2011 1 commit
  31. 04 Jan, 2011 1 commit
  32. 29 Nov, 2010 1 commit
  33. 23 Nov, 2010 1 commit
  34. 18 Nov, 2010 1 commit