- 14 Sep, 2018 40 commits
-
-
PhistucK authored
Previously, DateTimeFormat.prototype.formatToParts returned an object with the property key 'dayperiod' which is incorrect as per the spec. This patch updates the property key to say 'dayPeriod', making this spec compliant. R=cira@chromium.org Bug: chromium:865351 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I37f50797387bc69d5e29d7c2911bc5cc0fad37ac Reviewed-on: https://chromium-review.googlesource.com/1145304Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: PhistucK <phistuck@gmail.com> Cr-Commit-Position: refs/heads/master@{#55922}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6cd63aa164af2e3b4a846933899a9a1baa54b1ef Reviewed-on: https://chromium-review.googlesource.com/1224032Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55921}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I85fc4ba0e4188d60d15e389e4682541c65324b55 Reviewed-on: https://chromium-review.googlesource.com/1227071 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I20fd23b5370d15dddc913f6bdb05e649d71c2059 Reviewed-on: https://chromium-review.googlesource.com/1224373Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55919}
-
Marja Hölttä authored
This reverts commit ad72d195. Reason for revert: Build failures on *san Original change's description: > [in-place weak refs] Fix MaybeObject function names > > E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap > object, instead returned a weakly pointed heap object. Change the function names > (in this case, to "GetHeapObjectIfWeak") to reflect this. > > Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). > > BUG=v8:7308 > > Change-Id: I4ef078572b4f4415afe7e2e706d3bd684e16e47d > Reviewed-on: https://chromium-review.googlesource.com/1219025 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55906} TBR=ulan@chromium.org,marja@chromium.org,yangguo@chromium.org,ahaas@chromium.org,tebbi@chromium.org,ishell@chromium.org Change-Id: I054b578518e3f6fd7dbcddf0b56cc018726c1e7a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1226874Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55918}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I41b3d7c41ee9f8ff12f70feddcf38f2c9efc5049 Reviewed-on: https://chromium-review.googlesource.com/1224056Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55917}
-
Benedikt Meurer authored
When the backend sees an Int64Constant in a translation, this currently indicates the value is a Smi value. Bug: v8:8015 Change-Id: I1527a6374b395d3a33ae0339df4b563084ea678e Reviewed-on: https://chromium-review.googlesource.com/1226593Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55916}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I56b730814539df7fdc2e1e5fb06c8b2b104b5fc8 Reviewed-on: https://chromium-review.googlesource.com/1223830 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5404f0b94c7badce2c59d8eac2c32810f4fa2c3c Reviewed-on: https://chromium-review.googlesource.com/1224317Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55914}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ifb940f40d4145a6074702a3d870242aeca625d96 Reviewed-on: https://chromium-review.googlesource.com/1224092Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55913}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I4236a2cf85a414f9d7d1fbdaaaaf1c72a84f02e3 Reviewed-on: https://chromium-review.googlesource.com/1224093Reviewed-by:
-
Ivica Bogosavljevic authored
Port 6346cdb6 Change-Id: I397ff152f363a3f0345105fbdf5d939bc3245fb4 Reviewed-on: https://chromium-review.googlesource.com/1225707Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55911}
-
Yang Guo authored
R=jgruber@chromium.org Bug: chromium:882664 Change-Id: I12248de9a01839433daa40e8273a18a15a9867bb Reviewed-on: https://chromium-review.googlesource.com/1221547 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
It's the same as JSFunction::BodyDescriptor, so the special cases can be removed. This is a pre-step for refactoring BodyDescriptorWeak away. BUG=v8:7308 Change-Id: Id65ce79f044960168d290fbbfdbc2a7aa854230e Reviewed-on: https://chromium-review.googlesource.com/1226592 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55909}
-
Ulan Degenbaev authored
Currently dead ArrayBuffers with external memory are discovered and freed in sweeper. If sweeping is slow, it can take long time until the external memory is freed. This is why wasm currently forces at least two back-to-back GCs on allocaiton failure. This patch ensures eager finalization of ArrayBuffers on critical memory pressure notification. Bug: v8:7621 Change-Id: I96c75922577388cafab049f5cbce01d636a7b400 Reviewed-on: https://chromium-review.googlesource.com/1224328 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib48ead467519354715e3bc0e3f718cbdda28f989 Reviewed-on: https://chromium-review.googlesource.com/1225704 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Marja Hölttä authored
E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap object, instead returned a weakly pointed heap object. Change the function names (in this case, to "GetHeapObjectIfWeak") to reflect this. Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). BUG=v8:7308 Change-Id: I4ef078572b4f4415afe7e2e706d3bd684e16e47d Reviewed-on: https://chromium-review.googlesource.com/1219025Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4f9eb0fedbe1d35a571f3d5b111705a820edfb5b Reviewed-on: https://chromium-review.googlesource.com/1224377 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Stephan Herhut authored
The current formatting makes the build command seem to be one line, whereas it should be two. Change-Id: I9abe7cf3351aae1f1df51bf1e3ca46a0ed2c012b Reviewed-on: https://chromium-review.googlesource.com/1225708Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#55904}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I2a7a8c8447d2835205f7a506f04efe4d1801b934 Reviewed-on: https://chromium-review.googlesource.com/1224316Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ie0591d8f32ebd4b9681ef9eeec092e30b73bd0b8 Reviewed-on: https://chromium-review.googlesource.com/1224172Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie05d919cfd5cc4447c00603c8a46e975ad85cce3 Reviewed-on: https://chromium-review.googlesource.com/1224378Reviewed-by:
-
Clemens Hammacher authored
This test was disabled because of flakes. This should be fixed now. R=ahaas@chromium.org Bug: v8:7872 Change-Id: I288f3776ca7f946caf20a66f1cdf5d37bd6ba245 Reviewed-on: https://chromium-review.googlesource.com/1224376Reviewed-by:
-
Michael Achenbach authored
The test debug-live-edit-recursion flakily fails predictable testing and should match the status file rule debug-liveedit-* that skips the other ~10 liveedit tests. Bug: v8:8147 Change-Id: I9d88b44d97daa09914e0fa46fb204e85c1e7344c Reviewed-on: https://chromium-review.googlesource.com/1224430Reviewed-by:
-
Clemens Hammacher authored
This implements the five sign extension opcodes for ia32 and x64 (and bails out on other architectures). R=titzer@chromium.org Bug: v8:6600 Change-Id: Ibb8bae0e229e276b346f2d054b51864a0995a096 Reviewed-on: https://chromium-review.googlesource.com/1174533 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55898}
-
Jakob Gruber authored
This reverts commit 99e13e58. Reason for revert: Reverting in favor of a general mechanism for this in Torque. Original change's description: > [builtins] Add FastCallFunction builtin that elides some checks > > This CL adds a new "Call" stub that can be used by builtins that will > call the same JS call-back function often (e.g. compare function in > Array.p.sort). The checks have to be done upfront once, but can then > be omitted. > > R=jgruber@chromium.org > > Bug: v8:7861 > Change-Id: Id6e4ca27c3d488a7b1f708cbcb4cbe6cc382513e > Reviewed-on: https://chromium-review.googlesource.com/1208574 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55769} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7861 Change-Id: I47260993ef2a16bd5348bb0b46da4d34d33ea10b Reviewed-on: https://chromium-review.googlesource.com/1226871 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I8546c58afbac278a764067173570b433dff6674d Reviewed-on: https://chromium-review.googlesource.com/1224413Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55896}
-
Clemens Hammacher authored
We are currently wrapping the pointer to the instruction start in a Foreign. The argument buffer, which is also a raw pointer, is passed directly though. This CL changes this to also pass the code entry as a raw pointer. R=mstarzinger@chromium.org Change-Id: Id7344efa589a5297339ec01c3cfa7688bcc706b3 Reviewed-on: https://chromium-review.googlesource.com/1226970Reviewed-by:
-
Florian Sattler authored
NOTRY=true Change-Id: I28637031771ab994c3f4b7fe642eddfce9c69b16 Reviewed-on: https://chromium-review.googlesource.com/1225976Reviewed-by:
-
Creddy authored
This reland of the commit e938b7a3. Original change's description: > Enable OneShot optimizations by default > > BUG=v8:8072 > > Change-Id: I2068d66644628fe1de7a6be30b8d43ecfae04e93 > Reviewed-on: https://chromium-review.googlesource.com/1220047 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55875} TBR=cbruni@chromium.org,chandanreddy@google.com Change-Id: I2152d4f3886913ef7ffabf8611c3448299560d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8072 Reviewed-on: https://chromium-review.googlesource.com/1224933 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
-
Georg Neis authored
Tbr: hpayer@chromium.org Change-Id: I3f10ee70a9f9990e0259095826ac40371a96bac5 Reviewed-on: https://chromium-review.googlesource.com/1225756 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: If90c13658713cbfdf06200e49773e67495dce85b Reviewed-on: https://chromium-review.googlesource.com/1225754Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55891}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I3077883a8509a988090d2c051e5bd85c139a38e6 Reviewed-on: https://chromium-review.googlesource.com/1224326 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55890}
-
Georg Neis authored
Additionally: - Remove partiality from ContextRef::previous as long as we don't need it. - Fix a nasty bug in serialization dispatch (the order of types was incorrect). Bug: v8:7790 Change-Id: I354a69cf37e1dcdd691aab8af668c5cef165cf1e Reviewed-on: https://chromium-review.googlesource.com/1224438Reviewed-by:
-
Michael Achenbach authored
This reverts commit 836773c0. Reason for revert: Breaks full-debug support: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20full%20debug/5493 Original change's description: > Implement v8::internal::MicrotaskQueue::EnqueueMicrotask > > This adds `queue` and `pending_microtask_count` as members of > v8::internal::MicrotaskQueue, and implements its EnqueueMicrotask. > The implementation itself is similar to Isolate::EnqueueMicrotask. > > Bug: v8:8124 > Change-Id: Idb5c50b2add96b72cbe9e36aeec7cb568072f0cb > Reviewed-on: https://chromium-review.googlesource.com/1205430 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55884} TBR=ulan@chromium.org,adamk@chromium.org,hpayer@chromium.org,tzik@chromium.org Change-Id: I299884eb6b41fcbff7c486cad636ab7b9821dfe3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8124 Reviewed-on: https://chromium-review.googlesource.com/1225752Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55888}
-
Stephan Herhut authored
Reduce the number of workers in the atomic compare-exchange test to make it run faster on systems with few cores. Bug: v8:8164 Change-Id: I4de22863e1f2a44d9da4416161d08f5acfcece22 Reviewed-on: https://chromium-review.googlesource.com/1224771 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This adds support to TurboFan's representation selection for the Word64 representation, and makes use of that to handle indices for memory access and allocation instructions (i.e. LoadElement, StoreElement, Allocate, etc.). These instructions had previously used Word32 as representation for the indices / sizes, and then internally converted it to the correct representation (aka Word64 on 64-bit architectures) later on, but that was kind of brittle, and sometimes led to weird generated code. The change thus only adds support to convert integer values in the safe integer range from all kinds of representations to Word64 (on 64-bit architectures). We don't yet handle the opposite direction and none of the representation selection heuristics for the numeric operations were changed so far. This will be done in follow-up CLs. This CL itself is supposed to be neutral wrt. functionality, and only serves as a starting point, and a cleanup for the (weird) implicit Word64 index/size handling. Bug: v8:7881, v8:8015, v8:8171 Design-Document: http://bit.ly/turbofan-word64 Change-Id: I3c6961a0e96cbc3fb8ac9d3e1be8f2e5c89bfd25 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel Reviewed-on: https://chromium-review.googlesource.com/1224932 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This truncation doesn't have a proper meaning anyways and has never been used inside the representation selection. For pointer fields we also don't need to pass on a truncation anyways. Bug: v8:8015 Change-Id: I5ff49e20b70fa70d6bcf7401a357cd7ad9f1a938 Reviewed-on: https://chromium-review.googlesource.com/1226870 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
tzik authored
This adds `queue` and `pending_microtask_count` as members of v8::internal::MicrotaskQueue, and implements its EnqueueMicrotask. The implementation itself is similar to Isolate::EnqueueMicrotask. Bug: v8:8124 Change-Id: Idb5c50b2add96b72cbe9e36aeec7cb568072f0cb Reviewed-on: https://chromium-review.googlesource.com/1205430 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: If9a66df529dc5870f6d5146d9a83d22367ffdc59 Reviewed-on: https://chromium-review.googlesource.com/1224114Reviewed-by:
-
