1. 07 Jul, 2020 1 commit
  2. 23 Jun, 2020 1 commit
  3. 07 Nov, 2019 1 commit
    • Sigurd Schneider's avatar
      [coverage] Fix coverage with default arguments · 0dfd9ea5
      Sigurd Schneider authored
      In the presence of default arguments, the body of the function gets
      wrapped into another block. This caused our trailing-range-after-return
      optimization to not apply, because the wrapper block had no source
      range assigned. This CL correctly assignes a source range to that block,
      which allows already present code to handle it correctly.
      
      Note that this is not a real coverage bug; we've just been reporting
      whitespace as uncovered. We're fixing it for consistency.
      
      Originally reported on github.com/bcoe/c8/issues/66
      
      Bug: v8:9952
      Change-Id: Iab3905f558eb99126e0dad8072d03d0a312fdcd3
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903430
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#64836}
      0dfd9ea5
  4. 05 Sep, 2019 1 commit
    • Sigurd Schneider's avatar
      [debugger] Fix code coverage for async functions · 3b0f89d0
      Sigurd Schneider authored
      Async functions were not correctly fixed up for code coverage, which
      caused an additional uncovered range to be reported between a return
      statement and the closing bracket.
      
      This CL adds code that detects such ranges, and removes them, similarly
      to how the ranges are removed for normal functions. The removal process
      is different, because the parser rewrites async functions to contain a
      try-catch handling promise rejection.
      
      Change-Id: I73b08d64be74d26c32f2f9652d027430d4671251
      
      Bug: chromium:981313, v8:8381
      Change-Id: I82a7f0c54d3a48609ef5255a7659d9557e163566
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782837Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63561}
      3b0f89d0