- 25 Oct, 2017 29 commits
-
-
Leszek Swirski authored
Expressions of the form a_0 + a_1 + a_2 + a_3 + ... + a_n seem to be reasonably common for cases such as building templates. However, parsing these expressions results in a n-deep expression tree: ... / + / \ + a_2 / \ a_0 a_1 Traversing this tree during compilation can cause a stack overflow when n is large. Instead, for left-associate operations such as add, we now build up an n-ary node in the parse tree, of the form n-ary + / | \ / | ... \ a_0 a_1 a_n The bytecode compiler can now iterate through the child expressions rather than recursing. This patch only supports arithmetic operations -- subsequent patches will enable the same optimization for logical tests and comma expressions. Bug: v8:6964 Bug: chromium:724961 Bug: chromium:731861 Bug: chromium:752081 Bug: chromium:771653 Bug: chromium:777302 Change-Id: Ie97e4ce42506fe62a7bc4ffbdaa90a9f698352cb Reviewed-on: https://chromium-review.googlesource.com/733120 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48920}
-
Leszek Swirski authored
Use an upper limit search followed by a binary search in the expression depth test. As our maximum expression depths increase, a simple linear search wastes cycles. Bug: v8:6964 Change-Id: I0669e4090f6cc1628d1dec475b9bd8ff52be3f7d Reviewed-on: https://chromium-review.googlesource.com/735346 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48919}
-
Jaroslav Sevcik authored
This reverts commit 37b4b2f1. Reason for revert: Likely breaking canary. Original change's description: > [turbofan] Prune control flow based on failed map checks and comparisons. > > This introduces unreachable state into load elimination. We mark state > as unreachable if we know statically that a map check would fail. > When processing effect phis, we disconnect unreachable state's > control from the effect phi's merge, and point it to RuntimeAbort. > The control input to the merge is then updated with Dead. Dead > code elimination prunes the merge, phis and effect phis. > > Bug: v8:6396 > Change-Id: I01874b576e548747a915c7b645b96ebaa6f6700d > Reviewed-on: https://chromium-review.googlesource.com/730754 > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48810} TBR=jarin@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6396, chromium:777843 Change-Id: I6fac6f86e138f33756e688ec30424cb940690dae Reviewed-on: https://chromium-review.googlesource.com/737829Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48918}
-
Georgia Kouveli authored
Bug: v8:6644 Change-Id: I47482fa15fa89b1d9cd6c943e89dcc543596de5d Reviewed-on: https://chromium-review.googlesource.com/738093Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#48917}
-
Michal Majewski authored
This is a reland of a24c7c9a Original change's description: > Reuse arch/mode discovery in deopt fuzzer > > Bug: v8:6917 > Change-Id: I1b7169c8702c8649812b17579d38d64de676ed60 > Reviewed-on: https://chromium-review.googlesource.com/723420 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48838} Bug: v8:6917 Change-Id: I03b2c288257d44c2df9d0fa6cf4750d1c5719d59 Reviewed-on: https://chromium-review.googlesource.com/735719 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48916}
-
jgruber authored
Bug: Change-Id: Ib05bf9abb43872c69102f839876a869c55f8ca48 Reviewed-on: https://chromium-review.googlesource.com/737798Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48915}
-
Loo Rong Jie authored
Bug: v8:6996,v8:6443 Change-Id: If968750687a8a7c0d1d4c1991c64236ebed55a5b Reviewed-on: https://chromium-review.googlesource.com/737490Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#48914}
-
Michael Lippautz authored
This reverts commit e26cd874. Reason for revert: The issue has been fixed. See related bug for description and CLs. Original change's description: > [heap] Add TSAN suppression for lock-order inversion in Scavenger > > The Scavenger currently requires taking the lock for OLD->NEW processing > and can also take another lock for sweeping a different page. > > Since order of pages during scavenge and sweep is unstable this may > result in lock order inversion reports on TSAN when long-running > programms are only executed on a single thread. > > The report is a false positve, hence flag it as suppression until we > redesign this particular piece. > > No-try: true > Bug: v8:6923 > Change-Id: I82355be1c8d83ea61cc21152aeb10b58b1dc4b86 > Reviewed-on: https://chromium-review.googlesource.com/716261 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48504} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6923 Change-Id: I7711466c6e2175dcab8d64d6a642e458e1cde3f5 Reviewed-on: https://chromium-review.googlesource.com/738110Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
We were already handling the case that a called import throws, but if it returned an error which is not convertible to a number, we failed with a CHECK error. This CL fixes this. R=titzer@chromium.org Bug: chromium:771970 Change-Id: I6c9983459109d49c43304610b696d49de986a250 Reviewed-on: https://chromium-review.googlesource.com/735354 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48912}
-
Georg Neis authored
E.g. use TrueConstant() instead of BooleanConstant(true) and NullConstant() instead of HeapConstant(factory...null_value()). R=jkummerow@chromium.org Bug: Change-Id: I0588d71940d8baf289eb8f8e6c8d20aa717d57f6 Reviewed-on: https://chromium-review.googlesource.com/735681 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48911}
-
Ulan Degenbaev authored
The IsWhite check in the write barrier uses word size memory operations. It should use 32-bit cell size operation instead. Bug: v8:6955 Change-Id: I5bbcd99dcd7e3d435f96022a745a6c80c83eb3b3 Reviewed-on: https://chromium-review.googlesource.com/735153Reviewed-by:
-
Andreas Haas authored
R=titzer@chromium.org Change-Id: I028ec3b2e511079b14454fe0c138715c52e492b9 Reviewed-on: https://chromium-review.googlesource.com/737790Reviewed-by:
-
Michael Lippautz authored
All use cases of the RecursiveMutex have been removed. Bug: v8:6923 Change-Id: I25aeee2447db185dbaacf96ab06a660834a408b7 Reviewed-on: https://chromium-review.googlesource.com/735345Reviewed-by:
-
Ben L. Titzer authored
Pending the outcome of the discussion on the GitHub issue: https://github.com/WebAssembly/design/issues/1138 R=clemensh@chromium.org,ahaas@chromium.org Bug: Change-Id: I54a218a93c24cb221b9f0195e2b1abbe6208d8e2 Reviewed-on: https://chromium-review.googlesource.com/735343Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48907}
-
Clemens Hammacher authored
Now that https://crrev.com/c/728026 has landed, we can construct the constexpr RegLists using symbolic register names instead of hard-coding the register codes. R=titzer@chromium.org Bug: v8:6600 Change-Id: I21e46aeb5e8598a56f641341bcd7cf718fe4fbf9 Reviewed-on: https://chromium-review.googlesource.com/735548Reviewed-by:
-
Benedikt Meurer authored
This optimization was disabled because 32-bit builds didn't properly find certain integer keys in maps anymore. The reason was that the runtime wasn't using ComputeIntegerHash for the full Signed32 range, but only for the SignedSmall range. This change improves the ARES-6 Basic test by around 6-7% on the steady state. Bug: chromium:77459, v8:6410, v8:6354, v8:6278, v8:6344 Change-Id: Ifae64e6b23ca8acee4c792be299f64caf951242f Reviewed-on: https://chromium-review.googlesource.com/737871Reviewed-by:
-
Michael Achenbach authored
This reverts commit eeaffa9f. Reason for revert: Breaks msan compile (uninitialized value in snapshot): https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/17824 Original change's description: > [objects] Introduce {CodeDataContainer} object type. > > This introduces the {CodeDataContainer} as a container for all mutable > fields associated with a {Code} object. For now only the kind-specific > flags are moved, but more fields can/will be moved gradually. The goal > is to make all fields in the {Code} header be immutable eventually. > > R=jarin@chromium.org > BUG=v8:6792 > > Change-Id: I2eeba893afaba877fb6117e1f18371898c3a175e > Reviewed-on: https://chromium-review.googlesource.com/732987 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48902} TBR=mstarzinger@chromium.org,jarin@chromium.org Change-Id: I74fe833b074752d640cff4aa4680f250e1bd8780 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6792 Reviewed-on: https://chromium-review.googlesource.com/738029Reviewed-by:
-
Marja Hölttä authored
- Make it possible to store quarter-bytes instead of full bytes. - Don't store is_used; it can be recovered correctly based on the actual full parse (when a lazy function is eventually called) and has_forced_scope_allocation. - With the is_used change, the old testing approach (which compared a scope for which we didn't do scope allocation to the baseline) no longer made sense. Replaced it with a new testing approach, which is also closer to the actual usage. - First version (reverted): https://chromium-review.googlesource.com/725422 BUG=v8:5516 Change-Id: I1468af6670b689a104bd867377caa1d236070820 Reviewed-on: https://chromium-review.googlesource.com/733123Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48903}
-
Michael Starzinger authored
This introduces the {CodeDataContainer} as a container for all mutable fields associated with a {Code} object. For now only the kind-specific flags are moved, but more fields can/will be moved gradually. The goal is to make all fields in the {Code} header be immutable eventually. R=jarin@chromium.org BUG=v8:6792 Change-Id: I2eeba893afaba877fb6117e1f18371898c3a175e Reviewed-on: https://chromium-review.googlesource.com/732987Reviewed-by: -
Ulan Degenbaev authored
Body descriptors are used by marking and scavenging visitors. Change-Id: I6912bb5b924755db5750f0a3b1e4909bff5375c7 Reviewed-on: https://chromium-review.googlesource.com/732978Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48901}
-
Clemens Hammacher authored
Otherwise, the quiet NaN bit might flip already when loading the float/double from memory or storing it. This fixes another NaN bit flip which happened on a single bot only. R=titzer@chromium.org Bug: v8:6954 Change-Id: Ica9be71db9c5b505302686e9c0a4b1cae020a7e4 Reviewed-on: https://chromium-review.googlesource.com/735320Reviewed-by:
-
Michaël Zasso authored
We found this while trying to integrate V8 6.3 into Node.js. One of the tests started to crash on Windows. https: //github.com/nodejs/node/pull/16271#issuecomment-337790715 Bug: Change-Id: I82514ff7b9ca6a2b5c4489fe7388c4beda9931c9 Reviewed-on: https://chromium-review.googlesource.com/735400Reviewed-by:
-
Benedikt Meurer authored
Elements on typed arrays are never looked up in the prototype chain, so there's no point in depending on the prototype chain validity cells for keyed stores to typed arrays. You just risk going megamorphic for unrelated changes. Bug: v8:6999 Change-Id: Id831de42a2c9eadfd5317ee9b5dbfaa207f236fe Reviewed-on: https://chromium-review.googlesource.com/737789Reviewed-by:
-
Georg Neis authored
R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I55c11c1328c92983286a8173795ce38f0b1e9e8e TBR: yangguo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/735322Reviewed-by:
-
Georg Neis authored
Bug: v8:6791 Change-Id: Id34db2021c02b885be3f300648d5941362381d0b Reviewed-on: https://chromium-review.googlesource.com/735561 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
as opposed to waiting until state() is PREMONOMORPHIC like named Load/StoreICs do. Keyed ICs do not have PREMONOMORPHIC state. Bug: v8:6999 Change-Id: If37705d3301fb93a2fc2bf10fdeb255ff06fdb5e Reviewed-on: https://chromium-review.googlesource.com/737655 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibd55b6b2e375f53b527168995d0e89bd7a8109e4 Reviewed-on: https://chromium-review.googlesource.com/737531 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48894}
-
Jaroslav Sevcik authored
I am not committing the regression test from the bug because it takes ages to run, but I have locally verified that it passes now. Bug: chromium:776645 Change-Id: Ia7128d9fa3cf864b1c1b646802a973fe41d4c4ae Reviewed-on: https://chromium-review.googlesource.com/735484Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48893}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f2dd2d1..2647b49 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/22e74eb..e2235db Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2a5ee2c..fb9e0ad TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I3081ed8d8e779c661f7d59a5ee0fd3ce6eaf3371 Reviewed-on: https://chromium-review.googlesource.com/737252Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48892}
-
- 24 Oct, 2017 11 commits
-
-
Camillo Bruni authored
This CL makes --trace-maps available in the default build by disabling certain expensive/intrusive features. This is an intermediate step to be able to write proper tests for --trace-maps and the new map-processor. Change-Id: Ib6a8fc9c77796c106d3af9d741d48abe6c6b9099 Reviewed-on: https://chromium-review.googlesource.com/734648Reviewed-by:
-
Camillo Bruni authored
Bug: v8:6921 Change-Id: Icbbb7c08b9ff9f20339988770d88d96653a9ddef Reviewed-on: https://chromium-review.googlesource.com/718656 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Mircea Trofin authored
It appears in the cctest context, both the old STUB, and the current WASM_FUNCTION "just work"; however, in the upcoming off-the-gc wasm world, we codegen call sites differently on x64 - far calls for js-to-wasm (this case), and near calls otherwise. Bug: Change-Id: Iebf8acf164f07742fc367b7bbf266913dbc60c46 Reviewed-on: https://chromium-review.googlesource.com/735131Reviewed-by:
-
Camillo Bruni authored
- Remove Log::MessageBuilder::AppendAddress - Remove Log::MessageBuilder::Append(String*) - Fix pointer (void*) formatting Change-Id: I806892cbc77b635d1e03b5d7282569be2f714356 Reviewed-on: https://chromium-review.googlesource.com/734483 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Before, the standard way to create a RegList was either: RegList list = (1 << 0) | (1 << 1) | ... or RegList list = rax.bit() | rdx.bit() | ... The first way allows to make the RegList constexpr, but needs comments to document which registers you are referring to, and it has no checks that all bits you set on the RegList actually belong to valid registers. The second one uses the symbolic names, hence is much more readable and makes it harder to construct invalid RegLists. It's not constexpr though, since the {bit()} method on the register types is not constexpr. This CL adds a constexpr accessor to get the code and bit of a constexpr Register, and adds a helper method to create a constexpr RegList like this: constexpr RegList list = Register::ListOf<rax, rdx, rdi>(); This new method is used in a number of places to test its applicability. Other uses of the old pattern remain and can be cleaned up later. R=tebbi@chromium.org Change-Id: Ie7b1d6342dc5f316dcfedd0363b3540ad5e7f413 Reviewed-on: https://chromium-review.googlesource.com/728026 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#48887}
-
Michal Majewski authored
Bug: v8:6972 Change-Id: I9e341f980ca392920e0789121707e25916981265 Reviewed-on: https://chromium-review.googlesource.com/730383Reviewed-by:
-
Michael Lippautz authored
Similar to the incremental marker, rename the MarkingState to MajorMarkingState and avoid using atomics on live byte count as the concurrent tasks cache its value. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_tsan_rel;master.tryserver.v8:v8_linux64_tsan_concurrent_marking_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: chromium:750084 Change-Id: Id37bb89385d4fbae95542073ea652617e61010d5 Reviewed-on: https://chromium-review.googlesource.com/735399 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Adam Klein authored
This removes all but one caller of Literal::raw_value(), thus hiding AstValue from the rest of the codebase. This is in preparation to move much of AstValue's implementation up into Literal itself, thus avoiding the overhead of the underling ZoneObjects and allowing us to remove complexity such as the cache of Smi-valued AstValues. Bug: v8:6984 Change-Id: I1b90aa64b9d26db36ef486afe73cda4473ef866e Reviewed-on: https://chromium-review.googlesource.com/731109Reviewed-by:
-
Adam Klein authored
Only rewind destructuring assignments if we actually preparsed the arrow function. For the case of single-expression bodies, we don't preparse, but we were previously erroneously rewinding. Bug: v8:6970 Change-Id: I38e15a8a5bdb05abee3bafe7bbd7736b55a6950b Reviewed-on: https://chromium-review.googlesource.com/733950Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:777345 Change-Id: Icedf8645c12a757ac753198034d24e0ca88eb7e3 Reviewed-on: https://chromium-review.googlesource.com/735721 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Ross McIlroy authored
This is to enable it to also be used for reporting AsmJS errors such that this can be moved off-thread. BUG=v8:5203 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia46040b14d010702f10c02b8254aea84cba4d54d Reviewed-on: https://chromium-review.googlesource.com/735606 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
