- 29 Sep, 2020 10 commits
-
-
Victor Gomes authored
Removes the arguments adaptor frame during optimization (for x64) and deoptimization. Change-Id: Ica78ebbb9216555dd3f1adf05d6b293e8add0050 Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410195 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70194}
-
Manos Koukoutos authored
Change-Id: I2859b2f83a1b3a8f70f906f698a8531796b767af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436332Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#70193}
-
Mike Stanton authored
Here is an alternate fix for chromium:1123379, which addresses a TODO. A callback is provided to the GraphAssembler when it's working on an unscheduled graph. In such cases, changed nodes in the main graph need to be revisited after change. The callback ensures that the GraphAssembler kicks that process off when necessary. Bug: chromium:1123379 Change-Id: I9d864c3390fbe670ee450152a67555dcbfa8f581 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2433924 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70192}
-
Dominik Inführ authored
Initializing running_ to true in Run() could happen after Stop(). Bug: v8:10315 Change-Id: Ibde2ff8cb8a5db862f970df261481cb55f8b6c96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436459Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70191}
-
Manos Koukoutos authored
Change-Id: I7bca3ed949a5dd036c3255cc5853819312387cce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436330Reviewed-by:
-
Jakob Kummerow authored
V8 can no longer produce the data this script used to consume. Bug: v8:10933 Change-Id: Ia78f24b34ce84e19a1a0bf98c75f1ca5de36618e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435228 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70189}
-
Jakob Kummerow authored
Bug: v8:10933 Change-Id: I33aad48c65292fa4e886c4485518735bc5926fdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435647 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Reverted: * FixedDoubleArray * BigInt * HeapNumber * Partial work of JSDataView Bug: v8:7790 Change-Id: I075e1d6d50129771f6208f198911797c6db3b7cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431944 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/693ed52..38a49c1 Rolling v8/third_party/aemu-linux-x64: H7hrpKGUlOVzq9skYXcIJ0DSDdaFuCLaA8hiD5ii0fEC..FfxmX7LQ9OID3pVAmcemr6u9lK3xjXzAXxvqzEcclMwC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3cd3b4e..18d69fb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/77397c4..1099c11 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d6101aa24325a778ee3044f8ac9f93f60c078a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436695Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70186}
-
Ng Zhi An authored
Functions with Simd128 in their signature will be lowered to 4 Word32. Later for Int64 lowering, it needs to use the lowered signature. Otherwise we will have weird parameter and signature mismatch, since it expects Parameter[1] to be == signature()->GetParam(0). Bug: v8:10507 Change-Id: Ia9417ecd46c1768344ed1fb3ebfe4e8dd9c3e397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432626 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#70185}
-
- 28 Sep, 2020 30 commits
-
-
Ng Zhi An authored
The value should be v128 according to https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#global-constructor. Change-Id: I9d29905daaaf19cdcaf686991f4887c3e709d2d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436638Reviewed-by:
-
Ng Zhi An authored
If return's input counts did not change, there is no need to change the node at all. Bug: chromium:1127620 Change-Id: I16d14a273d44b9fcd0b5a8af74b7a5a2eda569ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434998 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: chromium:1132641 Change-Id: Ifa005f9c901ccc865159b618e5145b6d83293b2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436078 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70182}
-
Manos Koukoutos authored
Changes: - Add current global index argument to consume_init_expr. - Inline DecodeGlobalInModule. Move the check for undefined global indexes into into consume_init_expr. Note: This fixes a bug where the index wasn't checked for nested global.get. - Under --experimental-wasm-gc, allow global initializers to reference already defined globals in the same module. - Rename ModuleDecoderImpl::DecodeInitExpr -> DecodeInitExprForTesting. Remove redundant "start" argument. - Add tests for global initializers. Remove a redundant test. Bug: v8:7748 Change-Id: Ieb4a768f8cfdd423e5f439bb3467700068f240b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428596 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This additionally combines --future with all other standard testing variants. This also enables using concurrent_marking in status files to skip tests in this variant. This also marks a slow test that times out in the new config. Bug: v8:10875 Change-Id: Id904f6a2c51b814eecfccb523a897de2f5d96f56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423719 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Adam Klein authored
These are either resolved (in which case I've removed them), or never will be done (in which case I've reworded them in non-TODO terms). Bug: v8:10933 Change-Id: I2e36df770cf2109974a790916172b6e1bace06fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432069Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#70179}
-
Adam Klein authored
This test likely did something in 2013 when we still had legacy const, but now it seems like it's mostly a poor unittest of when optimization/deoptimization happens. Bug: v8:10933 Change-Id: Ib816e0eddf9224a4ad37096591da9032740d5e7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432313Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#70178}
-
Clemens Backes authored
The vast majority of operations increases the stack size by at most one. Many opcode (e.g. all unary and binary operations) never grow the stack at all. Still, for every "push" operation, they check whether the storage for the vector that holds the stack values needs to grow. This CL avoids those redundant checks by ensuring that there is space for at least one more stack element before decoding each instruction. By centralizing this check, we not only improve performance, but also reduce code size significantly (~49 kB on x64 release). R=thibaudm@chromium.org Bug: chromium:1096565, v8:10933 Change-Id: I986dcac734b986d1ce953b7ec3bde8ad31b4f2b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431525 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70177}
-
Camillo Bruni authored
Change-Id: Ia55be7d7eda930e6ebf2a0e46c466873006e9d68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429264 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
A Wasm module's start function might be imported from JavaScript, and as such might contain calls to Blink. For such a case, we must make sure that an "incumbent context" is available. Usually, having any JavaScript function on the stack is enough to ensure that; but in the special case of async compilation, the "success" task is executed directly from the event loop, so we have to manually enter a context. Additionally, we need to ensure that such a start function's own context is properly entered: in addition to setting it as the current context on the isolate (as the function call sequence is doing), we have to register it in the list of entered contexts, as if v8::Context::Enter had been used. Bug: chromium:1096558 Change-Id: I12679ab49ee764572e3742da24889dcd55c29160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292248Reviewed-by:
-
Camillo Bruni authored
Bug: v8:10668 Change-Id: I51f81a66408a4b262f9ac7e6421609c5e485f779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435107 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: chromium:1052746 Change-Id: Iafe5104952d8086e2cabdff8aa031e964ff0626a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423704 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Control-flow aware allocation has been enabled by default for a long time now. This removes the unused code paths related to splintering. R=neis@chromium.org Bug: v8:10933 Change-Id: I19d9eb448c3912b24a1ad16030e7dd556b13accc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434328Reviewed-by:
-
Mythri A authored
For loads like Array.prototype.push, using dynamic map checks for loading loading "push" from array prototype would prevent constant folding of the push builtin. This would prevent inlining of these builtins in the later phases. So, disable dynamic map checks when loading fields from array prototype. Bug: v8:10582 Change-Id: I8b44392a81194a3a5bd9b5ced6b1175658cec1f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435367 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c8dc0f5..693ed52 Rolling v8/third_party/aemu-linux-x64: laU2vAii09mMfCaTLtA8O6UYjPdUXy0B-0zzOR0OPekC..H7hrpKGUlOVzq9skYXcIJ0DSDdaFuCLaA8hiD5ii0fEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0de9874..3cd3b4e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d1580d5..77397c4 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/83b2ac6..aef20f0 Rolling v8/third_party/jsoncpp/source: https://chromium.googlesource.com/external/github.com/open-source-parsers/jsoncpp/+log/645250b..9059f5c Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f8517bd..4668fea TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30380df349519ea77ede52e51ec902af386992f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435601Reviewed-by:
-
Victor Gomes authored
- Improves return address prediction - Fix PopAndReturn CSA tests Change-Id: I5ed76e32bb997f47dcce725511a8653e34a4c398 Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435369 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Maya Lekova authored
This CL also adds some unit tests, locally tested under x64. The double support is based on this original CL by Gus Caplan (snek@chromium.org): https://chromium-review.googlesource.com/c/v8/v8/+/2264612 Bug: chromium:1052746 Change-Id: Ibdf631689b01ab619a72005226bfc015b4737dde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416028Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Remove debug code that fails with predictable tests. Bug: chromium:1130673 Change-Id: Ie0009a3b18979057b08c25d22c58c7542dd1db6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435678Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70167}
-
Camillo Bruni authored
Bug: v8:10667, v8:10933 Change-Id: I06ebcdf12ee5acbd56ef3741af2b592b5d0351a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435209 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Milad Fa authored
Fixes the following compilation error: 'atomic_uint8_t' in namespace 'std' does not name a type Change-Id: Ie231b544cafc694271f50f4841b823e8cff3ec1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434390 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#70165}
-
Georg Neis authored
Gracefully handle hugely nested JSBoundFunctions. Bug: chromium:1125145 Change-Id: I08f136fa9d35cf16ea8da5132d4d483a75d0ba94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418091 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70164}
-
Camillo Bruni authored
This changes all tools to use ES6 modules and proper imports. Step 1: Add converted .mjs files (*this CL*) Step 2: Update node-ci build to use new .mjs files Step 3: Remove outdated .js files Bug: v8:10667, v8:10933 Change-Id: I3e92e66f896d8a9cacaf6d421f8d2c86fb3bc444 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431045 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Previously ToNumber could be called with an empty context. In a previous CL (https://crrev.com/c/v8/v8/+/2078580) we added DCHECKS to make sure that some paths were not using the empty context. Now we are doing the next step of adding a primitive to separate the cases. Small update from delphick@ to get the builtin descriptor right. Bug: v8:6949, v8:10933 Change-Id: Ie40b169f680f60a08eb26fac1fcfcef7d6169e65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428863 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#70162}
-
Almothana Athamneh authored
Bug: v8:10955 Change-Id: I630d37bce852712cd38f28f443f1bb5f3d9a50bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434331Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#70161}
-
Simon Zünd authored
The compilation cache doesn't know about REPL mode. This means that non-REPL mode compiled scripts are successfully found for their REPL mode equivalent and vice versa. This CL disables the compilation cache for REPL mode scripts. Performance is not really a concern as DevTools console inputs are usually very small. R=leszeks@chromium.org Bug: chromium:1108021 Change-Id: If396c7aa004188730762e4f6bd01dae2fc141181 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434333 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#70160}
-
Camillo Bruni authored
The tool has been outdated for a while and replaced by profview for most use-cases. The last version is still hosted under https://v8.github.io/tools/v8.4/profviz/profviz.html Bug: v8:9260, v8:10667 Change-Id: I54888640a627ee8e4d8ad2ab63bd91e04e6fb98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434335Reviewed-by:
-
Michael Achenbach authored
This prepares moving the build directory on bots to out/build. For a smooth transition, the performance runner will dynamically check for the build in several locations. This prepares: https://crrev.com/c/2426643 NOTREECHECKS=true Bug: chromium:1132088 Change-Id: Ia12fcdedec0f4ac2bfe087e8154c0acb8771a43f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431364 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Dan Elphick authored
These tests were incorrectly declaring the number of parameters the generated function would take by omitting the receiver and PopAndReturnVariable was accessing the wrong parameter. Also updated a passed in parameter to not match the constant that was being returned in case that led to the test passing accidentally. Bug: v8:10933 Change-Id: Ia354e4e30b464a333039ab6bc54198acd16a4789 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434334Reviewed-by:
-
evih authored
Currently, the generic wrapper is used for i32, i64, f32 and f64 params and 0 or 1 i32, i64, f32, f64 return value. Bug: v8:10701 Change-Id: I3776de617aa4a384fdff5154ddad8ff405001a33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429266 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Incl. random handler-related cleanups. Change-Id: I0a80e515c44aaf57a1834ee8ffa9cd47a31ea7be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2398518 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
