1. 03 May, 2019 1 commit
  2. 28 Feb, 2019 1 commit
    • Leszek Swirski's avatar
      Reland "[ignition] Skip binding dead labels" · c7ebc581
      Leszek Swirski authored
      This is a reland of 35269f77
      
      Switches on an expression that unconditionally throws would have all their
      case statements dead, causing a DCHECK error in the SwitchBuilder. This
      fixes up the DCHECK to allow dead labels.
      
      Original change's description:
      > [ignition] Skip binding dead labels
      >
      > BytecodeLabels for forward jumps may create a dead basic block if their
      > corresponding jump was elided (due to it dead code elimination). We can
      > avoid generating such dead basic blocks by skipping the label bind when
      > no corresponding jump has been observed. This works because all jumps
      > except JumpLoop are forward jumps, so we only have to special case one
      > Bind for loop headers to bind unconditionally.
      >
      > Since Binds are now conditional on a jump existing, we can no longer rely
      > on using Bind to get the current offset (e.g. at the beginning of a try
      > block). Instead, we now expose the current offset in the bytecode array
      > writer. Conveniently, this means that we can be a bit smarter about basic
      > blocks around these statements.
      >
      > As a drive-by, remove the unused Bind(target,label) function.
      >
      > Bug: chromium:934166
      > Change-Id: I532aa452fb083560d07b90da99caca0b1d082aa3
      > Reviewed-on: https://chromium-review.googlesource.com/c/1488763
      > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59942}
      
      TBR=rmcilroy@chromium.org
      
      Bug: chromium:934166
      Change-Id: If6eab4162106717ce64a2dc477000c6a76354cb4
      Reviewed-on: https://chromium-review.googlesource.com/c/1494535Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59948}
      c7ebc581
  3. 24 Aug, 2015 1 commit
    • littledan's avatar
      Add a separate scope for switch · 45e2628d
      littledan authored
      The ES2015 specification for switch statements 13.12.11 specifies that
      they get their own lexical scope. This patch introduces such a scope
      through a complex desugaring in terms of blocks, done so that Crankshaft
      does not have to be updated to support multiple constructs providing
      scopes.
      
      Recommitting this patch after a bug fix in Crankshaft to allow a
      desugaring with certain elements missing a source location:
      https://codereview.chromium.org/1313443002
      
      BUG=v8:4377
      LOG=Y
      R=adamk
      
      Review URL: https://codereview.chromium.org/1309163003
      
      Cr-Commit-Position: refs/heads/master@{#30340}
      45e2628d
  4. 22 Aug, 2015 1 commit
  5. 21 Aug, 2015 1 commit
    • littledan's avatar
      Add a separate scope for switch · 9edbc1f2
      littledan authored
      The ES2015 specification for switch statements 13.12.11 specifies that
      they get their own lexical scope. This patch introduces such a scope
      through a complex desugaring in terms of blocks, done so that Crankshaft
      does not have to be updated to support multiple constructs providing
      scopes.
      
      BUG=v8:4377
      LOG=Y
      R=adamk
      
      Review URL: https://codereview.chromium.org/1293283002
      
      Cr-Commit-Position: refs/heads/master@{#30314}
      9edbc1f2
  6. 17 Nov, 2011 1 commit
  7. 08 Nov, 2011 2 commits
  8. 02 Oct, 2009 1 commit
  9. 27 Feb, 2009 1 commit
  10. 10 Dec, 2008 1 commit
  11. 03 Nov, 2008 1 commit
  12. 07 Oct, 2008 1 commit
  13. 03 Oct, 2008 1 commit
  14. 18 Sep, 2008 1 commit