Commits · 5165722a39e495e5657314c579ed3bbed5f70df9 · Linshizhi / V8

09 Dec, 2019 3 commits

[wasm] Document feature flags better · 5165722a

Clemens Backes authored Dec 09, 2019

For each wasm feature flag, this adds a link to the proposal repository,
and states who is the v8-side owner of the implementation.
For stated and shipped features, it also sais since which v8 version
this is the case.
It also adds some documentation about the meaning of the three categories
(experimental, stages, shipped).

R=mstarzinger@chromium.org, adamk@chromium.org

No-Try: true
Change-Id: Idbb26eb9e68c7a81aed0e1c1b1d12d5de40d7c2e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954395
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65378}

5165722a

Reland "[runtime] Cache prototype chain enumerable keys in PrototypeInfo" · 3b753563

Zhang, Shiyu authored Dec 07, 2019

This is a reland of 5253d7bf

Original change's description:
> [runtime] Cache prototype chain enumerable keys in PrototypeInfo
> 
> This CL adds a prototype_chain_enum_cache to cache the enumeration of a
> prototype and its entire chain on the PrototypeInfo. It can improve for-in
> performance via simply merging the receiver enumeration with this cache.
> 
> It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook.
> 
> Contributed by tao.pan@intel.com
> 
> Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844
> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#65224}

Change-Id: I93b74727c46abbaab163324c50fbd977fcc9bb36
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955232Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#65377}

3b753563

Update V8 DEPS. · 118b2360

v8-ci-autoroll-builder authored Dec 09, 2019

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/51a024f..c3cb105

TBR=machenbach@chromium.org,tmrts@chromium.org

Change-Id: I8a81064241961d90f3d9c4dce490a90d060eeb49
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955990Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#65376}

118b2360

07 Dec, 2019 1 commit

Update V8 DEPS. · 63da8397

v8-ci-autoroll-builder authored Dec 07, 2019

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/35a759a..4f02786

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/447ab8a..51a024f

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fe18a43..6b52dc2

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d1940b1..57e481c

Rolling v8/tools/luci-go: git_revision:7d11fd9e66407c49cb6c8546a2ae45ea993a240c..git_revision:37a855b64d59b7f079c9a0e5368f2757099d14d3

TBR=machenbach@chromium.org,tmrts@chromium.org

Change-Id: Ie906df3d577d1b5de1e520d2ac9b1a50d08c68dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955988Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#65375}

63da8397

06 Dec, 2019 17 commits

[heap] Bail out from incremental marking in embedder-tracer · 39cbe0a8

Anton Bikineev authored Dec 06, 2019

This fixes DCHECK build with --noincremental-marking flag.

Change-Id: If1e8f9ec09bd91e628c3e92bbcd40f6960473f5b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955598Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65374}

39cbe0a8

Add a null check for the slot argument of the TraceReference constructor · 230b339f

David Carlier authored Dec 03, 2019

This check is useful for preventing a segfault upon usage of this argument.

Change-Id: I3cc77f84d7e3ca2a96ec36a50bddb9c2eadeb62f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946336Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65373}

230b339f

Print source position table when printing bytecode. · ea160554

Ross McIlroy authored Dec 06, 2019

Change-Id: I9be7c10193553088b72b6303408636b4fea64f5c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955594Reviewed-by: Dan Elphick <delphick@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65372}

ea160554

[torque] Add bitfield declarations · 57074692

Seth Brenith authored Dec 06, 2019

This change is the first part of adding Torque support for a "bitfield
struct", which represents a set of bitfields packed together into an
integer value. With this change, Torque can generate the list of
BitField template specializations that allow runtime code to use the
bitfield values. The flags used in SharedFunctionInfo are converted to
Torque to exercise this functionality. Bitfield values are not yet
accessible directly from Torque code.

Bug: v8:7793
Change-Id: I9e4a3df7c847111b6e02e513f175dbf938b0be35
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1949047
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65371}

57074692

[Liftoff] Emit and test debug side table · 31e9ebee

Clemens Backes authored Dec 06, 2019

This adds a method to generate the debug side table via Liftoff, and
adds first tests that check that the number of entries is as expected.
These tests will be extended in a follow-up CL to test the actual
content of the debug side table.

R=mstarzinger@chromium.org

Bug: v8:10019
Change-Id: I393ffabed3408463ffba232a66e2dffd7dd74f15
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954390
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65370}

31e9ebee

[tools] Add benchmark, browser, device and standard deviation options · 7cb7f775

Dan Elphick authored Dec 06, 2019

Add --benchmark option to allow selecting a benchmark other
v8.browsing_desktop. If not using the default, the options to generate
v8 runtime call stats will be automatically added.

Adds --stdev option to calculate the standard deviation of the
results in the table.

Add --device and --browser option that are passed through to
run_benchmark.

Change-Id: I8c57c9eba7aea84108a2e3d4fdd098a7695cad53
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955588Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65369}

7cb7f775

[promises] Port Promise.prototype.then to Torque. · bed702fa

Joshua Litt authored Dec 06, 2019

Bug: v8:9838
Change-Id: Ib2741501330629a29c1f3fe4f4a93a73982ab4de
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1929400
Commit-Queue: Joshua Litt <joshualitt@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65368}

bed702fa

[base] add missing <functional> include · 40662227

Anna Henningsen authored Dec 06, 2019

The recently introduced usage of `std::logical_and` requires this.
This un-breaks building Node.js with the current V8 master branch
on FreeBSD.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1940476
Refs: https://github.com/nodejs/node-v8/issues/124
Change-Id: Ic9d63c40e1b533f7f1c59a05f8577ee0bb0d6aa1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955584Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65367}

40662227

[builtins] Fix %TypedArray%.from builtin · 17429d2b

Igor Sheludko authored Dec 06, 2019

... broken during porting to Torque here
https://chromium-review.googlesource.com/c/v8/v8/+/1891610

Bug: chromium:1028538
Bug: v8:8906
Bug: v8:4153
Change-Id: I0fb33299832964a1990e9e60a351aa88e246b3a3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955585
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65366}

17429d2b

[wasm] Remove Sign Extension flag, and helper functions · 80bb70a2

Deepti Gandluri authored Dec 06, 2019

Change-Id: I607e9565e29b2159c1783cd58fb5a2e19c02b221
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955524
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65365}

80bb70a2

[wasm] Remove outdated TODO · ac69dfa7

Clemens Backes authored Dec 06, 2019

Sign extension opcodes are already tested in the interpreter since
https://crrev.com/c/1083337, thus remove the obsolete TODO.

R=gdeepti@chromium.org

No-Try: true
Change-Id: I08323b9d43fa46d1fcf9965e5106a68767f695b5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954400
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65364}

ac69dfa7

Remove the stack frame cache to avoid memory leaks · 6816bc52

Ulan Degenbaev authored Dec 06, 2019

The cache adds a strong pointer from a code object to closures and
thus can leak arbitrary objects.

Bug: chromium:1030043
Tbr: yangguo@chromium.org
Change-Id: I8ce90119fa97eaea59d42e7fae5acd336b5fe5d9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954392
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65363}

6816bc52

[wasm-simd] Add some AVX codegen · 3f746ecf

Ng Zhi An authored Dec 04, 2019

Adds AVX codegen for f64x2 min, max, qfma, and qfms.

Bug: v8:9561
Change-Id: Id32ba8d4367e4f9b3cccea2bc7ce24dfb04ec188
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950487Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65362}

3f746ecf

Collate packed shift data instructions into macro list · 277381d8

Ng Zhi An authored Dec 04, 2019

Bug: v8:10021
Change-Id: Ibececfd23b852d7cecf609f6ae1a4b01ea8b55f6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950485Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65361}

277381d8

Reland "Implement top-level await for REPL mode" · f96f9312

Simon Zünd authored Nov 25, 2019

This is a reland of 5bddc0e1

The original CL was speculatively reverted as it was suspected to
cause failures on the non-determinism bot. This was ultimately
confirmed to not be the case, so this CL is safe to reland as-is.

Original change's description:
> Implement top-level await for REPL mode
>
> Design doc: bit.ly/v8-repl-mode
>
> This CL allows the usage of 'await' without wrapping code in an async
> function when using REPL mode in global evaluate. REPL mode evaluate
> is changed to *always* return a Promise. The resolve value of the
> promise is the completion value of the REPL script.
>
> The implementation is based on two existing mechanisms:
>   - Similar to async functions, the content of a REPL script is
>     enclosed in a synthetic 'try' block. Any thrown error
>     is used to reject the Promise of the REPL script.
>
>   - The content of the synthetic 'try' block is also re-written the
>     same way a normal script is. This is, artificial assignments to
>     a ".result" variable are inserted to simulate a completion
>     value. The difference for REPL scripts is, that ".result" is
>     used to resolve the Promise of the REPL script.
>
>   - ".result" is not returned directly but wrapped in an object
>     literal: "{ .repl_result: .result}". This is done to prevent
>     resolved promises from being chained and resolved prematurely:
>
>     > Promse.resolve(42);
>
>     should evaluate to a promise, not 42.
>
> Bug: chromium:1021921
> Change-Id: I00a5aafd9126ca7c97d09cd8787a3aec2821a67f
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1900464
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#65273}

TBR: yangguo@chromium.org,verwaest@chromium.org
Bug: chromium:1021921
Change-Id: I95c5dc17593161009a533188f91b4cd67234c32f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954388Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65360}

f96f9312

[mips64][liftoff] Change FillStackSlotsWithZero to use bytes · 3158cf1a

Zhao Jiazhong authored Dec 05, 2019

port 785fa6b4 https://crrev.com/c/1947350

Change-Id: I76e7d7b0afcea14bee7e11c8317ede5f4c880d1d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1951281
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Zhi An Ng <zhin@chromium.org>
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65359}

3158cf1a

Update V8 DEPS. · 35e9fd3e

v8-ci-autoroll-builder authored Dec 06, 2019

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4538ab6..35a759a

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/989b615..447ab8a

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9212599..fe18a43

TBR=machenbach@chromium.org,tmrts@chromium.org

Change-Id: Ia4997c1b485d3a842a97766c8c5af631917247b4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954064Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#65358}

35e9fd3e

05 Dec, 2019 18 commits

PPC: Using a scratch register under LoadRealStackLimit · 0a055086

Milad Farazmand authored Dec 05, 2019

Change-Id: Id9e9142a8ff185309b91dcfff70dae8ccf8b5166
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954244Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#65357}

0a055086

[DevTools] Roll inspector_protocol (V8) · a16b2c7e

Johannes Henkel authored Dec 05, 2019

New revision: f5a3199a3f37c7e48a9ffdbee04aa5c8f38d2889

Use crdtp::span<uint8_t> instead of const ProtocolMessage&. (V8)
Also includes a PR which moves Serializable into the crdtp library
and adds a simple test. Hadn't rolled this yet.

Upstream review:
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1952196

Change-Id: If78bc8f11be8fb248dd66babc0190870312f7ec4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1952158
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65356}

a16b2c7e

Remove own toString from NativeError prototype · cf7646c5

Gus Caplan authored Nov 24, 2019

In 5742da05, the toString property was
accidentally applied to all NativeError prototypes, when it should only
be inherited from Error.prototype.

Refs: https://github.com/tc39/ecma262/issues/1794
Bug: v8:10017
Change-Id: I2af9a31f463deb9871dd7a4a5a2e4dd7485ed38c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1933054Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65355}

cf7646c5

[class] Improve error message for calling anonymous class constructors · 33eb4730

Shu-yu Guo authored Dec 05, 2019

The current error message assumes all classes are named, which results
in a double space and awkward wording when calling an anonymous class
constructor.

Bug: v8:10025
Change-Id: Ibe913152c0816cbbaaa0c7a88db4e415762ae9bb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947336
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65354}

33eb4730

[tools] Add script to collect runtime stats from benchmarks · 666668f1

Dan Elphick authored Dec 05, 2019

Adds a script that runs a v8.browsing_desktop story a number of times
and extracts the runtime call stats as either a table or csv.

Change-Id: I4e93cd120b3496410517a2f26547b954fc59d92a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1953343
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65353}

666668f1

[turbofan][cleanup] Add helpers for SmiTagging with 31 bit Smis · bc99b08f

Santiago Aboy Solanes authored Dec 05, 2019

There was some common code regarding smi tagging and either overflowing
or deopting if the number was too big for 31 bit smis.

Bug: v8:10021
Change-Id: I9cd9e5ff29b06638a10dd0c5a9f72ff13df6d6bc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950964
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65352}

bc99b08f

[top-level-await] Stop throwing exceptions with TLA. · 854f28ce

Joshua Litt authored Dec 04, 2019

Bug: v8:9970
Change-Id: I0e542fc63211e78800eab82257ccab9583305433
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946534Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Joshua Litt <joshualitt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65351}

854f28ce

Update V8 version after branch cut · b7c67e0a

Michael Hablich authored Dec 05, 2019

TBR=machenbach@chromium.org

Change-Id: I87ab17cd62b88aedd5b4e918eb16faca8146d7fc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1952867Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65350}

b7c67e0a

[test] Use Fuchsia test runner for unittests · 1af723d5

Almothana Athamneh authored Dec 05, 2019

This CL attempts to run unittests on Fuchsia
using Infra

Bug: chromium:934932
Change-Id: I4b7cb740e17e65e91ca8c6ba6dfd07719e473e20
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948709
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65349}

1af723d5

[cleanup][turbofan] Move common SmiUntag code out of if else body · 450dfc2b

Santiago Aboy Solanes authored Dec 04, 2019

Bug: v8:10021
Change-Id: Id0616fa2c320bd5a817745310debf63fcf58e107
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950490
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65348}

450dfc2b

[heap] Decouple the lifetime of a TracedNode from the target object · d7160560

Ulan Degenbaev authored Dec 04, 2019

Currently a TracedNode of a TracedReference is freed only if its target
V8 object is unreachable. This is problematic for TracedNodes created for
long-living (or immortal) V8 objects and leads to memory leaks.

This CL adds logic for collecting unreachable TracedNodes:
1) Each TracedNode gets a markbit. Initially the markbit is set (i.e.
   we have black allocation for TracedNodes).
2) During marking RegisterEmbedderReference sets the markbit of the
   corresonding TracedNode.
3) In the atomic pause of Mark-Compact when TracedNodes are iterated,
   we check the markbits and free TracedNodes with cleared markbits.
   After this processing all markbits are cleared for the next GC.

Note that the new logic does not apply to TracedNode that have
callbacks and/or destructors.

Bug: chromium:1029738
Change-Id: I38e76a8b4a84170793998988b1a7962e40874428
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948722
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65347}

d7160560

[turbofan] Check bounds in node input accessors · 4bb495f4

Georg Neis authored Dec 05, 2019

... even in release builds.

Bug: chromium:1029576
Change-Id: Iefc6b267c9db09f68742152a302726fcfe4c75b7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948714
Auto-Submit: Georg Neis <neis@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65346}

4bb495f4

[turbofan] Keep sharing when merging into dead environment · 874cd773

Maya Lekova authored Dec 05, 2019

Also make return and unconditional jumps kill the environment instead
of clearing it. This was still leftover from before we introduced
liveness and prevented sharing as well.

Bug: v8:7790
Change-Id: Ic79d64c9eaedf608d26e3265d4b27d21f7f3dfe1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948710
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65345}

874cd773

[liftoff] Fix zeroing the stack on arm64 · 18450061

Ng Zhi An authored Dec 04, 2019

Bug: v8:9909
Bug: chromium:1030912
Change-Id: I56134087156e4fe2598ef5a282cd57344a729a38
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950225
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65344}

18450061

Whitespace change to trigger bots · d3821800

Michael Achenbach authored Dec 05, 2019

Change-Id: I2ad2c61a3ca77611bb40e66647a269b5d16a64b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950976Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65343}

d3821800

[mips][wasm-simd] Implement f64x2 min max · 496adfce

Zhao Jiazhong authored Dec 04, 2019

port 91ee5f04 https://crrev.com/c/1925614

Original Commit Message:

 [wasm-simd] Implement f64x2 min max for arm

Change-Id: I41b350cdcc9242b2fed6260873dc202367509137
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947690
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65342}

496adfce

Update V8 DEPS. · 429701fd

v8-ci-autoroll-builder authored Dec 05, 2019

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e35470d..4538ab6

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/10bac4e..989b615

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9777ab3..9212599

Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e77e1c0..f262c1b

TBR=machenbach@chromium.org,tmrts@chromium.org

Change-Id: I05d2c76d1e776edff77bf16a763ca6d80121546a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950924Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#65341}

429701fd

[mips][wasm-simd] Use signed extract lane · 185cc913

Zhao Jiazhong authored Dec 04, 2019

port 9fcbb5e3 https://crrev.com/c/1873700

Original Commit Message:

  Replace unsigned extract lane followed by sign extend
  as added here https://chromium-review.googlesource.com/c/v8/v8/+/1846711
  with a signed extract lane for I8x16 and I16x8.

Change-Id: I46f9d3ed364f28289e23a635281ea0ef44865d1a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947689
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65340}

185cc913

04 Dec, 2019 1 commit

[heap] generate definitions for ProcessMarkingWorklist() · 94ec4296

Anna Henningsen authored Dec 04, 2019

Since other files now call this template function, where no definition
of it is available, definitions need to be generated explicitly.

This fixes Node.js debug builds with the current V8 master branch.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1940250
Refs: https://github.com/nodejs/node-v8/issues/129
Change-Id: Icc99f7a4c3669452ade65229d6ae48b49e2da0e4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950971Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65339}

94ec4296