- 22 Oct, 2018 22 commits
-
-
Benedikt Meurer authored
This CL introduces a new fast-path for `Promise.all(a)` for the case that elements in `a` are native promises, and the Promise.prototype and Promise function itself are intact. If so, we can skip the lookups of "resolve" on Promise and "then" on the result of invoking "resolve", which are both quite expensive, and we can instead directly call the PerformPromiseThen() operation on the element of `a`. In addition to that we don't need to create and chain a result promise, since this is only used when either async_hooks or DevTools are enabled. Otherwise it's a "throwaway promise" only used to satisfy the operation parameter signature (see https://github.com/tc39/ecma262/pull/1146). This results in a significant performance improvement on `Promise.all()` heavy code. For example the parallel-promises-es2015-native test goes from around 84ms to roughly 68ms, which is almost a 20% improvement. Bug: v8:7253 Ref: tc39/ecma262#1146 Change-Id: Iab9c57edb26d13a467b0653fd8de6149c382efc6 Reviewed-on: https://chromium-review.googlesource.com/c/1293374Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56858}
-
Clemens Hammacher authored
This removes the {error} and {verror} methods of {ResultBase} and introduces a named constructor {Error} instead. This allows to construct an error result in a single expression, and moves {Result} closer to a container that is initialized once and is immutable afterwards (just the {MoveErrorFrom} method is still violating this pattern). R=titzer@chromium.org Bug: v8:8238 Change-Id: Iec16c8c6d66300ee82a48e8a9e941c72ae26e202 Reviewed-on: https://chromium-review.googlesource.com/c/1293370 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56857}
-
Camillo Bruni authored
Making --data-path a subdir of --user-data-dir makes it easier to clean up data after a benchmark run. Bug: chromium:861668 Change-Id: If44527163ea396b11346d65d76411d03a5b9a424 Reviewed-on: https://chromium-review.googlesource.com/c/1292065Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#56856}
-
Marja Hölttä authored
This reverts commit 49bd7f50. Reason for revert: breaks nonintl build since the added string is inside wrong ifdefs Original change's description: > [js weak refs] Add WeakCell.clear() > > BUG=v8:8179 > > Change-Id: Ic0d9af273a8a92177bf60e4be0dd5bddaf31868c > Reviewed-on: https://chromium-review.googlesource.com/c/1292058 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56853} TBR=marja@chromium.org,hpayer@chromium.org,gsathya@chromium.org Change-Id: I7d6831cfd8a5263ee327c2a80274d1cd10dd65cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8179 Reviewed-on: https://chromium-review.googlesource.com/c/1293573Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56855}
-
Michael Starzinger authored
This changes the encoding of values stored in exception objects from a typed uint16 array (a JSObject) to a {FixedArray} instead. Note that it increases the memory footprint of the encoding, but will allow accessing elements directly from generated code and also encode reference types properly. The memory footprint can/should be optimized only after the implementation is feature complete. R=clemensh@chromium.org BUG=v8:8341 Change-Id: If67c4e498d815e14f95d014e6a1f7a6725aa0b3a Reviewed-on: https://chromium-review.googlesource.com/c/1293371 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56854}
-
Marja Hölttä authored
BUG=v8:8179 Change-Id: Ic0d9af273a8a92177bf60e4be0dd5bddaf31868c Reviewed-on: https://chromium-review.googlesource.com/c/1292058Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56853}
-
Ross McIlroy authored
BUG=v8:8293 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic0e12cbcea76f76fce543714dee972c784095143 Reviewed-on: https://chromium-review.googlesource.com/c/1290795 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#56852}
-
Toon Verwaest authored
Change-Id: I16f68db6b7793e3d7839e0afcd7c5bd6753b0913 Reviewed-on: https://chromium-review.googlesource.com/c/1292063Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56851}
-
Stephan Herhut authored
Change the status files to only run on release bots and furthermore exclude those that run on an arm simultaor. This should still provide sufficient coverage while keeping resource usage at bay. Bug: v8:8331, v8:8332 Change-Id: I515e68929af660932a1224294bd09ebc05705324 Reviewed-on: https://chromium-review.googlesource.com/c/1292061Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Hai Dang authored
This improves the performance of copying Smi or Object arrays if the new array is allocated in new space. Bug: v8:7980 Change-Id: I8e91a879f603d118b4bb1393e7b8b92f4c0b3696 Reviewed-on: https://chromium-review.googlesource.com/c/1283053 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Florian Sattler authored
BUG=v8:7926 Change-Id: Ib4dd3017c7d6f28025ab308063d7dedd0138dfa6 Reviewed-on: https://chromium-review.googlesource.com/c/1291470 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Toon Verwaest authored
This improves the error message for []=>{}. Now rather than pointing at ] and saying that's the unexpected token, it reports "SyntaxError: Malformed arrow function parameter list", pointing at [. Change-Id: I88457dc9f929a7c2b07b36ea798f11e9a7d24414 Reviewed-on: https://chromium-review.googlesource.com/c/1293369 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: -
Yang Guo authored
Bug: v8:8333 Change-Id: I04bb28f909a1c144f513964115b4f2dfaced3146 Reviewed-on: https://chromium-review.googlesource.com/c/1291372 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#56846}
-
Hannes Payer authored
Bug: chromium:897074 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I728572cda9a8914ee689eeee68a060b5713e4c6b Reviewed-on: https://chromium-review.googlesource.com/c/1290972Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56845}
-
Ross McIlroy authored
BUG=v8:8293 Change-Id: Ic58ac512d5f32d26756e21ca929dda79f133a40e Reviewed-on: https://chromium-review.googlesource.com/c/1290982Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56844}
-
Toon Verwaest authored
Change-Id: I7d95c0263649c69ff960925fcbde49e0ba9fa064 Reviewed-on: https://chromium-review.googlesource.com/c/1292059Reviewed-by:
-
Andreas Haas authored
Two zones in ExecuteCompilation have the same scope, so we can combine them. In addition I moved measurement code at the end of the function so that we don't have to store the result of the compilation in a helper. R=clemensh@chromium.org Bug: v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3b4790fa62adbe361d41be188c7f0510b12d957c Reviewed-on: https://chromium-review.googlesource.com/c/1291072 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds an attribute field to the binary encoding of exception types in the exceptions and import section. Currently the attribute value is not used and expected to be zero, but it ensures the binary encoding is extensible for future changes. R=clemensh@chromium.org TEST=unittests/WasmModuleVerifyTest BUG=v8:8153 Change-Id: I6f0e10cb1b6515177d8200ebf1f4f0b122832868 Reviewed-on: https://chromium-review.googlesource.com/c/1291075 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Georg Neis authored
Avoid calling Map::TransitionToPrototype (which reads and writes the JS heap) by skipping the JSCallReducer optimization of Function#bind whenever the receiver has a custom prototype. Bug: v8:7790 Change-Id: Ie21475c5dc5c53d90c6afae8198837deb40dac8e Reviewed-on: https://chromium-review.googlesource.com/c/1288631Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
With async_hooks it's also possible that the "current microtask" is an await task, whose generator is already suspended, when there's an exception thrown in the AFTER callback. In that case we cannot build a meaningful async stack trace. Bug: chromium:897406, v8:7522 Change-Id: I682dc1fc3ebb1864e1c2061041ff99ced0313f0c Reviewed-on: https://chromium-review.googlesource.com/c/1292057Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56839}
-
Hajime Hoshi authored
This CL adds OnFailure::DUMP_ON_FAILURE representing a scope where base:: DumpWithoutCrash is called when V8 execution is detected. As V8 can't call base functions, this CL also adds Platform::DumpWithoutCrash. Doc: https://docs.google.com/document/d/1PStT6dPlSM7QfGUJQD6t6LNLTv_48gNMhY5RdEpt3XQ/edit?disco=AAAACJ6Xg0o&ts=5bc0be1b BUG=chromium:870606 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5df62fd99ed78adb4e2505aeaee3d526d6786e59 Reviewed-on: https://chromium-review.googlesource.com/c/1276325Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56838}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bd2533d..6455acf Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/ccad447..b029971 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4eec5e59be17ef15b3e4698c6ef6852e185dfc88 Reviewed-on: https://chromium-review.googlesource.com/c/1293073Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56837}
-
- 21 Oct, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8579f3d..bd2533d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I46a9153202602b8df138a9e2aeebdc8ef65ce4fa Reviewed-on: https://chromium-review.googlesource.com/c/1293069 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 20 Oct, 2018 4 commits
-
-
Alexei Filippov authored
Do not encode single byte characters with \uXXXX. BUG=chromium:895974 Change-Id: If8e0bdb19d326228a7d3d0c9559d4457c8bfd270 Reviewed-on: https://chromium-review.googlesource.com/c/1292679Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
Originally timestamps were added in crrev.com/c/1159361 to ease debugging. Since then, however, timestamps were introduce to the LogDog viewer and are rendered in a separate column, making it easier to scan text for important messages starting with '>>>'. We do keep the log level, but make sure that it always takes a fixed width such that the actual messages are aligned vertically. R=machenbach@chromium.org No-Try: true Change-Id: I3a741069824aa25e674aca79da03a725017cb956 Reviewed-on: https://chromium-review.googlesource.com/c/1291370Reviewed-by:
-
Jakob Gruber authored
Another flake possibly caused by code printing in combination with embedded builtins. TBR=sigurds@chromium.org No-try: true Bug: v8:6666,v8:8334 Change-Id: I6a82e66a516e9cd8a7e2bac05c6ca1214b508dc3 Reviewed-on: https://chromium-review.googlesource.com/c/1292909 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0353cd5..8579f3d Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/64bf5c7..7e3c46a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/237fb2a..b026043 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/93277a7..98f1e59 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/486c9b5..f78187a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I46c3e04ff35809c23d5646e5031abd5e5b9829e4 Reviewed-on: https://chromium-review.googlesource.com/c/1292682 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 19 Oct, 2018 13 commits
-
-
Frank Tang authored
Remove the file src/objects/intl-objects-inl.h Remove Intl functions: TypeFromInt(), TypeFromSmi(), IsObjectOfType(), AvailableLocalesOf() CreateNumberFormat() and Handle<String> version of CreateICULocale Also remove StringToICUService() inside src/objects/intl-objects.cc Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifbd7ce162e04b8563c09e3ee5d99c55c6ad7bf7a Reviewed-on: https://chromium-review.googlesource.com/c/1290116 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:6891 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I623f996c0d80cd23dcad6ffedac993678a2af959 Reviewed-on: https://chromium-review.googlesource.com/c/1289609 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56830}
-
Daniel Clifford authored
In the process: - add volatile types for FastJSArray and remove the length_fast accessor from JSArray with the application of more rigorous typing. - add micro benchmarks for testing all the interesting slice cases Also update a few assorted places in .tq code to make them more idiomatic. The original version of this patch had an overly agressive assert that has been loosened. TBR=jgruber@chromium.org Change-Id: I56870862f4b124d1b38372daa326182a526c874c Reviewed-on: https://chromium-review.googlesource.com/c/1291375Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#56829}
-
Jakob Gruber authored
Flake possibly caused by code printing in combination with embedded builtins. TBR=sigurds@chromium.org No-try: true Bug: v8:6666,v8:8334 Change-Id: Ia6ad44fc0bffcf2adf3d3172672c504789324f16 Reviewed-on: https://chromium-review.googlesource.com/c/1291379 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This method only recorded stats of the generated code object. Since both counters that are updated are thread-safe anyway, we can just update them from the background instead (during {ExecuteCompilation}). R=mstarzinger@chromium.org Bug: v8:7921 Change-Id: Ia6074be8339b100f328938136ecb10144fc79f12 Reviewed-on: https://chromium-review.googlesource.com/c/1291074 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#56827}
-
Clemens Hammacher authored
And remove the TurboFan/Liftoff specific {FinishCompilation} implementations completely. Compilation errors are now stored in the {WasmCompilationUnit} directly as a {Result<WasmCode*>}. They are retrieved via {WasmCompilationUnit::ReportError}, which moves the error to the {ErrorThrower}. This prepares more changes to completely remove the {FinishCompilation} phase. R=titzer@chromium.org Bug: v8:7921 Change-Id: I4f9a6e919359aeab074880d0d38211500b76e4ec Reviewed-on: https://chromium-review.googlesource.com/c/1290975 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sigurd Schneider authored
TBR=herhut@chromium.org Notry: true Change-Id: I6e7cb57b5e59405e040d3d574a8e6f630ac27cf3 Bug: v8:8331, v8:8332 Reviewed-on: https://chromium-review.googlesource.com/c/1291369 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Change-Id: Id50564cc1a83de218fb30293bed3eb0a8fcdd8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1283011 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Previously, this was just a field on the WasmResult, which is not allowed according to the style guide. A special r-value accessor for the value is needed for the cases where the contained type is not copyable, e.g. unique_ptr. R=titzer@chromium.org Bug: v8:8238 Change-Id: Ia3c14c4c62c3c2e07f1dc4594f1bc9d1da88f91e Reviewed-on: https://chromium-review.googlesource.com/c/1290974 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:8179 Change-Id: I7c74b3d209ef320ea9f36c684f35a03ff9ce1539 Reviewed-on: https://chromium-review.googlesource.com/c/1291069 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Toon Verwaest authored
RewritableExpression always contain Assignment until rewriting; which we only do after parsing a function. We don't call ->Is on possibly rewritten expressions afterwards (we'll simply visit them instead). Change-Id: I3be91e9f6701994a571d280515c9da34257f5425 Reviewed-on: https://chromium-review.googlesource.com/c/1291071Reviewed-by:
-
Stephan Herhut authored
The atomics and compare-exchange stress tests are intended to test code generation only anyway and can be quite slow. So skip all the variants. Notry: true Change-Id: Idf443b134558990c7eac43301fa816399794b9d5 Reviewed-on: https://chromium-review.googlesource.com/c/1291077 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Stephan Herhut authored
The atomics stress tests use shared array buffers to record non-deterministic interleaving of execution in web workers. This produces non-deterministic heap results even in predictable mode. NOTRY=true Change-Id: Ic41c53bb6f5c67393fed7b9670c13cee6bc3481b Reviewed-on: https://chromium-review.googlesource.com/c/1290979 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
