- 17 May, 2021 20 commits
-
-
Santiago Aboy Solanes authored
Instead of calling the C function directly from codegen, we call a builtin that calls the C function. This is done to encapsulate the push/pop registers in the code in the builtin. Bug: v8:7790, v8:11600 Change-Id: I4c77a80803d4eb44526b716901afe0e8ccbe077d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2892663Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74599}
-
Jakob Kummerow authored
Turns out std::sort() gets angry when various ranges of an array alias each other in memory. We wouldn't like it when it's angry. Fixed: chromium:1209152 Change-Id: Ic927b46c59d10f7d3856768628c773b344005979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897098 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74598}
-
Ross McIlroy authored
Move a field and pack enums in Truncation to save 2 word for each NodeInfo. BUG=v8:9684 Change-Id: Ib470019b13a1cb8586c1bc585ff1aff6a88267ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2892664 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74597}
-
Jakob Gruber authored
We can't mutate heap state from the compiler thread; turn this into a predicate and emit generic code if it returns false. Bug: v8:7790 Change-Id: I6186a87e178d0c0206b6e7659fa2a41bf65fd835 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876845 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74596}
-
Jakob Gruber authored
When fuzzing and concurrent compilation is enabled, disable Turbofan tracing flags since reading/printing heap state is not thread-safe and leads to false positives on TSAN bots. For future work: consider teaching fuzzers to avoid these flags instead of forcing implications in V8. Bug: chromium:1205289 Change-Id: Icc26abd7c628cbcdd3671a27f955fb9fe7207172 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897102Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74595}
-
Michael Lippautz authored
ObjectView abstracts Start/End/Size of an object over the different internal representations (HeapObjectHeader and LargePage). Bug: chromium:1056170 Change-Id: I4e888f907fff94c1b02d5e21b4ec3f4a78a471f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2892081 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74594}
-
Georg Neis authored
Remove the handle-taking ObjectRef constructor in favor of (Try)MakeRef as bottleneck. Bug: v8:7790 Change-Id: I3cc3a1dcef4bac53a91c573d1a532332b88c6eb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2883664 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74593}
-
Santiago Aboy Solanes authored
The instance_size of a live map can change via ShrinkInstanceSize. This change was outside of the scope of the MapUpdater. In order to have a consistent view of the data, the concurrent reader will access the map updater lock if needed. Also refactor MapUpdaterMutexDepthScope (now named `MapUpdaterGuardIfNeeded`) so that A) it's not possible to forget to lock it, and B) add V8_NODISCARD to the class. As a second refactor use std::function in TraverseCallback. Bug: v8:7790 Change-Id: I57dd00699ccb1c9f132a950db93704b07ca115ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862765Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74592}
-
Georg Neis authored
This reverts commit 445f0f74. Reason for revert: TryMakeRef is again ready for this. Original change's description: > [compiler] Temporarily change ContextRef back to kSerialized > > This can be reverted once TryMakeRef checks the heap predicate. > I'm not reverting the previous CL because newer changes already depend > on it. > > Tbr: jgruber@chromium.org > Bug: v8:11765, v8:7790 > Change-Id: Iacc6a78a70fe6f40c9421258889c2175fb400b04 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891579 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Auto-Submit: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74531} Bug: v8:11765 Bug: v8:7790 Change-Id: I0b38791255182f1f8d0a5cf79f18d86568172487 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897101 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74591}
-
Jakob Gruber authored
Bug: chromium:1209774 Change-Id: Ie4d9a673a1c9d91d47cfb75682ff381a4c3075ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897100 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#74590}
-
Santiago Aboy Solanes authored
This ends up cleaning up the last of the macros in object-macros which were using `synchronized_`. There are still a few methods which use `synchronized_` but those were defined ad-hoc (i.e. w/o macros). Bug: v8:7790 Change-Id: Ib2d35030fd032293e746c09e10156e526af8d032 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897085Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74589}
-
Clemens Backes authored
This will allow us to refactor those V8 files without being concerned about potential interference with the security of the trap handler. This requires the duplication of V8_EXPORT_PRIVATE, the CHECK/DCHECK macros, and V8_DISABLE_ASAN. The trap-handler specific definitions are prefixed with "TH_". R=ahaas@chromium.org Bug: v8:11755 Change-Id: Iac39b553704ef50e51937375c8db805d57ce2625 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2880218 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74588}
-
Jakob Gruber authored
This is a reland of 5f0ac36c Fixes Ref construction failures in: - MapRef::instance_descriptors - NativeContext reads (see also crrev.com/c/2891575) Original change's description: > [compiler] Consider IsPendingAllocation in Ref construction > > The logic in JSHeapBroker::TryGetOrCreateData assumes that parts > of the object are safe to read. In particular, the instance type > must be readable for the chain of `Is##Name()` type checks. > > This is guaranteed if > > - a global memory fence happened after object initialization and > prior to the read by the compiler; or > - the object was published through a release store and read through > an acquire read. > > The former is protected by the new call to ObjectMayBeUninitialized > (which internally calls IsPendingAllocation) in TryGetOrCreateData. > > The latter must be marked explicitly by calling the new > MakeRefAssumeMemoryFence variant. > > Note that support in this CL is expected to be incomplete and will > have to be extended in the future as more cases show up in which > MakeRef calls must be converted to MakeRefAssumeMemoryFence or to > TryMakeRef. > > Bug: v8:7790,v8:11711 > Change-Id: Ic2f7d9fc46e4bfc3f6bbe42816f73fc5ec174337 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874663 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74474} Bug: v8:7790,v8:11711,chromium:1207680,chromium:1207679 Change-Id: Ib3dbf59909e6982a3230dd6a67c9fb7d6ffb9ab4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2886861Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74587}
-
Lu Yahan authored
Bug: v8:11767 Change-Id: I8ddd578bbc60c72c8d8e269da5492e6fce68482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2894025Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#74586}
-
Clemens Backes authored
V8 uses "thread_local" since several years now, so we can assume it to be available on all platforms. This avoids a cumbersome macro definition. R=ahaas@chromium.org Bug: v8:11755 Change-Id: I64826188a15a22238ffbcb3215a5b5d66470d573 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2885038Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74585}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: Ia5a507b462498b4e10722a7052a19a41ad7e41ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897088 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74584}
-
Wenyu Zhao authored
This CL fixes a failed DCHECK due to incorrect heap capacity. Also skips three new tests that create multiple isolates. Bug: v8:11641 Change-Id: I1061b3370efbe2b272bd490705fc728d6bb26910 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2896644 Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74583}
-
Michael Achenbach authored
Led to time-outs and tree closure: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/36738 No-Try: true Change-Id: Ia1e5294cf823429d4917b30b6478231a64c81b7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897252 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#74582}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9be9e38..c81ea93 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I636ba44c19f6b96fb1039fa3d3cbc7c92bbaa940 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2899839Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74581}
-
Fanchen Kong authored
This CL makes a call to CollectCallFeedback from Ignition load the receiver lazily, which may improve the performance of Octane/{Richards, Delta-Blue} with --no-opt for 1-3%. Bug: chromium:1207349 Change-Id: I5fb09d5c5662ef8714acf71dd7341d3164b44f93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2895358Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Fanchen Kong <fanchen.kong@intel.com> Cr-Commit-Position: refs/heads/master@{#74580}
-
- 16 May, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2123428..9be9e38 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic52ed6354cfe84f4e91198522898159fd8a2dd4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2899337Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74579}
-
- 15 May, 2021 4 commits
-
-
Junliang Yan authored
Change-Id: I636b9e8ab8ac89cbdf9814bc1bce2eaad2bcf030 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2892606Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#74578}
-
Frank Tang authored
Map 'Intl.Locale-info' to '--harmony_intl_locale_info', To be ready for https://github.com/tc39/test262/pull/2987 Bug: v8:11638 Change-Id: I119068612867648de30f63aa64c3c2bc5d63e50b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2893824 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74577}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/00d8280..2123428 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/b0912f9..20b1d0f Rolling v8/third_party/aemu-linux-x64: JANUSSL6vlpZwl7eeXT1Jv3TTKfhHXjW18WlDQyun4kC..WNXEl7yxDUmMN9Rkovz3EfBwNd26BEXmanIIz_jO2DgC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/affd272..a532699 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5974ca0..cd15203 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/084aee0..4ae2535 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3e6d345..5ce08a7 Rolling v8/tools/luci-go: git_revision:d7393d163ecb11c44626b3b221f86efdd2861565..git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2 Rolling v8/tools/luci-go: git_revision:d7393d163ecb11c44626b3b221f86efdd2861565..git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2 Rolling v8/tools/luci-go: git_revision:d7393d163ecb11c44626b3b221f86efdd2861565..git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c2ade9ac20eb15d20bd469b888d67a4c3a67430 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2898781Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74576}
-
Andrey Kosyakov authored
Change-Id: I81ff7fca841015ebc8cee66546ab40efb3065731 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2892842Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#74575}
-
- 14 May, 2021 15 commits
-
-
Shu-yu Guo authored
This option is used for --stress-snapshot when sharing the RO heap. The RO heap is shared, so deserializing non-startup snapshots need to ensure they use the same RO object cache mapping as the startup snapshot. Cq-Include-Trybots: luci.v8.try:v8_linux64_gc_stress_custom_snapshot_dbg_ng Bug: v8:11750 Change-Id: Ia2baa24d5b7d494ef5b7ff3c9cbcee846881182e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897945Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74574}
-
Ng Zhi An authored
wasm-scope-info requires SIMD, since it prints the value of the SIMD value in scope. We skip it using statusfile when SIMD is not supported. Change-Id: Id64e130a1c497bae95ec5e794ad05816f8c908e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2893568Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#74573}
-
Mike Stanton authored
This allows us to eliminate some boilerplate. Bug: v8:7790 Change-Id: Id3a14f27621435ea4e7cbf8daf68b71da62e3f1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2875209 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74572}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I9a4dad42f433ce0adf928461cf0db589df3d69e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897087 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74571}
-
Manos Koukoutos authored
This is to make space for new instructions, such as br_on_non_null. Change-Id: Id631478a1c0da2c20efe81aabe755d5fda841dba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897086Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74570}
-
Yuri Iozzelli authored
See https://github.com/WebAssembly/branch-hinting for a description of the proposal. Change-Id: Ib6e980fc20aa750decabdeb9e281f502c9fe84ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784696 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74569}
-
Santiago Aboy Solanes authored
Mimics the kArchStoreWithWriteBarrier store in generated code by having a relaxed store to the same address, with the same value. This is done in order for TSAN to see these stores from generated code. Since it is done only for kArchStoreWithWriteBarrier TSAN will see tagged stores only. Bug: v8:7790, v8:11600 Change-Id: I275dd46f5556b3a095c416adc03f2f0ac5bde41c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848470Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74568}
-
Mike Stanton authored
This CL simplifies the approach to HeapNumbers in concurrent compilation. We'll only create a HeapNumberRef for immutable HeapNumbers -- this means that we don't need to validate the read of the value with a compilation dependency check. Mutable HeapNumbers are handled differently (the value is read for constant folding, and protected with a constant field dependency). This CL includes 2 reverts: Revert "[compiler] Make HeapNumberRef background serialized" Revert "[compiler] Fix endianness issue when reading HeapNumber" Bug: v8:7790 Change-Id: I24e65583b787c214b917e96e789d711c2a7c9694 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891576 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74567}
-
Vicky Kontoura authored
This CL adds support for regular expressions. To serialize a regular expression, the pattern and flags are extracted and serialized as strings. Also, JSRegExp::StringFromFlags() is introduced to allow for transforming back from JSRegExp::Flags to the corresponding flag string. To verify that this implementation is on par with RegExp.prototype.flags, unittests are introduced under regexp/regexp-unittest.cc and RegExpBuiltinsAssembler::FlagsGetter() is updated to include a slow path that calls JSRegExp::StringFromFlags() through a runtime function. Bug: v8:11525, v8:11706 Change-Id: I9cad4c464129ba1cbf64672130d8410730d7d679 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878751 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74566}
-
Camillo Bruni authored
Make sure we have no pending promises if correctness fuzzing is active. Due to fast-paths we might not create all intermediate promises that aren't spec visible. However, promise hooks might expose them and cause different output which in turn breaks correctness fuzzing. Drive-by-fix: - Replace IsAnyPromiseHookEnabledOrDebugIsActiveOrHasAsyncEventDelegate with NeedsAnyPromiseHooks Bug: v8:1207791 Change-Id: I5b956336c43348e029c3e283993d4140a8897439 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2886862Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74565}
-
Ross McIlroy authored
Calling SharedFunctionInfoRef::GetBytecodeArray is expensive as it needs to call HeapBroker::GetOrCreateData each time. Instead have bytecode graph builder save the bytecode_array and use it instead. BUG=v8:9684,v8:7790 Change-Id: I1e847a8e371142f0108fbfbb1e151edf1c55beb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2892667Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74564}
-
Benedikt Meurer authored
Various WebAssembly APIs that don't have observable side-effects aren't marked as such, leading to the inability of DevTools front-end to generate eager evaluation previews in the Console, and also making them unusable in conditional breakpoints and logpoints. Bug: chromium:1164241 Change-Id: I8f0675d2ed5b362b34a6f6c756d372a61e9e8564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891571 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74563}
-
Wenyu Zhao authored
Added a CSA assertion to disallow page access when FLAG_enable_third_party_heap = true. Also skipped two PageFromAddress callers in CSA that is not necessary when barriers are disabled. Bug: v8:11641 Change-Id: Ib0e3ff7a7dbacb7c6e7a53a720b95e51cdf2e645 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878757Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Cr-Commit-Position: refs/heads/master@{#74562}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80d2921..00d8280 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9b15350..b0912f9 Rolling v8/third_party/aemu-linux-x64: KMQBSqcXw7u61OKLUonbaZeROpW1KXX9tM-8Klzxus8C..JANUSSL6vlpZwl7eeXT1Jv3TTKfhHXjW18WlDQyun4kC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/52e67e7..affd272 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f5c054c..5974ca0 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c830e4e..3e6d345 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/06d525c..f6e0cbe Rolling v8/tools/luci-go: git_revision:e03dc36a7374fdf2331886695fa8b13457e15b92..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565 Rolling v8/tools/luci-go: git_revision:e03dc36a7374fdf2331886695fa8b13457e15b92..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565 Rolling v8/tools/luci-go: git_revision:e03dc36a7374fdf2331886695fa8b13457e15b92..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9405aae219860c21833081ad67e006d7b1048b71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2895357Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74561}
-
Shu-yu Guo authored
This is a reland of 8b74fd45 Changes since revert: - Reverted a61aa491 for not fixing the jitless toggling issue on Chromium Win64 - Fix jitless toggling on Win64 by checking FLAG_jitless in EmbeddedDataWithMaybeRemappedEmbeddedBuiltins Original change's description: > Reland^3 "[ptr-cage] Turn on shared pointer cage by default for arm64 and x64"" > > This is a reland of 054ff044 > > Change since revert: > > - Remove assignment to FLAG_enable_short_builtins in test since > it's write-once in CFI. > > Original change's description: > > Reland^2 "[ptr-cage] Turn on shared pointer cage by default for arm64 and x64" > > > > This is a reland of 1f504c36 > > > > Changes since revert: > > > > - Removed disabling of RO heap sharing when --stress-snapshot is passed; > > was fixed by f4a6c628 > > - Fixed crashing tests that caused revert separately in > > a61aa491 > > > > Original change's description: > > > > [ptr-cage] Turn on shared pointer cage by default for arm64 and x64 > > > > > > > > Reviewed-on: > > > https://chromium-review.googlesource.com/c/v8/v8/+/2873226 > > > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#74422} > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878855 > > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > > Reviewed-by: Adam Klein <adamk@chromium.org> > > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > > Reviewed-by: Dan Elphick <delphick@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#74448} > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891460 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Commit-Queue: Shu-yu Guo <syg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#74546} > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2893567 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74548} TBR=ishell@chromium.org Bug: v8:11460 Change-Id: Ied925de5f886a906b1ca178365aee73155e679cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891697Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74560}
-