- 08 May, 2019 34 commits
-
-
Tom Tan authored
Below change canceled removing x18 from restore_list for deoptimization entries, but it also doesn't remove it from the saved_register list which causes x18 be restored incorrectly when deopt happens. https://chromium-review.googlesource.com/c/v8/v8/+/1583762 Bug: chromium:893460 Change-Id: Iccb950150a07119a3642dc42f044e94eb49db76e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600674Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61342}
-
Balaram Makam authored
Patch from Chukwuchebem Orakwue <c.orakwue@samsung.com> Change-Id: Ic5b302f4965b0f032839ef06e1221f56c37f76a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582055Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61341}
-
Mythri A authored
Bug: v8:8394, v8:8395 Change-Id: I1cbb87b67bef4d469abde99070b7870e2b8d0c90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601149 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61340}
-
Santiago Aboy Solanes authored
Going back on https://chromium-review.googlesource.com/c/v8/v8/+/1445978 since now 'tagged' means 'full tagged' again. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I3e39d631cc720a28577dad482dadfcc8332b6b18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593301 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61339}
-
Jakob Kummerow authored
For faster calls from Wasm to C-API functions, passing parameter values directly instead of through JavaScript wrapper objects. Change-Id: I31e7d1622dedaf3154483306ab159427ac167663 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591601Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61338}
-
Pierre Langlois authored
This fixes a crash when using --trace-ic on Arm64 debug. For a given return address, the assembler's `target_address_from_return_address()` method will displace it to give you the call-site address. However, this is fragile because it needs to decode the instruction stream to distinguish between different call sequences. So it triggered an assertion on Arm64 because we now use BL for builtin to buitin calls. We only use this when tracing IC states to detect if the caller is a deoptimized function. But to do this it doesn't matter if the address we have is the return or the call-site address. So we can just remove the need for the fragile Assembler method. As a drive-by, also remove `return_address_from_call_start()` which was doing the opposite and was unused. Change-Id: I5988d17eadd1652ed85d662e62bc4c579665dd31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594566 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61337}
-
Frederik Gossen authored
Lazy compilation no longer asserts the non-existence of code. Code may exist when tiering finishes (and publishes code) after {CompileLazy} started execution and before it reached the DCHECK. Bug: v8:9211 Change-Id: I03ed44da7e16f1e4b4dca4b314a56cf6828bf1a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596447Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: v8:9213 Change-Id: If1299bb11a238b7732dde6931a79b991119cec2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596730Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@google.com> Cr-Commit-Position: refs/heads/master@{#61335}
-
Sigurd Schneider authored
This CL introduces an AnnotationSet to unify annotation handling. Grammar rules now accept a list of annotations (via annotations Symbol), where an annotation is an Identifier starting with '@'. The new class AnnotationSet can be used to restrict the allowed annotations and query presence of annotations in the Make* functions. Bug: v8:7793 Change-Id: Iad5435d4a94a3bea99aca76c23d2cffffe78a97f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601142 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61334}
-
Toon Verwaest authored
Flatten cons strings into a buffer instead, as we already did for strings larger than 64 anyway. Change-Id: Ida7afb9f7ceb38505d67bedfdfbc43c8b4d8c303 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599428 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Mythri A authored
This is a reland of 289b2576. The fix for failures landed here: https://chromium-review.googlesource.com/c/v8/v8/+/1599388 Original change's description: > [Test] Update tests to work with lazy feedback allocation. > > This adds either %EnsureFeedbackVectorForFunction or > %PrepareFunctionForOptimization to allocate feedback vectors when testing > optimization, allocation sites, IC transitions etc., > > Bug: v8:8394 > Change-Id: I6ad1b6d460e4abda693b326cddb87754e080a0a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593303 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Auto-Submit: Mythri Alle <mythria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61212} Bug: v8:8394 Change-Id: Idb5bba221d138e6fd73155f959b9e16fc948c709 TBR: rmcilroy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599607Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61332}
-
Clemens Hammacher authored
The {DiscardSystemPages} call occasionally fails on win32, thus disable it until the error is found. R=mstarzinger@chromium.org Bug: v8:8217, chromium:960707 Change-Id: Idf77dd8e85d3d38cc12a9f4d2db5cc98eb2c7d08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601150Reviewed-by: -
Santiago Aboy Solanes authored
This is a reland of 3c510438 TBR=jarin@chromium.org Original change's description: > [ptr-compr][turbofan] Calling the non-compressed Tagged loads and stores > > This CL changes the instruction selector so that we use the normal load > and store, instead of the one that (de)compresses. > > Also removed "return;"s and "break;"s that were unnecessary. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng > Bug: v8:8977, v8:7703 > Change-Id: I4f2a82bfc4d300dd56300f394f59c3f9da242ba8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593296 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61304} Bug: v8:8977, v8:7703 Change-Id: I3a587662248fad0d633b543ec03f1aba88410ff1 Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601151Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61330}
-
Benedikt Meurer authored
Pass the FunctionLiteral to `SharedFunctionInfo::ToTracedValue()` and take the source position from that for logging, as the SFI itself might not have a way to get to the source position in the beginning (currently that's the case for functions that are marked for eager compilation). Tbr: ulan@chromium.org Bug: chromium:956848, v8:8598, v8:9039 Change-Id: I05c31c7d48734f1f301930ba455d3d5a77b9df13 Doc: bit.ly/v8-tracing-signals Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601146 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#61329}
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: Idbfc2ddb46e258eee2ef23528531b666a532d72c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599775Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#61328}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I4ef23446609e0b276877aedaccbd738497f2853f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601145Reviewed-by:
-
Toon Verwaest authored
MakeExternal can change byteness of strings without updating wrappers; hence we cannot trust byteness of wrappers. Unwrap the string before checking encoding. Bug: chromium:960680 Change-Id: I95d2bca906141c0d8b3de8fdac44b9fdb2ef2c43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601140Reviewed-by:
-
Santiago Aboy Solanes authored
We are changing all heap Tagged loads and stores to used the Compressed representation. From this point forward, MachineType::TypeCompressedTaggedXXX has to be used instead of MachineType::TaggedXXX. This function was added in the middle of my CLs and therefore was not included in my wasm CL. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: If3973d436ae04520b36d0f442b7886a58ac901ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601137Reviewed-by:
-
Clemens Hammacher authored
This reverts commit cc71d5ca. Reason for revert: gc-stress failures, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/22357 Original change's description: > [wasm][gc] Use SetPermissions to discard pages > > On 32bit windows, DiscardSystemPages fails sometimes (see bug). We don't > have a reproducer, so this is a purely speculative fix. > {SetPermissions} has some platform-specific logic to also discard the > pages. Specifially, on windows it uses {VirtualFree} instead of > {DiscardVirtualMemory}. > {SetPermissions} is also semantically stronger, since it forbids any > further access to the pages. > > R=mstarzinger@chromium.org > > Bug: v8:8217, chromium:960707 > Change-Id: I8b3325264c86aff8d6e7c6b01c22ae410e87faf4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601134 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61321} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: Ib2d534a6906ea5d390d08943ea71e1f8799278e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8217, chromium:960707 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601147Reviewed-by:
-
Maciej Goszczycki authored
Seems like the CodeBuilder CL actually caused this. This is a reland of 964edc25 Original change's description: > [heap] Set read-only space's and its pages' heap_ to null. > > Various small changes are required to enable this. > > HeapObject::GetReadOnlyRoots no longer uses the Space's heap when > possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition). > This requires that ReadOnlyRoots be construct-able using a raw pointer > to the read-only space's roots array. > > Global read-only heap state is now cleared by tests where appropriate > and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future > issues easier. > > String padding is now always cleared just before read-only space is > sealed when not deserializing. > > Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372 > Bug: v8:7464 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830 > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61188} Bug: v8:7464 Change-Id: If75bbd16c2e2af5b80cd60811dfd7866f8be8309 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599186 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#61323}
-
Mythri A authored
Bug: v8:9207 Change-Id: Ie137e8c2395e835d532394495d892ad9b2cfc90d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601133 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
On 32bit windows, DiscardSystemPages fails sometimes (see bug). We don't have a reproducer, so this is a purely speculative fix. {SetPermissions} has some platform-specific logic to also discard the pages. Specifially, on windows it uses {VirtualFree} instead of {DiscardVirtualMemory}. {SetPermissions} is also semantically stronger, since it forbids any further access to the pages. R=mstarzinger@chromium.org Bug: v8:8217, chromium:960707 Change-Id: I8b3325264c86aff8d6e7c6b01c22ae410e87faf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601134Reviewed-by: -
Peter Marshall authored
Perfetto will actually call this from the main thread in various cases so we need to implement it. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: I509fa277fb0f7e98e9dea4d991a2d313e0a249da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599183Reviewed-by:
-
Santiago Aboy Solanes authored
This reverts commit 3c510438. Reason for revert: Breaks pointer compression bots (https://ci.chromium.org/p/v8/builders/try.triggered/v8_linux64_pointer_compression_rel_ng_triggered/b8914100067516580000) Original change's description: > [ptr-compr][turbofan] Calling the non-compressed Tagged loads and stores > > This CL changes the instruction selector so that we use the normal load > and store, instead of the one that (de)compresses. > > Also removed "return;"s and "break;"s that were unnecessary. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng > Bug: v8:8977, v8:7703 > Change-Id: I4f2a82bfc4d300dd56300f394f59c3f9da242ba8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593296 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61304} TBR=mvstanton@chromium.org,jarin@chromium.org,solanes@chromium.org Change-Id: I022895f648b7f9a24944d1c647ba76773cee3669 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8977, v8:7703 Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601136 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Joyee Cheung authored
Bug: v8:8578 Change-Id: If6b62b7d0ca2be03ab46c58d33aa2353ddd44986 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584251 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#61318}
-
Peter Marshall authored
The default protobuf compiler main builds generators for the CLI tool for all the supported languages. This CL adds a custom main() which only requires the CPP generator. The protobuf compiler is a build-time dependency so this won't shrink binary size but will speed up compile a little bit and means we don't have to list all of the files for the other supported languages in the build.gn file. That should hopefully make protobuf rolls a bit easier given that we are maintaining GN build files for protobuf. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: Iac432dfe53b7ac9cfa819be1b2945d5948ffff38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599448 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Peter Marshall authored
This is needed for Perfetto which sometimes chooses to bypass the task queue if the task queue uses a given thread to run tasks. Bug: v8:8339 Change-Id: Iecec5e7883d174e4b63495ecdadfb96105e4505c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588471 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Simon Zünd authored
This is a reland of 2d45ecf0 The reland properly initializes struct fields in unittests. To prevent this in the future, TorqueCompilerOptions uses brace initialization. Original change's description: > [torque] Introduce force_assert_statements compiler option > > "assert(...)" statements are usually only visited and generated in > debug builds. To provide Language Server support for statements inside > asserts, the force_assert_statements option allows to manually > override this behavior and visit assert statements in release builds. > > R=sigurds@chromium.org > > Bug: v8:7793 > Change-Id: I38f48e35f2b0a1a98abb74b7babb1edd2d7dba24 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599180 > Auto-Submit: Simon Zünd <szuend@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61295} Bug: v8:7793 Change-Id: I96ef863c8c85ae87a00cbe858655d4a2c9368b41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599599 Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Andreas Haas authored
Incorrect sub-typing caused some spec tests to fail. The rules in the spec are here: https://webassembly.github.io/reference-types/core/exec/modules.html#globals R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ic0924b98a39395e351fec901c47a9debfe56be9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598763 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Yu Yin authored
Above test passes on simulator but may take up about 3 minutes. Test passes normally on native mips. ppc & arm both skip it on simulator. Change-Id: Ifd51a29ab653fa80e541fb2a7a8b0ae680a4454d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598913Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61313}
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: v8:9145 Change-Id: I4672c61f6fc40878c2997826ac6492c37edbfc64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599597Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I8f51731a789b242cdd489f6321bc1ba909aa5d66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599548Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/27799cd..ec592be [spec] Constrain name section ordering (#1012) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/ec592be [spec] Typo in type table (#1013) (Galaxtone) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/08fe3e3 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I2610be6a50dd18800dc5096dbd0f9188d2f9879e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600972Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61310}
-
Yu Yin authored
port https://crrev.com/c/1588430 to mips. Change-Id: Ic1474294a8be5191cc8d10ba65cdc5eb28ac1362 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596045Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61309}
-
- 07 May, 2019 6 commits
-
-
Alexei Filippov authored
Change-Id: Iaf4ad9a097e7201d072341525e6364e1d4f689b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599774Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#61308}
-
Z Duong Nguyen-Huu authored
This is the follow-up for frozen, sealed packed elements kind. Design docs: bit.ly/fast-frozen-sealed-elements-in-v8 This change is only support the transition from holey elements to holey sealed elements (via object.seal) or to holey frozen elements (via object.freeze). Added tests for non-extensible, sealed, frozen holey elements in https://chromium-review.googlesource.com/c/v8/v8/+/1574503 and https://chromium-review.googlesource.com/c/v8/v8/+/1582481 Bug: v8:6831 Change-Id: Ia4373648f79f2ebebb390982a503145844a0c123 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574777 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Milad Farazmand authored
Port 0a0d70eb R=sigurds@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id4a864b95368c392de8b363076114cd36c463397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598549Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61306}
-
Balaram Makam authored
When one of two compared strings is empty, or when both are the same object, we can skip the calls to Flatten and into ICU. Performance results on hikey620(cortex-a53) device: Speedometer2.0 - no impact. Jetstream2.0 - only impacts CDJS subtest: name old score new score delta CDJS 2.33 ± 3% 2.38 ± 1% +2.35% (p=0.009 n=6+5) Change-Id: Ibe490f86188caab1d7712b52c610658e1e2b819c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584221 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This CL changes the instruction selector so that we use the normal load and store, instead of the one that (de)compresses. Also removed "return;"s and "break;"s that were unnecessary. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I4f2a82bfc4d300dd56300f394f59c3f9da242ba8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593296 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Mythri A authored
In PrepareFunctionForOptimization, for functions that are already optimized we didn't hold on to the bytecode array strongly. If these functions get deoptimized before we call OptimizeFunctionOnNextCall, then they need to be re-optimized again. So we should hold the bytecode arrays for optimized functions as well. OptimizeFunctionOnNextCall removes it from the table if the function is still optimized. Bug: v8:8801 Change-Id: I7f3d94d9842223d85843c9ddb109c8bc9f414891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599388 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
