- 14 Sep, 2020 12 commits
-
-
Manos Koukoutos authored
Changes: - Add optional WasmModuleObject field to WasmGlobalObject - Introduce DynamicTypeCheckRef. Use it to typecheck imported global objects. - Correctly typecheck imported WasmGlobalObjects. - Add some testing infrastructure and one test file Bug: v8:7748 Change-Id: Icc62d378d17696c5808d580f1ec84186c9556ec1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403248Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69872}
-
Camillo Bruni authored
Bug: v8:10763 Change-Id: I8e8f7924928175516e7ba2500f4660dc160158b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2409278Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69871}
-
Hidehiko Abe authored
Currently is_linux GN variable is set to true on building Chrome OS but it is planned to be set false. This CL is the preparation to keep the compatibility. Bug: chromium:1110266 Test: Built locally. Change-Id: Ibb9a57269f5a147e372fd33a473d9514379e1c68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2405847Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69870}
-
Michael Achenbach authored
No-Try: true Bug: v8:10911 Change-Id: I0cd19075f55494b7fefa5cbc7b2993ac1b6eefac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2409494 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69869}
-
Jakob Gruber authored
Optimized code that is marked for deoptimization is not considered 'attached' or 'available', but we still want to discard it prior to serialization. Change JSFunction::CanDiscardCompiled to explicitly check for this case. Bug: v8:10881, v8:10869 Change-Id: Id573c21e331afdae28be4ab434d522249d1ac9be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2409275 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#69868}
-
Camillo Bruni authored
This is a reland of 6798619a Original change's description: > [d8] Add d8 global variable > > - Add a a "d8" global variable where d8 can provide helpers. > This in in preparation of adding d8.log for testing our log parsers > written in JavaScript. > > - Separate d8 helper creation into individual functions. > > Bug: v8:10668 > Change-Id: I84e434452463afb93ae403f890d8841b20b00703 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400990 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69801} Tbr: verwaest@chromium.org Bug: v8:10668 Change-Id: If3256ec4e11f01ef1dc5c2e61fa33ed6d7a6aee3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2409274Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69867}
-
Jakob Gruber authored
The stress-snapshot mode clears bytecode arrays from shared function infos which the MarkCompactCollector later tries to access. The simplest fix here is to disable incremental marking in this specialized testing mode. Bug: v8:10882 Change-Id: Ie0b5fc4c6411f0768b4e76d21fbd225dc56aab6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2409277 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#69866}
-
Michael Achenbach authored
This skips the top outliers in debug mode and marks other tests as slow that frequently flakily time out, see bug. No=Try: true Bug: v8:10909 Change-Id: I26b22cceba4a93496f340fe25af0685391fa762b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2407897 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Daniel Bevenius authored
This commit adds a static cast to CONSTEXPR_DCHECK in as_int(). The motivation for this is that currently this check generates the following compiler warning: /v8/src/objects/internal-index.h: In member function ‘constexpr int v8::internal::InternalIndex::as_int() const’: /v8/src/objects/internal-index.h:44:29: warning: comparison of integer expressions of different signedness: ‘const size_t’ {aka ‘const long unsigned int’} and ‘int’ [-Wsign-compare] 44 | CONSTEXPR_DCHECK(entry_ <= std::numeric_limits<int>::max()); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I6adda356dbbe522221731a29f205213f1ba23755 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2407892Reviewed-by:Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#69864}
-
Almothana Athamneh authored
NOTRY=true Bug: chromium:1126457 Change-Id: I08df6070586cdc435595ddda74e1e8cfe2abf2b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401423 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#69863}
-
Camillo Bruni authored
Stress configurations cause maps to be GC'ed too early. We now keep them alive by storing the object in a global variable. Bug: v8:10892 Change-Id: If03c42612d9907b3b6d0df8bb2de879857a89e0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404774Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69862}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d01f3c3..dc90e7d TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e0cfda5b01f6a35ab869965087ad26524474415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2407137Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#69861}
-
- 13 Sep, 2020 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/db4df0f..d01f3c3 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iddb6c36450238243b29bf8e49f9695c6b333d620 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2408129Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/349143e..db4df0f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie89554bf1e2f1955ab3dd989c9123dda8bbbd45d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2408294Reviewed-by:
-
- 12 Sep, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b3e63d3..349143e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/13bf125..e53ee0c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fb6d901..a1e1549 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/97d6ab3..bf815f1 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a0ebbea978c6b54047998f5852ec3c1965b916c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2407492Reviewed-by:
-
- 11 Sep, 2020 25 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Bug: v8:10501 Change-Id: I92700c2367aecb9eb5adf2a7c8d863815bbfe6ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404459Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#69857}
-
Ng Zhi An authored
We need to construct Float32 nodes for f32x4, using Word32 operators will cause the wrong register to be allocated, triggering a CHECK failure. Bug: v8:10507 Change-Id: I70842f1d61b90fed2407ee52af4bc5a6b1b82ba6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2399050Reviewed-by:
-
Ng Zhi An authored
F32x4 and F64x2 pmin and pmax were accepted into the proposal [0], this removes all the ifdefs and todo guarding the prototypes, and moves these instructions out of the post-mvp flag. [0] https://github.com/WebAssembly/simd/pull/122 Bug: v8:10904 Change-Id: I4e0c2f29ddc5d7fc19a209cd02b3d369617574a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2405802Reviewed-by:
-
Etienne Pierre-doray authored
Dynamic index generation used as starting seend boosts performance for Jobs that have many work items. This is taken from https://source.chromium.org/chromium/chromium/src/+/master:base/task/job_perftest.cc;l=30?q=job_perftest&ss=chromium Change-Id: Ie1ba432808f07498f90ab4c0af419b8f9b72e342 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2405799 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I463c7472ebaa5b4092b7f0e69e259abbf9c3bc06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2390769 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69853}
-
Georg Neis authored
... by unparking the local heap before accessing the handles. Bug: v8:7790 Change-Id: I0910fd8ad2a1e9cbbf312acb4f26358a09891f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404455Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#69852}
-
Victor Gomes authored
Only for the interpreter. Change-Id: I2456a7d6b385b3b8ebcb3ff8782ea5586289bea6 Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400343 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Dominik Inführ authored
FLAG_local_heaps needs to be set before creating the context, otherwise the StressConcurrentAllocatorTask is already started. Setting the flag then races with background thread, which checks FLAG_local_heaps while creating LocalHeap. Bug: v8:10315 Change-Id: If6de748ec174dffb94a2582d24e37d24586ee95a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404823Reviewed-by:
-
evih authored
Currently, the generic wrapper is used for i32 and i64 params and 0 or 1 i32 return value. Bug: v8:10701 Change-Id: I8c47e78fa9beeda01bdb647e1fcf9ebe6baf1ee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403243 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#69849}
-
Almothana Athamneh authored
NOTRY=true Bug: chromium:1126457 Change-Id: I5239fe552e71d7a9a20a07188a368fd57429142a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404449 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Almothana Athamneh authored
Bug: chromium:1126467 Change-Id: Iae955b2fc832703f208e279c5bc4dff9c5b8e5cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400996Reviewed-by:
-
Leszek Swirski authored
This reverts commit 853efc77. Reason for revert: More TSAN failures: https://ci.chromium.org/p/v8/builders/ci/V8%20NumFuzz%20-%20TSAN/11176 Original change's description: > Reland "[offthread] Enable off-thread finalization in --future" > > This is a reland of ff0c5cfa > > Relanding after fixing TSAN failure in https://crrev.com/c/2404767. > > Original change's description: > > [offthread] Enable off-thread finalization in --future > > > > Enable the new LocalHeap-based off-thread finalization behind --future. > > > > Bug: chromium:1011762 > > Change-Id: I4b33fc300a34530d75aa1a3e197e0d1326994efa > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403252 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#69813} > > Bug: chromium:1011762 > Change-Id: I552a2668391707ee69162eb94143daa7c11721d6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404772 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69841} TBR=ulan@chromium.org,leszeks@chromium.org,verwaest@chromium.org,dinfuehr@chromium.org Change-Id: I291c16272a3fd02ee3afa23e2af7e66bae82a92e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404824Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69846}
-
Mythri A authored
We used to store MinimorphicPropertyAccessInfo indexed on the feedback slot id. This works fine when there is no inlining but returns the wrong access information when functions are inlined. Index it based on FeedbackSource to avoid these problems. Bug: v8:10582,chromium:1125871 Change-Id: Id01010f3153f7e21495d73899a8604a64417ae95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401426 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:10880 Change-Id: I7a9ba96e4b0c83565c4749101082c661e21d5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400598Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69844}
-
Santiago Aboy Solanes authored
Since the AllowHandleDereference scope doesn't happen for kNeverSerialized (see https://crrev.com/c/v8/v8/+/2402033), there is no need to have the extra if. Bug: v8:7790 Change-Id: I4c9f93d2e754625e7b30aee61e2b502161bd60c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404770 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Victor Gomes authored
This optimization does not work when the stack arguments are reversed. Change-Id: Ib543e6ca234cc70708909e0b3cd474b1309ec40e Bug: chromium:1126769, v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404775 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This is a reland of ff0c5cfa Relanding after fixing TSAN failure in https://crrev.com/c/2404767. Original change's description: > [offthread] Enable off-thread finalization in --future > > Enable the new LocalHeap-based off-thread finalization behind --future. > > Bug: chromium:1011762 > Change-Id: I4b33fc300a34530d75aa1a3e197e0d1326994efa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403252 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69813} Bug: chromium:1011762 Change-Id: I552a2668391707ee69162eb94143daa7c11721d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404772Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69841}
-
Dominik Inführ authored
The problem here was that IncrementalMarking::Step was invoking new_space()->ResetOriginalTop() which sets original_top to the current top. IncrementalMarking::Step could be invoked during InvokeAllocationObservers(), which is called right after acquiring a new LAB and allocating the first object in it. However this first allocation might be from generated code with allocation folding enabled. The generated code might not use all of the memory it allocated and in that process move top backwards again. Nevertheless InvokeAllocationObservers() could already set original_top to the current top. If the generated code later not uses all of that memory, original_top can be bigger than top. Fix this problem by ensuring that original_top always equals the LAB start. Each time LAB start is moved/accounted for, original_top is now updated as well for the new space. Also IncrementalMarking::Step() isn't allowed to move original_top anymore. Bug: chromium:1116278, v8:10315 Change-Id: Ib18a0b07e2665b8ba933555387b84329cbecdf5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2398519Reviewed-by:
-
Daniel Bevenius authored
The commit updates the way the usage is printed for cctest to make use of HelpOptions which allows the usage string to be passed into SetFlagsFromCommandLine function. Change-Id: I8dcd48ca8bb7b025f77c0f05ab37ce4f7b6fae04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2402032Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#69839}
-
Leszek Swirski authored
When creating and inserting strings into the string table, we have to make sure that the writes to the string's fields (including its characters) are not reordered to after the write of the string into the table itself. Thanks TSAN! Bug: chromium:1011762 Change-Id: Ib8a22e3980f6b5c57561ca23549c1462c4c017c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404767 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Georg Neis authored
- serializer-*: In some stress configuration, the new map of x was GC'd at the beginning of optimization, thus generating a soft-deopt for the store to x (thus in turn skipping inlining of f). - native-context-*: In some stress configuration, f had its feedback flushed. Bug: v8:10892 Change-Id: Icd9f9c0ba6feb938ae8c3b0031b02b766f2e3f91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404764 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: Idb5ac9b0d3703e94f33d74318080790d00c4ec45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401428 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#69836}
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: Ib0c95f27d21e4aea09dcc9804a800b16440a2fe2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403254Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I0e58244a679d5fd7f597c90c6f41ac255024de3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403253Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/471a6cd..b3e63d3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/70f34e0..13bf125 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/898c6c0..f8517bd TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42f50f1bd40a05adb6205a94e3d3007a4fc6b5f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2405315Reviewed-by:
-
