- 12 Apr, 2018 19 commits
-
-
Peter Marshall authored
Looking up line numbers with the JITLineInfoTable would sometimes give wrong answers. Fix these bugs and add a cctest for this data structure. Also do some cleanup while we're here like inlining the (empty) constructor and destructor and removing the empty() method which is only used unnecessarily anyway, to make the contract of GetSourceLineNumber a bit clearer. Also rename the data structure to SourcePositionTable, because it doesn't just provide info for JIT code, but also bytecode, and 'Info' is pretty ambiguous. Bug: v8:7018 Change-Id: I126581c844d85df6b2b3f80f2f5acbce01c16ba1 Reviewed-on: https://chromium-review.googlesource.com/1006795Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#52571}
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ifd0eee86da0bf8b8e234b6f55ddce77239d0a3a5 Reviewed-on: https://chromium-review.googlesource.com/1009905 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#52570}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Change-Id: I1f7281fdf4144ad192efa6581df3109a0f6abd68 Reviewed-on: https://chromium-review.googlesource.com/1010067Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52569}
-
Clemens Hammacher authored
Memory size, mask and function table size are 32-bit values in wasm. There is no relation to pointer size. Hence, replace uintptr_t by uint32_t. These fields are already being loaded as uint32_t in wasm-compiler.cc, causing problems on big endian systems. R=mstarzinger@chromium.org Change-Id: Ie03b552934262d5fa8de9998abdd7409e60af690 Reviewed-on: https://chromium-review.googlesource.com/1005154 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52568}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:827890 Change-Id: I25d647f3511c2101c30cca88b91c372ee4fee05b Reviewed-on: https://chromium-review.googlesource.com/1009662Reviewed-by:
-
Toon Verwaest authored
Bug: chromium:831981 Change-Id: Ie0e4bb6ca585f76829e0100202e01d02c521ac51 Reviewed-on: https://chromium-review.googlesource.com/1009902Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#52566}
-
sreten.kovacevic authored
Add big endian support for MIPS in Liftoff. Bug: v8:6600 Change-Id: Ibd90e7b6a8f0f826bd70ef489135cabcadeed7b0 Reviewed-on: https://chromium-review.googlesource.com/995457 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52565}
-
Michael Achenbach authored
It'll replace the linux32 debug trybot in CQ soon when it's confirmed stable. This also adds the corresponding MB config. NOTRY=true TBR=sergiyb@chromium.org Change-Id: I99464d7d2d776390e59c48f0f65daa213a14f0f7 Reviewed-on: https://chromium-review.googlesource.com/1009746Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Change-Id: Ie97090587841830ed82097f5411131a9dc9ff5e6 Reviewed-on: https://chromium-review.googlesource.com/1009742 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
This is a reland of 9a7e9cf2 Original change's description: > Enable cfi-icall on the v8 CFI bots > > BUG=v8:7164 > > Change-Id: I7522ba6ac2bde89c84bcd49bc116a432091a2938 > Reviewed-on: https://chromium-review.googlesource.com/990802 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52343} CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_cfi_rel_ng Bug: v8:7164 Change-Id: I683116e86685fb7295bb576e57ce85fed7445b3c Reviewed-on: https://chromium-review.googlesource.com/1003692Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: chromium:831989, chromium:824681 Change-Id: I0a8b2cc9f80af5f954bd358c30a3c6d84b6adeae Reviewed-on: https://chromium-review.googlesource.com/1009603Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52561}
-
Peter Marshall authored
Fixes some failing test262 tests for a corner-case in the spec where we need to use the buffer constructor from a different realm. Bug: v8:7512 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3f1334f6181eaaddf0326156139ac20a970c235b Reviewed-on: https://chromium-review.googlesource.com/966223 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: chromium:829253 Change-Id: Ie9102adcecfe4f019ccf8b5e82e55509a416bfc3 Reviewed-on: https://chromium-review.googlesource.com/1007195Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52559}
-
Vlad Tsyrklevich authored
It's not possible to use GeneratedCode for this test because the called stubs use the stdcall calling convention but GeneratedCode does not allow specifying a custom calling convention. BUG=v8:7164 Change-Id: Ic28c4313bb2b68103b94e4c1ae7c037a789edce2 Reviewed-on: https://chromium-review.googlesource.com/1008994Reviewed-by:
-
Michael Achenbach authored
V8 part for https://crrev.com/c/1007058 NOTRY=true Change-Id: I212eb12e83ea647af7d009747bf94baf3ab9febf Reviewed-on: https://chromium-review.googlesource.com/1007238Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52557}
-
Jungshik Shin authored
This is to fix an assertion failure in formatToParts when Chinese calendar is specified with 'u-ca-chinese'. See https://github.com/tc39/ecma402/issues/225 . This CL is a temporary work-around to get v8 match the spec in terms of the external behavior, but it's not taking the steps in the spec, yet. Moreover, the spec may have to be revised as to how to pick the best match pattern when the default calendar for a locale is different from the calendar specified via 'u-ca'. How to handle 'related year' part also needs to be specified. Bug: chromium:826549 Test: intl/date-format/format-with-extensions Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1f9a2467e86e71e024bc9babe18f16e49746008e Reviewed-on: https://chromium-review.googlesource.com/1006915Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52556}
-
Kim-Anh Tran authored
When using registers during the Liftoff-prologue, we need to make sure that all reserved registers are correctly pushed to and restored from stack. Change-Id: Iac444448cfd99fca70a811cb941d0cf5979d638b Reviewed-on: https://chromium-review.googlesource.com/1005754 Commit-Queue: Kim-Anh Tran <kimanh@google.com> Reviewed-by:
-
Junliang Yan authored
Port 077205be Original Commit Message: This CL allows SetPrototypeAdd and ArrayIteratorPrototypeNext to be called on temporary objects during side effect free evaluation. R=kozyatinskiy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I4f6d4e885c19a032723ea8fe39976780900ba922 Reviewed-on: https://chromium-review.googlesource.com/1008634Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#52554}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/73e352e..bf6af18 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2c59f67..a227198 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I561d492911e3528b7fdf19fc24efa671eaa1245c Reviewed-on: https://chromium-review.googlesource.com/1009283 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52553}
-
- 11 Apr, 2018 19 commits
-
-
Alexei Filippov authored
Previously embedder had to create an instance of TracingCpuProfiler explicitly. The patch makes the profiler created automatically for every isolate. The profiler has no overhead unless tracing with v8.cpu_profiler category is enabled. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I9369c2c56bcddc72093eda33dc2bc185c9253b4a Reviewed-on: https://chromium-review.googlesource.com/1006049 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port ada64b58 Original Commit Message: Before Turbofan/Ignition it was possible to use external profilers to sample running V8/Node.js processes and generate reports/FlameGraphs from that. It's still possible to do so, but non-optimized JavaScript functions appear in the stack as InterpreterEntryTrampoline. This commit adds a runtime flag which makes interpreted frames visible on the process' native stack as distinguishable functions, making the sampled data gathered by external profilers such as Linux perf and DTrace more useful. R=matheus@sthima.com.br, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I0416b53c53248a5624061d0155712a3e2396c725 Reviewed-on: https://chromium-review.googlesource.com/1008045Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#52551}
-
Sigurd Schneider authored
The promise constructor fast-path did allocate contexts that were too large, resulting in GC overhead compared to the slow-path which contributes to a performance regression we are currently dealing with. Bug: chromium:829253 Change-Id: I82883358933df9ce5241bad53b85867455046cc1 Reviewed-on: https://chromium-review.googlesource.com/1007054Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7570 Change-Id: I8b15d6e9f4991d0a6884277a5d67090f24270fcc Reviewed-on: https://chromium-review.googlesource.com/1005261Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52549}
-
Alexey Kozyatinskiy authored
This CL allows SetPrototypeAdd and ArrayIteratorPrototypeNext to be called on temporary objects during side effect free evaluation. Bug: v8:7588 Change-Id: Id77848e48d98c243de91bc6c0fae5a0877e693d4 Reviewed-on: https://chromium-review.googlesource.com/998439 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Andreas Haas authored
ValueDeserializer::ReadWasmModule does not call API functions, therefore there can be no scheduled_exceptions, and therefore we do not have to translate scheduled_exceptions to pending_exceptions. On the contrary, there can be pending_exceptions, which causes the call to RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION to crash. This CL fixes a crash in a layout test which was caused by another CL (https://crrev.com/c/975547). R=mstarzinger@chromium.org CC=binji@chromium.org Change-Id: I3078a2a9a532b079b5a4ea604c2f3f777fa2e287 Reviewed-on: https://chromium-review.googlesource.com/1006794Reviewed-by:
-
Hannes Payer authored
Bug:chromium:831501 Change-Id: I82daa3dc1a6cc08cb63e42f4a54b69d28303ce0f NOTREECHECKS=true Change-Id: I82daa3dc1a6cc08cb63e42f4a54b69d28303ce0f Reviewed-on: https://chromium-review.googlesource.com/1006755 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
-
jgruber authored
All call sites passed nullptr as the isolate argument and DOUBLE as the exponent type. Remove these unused arguments and related dead code. Bug: v8:6666 Change-Id: Ie94d9b489f494b2a5c80f5cc3dc81013ed4f4414 Reviewed-on: https://chromium-review.googlesource.com/1006754Reviewed-by:
-
Sigurd Schneider authored
This test relies on allocation mementos remaining in place; with the new forced GC in the deoptimizer, this test can't be run with the deopt fuzzer on anymore. Bug: v8:7644 Change-Id: I6271c00a7b6c4e90a5e190bac5debaafad03a0e3 Reviewed-on: https://chromium-review.googlesource.com/1004774Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52544}
-
Michael Starzinger authored
This improves the stack layout of {WasmCompiledFrame} frames built by Liftoff so that the first spill slot immediately follows the frame marker. We will rely on this in the future when we expect the first spill slot to always hold a {WasmInstanceObject} reference. R=clemensh@chromium.org Change-Id: I2babe8a813af23f3b5bc139a2b0b334072625f7b Reviewed-on: https://chromium-review.googlesource.com/1006615Reviewed-by: -
Clemens Hammacher authored
On indirect function calls, if the corresponding table entry is empty, we cannot call {GetCodeFromStartAddress}. In that case, the signature check will fail anyway, so perform the signature check first, and only get the code object if the check succeeds. R=mstarzinger@chromium.org Bug: chromium:831463 Change-Id: Iead949e4c12502b1a2a3949db2dabab4a184a1e7 Reviewed-on: https://chromium-review.googlesource.com/1005005Reviewed-by: -
Simon Zünd authored
Benchmark now sorts every element type of TypedArray and groups the benchmarks by integer and floating point types. Also adding a sort benchmark that uses multiple custom compare functions. R=petermarshall@chromium.org Bug: v8:7624 Change-Id: Id0f44adf78398c99a17fe3edb6ee5d7fccc4d99b Reviewed-on: https://chromium-review.googlesource.com/1000774 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#52541}
-
Dan Elphick authored
Builds with and without embedded builtins (when combined with RO_SPACE changes) results in different v8heapconst.py. So this marks embedded builds as non-shipping. When embedded builtins becomes the default then this non-embedded builds should be marked as non-shipping. Bug: v8:7464 Change-Id: I8649183daf63ae9f54ed6207ed1104ecf33c89ff Reviewed-on: https://chromium-review.googlesource.com/1005515 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
Blacklist two functions that can call casted function pointers, there is not an easy way to fix these failures yet. BUG=v8:7164 Change-Id: I895ccb09359d38c95c1ff93e41c306ecb1ad57fc Reviewed-on: https://chromium-review.googlesource.com/1003226Reviewed-by:
-
Clemens Hammacher authored
This reverts commit e5a687be. Reason for revert: Crashes on GCC: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/19002 Original change's description: > [CFI] Refactor test use to use GeneratedCode > > Replace direct call to generated code with call using GeneratedCode to > match the rest of v8. > > BUG=v8:7164 > > Change-Id: I3e45d3e7c45f06fc362a22217ee7f0f1b70745e2 > Reviewed-on: https://chromium-review.googlesource.com/1002534 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52536} TBR=clemensh@chromium.org,vtsyrklevich@chromium.org Change-Id: I684a93d20f104244e2b74ab79ddc7d6e3a1ecf3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7164 Reviewed-on: https://chromium-review.googlesource.com/1006614Reviewed-by:
-
Simon Zünd authored
The sort benchmarks are currently in their own directory, because we might want to run them in isolation during the upcoming sort rework. R=jgruber@chromium.org, petermarshall@chromium.org Bug: v8:7382 Change-Id: Ic2e4e34d2838690529511d591099a66d0b908b0a Reviewed-on: https://chromium-review.googlesource.com/1004997Reviewed-by:
-
Vlad Tsyrklevich authored
Replace direct call to generated code with call using GeneratedCode to match the rest of v8. BUG=v8:7164 Change-Id: I3e45d3e7c45f06fc362a22217ee7f0f1b70745e2 Reviewed-on: https://chromium-review.googlesource.com/1002534 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=santa NOTREECHECKS=true Change-Id: Icb7495de49d4cb4fd675d9d7c128a94aa5e8a443 Reviewed-on: https://chromium-review.googlesource.com/1006574 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c4de990..73e352e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1bae362..2c59f67 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I984a13dc91dddbf0ab6c79eca97395aaf6ad8c56 Reviewed-on: https://chromium-review.googlesource.com/1006097Reviewed-by:
-
- 10 Apr, 2018 2 commits
-
-
Matheus Marchini authored
Before Turbofan/Ignition it was possible to use external profilers to sample running V8/Node.js processes and generate reports/FlameGraphs from that. It's still possible to do so, but non-optimized JavaScript functions appear in the stack as InterpreterEntryTrampoline. This commit adds a runtime flag which makes interpreted frames visible on the process' native stack as distinguishable functions, making the sampled data gathered by external profilers such as Linux perf and DTrace more useful. R=bmeurer@google.com, franzih@google.com, jarin@google.com, yangguo@google.com Bug: v8:7155 Change-Id: I3dc8876aa3cd9f1b9766624842a7cc354ccca415 Reviewed-on: https://chromium-review.googlesource.com/959081 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Alexei Filippov authored
If it does not, the stack may be in an unconsistent state. Bailout if so. BUG=chromium:828881 Change-Id: Ia66077d3846bf9a1d556a37fd8e0ca856f9d2464 Reviewed-on: https://chromium-review.googlesource.com/1002535Reviewed-by:
-
