- 29 Nov, 2018 14 commits
-
-
George Wort authored
This supports the use of f32 values for the arm32 port of Liftoff. Bug: v8:6600 Change-Id: I1fa2782f5a8bc6687a17d2df6e4ec8036b23452c Reviewed-on: https://chromium-review.googlesource.com/c/1354040 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57932}
-
Marja Hölttä authored
NOTRY=true Change-Id: I076e2f6c39674a98827e5939c9527678a5f81368 Reviewed-on: https://chromium-review.googlesource.com/c/1354882 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#57931}
-
Tobias Tebbi authored
Disable CSA re-scheduling for the branch point, to address performance regressions. Bug: chromium:907011 Change-Id: I608ae23c20d8e1dd9a233dcb2d3f4ab4d8a5241e Reviewed-on: https://chromium-review.googlesource.com/c/1351009Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57930}
-
Ross McIlroy authored
Swaps around the checks in CompileLazy to ensure we always enter the runtime to lazy compile if a function's SFI is uncompiled. This is necessary with bytecode flushing since the function may have an optimized code marker in the feedback vector, even if the bytecode has been flushed, and we don't want to try to optimize this flushed function. BUG=v8:8395 Change-Id: I7a348c40146673ba4a8f5e14d06995bbcc141695 Reviewed-on: https://chromium-review.googlesource.com/c/1352277 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#57929}
-
Jakob Kummerow authored
Explicitly disallow implicit casting of ObjectPtr to bool to match clang's and MSVC's behavior. Introduce a few function overloads using ObjectPtr instead of Object*. Fix printing of ObjectPtr for objects-printer.cc and GTest. Bug: v8:3770 Change-Id: I3c3580d363ae6d9fe8f743c6151abc11a915f05c Reviewed-on: https://chromium-review.googlesource.com/c/1351245 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57928}
-
tzik authored
This CL marks v8::Isolate::GetEnteredContext as deprecated in favor of replacing it with GetEnteredOrMicrotaskContext. Blink no longer uses it, and Node.js does not use this too. GetEnteredOrMicrotaskContext() is relevant for all known cases over GetEnteredContext(), and it costs 2% of a benchmark score to maintain the entered contexts under the nestable microtask context. https://crrev.com/c/1322290 is a context for the bencmark and nestable microtask contexts. Bug: v8:8124 Change-Id: I260e32daadf34dc587926a1e20ab950ff2e31699 Reviewed-on: https://chromium-review.googlesource.com/c/1353025 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57927}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Change-Id: I74a1f7a66ee31ea4e6b02286de2f99c75f596027 Reviewed-on: https://chromium-review.googlesource.com/c/1354879Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57926}
-
Michael Achenbach authored
This reverts commit ddaa1f0a. Reason for revert: Still flaky on windows. Maybe reland and keep skipped on windows? https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32%20-%20nosnap%20-%20shared/31002 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/27826 Original change's description: > Reland "[cpu-profiler] Fix stack iterability for fast C calls with no exit frame" > > This is a reland of d5f4a33e > > Original change's description: > > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > > > Before fast C calls, store the current FP and PC on the isolate. When > > iterating frames in SafeStackFrameIterator, check if these fields are > > set and start iterating at the calling frame's FP instead of the current > > FP, which will be in C++ code. We need to do this because c_entry_fp is > > not set on the Isolate for Fast-C-Calls because we don't build an exit > > frame. > > > > This change makes stack samples that occur within 'Fast-C-Calls' > > iterable, meaning we can properly attribute ticks within the JS caller. > > > > Fast-C-Calls can't call back into JS code, so we can only ever have one > > such call on the stack at a time, allowing us to store the FP on the > > isolate rather than the stack. > > > > TBR=v8-mips-ports@googlegroups.com > > > > Bug: v8:8464, v8:7202 > > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > > Reviewed-by: Alexei Filippov <alph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#57896} > > TBR=v8-mips-ports@googlegroups.com > TBR=jgruber@chromium.org > > Bug: v8:8464, v8:7202 > Change-Id: I5f37ded4ea572e8e9890ba186aa3d74a0dfc1274 > Reviewed-on: https://chromium-review.googlesource.com/c/1354042 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57912} TBR=alph@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,martyn.capewell@arm.com,v8-arm-ports@googlegroups.com,v8-mips-ports@googlegroups.com,ibogosavljevic@wavecomp.com Change-Id: If810648dbf60df2ff70455b6e8ef466136c90145 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8464, v8:7202 Reviewed-on: https://chromium-review.googlesource.com/c/1354461Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57925}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bbd67a3..b7e2add Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/6028a96..2e948dd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/17079a5..eee0f6a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib83450725f0228b99e29c05be42dd66d627917b8 Reviewed-on: https://chromium-review.googlesource.com/c/1351305 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57924}
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: If41076a377d12922cc3df859c678e1f20b99b00d Reviewed-on: https://chromium-review.googlesource.com/c/1351242 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57923}
-
Deepti Gandluri authored
Change-Id: Ia36e1b478c285752f2dafaaed509fc698acb2ccc Reviewed-on: https://chromium-review.googlesource.com/c/1354246 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#57922}
-
Jakob Kummerow authored
TransitionArray, NormalizedMapCache, DependentCode to the new design. Bug: v8:3770 Change-Id: I8bd56f231fb62b146e0fb05989418aedb62a628b Reviewed-on: https://chromium-review.googlesource.com/c/1350287 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57921}
-
Aleksei Koziatinskii authored
This method was experimental and deprecated for a while. R=dgozman@chromium.org Bug: none Change-Id: I7d5a13a83f36ecc7a92300f690dff5c8bb26f8de Reviewed-on: https://chromium-review.googlesource.com/c/1354182Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57920}
-
Aseem Garg authored
This reverts commit 9436e8a8. Reason for revert: Breaks TSAN. Original change's description: > [wasm] Add I64AtomicWait implementation > > Bug=v8:8075 > R=adamk@chromium.org,binji@chromium.org > > Change-Id: I11ef5daccd043123b23e60c93ee0df79cabe9ccd > Reviewed-on: https://chromium-review.googlesource.com/c/1342948 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ben Smith <binji@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57917} TBR=binji@chromium.org,adamk@chromium.org,aseemgarg@chromium.org Change-Id: Ic82ce8794410a0d4d19de07abd9bb8a7aaff1c1c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1351303Reviewed-by: Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57919}
-
- 28 Nov, 2018 26 commits
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: If405611d359d29ae1958beebd9202e068434a621 Reviewed-on: https://chromium-review.googlesource.com/c/1350286 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57918}
-
Aseem Garg authored
Bug=v8:8075 R=adamk@chromium.org,binji@chromium.org Change-Id: I11ef5daccd043123b23e60c93ee0df79cabe9ccd Reviewed-on: https://chromium-review.googlesource.com/c/1342948Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57917}
-
Igor Sheludko authored
Bug: v8:8477, v8:8238 Change-Id: Ice11af2becb3b88a884c9231ed9610210efcc4d6 Reviewed-on: https://chromium-review.googlesource.com/c/1352292Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57916}
-
Tom Tan authored
Two Fixes included to make V8 build work for Windows ARM64. 1. Don't emit ".def" and related macros to define function beginning, because they are invalid for Windows ARM64. 2. Set alignment of data section to 8 which is required for instruction which loads element from v8_Default_embedded_blob_. Version 7.2.479 Performance and stability improvements on all platforms. TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I0bfea5dd8ed6c1340d11c13dcc2e492e7b22aa8c Reviewed-on: https://chromium-review.googlesource.com/c/1352210Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/7.2.479@{#1} Cr-Original-Branched-From: a8152aac-refs/heads/master@{#57863} Bug: chromium:893460 Reviewed-on: https://chromium-review.googlesource.com/c/1352791Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#57915}
-
Vasili Skurydzin authored
Change-Id: I1015edc7a4522ae161dfd408db2ddcfae5dbbc69 Reviewed-on: https://chromium-review.googlesource.com/c/1352218Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57914}
-
Vasili Skurydzin authored
Bug: v8:8043 Change-Id: Iff786eccd2dcb63e46e331b096d91a6ddb13f851 Reviewed-on: https://chromium-review.googlesource.com/c/1351129Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57913}
-
Peter Marshall authored
This is a reland of d5f4a33e Original change's description: > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > Before fast C calls, store the current FP and PC on the isolate. When > iterating frames in SafeStackFrameIterator, check if these fields are > set and start iterating at the calling frame's FP instead of the current > FP, which will be in C++ code. We need to do this because c_entry_fp is > not set on the Isolate for Fast-C-Calls because we don't build an exit > frame. > > This change makes stack samples that occur within 'Fast-C-Calls' > iterable, meaning we can properly attribute ticks within the JS caller. > > Fast-C-Calls can't call back into JS code, so we can only ever have one > such call on the stack at a time, allowing us to store the FP on the > isolate rather than the stack. > > TBR=v8-mips-ports@googlegroups.com > > Bug: v8:8464, v8:7202 > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57896} TBR=v8-mips-ports@googlegroups.com TBR=jgruber@chromium.org Bug: v8:8464, v8:7202 Change-Id: I5f37ded4ea572e8e9890ba186aa3d74a0dfc1274 Reviewed-on: https://chromium-review.googlesource.com/c/1354042Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57912}
-
Peter Marshall authored
These two tests fail if the memory used by builtins increases too much. They aren't intended to monitor the memory used by builtins, so these failures are spurious. Bug: v8:8521 Change-Id: I67e61abe30aaf69aeb3e6a2c885795061a318851 Reviewed-on: https://chromium-review.googlesource.com/c/1354041 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57911}
-
George Wort authored
This implements arithmetic operations on i64, as well as eqz and conditional set for the arm32 port of Liftoff. Bug: v8:6600 Change-Id: I21dc0f820e1429392599a5813c44b938c38093a2 Reviewed-on: https://chromium-review.googlesource.com/c/1348082 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57910}
-
George Wort authored
This allows f32 floor, ceil, trunc, and nearest_int to use a C fallback in Liftoff in the same way that f64 rounding can. Bug: v8:6600 Change-Id: I8b88d806633bcfe2d2dfac9defaf60e551bf21b1 Reviewed-on: https://chromium-review.googlesource.com/c/1353898 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57909}
-
Leszek Swirski authored
Changing the current file causes issues with gcov. Bug: v8:8517 Change-Id: Ic9959c64c36a027d205f9bb5aafcee08c84be15f Reviewed-on: https://chromium-review.googlesource.com/c/1353899Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57908}
-
Clemens Hammacher authored
This saves a few control merges in Liftoff, and might also generate smaller graphs in Turbofan. R=titzer@chromium.org Bug: v8:6600, v8:8423 Change-Id: Ice921f8b048809bc38b820b94688f482e67bd386 Reviewed-on: https://chromium-review.googlesource.com/c/1354039Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57907}
-
Yang Guo authored
Example: ~/v8$ tools/deprecation_stats.py include/v8.h --before=2018-10-01 Marked as V8_DEPRECATE_SOON: 21 556 : 2017-11-15 11:00:49 : V8_INLINE void MarkIndependent() 568 : 2017-11-15 11:00:49 : V8_INLINE bool IsIndependent() const 2404 : 2018-09-24 13:05:31 : V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(Local<Context> context) const 2421 : 2015-03-09 10:49:09 : Local<Number> ToNumber(Isolate* isolate) const 2423 : 2015-03-09 10:49:09 : Local<String> ToString(Isolate* isolate) const <...> 3416 : 2015-03-09 10:49:09 : Local<Array> GetOwnPropertyNames() 3516 : 2015-03-09 10:49:09 : bool HasRealNamedProperty(Local<String> key) 3533 : 2015-03-09 10:49:09 : bool HasRealIndexedProperty(uint32_t index) 3537 : 2015-03-09 10:49:09 : bool HasRealNamedCallbackProperty(Local<String> key) Marked as V8_DEPRECATED: 9 1395 : 2018-09-21 23:40:51 : const CachedData* GetCachedData() const 1853 : 2018-09-20 11:46:49 : MaybeLocal<Value> Parse(Isolate* isolate, Local<String> json_string) 1953 : 2018-09-20 11:46:49 : std::vector<uint8_t> ReleaseBuffer() 1977 : 2018-09-20 11:46:49 : void TransferSharedArrayBuffer(uint32_t transfer_id, Local<SharedArrayBuffer> shared_array_buffer) 5093 : 2018-09-20 11:46:49 : Local<Value> New(Isolate* isolate, double time) 6355 : 2018-09-20 11:46:49 : size_t max_semi_space_size() 6361 : 2018-09-20 11:46:49 : void set_max_semi_space_size(size_t limit_in_mb) 6380 : 2018-09-20 11:46:49 : size_t max_executable_size() const 6384 : 2018-09-20 11:46:49 : void set_max_executable_size(size_t limit_in_mb) R=delphick@chromium.org Change-Id: I723055d30457a4061cdc589a4be09c0279fd5923 Reviewed-on: https://chromium-review.googlesource.com/c/1352307 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#57906}
-
Clemens Hammacher authored
This constant is unused, and should never be used, since name sections are encoded as an unknown section with the special name "name". R=ahaas@chromium.org Change-Id: I2fa1a21506dbe30033aecb3c1bf9ad84b6b872bc Reviewed-on: https://chromium-review.googlesource.com/c/1352305Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57905}
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:8091 Change-Id: I9564b7836667089112b958f1e8644b35ffa855a8 Reviewed-on: https://chromium-review.googlesource.com/c/1352301 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57904}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I54db2251378147df63ca20f3d32d286186f3b784 Reviewed-on: https://chromium-review.googlesource.com/c/1352306Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57903}
-
George Wort authored
This makes changes to the generic code in Liftoff to support f32 values on the arm32 port, but does not implement any handling of them in practice. Bug: v8:6600 Change-Id: Ia1587c4eee0158ef6b0caa46b6b212cb96ef579f Reviewed-on: https://chromium-review.googlesource.com/c/1352287 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57902}
-
George Wort authored
This reduces wasm's ABI on Arm to only using the even-numbered float registers in anticipation of Liftoff supporting f32 values on the arm32 port. This is due to Liftoff assuming a one-to-one mapping between double and float registers. The ABI must be restricted in order to allow Liftoff compiled and Turbofan compiled functions to call each other. Turbofan continues to use all float registers internally however. Bug: v8:6600 Change-Id: I47d91b8216136e57f42fd9665ed57ec631eb0374 Reviewed-on: https://chromium-review.googlesource.com/c/1352278Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57901}
-
Andreas Haas authored
This new spec test version is https://github.com/WebAssembly/spec/pull/922 now. R=titzer@chromium.org Change-Id: I4e88e6fb5d20e0ab1d4c1011db88171937c0ff86 Reviewed-on: https://chromium-review.googlesource.com/c/1352300Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57900}
-
Maya Lekova authored
This reverts commit d5f4a33e. Reason for revert: Seems to cause a no snapshot build failure - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/21967 Original change's description: > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > Before fast C calls, store the current FP and PC on the isolate. When > iterating frames in SafeStackFrameIterator, check if these fields are > set and start iterating at the calling frame's FP instead of the current > FP, which will be in C++ code. We need to do this because c_entry_fp is > not set on the Isolate for Fast-C-Calls because we don't build an exit > frame. > > This change makes stack samples that occur within 'Fast-C-Calls' > iterable, meaning we can properly attribute ticks within the JS caller. > > Fast-C-Calls can't call back into JS code, so we can only ever have one > such call on the stack at a time, allowing us to store the FP on the > isolate rather than the stack. > > TBR=v8-mips-ports@googlegroups.com > > Bug: v8:8464, v8:7202 > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57896} TBR=alph@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,martyn.capewell@arm.com,v8-arm-ports@googlegroups.com,v8-mips-ports@googlegroups.com,ibogosavljevic@wavecomp.com Change-Id: I85f846e57b6fa845e7770c616435cebffdb2a245 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8464, v8:7202 Reviewed-on: https://chromium-review.googlesource.com/c/1352302Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#57899}
-
Jacob Bramley authored
The test was flaky because it assumed that AllocatedAssemblerBuffer would eventually return an address within near-call range. Rarely, this did not happen (within the retry limit), and so the test would crash. This fix allocates a single, kMaxWasmCodeMemory-sized buffer for the test, and generates call sequences within that buffer. BUG=v8:8245 Change-Id: I4b44d897c6cbda15a18ab992fa57805de3b2db29 Reviewed-on: https://chromium-review.googlesource.com/c/1347484Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jacob Bramley <jacob.bramley@arm.com> Cr-Commit-Position: refs/heads/master@{#57898}
-
Toon Verwaest authored
Change-Id: Iadc3d916dcda6f03c467e77fedff6d315dbb67f6 Reviewed-on: https://chromium-review.googlesource.com/c/1352299Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57897}
-
Peter Marshall authored
Before fast C calls, store the current FP and PC on the isolate. When iterating frames in SafeStackFrameIterator, check if these fields are set and start iterating at the calling frame's FP instead of the current FP, which will be in C++ code. We need to do this because c_entry_fp is not set on the Isolate for Fast-C-Calls because we don't build an exit frame. This change makes stack samples that occur within 'Fast-C-Calls' iterable, meaning we can properly attribute ticks within the JS caller. Fast-C-Calls can't call back into JS code, so we can only ever have one such call on the stack at a time, allowing us to store the FP on the isolate rather than the stack. TBR=v8-mips-ports@googlegroups.com Bug: v8:8464, v8:7202 Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 Reviewed-on: https://chromium-review.googlesource.com/c/1340241 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#57896}
-
Dan Elphick authored
Bug: v8:7295, v8:8238 Change-Id: Ide105b69ee77707a5a28d16abfb1ab44ebc3995d Reviewed-on: https://chromium-review.googlesource.com/c/1352273Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#57895}
-
Marja Hölttä authored
BUG=v8:7490,v8:8238 Change-Id: Id55ad482903abac635981d9e417e255fec427c52 Reviewed-on: https://chromium-review.googlesource.com/c/1352285Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57894}
-
Jakob Kummerow authored
pending a better approach. Bug: v8:8516 Change-Id: Ic107184b46c85ae5724619cc82c99686aee7edb9 Reviewed-on: https://chromium-review.googlesource.com/c/1352794Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57893}
-