Commits · 4e9b4a7b590f84fd59dfda52f51e1cbbda425673 · Linshizhi / V8

24 May, 2013 23 commits

MIPS: Replace tagged keys for fast access by smi, and use smi in boundscheck. · 4e9b4a7b

palfia@homejinni.com authored May 24, 2013

Port r14794 (05b08564)

BUG=

Review URL: https://codereview.chromium.org/15937009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4e9b4a7b

Un-flake test-cpu-profiler/SampleWhenFrameIsNotSetup · 77d93014

yurys@chromium.org authored May 24, 2013

It is OK for FindChild to return NULL. If the child must
exist GetChild should be used to force the assertion.

BUG=v8:2628
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15786004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77d93014

trace compare_nil_ic state in --trace-ic output · 2952a77d

olivf@chromium.org authored May 24, 2013

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15735020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14808 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2952a77d

Fix hole handling, and ensure smi representation is handled properly · 2a28f53b

verwaest@chromium.org authored May 24, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16013003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2a28f53b

Remove offset() and is_in_object() from hydrogen and lithium LoadNamedField... · 77f85fa0

titzer@chromium.org authored May 24, 2013

Remove offset() and is_in_object() from hydrogen and lithium LoadNamedField and StoreNamedField and use the appropriate methods on HObjectAccess instead

BUG=

Review URL: https://codereview.chromium.org/15881003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77f85fa0

Prepare push to trunk. Now working on version 3.19.5. · b4cafa4e

svenpanne@chromium.org authored May 24, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/16002003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4cafa4e

DummyUse if Representation::Tagged()+Type::Smi() to Representation::Smi() · eaec0b10

verwaest@chromium.org authored May 24, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15778006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eaec0b10

Update representation-from-uses to support smi. · c417df74

verwaest@chromium.org authored May 24, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15692004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c417df74

fix some names in compare nil ic · 7aa74c3d

olivf@chromium.org authored May 24, 2013

The compare nil ic introduces a mechanism called lightweight miss. The
idea is to insert a direct call to the miss handler instead of going
through the deopt routine. This can be use for uninitialized stubs, to
directly jump to the runtime.

This cl
1. Cleans up naming
2. localizes the lightweight miss functionality on the only user (compare nil ic)
3. fixes DoCodegen, to actually call the correct method (uninitialized vs initialized)

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/15806005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7aa74c3d

Fix edge case in stack trace formatting. · 7c2a1346

yangguo@chromium.org authored May 24, 2013

Bug description: in strict mode, null as receiver is not implicitly converted
to the global object, so that when formatting the stack trace, the receiver of
the stack frame is null. The IS_OBJECT check returns true for null, but
%GetDataProperty expected a JSObject, which results in a failed RUNTIME_ASSERT.

R=mvstanton@chromium.org
BUG=237617

Review URL: https://chromiumcodereview.appspot.com/15670003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14797 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c2a1346

Make (most of) --trace-codegen available in release mode. Better output. · 7c0f77a4

svenpanne@chromium.org authored May 24, 2013

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/15941004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14796 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c0f77a4

fix thread safety issue in FunctionTemplate test · dc9e80be

svenpanne@chromium.org authored May 24, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15791005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14795 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dc9e80be

Replace tagged keys for fast access by smi, and use smi in boundscheck. · c9a22a3c

verwaest@chromium.org authored May 24, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15763004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c9a22a3c

Introduce ObjectAccess, which is used by LoadNamedField and StoreNamedField to... · 94b4240f

titzer@chromium.org authored May 24, 2013

Introduce ObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts of an object are referred to by a given load or store. Refactor HGraphBuilder to use ObjectAccess, which removes the need to manually set GVN flags and simplifies the code as well.

Review URL: https://codereview.chromium.org/14284010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14791 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

94b4240f

Add belated test for the SeqStringSetChar bug. · 1d393554

yangguo@chromium.org authored May 24, 2013

R=titzer@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15849003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14790 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d393554

callback handler map not correctly populated by direct use of SetCallHandler · 91efd1e7

dcarney@chromium.org authored May 24, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15814005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

91efd1e7

MIPS: Fix assert on ARM · 22a336c1

palfia@homejinni.com authored May 24, 2013

Port r14781 (a3491cb7)

BUG=

Review URL: https://codereview.chromium.org/15952002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14788 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

22a336c1

MIPS: Require smi for keyed store to smi. · 8b8232e2

palfia@homejinni.com authored May 24, 2013

Port r14779 (33d24080)

BUG=

Review URL: https://codereview.chromium.org/15889007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14787 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b8232e2

MIPS: Tag length of FixedArrayBase and smi-array[x] as smi representation · 4b0f9cd4

palfia@homejinni.com authored May 24, 2013

Port r14778 (c7fdf61b)

BUG=

Review URL: https://codereview.chromium.org/15927005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14786 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4b0f9cd4

MIPS: Improve SeqStringSetChar implementation. · 31080249

palfia@homejinni.com authored May 24, 2013

Port r14769 (f0000b20)

BUG=

Review URL: https://codereview.chromium.org/15949002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14785 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31080249

MIPS: Always require exact maps. · 6aef61b5

palfia@homejinni.com authored May 24, 2013

Port r14768 (5dec309f)

BUG=

Review URL: https://codereview.chromium.org/15948003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14784 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6aef61b5

MIPS: Omit smi-check for write-barrier unless tagged. · 344d9057

palfia@homejinni.com authored May 24, 2013

Port r14767 (40dd85ec)

BUG=

Review URL: https://codereview.chromium.org/15745021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

344d9057

MIPS: Implement HChange support for Smis and use it in Load/StoreNameField · ae74636c

palfia@homejinni.com authored May 24, 2013

Port r14765 (22625125)

BUG=

Review URL: https://codereview.chromium.org/15781006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ae74636c

23 May, 2013 17 commits

Fix assert on ARM · b2e8d4c5

verwaest@chromium.org authored May 23, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15886004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14781 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b2e8d4c5

Simplifying GC heuristics, deleted old generation allocation limit. · 0d5dd777

hpayer@chromium.org authored May 23, 2013

BUG=

Review URL: https://codereview.chromium.org/14700006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14780 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d5dd777

Require smi for keyed store to smi. · d057410e

verwaest@chromium.org authored May 23, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15884002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14779 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d057410e

Tag length of FixedArrayBase and smi-array[x] as smi representation · 632f5918

verwaest@chromium.org authored May 23, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15858006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14778 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

632f5918

Fix embedded new-space pointer in LCmpObjectEqAndBranch. · 8fb20868

mstarzinger@chromium.org authored May 23, 2013

R=mvstanton@chromium.org
BUG=chromium:240032
TEST=mjsunit/regress/regress-crbug-240032

Review URL: https://codereview.chromium.org/15779004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14777 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8fb20868

Add asserts to String::GetFlatContent. · 6a806b99

yangguo@chromium.org authored May 23, 2013

R=verwaest@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/13841012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6a806b99

Missing type cell on ia32 from bindings. · 1a4482ab

mvstanton@chromium.org authored May 23, 2013

Javascript constructors called from C++ code didn't have a type cell
properly filled in on ia32. This showed up as a bug in webkit bindings.
Re-enabled flag optimize-constructed-arrays.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/15870002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14775 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1a4482ab

Don't use fast literal if the boilerplate map is still deprecated. · af451684

verwaest@chromium.org authored May 23, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15660005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14774 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af451684

Fix Windows build after r14770 · 28729d24

dslomov@chromium.org authored May 23, 2013

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15848003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28729d24

Externalization API for ArrayBuffer · fc73052d

dslomov@chromium.org authored May 23, 2013

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15001041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc73052d

Improve SeqStringSetChar implementation. · a1e18bdf

yangguo@chromium.org authored May 23, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15743006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1e18bdf

Always require exact maps. · 06b7bf60

verwaest@chromium.org authored May 23, 2013

R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13923003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

06b7bf60

Omit smi-check for write-barrier unless tagged. · d41f9290

verwaest@chromium.org authored May 23, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15848002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d41f9290

Avoid creating duplicate entries for a value when merging HSimulates · f691f48c

jkummerow@chromium.org authored May 23, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/15660003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f691f48c

Implement HChange support for Smis and use it in Load/StoreNameField · 308e6975

verwaest@chromium.org authored May 23, 2013

BUG=
R=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15303004

Patch from Daniel Clifford <danno@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14765 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

308e6975

de-isolate Persistent::Dispose · 36694884

dcarney@chromium.org authored May 23, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15648008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14764 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

36694884

Move global pretenuring flag check to ShouldGloballyPretenure(). · 2cbc81a5

hpayer@chromium.org authored May 23, 2013

BUG=

Review URL: https://codereview.chromium.org/15734007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2cbc81a5