- 11 Mar, 2019 6 commits
-
-
Mythri authored
This is a pre-work for allocating feedback vectors lazily. Feedback cells are required to share the feedback vectors across the different closures of the same function. Currently, they are held in the CreateClosureSlot in the feedback vector. With lazy feedback vector allocation, we may not have a feedback vector. However, we still need a place to store the feedback cells, so if feedback vector is allocated in future it can still be shared across closures. Here is the detailed design doc: https://docs.google.com/document/d/1m2PTNChrlJqw9MiwK_xEJfqbFHAgEHmgGqmIN49PaBY/edit BUG=v8:8394 Change-Id: Ib406d862b2809b1293bfecdcfcf8dea3127cb1c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503753 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60147}
-
Clemens Hammacher authored
The {id_} stored in {ThreadId} should not be atomic. Only getting a new id for the current thread needs to be atomic. If any user of {ThreadId} needs atomicity, that user should wrap {ThreadId} in a {std::atomic} instead. Drive-by: Remove {Equals} method, use {operator==} instead. Drive-by: Move static methods after member methods. R=ishell@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Bug: v8:8834 Change-Id: Id0470eb2fa907948843ac1153e2dc5dcd9a8fbc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1494006Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60146}
-
Michael Lippautz authored
v8::EmbedderHeapTracer::TracePrologue may call back into V8 during StartMarking. In this case we expect that the write barriers are set up and consistent, i.e., global flag matches page flag. Blink calls back into V8 in a corner case where sweeping is finalized on incremental marking start which may trigger resettting a V8 Value which may trigger DescriptorArray re-shuffling. Bug: chromium:940003 Change-Id: Ia15c798d0faaab802df1c3b569b5b6a323a4fe59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514492Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60145}
-
Shiyu Zhang authored
Currently, if input types are not string or number, ToString builtin will fall into runtime and a loop of ToPrimitive and type-checks is done in runtime, which is slow. This CL reimplements ToString to add support for that ToPrimitive and type-checks loop in CSA instead of runtime to improve performance. This will benefit Array.prototype.toString/join a lot when the array elements are objects. This Cl improves the performance of Speedometer2.0 EmberJS-Debug case by ~14% on Atom. Change-Id: I27c2669097be1e542e30119cdffcf79c0d16a0eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1498698 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60144}
-
Jaroslav Sevcik authored
If the branch associated with the condition is kDead, the current node will be killed anyway, so let us just survive the lowering. Bug: chromium:935092 Change-Id: If7b39e3b5452d6c9bc5199080eb38725e6c4eab5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1488769Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60143}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8da0480..61c98e6 Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/b552862..299e687 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If1c6e07dac6b0cc58a03307e737353ebb9fceb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513938Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60142}
-
- 10 Mar, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0ee4cbc..8da0480 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/26a1944..b88eedc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I67809fa36e3df8e65e2bb59a62d902c91675be23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513319Reviewed-by:
-
- 09 Mar, 2019 6 commits
-
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org Bug: chromium:934964 Change-Id: I95ffd94f31c60b0e82cac7653ad4e5978bd3b9d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503759Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60140}
-
Anna Henningsen authored
This should not be used anymore (and it definitely is not by Node.js or Chromium). Change-Id: I4a1ce1fda98efd197a64ce0969dae5c8b18f6e97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511484Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60139}
-
Deepti Gandluri authored
Integer splats should use an operand when a register is not allocated. Bug: V8:8927 Change-Id: I14c80b7b073fae3754ec32f4fa8605af399ef341 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513102Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60138}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ba214bf..0ee4cbc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a07cd8f..26a1944 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2f3c820..3485a26 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I8b2d600c00d4a84db60c36ae87fd6e8ecede8b56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513165Reviewed-by:
-
Yu Yin authored
We want to compare two inputs so need to perform the same operation(ExtractBits) on them. Change-Id: I6c81884fdd34dfa125b842f010cd40f8a6816a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511132Reviewed-by:
-
Deepti Gandluri authored
Change-Id: Ie080683af1d990e5205c75a2a199f0581d826811 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511630 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#60135}
-
- 08 Mar, 2019 26 commits
-
-
Sathya Gunasekaran authored
This allows the devtools to preview the private fields that are installed on an object. Change-Id: I6d8aad7ad0e51cdf18f6139b4bb8665e4b606aa5 Bug: v8:8773, v8:8337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1487914 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60134}
-
Z Duong Nguyen-Huu authored
Script, PrototypeInfo, JSCollectionIterator, JSWeakCollection, JSSloppyArgumentsObject, JSArgumentsObject Bug: v8:8952 Change-Id: Id0d7049f3d5971a0fd4af56dd4850ad3b44c22e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506198 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Matt Gardner authored
Call to ReduceKeyedLoadFromHeapConstant got lost in rebasing, as did the kHas check in ReduceElementAccessOnString. Added some tests to ensure both cases are covered. Change-Id: I8d6992c33315436b6228471b9bc57e3b267ad09f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508837Reviewed-by:
-
Z Duong Nguyen-Huu authored
This is the reland of https://chromium-review.googlesource.com/c/v8/v8/+/1495898 builtin_function_id corresponded to BuiltinFunctionId (a manually maintained list of 'interesting' functionsmainly used during optimization). With this change, we nuke builtin-function-id in favor of builtin-id and 8 bits is freed up in SFI. Bug: v8:6993 Change-Id: I7e1681cc2a95864c71ce8bdda075481310607166 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506445Reviewed-by:
-
Z Duong Nguyen-Huu authored
TemplateInfo, FunctionTemplateRareData, FunctionTemplateInfo, ObjectTemplateInfo Bug: v8:8952 Change-Id: Ib355cf825ca8c57be45d3a55ff595d356c8737ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504774Reviewed-by:
-
Junliang Yan authored
the problem is that we call irregexp code in two ways: 1. CallCFunction9 from CSA builtins 2. Through GeneratedCode::Call from the runtime. 1 is a standard C call and expects the target to be a FD, 2 is our own implementation where we dynamically generate a FD. So there's a mismatch between the two. Change-Id: I8391db30fa7586d296b5d1880a7f44dafad21a2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1487341 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Auto-Submit: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Mike Stanton authored
This CL contains find, findIndex, every and some. Now that we've established the pattern on the torque side for iterating array builtins, it's a very easy port, which nonetheless decreases code size in the snapshot, w00t! Bug: v8:8906 Change-Id: I3082d8e3e298e55733a42d6b441e5812b7f12f3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496976 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60128}
-
Clemens Hammacher authored
Reusing the same {Binary} object (with the same {ArrayBuffer} underneath) speeds up the limits test with 1M functions by a factor of 11x in an optdebug build. R=titzer@chromium.org Change-Id: I36d032d652c66f5b7f5a80399588652d7e3946ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511475Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60127}
-
Clemens Hammacher authored
R=sigurds@chromium.org Bug: v8:7490, v8:8834 Change-Id: I5d94c2f262826977bbf15ad32a10875f01304039 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505432Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
inspector target has header come from protocol_generated_sources in sources. So protocol_generated_sources needs to be in public_deps. Bug: chromium:931596 Change-Id: I3b5ea390e79549b48930b16819840e1a0f87304b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506994 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL cleans up a few things as noted by binji in https://github.com/WebAssembly/spec/pull/979, plus a few more I found along the way. In particular: 1) Remove the unused and incorrect {bytesWithHeader} method. 2) Introduce kMaxVarInt32Size and kMaxVarInt64Size constants. 3) Remove redundant {ensure_space} calls (irrelevant for performance). 4) Use {toModule} method instead of duplicating code. 5) Merge two identical leb encoding implementations. R=titzer@chromium.org CC=binji@chromium.org Change-Id: Idec74e2e46a71766107c182a4176c516d883adad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511273 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Change-Id: I60b39b08ab6843826a92b78b4f9e96e485f86198 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511479Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60123}
-
Igor Sheludko authored
... but do it once for the whole group of tests instead. Bug: v8:8929 Change-Id: I4c92a4cc29f8cf8a1011a563fe41972844c59972 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511476Reviewed-by:
-
Clemens Hammacher authored
A minor improvement to copy over all bytes at once. R=titzer@chromium.org CC=binji@chromium.org Change-Id: Ia9264a28afa76a5ed51d378d0db5bb192aeef2b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511272 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jakob Gruber authored
My standard procedure for debugging regexp builtin fuzzer finds is to turn on verbose mode and run the repro. This extends verbose output to include the generated script which contains e.g. the regexp pattern, the subject string, and the actual function call. Tbr: yangguo@chromium.org Bug: v8:8968 Change-Id: I0c7e930f4cbd34014f2781ca280919c5b002b049 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511276Reviewed-by:
-
Sigurd Schneider authored
This modifies the ObjectVisitor to provide a dedicated VisitEphemeron method invoked when visiting a EphemeronHashTable. This is pre-work for further changes to how ephemerons are handled during scavenging. Bug: v8:8557 Change-Id: Ia423b10667ec222cbe5f44d8a931ea33314625f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508673Reviewed-by:
-
Mike Stanton authored
Optimizations to use fast memmove to move elements are preserved, as well as heuristics for bailout to the runtime if left or right trimming is desired. Bug: v8:7672 Change-Id: I01ffc1143b63d705d99a40eab3a7e873596d0aa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499495 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
It's not being used, and causes compile errors on windows because of a name clash (see referenced bugs). R=mstarzinger@chromium.org CC=tebbi@chromium.org, jarin@chromium.org Bug: v8:8953 Change-Id: I22dcdbcbe92f92c390a2f2cdd289dda7f7dc4eb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505794Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60117}
-
Michael Starzinger authored
This updates the existing bootstrap.sh script for gcmole to work against LLVM and Clang version 8.0 releases. This is a follow-up to a previous change which adapted the gcmole plugin to compile against those same versions. R=mslekova@chromium.org BUG=v8:8813 Change-Id: Id6052fb9a7ec8a63d205eab2d4e233e2121c733d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511275Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60116}
-
Andreas Haas authored
We have to create WasmExportedFunction objects for any WebAssembly function which may escape a WebAssembly instance. Up until now we created these WasmExportedFunction objects eagerly during instantiation time: for any exported function, and any element in an exported table we create such an object. With the anyref proposal, the table.get instruction can allow any function in a table to escape its instance. Therefore we would have to create a WasmExportedFunction object for any function which is put into a table. With this CL we create WasmExportedFunctions for table entries lazily. We initialize tables with placeholders consisting of the instance and the function index. If we encounter a placeholder in table.get, we create the WasmExportedFunction for the expected function to return it. R=mstarzinger@chromium.org CC=titzer@chromium.org Bug: v8:7581 Change-Id: I4f32bd7433285d0b04a22c0fb70b736bac55b3f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505575Reviewed-by:
-
Pavel Medvedev authored
instead of forwarding template constructors for these classes introduced in edab9a20 commit. TurboAssemblerBase constructors were declared as public to make the inherited TurboAssembler, and MacroAssembler ctors also public. This fixes Visual C++ 2017 compile error, when the template ctor in TurboAssemblerBase class matches deleted copy ctor. Bug: v8:8935 Change-Id: I1144a7025830c3a0ab86acaa8ea81def02d293b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496977Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60114}
-
Junliang Yan authored
Change-Id: I7d71c8cf4f7c0d1b833dc560b0d7418b1739e81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1508595 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Auto-Submit: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Jakob Kummerow authored
RotateRight32 needs a "number of bits" operand in the range 0..31. Thankfully that's how x86 shift instructions behave anyway, and how the bitwise shift operators in JavaScript are spec'ed, so this fix is unobservable in non-UBSan builds. RemoveArrayHolesGeneric can be used for length values anywhere in the uint32_t range, so it must not implicitly cast those to int. That actually caused an observable bug where a proxy's traps would not get called at all, but only for huge "length" properties, where the entire operation would also be painfully slow. Bug: chromium:935133, chromium:937652 Change-Id: I13f74ca27eae6b2b089d58217842b699b2574509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510272 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Bill Budge authored
- Converts most integer vector tests to use globals (except Select) so results can be checked in C++ code. - Remove integer vector result checking macros. - Add specializations of test CompareOps for floats, so we can use BinOps for integer vector compare opcodes. - Remove Run#format#CompareOpTests helper functions for integer vector types. Use Run#BinOpTests helper function instead. Bug: v8:6020 Change-Id: I968a71c874b028a750e1118cf51f6678cae90091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496281 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60111}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/37fdf54..ba214bf Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/44dfa15..b552862 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ccc2908..a07cd8f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ffb1ffb..2f3c820 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8d60039..60462ac TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I687a2ab71f8b6484d864a86db2579d55ded3882e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510578Reviewed-by:
-
Bill Budge authored
This is a reland of 821bc649 Original change's description: > [wasm simd] Fix F32x4 Min and Max > > - Fix F32x4 tests to save results in globals, so they can be checked > in C++ code. Perform correct checks in case of NaNs. > - Fix ia32, x64 implementations of F32x4Min, F32x4Max to correctly > deal with NaNs. > - Enable tests for all float values on all platforms, except skip > denormalized results on ARM, and skip extreme values for reciprocal, > reciprocal square root approximation opcodes. > - Disable Min, Max test for interpreter (see v8:8425) since it doesn't > handle NaNs correctly. > - Fix vmin, vmax implementations in ARM simulator. > > Bug: v8:8639 > Change-Id: I87e188e3cb078f09fdacfd9955f426c20a11bf64 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495897 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60021} Bug: v8:8639 Change-Id: Ic557aa1d323693eabf5885ff5eddc15e3174079b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501279Reviewed-by:
-
- 07 Mar, 2019 1 commit
-
-
Frank Tang authored
Antarctica/DumontDUrville has special casing. Bug: chromium:928068 Change-Id: I8aea2fafc2c14d6fbfee8a95910df7e8d7d1ff37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507329Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60108}
-
