- 14 Jun, 2010 1 commit
-
-
ricow@chromium.org authored
(fixes bug 619). This also fixes a bug in GetOwnProperty in runtime.cc discovered by the new test cases. That part of the code was not testable before since we had no way of correctly defining properties on elements. Review URL: http://codereview.chromium.org/2832001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4862 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2010 1 commit
-
-
ricow@chromium.org authored
The existing version will overwrite the existing writable flag with false even in the case where no new value is given and the existing writable flag is true. The reason for the issue is that there is no check to see if the provided descriptor actually has a writable attribute. This causes us to use the default value (false) even in the case where nothing was provided. In addition, the existing tests makes wrong assumptions (that writable is always set to false if not provided) and has been changed to follow the specification. Review URL: http://codereview.chromium.org/2271001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 May, 2010 1 commit
-
-
ricow@chromium.org authored
Object.defineProperty with empty property descriptor. The issue is fixed by implementing step 5 and 6 from DefineOwnProperty in the specification (ES5 8.12.9). This also fixes a bug in SameValue when used on boolean values (it would priorly return a number - not a boolean). Review URL: http://codereview.chromium.org/2131019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Feb, 2010 1 commit
-
-
ricow@chromium.org authored
DefineOrRedefineDataProperty to avoid invalid input. Added tests to object-define-property.js to test that it does not crash on invalid input. Review URL: http://codereview.chromium.org/572005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Feb, 2010 1 commit
-
-
ricow@chromium.org authored
DefineOwnProperty (changed to allow for redefinition of existing property) SameValue Extra info on propertydescriptor GetProperty HasProperty Currently the DefineOrRedefineAccessorProperty deletes the existing property on the object if it is a dataproperty (FIELD or NORMAL) and adds a new one. This can potentially be optimized. Review URL: http://codereview.chromium.org/555149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3786 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-