- 19 Jul, 2019 7 commits
-
-
Michael Starzinger authored
This adds decoding and compilation of the "atomic.fence" operator, which is intended to preserve the synchronization guarantees of higher-level languages. Unlike other atomic operators, it does not target a particular linear memory. It may occur in modules which declare no memory, or a non-shared memory, without causing a validation error. See proposal: https://github.com/WebAssembly/threads/pull/141 See discussion: https://github.com/WebAssembly/threads/issues/140 R=clemensh@chromium.org TEST=cctest/test-run-wasm-atomics/RunWasmXXX_AtomicFence BUG=v8:9452 Change-Id: Ibf7e46227f7edfe5c81c097cfc15924c59614067 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701856 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#62821}
-
Clemens Hammacher authored
Every time we clang-format this list, one more element gets stripped off into its own line. Fix this by disabling clang-format for this chunk (we did the same for the chunk below). R=mstarzinger@chromium.org Change-Id: I49efdccc78eb4186cdb15513600594d539082fd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708478Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62820}
-
Frank Tang authored
Sync with https://github.com/tc39/proposal-unified-intl-numberformat/pull/54 Bug: v8:9483 Change-Id: I2aec5a78be235bddd4faa568665b73b9b84d7c93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700426Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62819}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fb75973..c986429 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f8c5b19..42a883d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9217ff8..f4e0cc6 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/29ddc91..558ca3e TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I6e01c52d33ed9745dcfc170d829fa31545368ec1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1709112Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62818}
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I3e649e1398be429b8aff5b57316e320f9ca5ae8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1703763 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: Ica8329efa9be5944037e205f371d2bc34b882e0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1703762Reviewed-by:
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I132f7332d3dda572b72404ca20297c4defb5c62b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708450Reviewed-by:
-
- 18 Jul, 2019 23 commits
-
-
Andreas Haas authored
R=binji@chromium.org Change-Id: I01721c708b1e40cdef4bd48a1f9ca68b31c8f49d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708470Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62814}
-
Z Nguyen-Huu authored
Reflect.deleteProperty now is a Torque builtins, also containing fast path for proxy object. Bug: v8:6664 Change-Id: I76d6fba2c9d05d991132957783d987a190585ec8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1704943 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#62813}
-
Adam Klein authored
This fixes the debug code which checks that API callbacks return only valid JS values: BigInt was missing from the list of allowable types. Bug: chromium:985115 Change-Id: I8b3db409bd99e9e9b936d520d0fdbe75654e7602 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706623Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#62812}
-
Clemens Hammacher authored
This reverts commit bc33f5ae. Reason for revert: Still failing (OOM on win32): https://ci.chromium.org/p/v8/builders/ci/V8%20Win32/22210 Original change's description: > Reland "[arraybuffer] Rearchitect backing store ownership" > > This is a reland of 31cd5d83 > > Original change's description: > > [arraybuffer] Rearchitect backing store ownership > > > > This CL completely rearchitects the ownership of array buffer backing stores, > > consolidating ownership into a {BackingStore} C++ object that is tracked > > throughout V8 using unique_ptr and shared_ptr where appropriate. > > > > Overall, lifetime management is simpler and more explicit. The numerous > > ways that array buffers were initialized have been streamlined to one > > Attach() method on JSArrayBuffer. The array buffer tracker in the > > GC implementation now manages std::shared_ptr<BackingStore> pointers, > > and the construction and destruction of the BackingStore object itself > > handles the underlying page or embedder-allocated memory. > > > > The embedder API remains unchanged for now. We use the > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > > keep the backing store alive properly, even in the case of aliases > > from live heap objects. Thus the embedder has a lower chance of making > > a mistake. Long-term, we should move the embedder to a model where they > > manage backing stores using shared_ptr to an opaque backing store object. > > > > R=mlippautz@chromium.org > > BUG=v8:9380,v8:9221 > > > > Change-Id: I48fae5ac85dcf6172a83f252439e77e7c1a16ccd > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584323 > > Commit-Queue: Ben Titzer <titzer@chromium.org> > > Reviewed-by: Ben Titzer <titzer@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#62572} > > Bug: v8:9380, v8:9221 > Change-Id: If3f72967a8ebeb067c0edcfc16ed631e36829dbc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691906 > Commit-Queue: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62809} TBR=ulan@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org Change-Id: Iea755df9aaa1e95d284135bd0a6681b1340b6832 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9380, v8:9221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708487Reviewed-by:
-
Peter Marshall authored
Previously both tracing implementations would be run side-by-side when perfetto was enabled with the V8_USE_PERFETTO build flag. This CL makes them run separately. Both implementations now use the trace file provided by the user in D8 or the default v8_trace.json. Add tests for perfetto events (which must be tested differently due to the proto output format). Drive-by fix: Fix pass-by non-const ref in GetJSONStrings. Remove the TraceEvent struct for testing; we can just store a copy of the protobuf directly. Bug: v8:8339 Change-Id: Id50003e0f96e44b99a63a26693da6bdaca989504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1702619Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This is a reland of 31cd5d83 Original change's description: > [arraybuffer] Rearchitect backing store ownership > > This CL completely rearchitects the ownership of array buffer backing stores, > consolidating ownership into a {BackingStore} C++ object that is tracked > throughout V8 using unique_ptr and shared_ptr where appropriate. > > Overall, lifetime management is simpler and more explicit. The numerous > ways that array buffers were initialized have been streamlined to one > Attach() method on JSArrayBuffer. The array buffer tracker in the > GC implementation now manages std::shared_ptr<BackingStore> pointers, > and the construction and destruction of the BackingStore object itself > handles the underlying page or embedder-allocated memory. > > The embedder API remains unchanged for now. We use the > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > keep the backing store alive properly, even in the case of aliases > from live heap objects. Thus the embedder has a lower chance of making > a mistake. Long-term, we should move the embedder to a model where they > manage backing stores using shared_ptr to an opaque backing store object. > > R=mlippautz@chromium.org > BUG=v8:9380,v8:9221 > > Change-Id: I48fae5ac85dcf6172a83f252439e77e7c1a16ccd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584323 > Commit-Queue: Ben Titzer <titzer@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62572} Bug: v8:9380, v8:9221 Change-Id: If3f72967a8ebeb067c0edcfc16ed631e36829dbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691906 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62809}
-
Clemens Hammacher authored
{Assembler::Nop} currently fails if {n} is bigger than {kGap} (the destructor of {EnsureSpace} checks that not more than {kGap} bytes have been emitted). This CL fixes this by repeatedly using {EnsureSpace}, and also optimizes the implementation of {Assembler::Nop} a bit. It also removes stray cases for 10 and 11 nop bytes which have been added in https://crrev.com/8773039 without further comment, and are not documented in the Intel manual. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I07bbe311d2daa75dc27b91a0ccb503427c52841f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708476 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sathya Gunasekaran authored
This reverts commit e55e0aa5. Reason for revert: speculative revert for tsan breakage https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8907588363297935904/+/steps/Check__flakes_/0/logs/regress-437713/0 Original change's description: > [runtime] Fix protector invalidation > > Protectors trigger when special properties are modified or masked. Previously > we would check whether the property stored on the holder would invalidate the > protector. Stores to to the receiver rather than the holder, however, so this > CL changes holder for receiver, and adds additional checks that were missing. > > Bug: v8:9466 > Change-Id: I81bc3d73f91381da0d254e9eb79365ae2d25d998 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708468 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62805} TBR=leszeks@chromium.org,verwaest@chromium.org Change-Id: Id8fc36525b7c5631589a67073ad1fd5815ea2775 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9466 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708482Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62807}
-
Yang Guo authored
R=gsathya@chromium.org Change-Id: I892b96d5749066df476ace705f45a801a795c0a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706060 Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Protectors trigger when special properties are modified or masked. Previously we would check whether the property stored on the holder would invalidate the protector. Stores to to the receiver rather than the holder, however, so this CL changes holder for receiver, and adds additional checks that were missing. Bug: v8:9466 Change-Id: I81bc3d73f91381da0d254e9eb79365ae2d25d998 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708468 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#62805}
-
Clemens Hammacher authored
The destructor of the {WasmGCForegroundTask} can be called immediately when scheduling that task (if the platform determines that the task can never execute anyway). In that case, we deregister the task from the wasm engine so we do not access it later (which would be UAF). This deregistration leads to recursively taking a mutex now. The only later access to the task happens to cancel the task. For this purpose, we can also use the {CancelableTaskManager} of the isolate, and avoid all code in the destructor. This should fix the reentrant mutex, which leads to a DCHECK failure in debug builds and deadlock in release builds. R=mstarzinger@chromium.org Bug: chromium:984970, v8:8217 Change-Id: I14f05a21ea961ecc391dc59af3b5eebf31e0f873 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706480Reviewed-by: -
Pierre Langlois authored
With a write barrier, stores with negative offsets would allocate a temporary register to hold the offset when the `str` instruction is able to encode it. For instance, when writing the object map: ``` ;; This could be 'str x2, [x5, #-1]' movn x4, #0x0 str x2, [x5, x4] and x16, x5, #0xfffffffffffc0000 ldr x16, [x16, #8] tbnz w16, #2, #+0xba8 ; Jump out-of-line ``` The reason behind this is that the out-of-line code uses an 'add' instruction on the offset to compute the field address, putting pressure on the instruction selector to make sure the immediate fits in both 'str' and 'add'. But, this is not necessary since the macro-assembler is able to turn the 'add' into a 'sub' or use a temporary register if needed. Change-Id: I8838e4b81a0c0c1f90aa3d67861a9da1a6dfed06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708471Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#62803}
-
Ben L. Titzer authored
This test fails in --stress-opt mode because backing stores of memories/arraybuffers that are postMessage()'d leak in d8. In normal mode, only ~16 memories are allocated, which is not enough to OOM, but in stress mode, it can be 5x that number. Should be fixed by upcoming ownership changes. BUG=v8:9380 R=clemensh@chromium.org Change-Id: Iecec07d15339cf43b23f128f13d570dfe3b32130 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708475Reviewed-by:
-
Ulan Degenbaev authored
The multiplier should depend on the kTaggedSize. Bug: v8:7703 Change-Id: I3a13e51d06c31b70f6191b23b1913e7bc35cdb8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708473 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ross McIlroy authored
If we flush the bytecode from a SFI we might recompile a JSFunction while the function still has its old feedback vector. This should usually be fine since the new and old feedback vectors have the same layout, however some bugs in the parser mean that it's possible for eagerly and lazily compiled eval functions to have different bytecode and so potentially different feedback vector layouts. For now reset the feedback vector if it doesn't have the same size when we compile the JSFunction, and recreate a new one of the correct layout. This will be replaced with a CHECK once the parser bugs are fixed. BUG=chromium:984344,v8:9511 Change-Id: Ib8976f2541516f7a07e4d4ab7dc3c750dfe9b5d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708474 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Georg Neis authored
This is a reland of 6805395d, after resolving another issue. Original change's description: > Revert "Temporarily remove --concurrent-inlining from --future" > > This reverts commit 060b9ec4, as the > issue has been resolved. > > Bug: v8:7790 > Change-Id: Id8a56ad50a508eacd191f2777cc5afc0b838364f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700078 > Commit-Queue: Georg Neis <neis@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Auto-Submit: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62713} TBR=neis@chromium.org Bug: v8:7790 Change-Id: Ibc5991787982197d08942eb067c83001d91050ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708472Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#62799}
-
Ulan Degenbaev authored
When the main thread contributes to an item parallel job and runs an item parallel task, it currently emits a background GC trace event. That is confusing and may lead to incorrect accounting of main thread GC time. This patch fixes it by introducing a 'Runner' parameter to ItemParalllelJob::Task::RunInParallel and emitting a foreground GC event if the runner is the main thread. Bug: v8:9508 Change-Id: I755751bfe9eef427666d5f16fb50aa6093059e80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706485Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Andreas Haas authored
With recent spec changes, table.copy of length 0 does not trap anymore, and we copy backwards whenever src < dst. R=binji@chromium.org Change-Id: I48e2b65083565631abc41bf4fdf4971f80fdf440 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706471 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Zhang, Shiyu authored
.. by moving the element check forward. So that we skip try_fast path when we have elements on the receiver. Bug: chromium:977870,chromium:983982 Change-Id: Ib26fb3df215ffc5e0ac0c7e344a4239b845fe129 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1697042 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#62796}
-
Mike Stanton authored
We can save memory by only serializing a context chain to a *required* depth if we know it. Bug: v8:7790 Change-Id: I97d21f8cd7b56b26fddd95e00a26d5e520d96170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1678358Reviewed-by:
-
Patrick Thier authored
This is a reland of d4d28b73 Original change's description: > [regexp] Call the regexp interpreter without CEntry overhead > > Previously all RegExp calls went through Runtime_RegExpExec when --regexp-interpret-all was set. > > This CL avoids the runtime overhead by calling into the interpreter directly from the RegExpExec Builtin when the regular expression subject was already compiled to ByteCode (i.e. after the first call). > > Bug: v8:8954 > Change-Id: Iae9dfcef3370b772a05b2942305335d592f6f15a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698391 > Commit-Queue: Patrick Thier <pthier@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62753} Bug: v8:8954 Change-Id: I1f0b6de9c6da65bcb582ddb41a37419116a5c510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706053Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fdb6fae..fb75973 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/96450ca..f8c5b19 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/437e100..6077f44 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/db728d7..b1c3ca2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/efd0971..29ddc91 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ia24e77fdf5360cc32e000dedfe663ca0dab4693f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1707691Reviewed-by:
-
Deepti Gandluri authored
- Add vmovdqu to the assembler - Fix bugs in macro assembler for instructions with immediates - Fix codegen Bug: v8:9499 Change-Id: Id9a521561ed5481eb617b2d97e4af933aac7a54e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1707577Reviewed-by:
-
- 17 Jul, 2019 10 commits
-
-
Jon Kunkee authored
This is a reland of 13a04aba Original change's description: > fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references > > This change fixes missing symbol errors in the Windows 10 on ARM build > of Node.js. > > When a whole class is marked for export, all of its members are marked > as well. This can be a problem when inline members call undefined yet > inline members of other classes: the exported function will contain a > reference to the undefined inline function that should be satisfied at > link time, but because the other function is inline no symbol will be > produced that will satisfy that reference. > > Clang gets around this by masking inlined class members from export > using /Fc:dllexportInlines-. This is why b0a2a567 worked. > > Node.js' Windows builds use MSVC and so do not have access to this > flag. This results in unresolved symbols at link time. > > Bug: v8:9465 > Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62660} Bug: v8:9465 Change-Id: Ib7f1d84e080929e3db1b2a2b001e8e08924f4da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1703462Reviewed-by:
-
Dan Elphick authored
Fixes BytecodeArray::ClearFrameCacheFromSourcePositionTable when used with lazy source positions. This fixes cctest/test-serialize/CachedCompileFunctionInContext when used with --enable-lazy-source-positions and --stress-lazy-source-positions. R=rmcilroy@chromium.org Bug: v8:8510 Change-Id: I8c6e8fb944c87636307f62e8d738bfc72463a2f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706487 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Mike Stanton authored
Specifically the SharedFunctionInfo and the NativeContext. Bug: v8:7790 Change-Id: Idd1b1b4c7d8eee3ada42b99fee870dff46b631c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706472 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Yang Qin authored
AIX: Changing how CallFrequency object being passed from 'by value' to 'by constant reference' to avoid copy error. GCC compile issue in AIX: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 There is a gcc compile issue in AIX: Being passed by values may occur a copy error, which can be avoided by being passed by reference. This is why the old way of CallFrequency object 'being passed by values’ has been changed to the new way of CallFrequency object 'being passed by references' to avoid this issue. Bug: v8:8193 Change-Id: I3f2e662a9ef5b641b6e978c3e91167bacc0d13d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1689027Reviewed-by:
-
Jiayao Lin authored
Change-Id: If012756df78646769fb89200f2d10d71827d01a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687063 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#62787}
-
Jiayao Lin authored
Change-Id: I8034f64ba412a7d880fdc1b7bc4dce0b41fe3114 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696915Reviewed-by:
-
Milad Farazmand authored
This reverts commit e7cc0f81. Reason for revert: <INSERT REASONING HERE> Original change's description: > s390: cleanup TM family instructions > > Change-Id: I4a95a7508d66950db4a0032893ca0a34901b2d59 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1688559 > Reviewed-by: Joran Siu <joransiu@ca.ibm.com> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#62772} TBR=jyan@ca.ibm.com,joransiu@ca.ibm.com,yang.qin@ibm.com Change-Id: If7c26ba0b2f5ecc66a85841995a1ee21c3cba454 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706362Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#62785}
-
Andreas Haas authored
CC=binji@chromium.org R=mstarzinger@chromium.org Change-Id: Ie1c085f818111eadee9187db6883f8b1060c02f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706477 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Adding two small builtins pushed this test over the OOM threshold, so we disable it for now. Bug: v8:9488 Change-Id: I6c0696c260cd8ef9e6ee59caec4848aab439fdf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706049Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62783}
-
Clemens Hammacher authored
If multiple isolates are involved, we can run OOM when creating many wasm memories, because we only trigger GC in one isolate at a time. TBR=titzer@chromium.org No-Try: true Change-Id: I037b5a13c670c5da2abe54b5045df94637c94f72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706484Reviewed-by:
-
